38634 2010-05-06 02:14:04 -0700 [Qt] QWebFrame::setHtml doesn't emit loadFinished signal 2011-02-10 03:58:24 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED Qt, QtTriaged P2 Minor --- 1 jedrzej.nowacki webkit-unassigned commit-queue jedrzej.nowacki kasthuri.n-s kenneth laszlo.gombos oldest_to_newest 221587 0 55219 jedrzej.nowacki 2010-05-06 02:14:04 -0700 Created attachment 55219 Proposed autotest The method should emit the signal for all types of html code. For now, It seems that the signal is emitted only for a html containing external resources, which is slightly inconsistent. 344933 1 kasthuri.n-s 2011-02-03 12:46:28 -0800 Tried to reproduce with latest version of webkit trunk and the signal is emitted properly. 345398 2 jedrzej.nowacki 2011-02-04 00:19:52 -0800 Thanks for trying! Hmm, few months ago we had discussion about this bug. Apparently it was received as a feature not an issue. If I remember correctly that was the only way for a browser to set an error / warning page without polluting history. So if it works now, then something may be broken too :( Personally I don't like this kinds of side effects & hacks. I would love to see cleaner API here. Kenneth, is the usecase valid? 345486 3 tonikitoo 2011-02-04 07:44:10 -0800 > Hmm, few months ago we had discussion about this bug. Apparently it was received as a feature not an issue. If I remember correctly that was the only way for a browser to set an error / warning page without polluting history. So if it works now, then something may be broken too :( setHTML does not affect back/forward history, that is correct. > Personally I don't like this kinds of side effects & hacks. I would love to see cleaner API here. > > Kenneth, is the usecase valid? I am not kenneth, but I guess it is valid :) 345738 4 kasthuri.n-s 2011-02-04 13:23:56 -0800 ok, since I wasn't aware of the history, I just tried with a simple qt app which uses qwebview and calls setHtml() function of mainFrame. In that app I got the loadFinished signal. So do you have a writeup somewhere of the requirement so that I can understand it better? Thanks. 347697 5 laszlo.gombos 2011-02-08 14:41:28 -0800 Kasthuri, can you apply the patch and see if the test is still passing ? 348616 6 81881 kasthuri.n-s 2011-02-09 15:05:50 -0800 Created attachment 81881 patch to check loadFinished signal The proposed test modification was connecting for the loadFinished signal after calling setHtml() api which resulted in missing the signal for simple html files. Hence the test was failing. Updated the test to check for the loadFinished signal using QSignalSpy. 348790 7 81881 tonikitoo 2011-02-09 20:42:42 -0800 Comment on attachment 81881 patch to check loadFinished signal ok 348925 8 81881 commit-queue 2011-02-10 03:58:19 -0800 Comment on attachment 81881 patch to check loadFinished signal Clearing flags on attachment: 81881 Committed r78192: <http://trac.webkit.org/changeset/78192> 348926 9 commit-queue 2011-02-10 03:58:24 -0800 All reviewed patches have been landed. Closing bug. 55219 2010-05-06 02:14:04 -0700 2010-05-06 02:14:04 -0700 Proposed autotest tsts.diff application/octet-stream 561 jedrzej.nowacki ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC90ZXN0cy9xd2ViZnJhbWUvdHN0X3F3ZWJmcmFtZS5jcHAg Yi9XZWJLaXQvcXQvdGVzdHMvcXdlYmZyYW1lL3RzdF9xd2ViZnJhbWUuY3BwCmluZGV4IGJlYTdh NjcuLjZjY2JmOTEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC90ZXN0cy9xd2ViZnJhbWUvdHN0X3F3 ZWJmcmFtZS5jcHAKKysrIGIvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJmcmFtZS90c3RfcXdlYmZyYW1l LmNwcApAQCAtMjQxNCw2ICsyNDE0LDcgQEAgdm9pZCB0c3RfUVdlYkZyYW1lOjpzZXRIdG1sKCkK IHsKICAgICBRU3RyaW5nIGh0bWwoIjxodG1sPjxoZWFkPjwvaGVhZD48Ym9keT48cD5oZWxsbyB3 b3JsZDwvcD48L2JvZHk+PC9odG1sPiIpOwogICAgIG1fdmlldy0+cGFnZSgpLT5tYWluRnJhbWUo KS0+c2V0SHRtbChodG1sKTsKKyAgICBRVkVSSUZZKHdhaXRGb3JTaWduYWwobV92aWV3LT5wYWdl KCksIFNJR05BTChsb2FkRmluaXNoZWQoYm9vbCkpLCAxMDAwKSk7CiAgICAgUUNPTVBBUkUobV92 aWV3LT5wYWdlKCktPm1haW5GcmFtZSgpLT50b0h0bWwoKSwgaHRtbCk7CiB9CiAK 81881 2011-02-09 15:05:50 -0800 2011-02-10 03:58:19 -0800 patch to check loadFinished signal tst_qwebframe_changes.patch text/plain 1797 kasthuri.n-s SW5kZXg6IFNvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvcXQvQ2hhbmdlTG9nCShyZXZpc2lvbiA3ODE0MykKKysrIFNvdXJjZS9XZWJLaXQvcXQv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMDItMDkgIGth c3RodXJpICA8a2FzdGh1cmkubi1zQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFFXZWJGcmFtZTo6c2V0SHRtbCBkb2Vzbid0 IGVtaXQgbG9hZEZpbmlzaGVkIHNpZ25hbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9Mzg2MzQKKworICAgICAgICBRV2ViVmlldy0+cGFnZSgpLT5tYWlu RnJhbWUoKS0+c2V0SHRtbChodG1sKSBpcyBhbHdheXMgZW1pdHRpbmcKKyAgICAgICAgdGhlIGxv YWRGaW5pc2hlZCgpIHNpZ25hbCBmb3IgYWxsIHR5cGVzIG9mIGh0bWwgZmlsZXMuCisgICAgICAg IEJ1dCB0aGUgcHJvcG9zZWQgdGVzdCBjb250ZW50IHdhcyB0cnlpbmcgdG8gY2F0Y2ggdGhlIHNp Z25hbCBhZnRlcgorICAgICAgICBjYWxsaW5nIHNldEh0bWwoKSBhcGkgYW5kIGJlY3Vhc2Ugb2Yg dGhpcyB0aGUgZW1pdHRlZCBzaWduYWwgZm9yIGEgCisgICAgICAgIHNpbXBsZSBodG1sIHBhZ2Ug aXMgbmV2ZXIgY2F1Z2h0IGFzIGl0cyBlbWl0dGVkIGJlZm9yZSBldmVuIHRoZSBjb25uZWN0Cisg ICAgICAgIGNhbGwgd2FzIHN1Y2Nlc3NmdWwuCisKKyAgICAgICAgdXBkYXRlZCB0aGUgdHN0X1FX ZWJGcmFtZTo6c2V0SHRtbCgpIGluIHRzdF9xd2ViZnJhbWUuY3BwIHRvIGNoZWNrIGZvciAKKyAg ICAgICAgc2lnbmFsIHVzaW5nIHRoZSBRU2lnbmFsU3B5LgorICAgICAgICAgCisKKyAgICAgICAg KiB0ZXN0cy9xd2ViZnJhbWUvdHN0X3F3ZWJmcmFtZS5jcHA6CisKIDIwMTEtMDItMDkgIFJvYmVy dCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IENzYWJh IE9zenRyb2dvbsOhYy4KSW5kZXg6IFNvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdlYmZyYW1lL3Rz dF9xd2ViZnJhbWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdl YmZyYW1lL3RzdF9xd2ViZnJhbWUuY3BwCShyZXZpc2lvbiA3ODE0MykKKysrIFNvdXJjZS9XZWJL aXQvcXQvdGVzdHMvcXdlYmZyYW1lL3RzdF9xd2ViZnJhbWUuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0yNDQ2LDggKzI0NDYsMTAgQEAgdm9pZCB0c3RfUVdlYkZyYW1lOjpqYXZhU2NyaXB0V2luZG93 T2JqZQogdm9pZCB0c3RfUVdlYkZyYW1lOjpzZXRIdG1sKCkKIHsKICAgICBRU3RyaW5nIGh0bWwo IjxodG1sPjxoZWFkPjwvaGVhZD48Ym9keT48cD5oZWxsbyB3b3JsZDwvcD48L2JvZHk+PC9odG1s PiIpOworICAgIFFTaWduYWxTcHkgc3B5KG1fdmlldy0+cGFnZSgpLCBTSUdOQUwobG9hZEZpbmlz aGVkKGJvb2wpKSk7CiAgICAgbV92aWV3LT5wYWdlKCktPm1haW5GcmFtZSgpLT5zZXRIdG1sKGh0 bWwpOwogICAgIFFDT01QQVJFKG1fdmlldy0+cGFnZSgpLT5tYWluRnJhbWUoKS0+dG9IdG1sKCks IGh0bWwpOworICAgIFFDT01QQVJFKHNweS5jb3VudCgpLCAxKTsKIH0KIAogdm9pZCB0c3RfUVdl YkZyYW1lOjpzZXRIdG1sV2l0aFJlc291cmNlKCkK