38632 2010-05-06 01:39:53 -0700 [DRT/Chromium] ImageDiff should depend on WebKit 2010-05-06 10:26:23 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 jochen webkit-unassigned abarth commit-queue dglazkov eric tkent webkit.review.bot oldest_to_newest 221568 0 jochen 2010-05-06 01:39:53 -0700 [DRT/Chromium] ImageDiff should depend on WebKit 221571 1 55216 jochen 2010-05-06 01:46:45 -0700 Created attachment 55216 Patch 221572 2 55217 jochen 2010-05-06 01:48:06 -0700 Created attachment 55217 Patch 221581 3 jochen 2010-05-06 01:55:42 -0700 If you compile ImageDiff from within chromium with shared libraries, you run into undefined symbols: CurrentTime and ChromiumBridge::callOnMainThread. That's because these symbols are declared in WTF (and used) but defined in WebKit/chromium/src/ChromiumBridge.cpp 221586 4 55217 tkent 2010-05-06 02:11:43 -0700 Comment on attachment 55217 Patch This change looks ok. 221695 5 55217 dglazkov 2010-05-06 08:31:48 -0700 Comment on attachment 55217 Patch ok. 221749 6 55217 commit-queue 2010-05-06 09:46:50 -0700 Comment on attachment 55217 Patch Clearing flags on attachment: 55217 Committed r58889: <http://trac.webkit.org/changeset/58889> 221750 7 commit-queue 2010-05-06 09:46:56 -0700 All reviewed patches have been landed. Closing bug. 221784 8 webkit.review.bot 2010-05-06 10:26:23 -0700 http://trac.webkit.org/changeset/58889 might have broken GTK Linux 64-bit Release 55216 2010-05-06 01:46:45 -0700 2010-05-06 01:48:01 -0700 Patch bug-38632-20100506104642.patch text/plain 1397 jochen ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBjMDZlNzg4NmZiYmQ4ODcxMDI1OTI1MjcxODUzZDM5NjA2NDMwMmYyLi5kYmZiOWMx YjBlYTVkNGZmMDU5YmU0NWFmZGNkMjFlNTI4MmNhMjFkIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMDUtMDYgIEpvY2hlbiBFaXNpbmdlciAgPGpvY2hlbkBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBJbWFnZURp ZmYgZGVwZW5kIG9uIFdlYktpdC4gV2hlbiBjb21waWxlZCBmcm9tIHdpdGhpbiBDaHJvbWl1bSwg V1RGIGlzIG5vdCBhIHN0YW5kYWxvbmUgZHluYW1pYyBsaWJyYXJ5IGJ1dCBkZXBlbmRzIG9uIFdl YktpdC4KKwlodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg2MzIKKwor ICAgICAgICAqIER1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5cC9EdW1wUmVuZGVyVHJl ZS5neXA6CisKIDIwMTAtMDUtMDUgIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBlY2tAd2Via2l0Lm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpkaWZmIC0tZ2l0IGEvV2Vi S2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUuZ3lwL0R1bXBSZW5kZXJUcmVl Lmd5cCBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5cC9EdW1w UmVuZGVyVHJlZS5neXAKaW5kZXggYWNjZjhlYTljMmYyMWQ0MjFhZDdlZDkyYzliNjhjNWNiOTFj MTYzNi4uMGM2YjhiZGE2YmM5MzlkZjVlYjYzMWEwNGNjZjU3MDg2YTM4NmI0ZSAxMDA2NDQKLS0t IGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUuZ3lwL0R1bXBSZW5k ZXJUcmVlLmd5cAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJl ZS5neXAvRHVtcFJlbmRlclRyZWUuZ3lwCkBAIC0xNDcsNiArMTQ3LDcgQEAKICAgICAgICAgICAg ICd0YXJnZXRfbmFtZSc6ICdJbWFnZURpZmYnLAogICAgICAgICAgICAgJ3R5cGUnOiAnZXhlY3V0 YWJsZScsCiAgICAgICAgICAgICAnZGVwZW5kZW5jaWVzJzogWworICAgICAgICAgICAgICAgICc8 KHdlYmtpdF9hcGlfZGlyKS9XZWJLaXQuZ3lwOndlYmtpdCcsCiAgICAgICAgICAgICAgICAgJzwo d2Via2l0X3RvcCkvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUuZ3lwL0phdmFTY3JpcHRD b3JlLmd5cDp3dGYnLAogICAgICAgICAgICAgICAgICc8KGNocm9taXVtX3NyY19kaXIpL2dmeC9n ZnguZ3lwOmdmeCcsCiAgICAgICAgICAgICBdLAo= 55217 2010-05-06 01:48:06 -0700 2010-05-06 09:46:50 -0700 Patch bug-38632-20100506104804.patch text/plain 1404 jochen ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBjMDZlNzg4NmZiYmQ4ODcxMDI1OTI1MjcxODUzZDM5NjA2NDMwMmYyLi41NTJmOTBh NTJiNDkzOTcyYzdiMDMzMTllNzAzNWM3YWRlMzNmOWM5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMDUtMDYgIEpvY2hlbiBFaXNpbmdlciAgPGpvY2hlbkBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBJbWFnZURp ZmYgZGVwZW5kIG9uIFdlYktpdC4gV2hlbiBjb21waWxlZCBmcm9tIHdpdGhpbiBDaHJvbWl1bSwg V1RGIGlzIG5vdCBhIHN0YW5kYWxvbmUgZHluYW1pYyBsaWJyYXJ5IGJ1dCBkZXBlbmRzIG9uIFdl YktpdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4 NjMyCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5neXAvRHVtcFJl bmRlclRyZWUuZ3lwOgorCiAyMDEwLTA1LTA1ICBKb3NlcGggUGVjb3Jhcm8gIDxqb2VwZWNrQHdl YmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KZGlmZiAtLWdp dCBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5cC9EdW1wUmVu ZGVyVHJlZS5neXAgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5n eXAvRHVtcFJlbmRlclRyZWUuZ3lwCmluZGV4IGFjY2Y4ZWE5YzJmMjFkNDIxYWQ3ZWQ5MmM5YjY4 YzVjYjkxYzE2MzYuLjBjNmI4YmRhNmJjOTM5ZGY1ZWI2MzFhMDRjY2Y1NzA4NmEzODZiNGUgMTAw NjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5cC9E dW1wUmVuZGVyVHJlZS5neXAKKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvRHVtcFJl bmRlclRyZWUuZ3lwL0R1bXBSZW5kZXJUcmVlLmd5cApAQCAtMTQ3LDYgKzE0Nyw3IEBACiAgICAg ICAgICAgICAndGFyZ2V0X25hbWUnOiAnSW1hZ2VEaWZmJywKICAgICAgICAgICAgICd0eXBlJzog J2V4ZWN1dGFibGUnLAogICAgICAgICAgICAgJ2RlcGVuZGVuY2llcyc6IFsKKyAgICAgICAgICAg ICAgICAnPCh3ZWJraXRfYXBpX2RpcikvV2ViS2l0Lmd5cDp3ZWJraXQnLAogICAgICAgICAgICAg ICAgICc8KHdlYmtpdF90b3ApL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmd5cC9KYXZh U2NyaXB0Q29yZS5neXA6d3RmJywKICAgICAgICAgICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGly KS9nZngvZ2Z4Lmd5cDpnZngnLAogICAgICAgICAgICAgXSwK