38631 2010-05-06 01:26:46 -0700 Chromium Dev Tools: Large toolbar icons flash when dev tools is opened in docked mode. 2010-05-06 10:26:51 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman abarth dglazkov eric timothy webkit.review.bot oldest_to_newest 221556 0 pfeldman 2010-05-06 01:26:46 -0700 Today, inspector has a chance to be rendered before the theme and docked state are set. As a result, large toolbar icons flicker. 221562 1 55214 pfeldman 2010-05-06 01:33:28 -0700 Created attachment 55214 [PATCH] Proposed change. 221674 2 55214 timothy 2010-05-06 07:43:49 -0700 Comment on attachment 55214 [PATCH] Proposed change. WebKit/chromium/src/js/DevTools.js:195 + var paramsIndex = window.location.href.indexOf("?"); Use window.location.search, and it will be just the query string part (plus the prefix "?".) WebKit/chromium/src/js/DevTools.js:200 + var pair = params[i].split("="); Do you need to worry about URL encoding? If so you should call decodeURIComponent. WebKit/chromium/src/js/DevTools.js:202 + } I like extra lines after these. WebKit/chromium/src/js/DevTools.js:207 + } Ditto. Use window.location.search, otherwise r+. 221689 3 55242 pfeldman 2010-05-06 08:16:35 -0700 Created attachment 55242 [PATCH] Review comments addressed. Thanks for the hint! I don't care about escaping - I am passing booleans and rgb values, all latin, works for me locally. 221738 4 55242 timothy 2010-05-06 09:41:19 -0700 Comment on attachment 55242 [PATCH] Review comments addressed. > - this.drawer.resize(); > + if (this.drawer) > + this.drawer.resize(); Why this change? 221741 5 pfeldman 2010-05-06 09:44:31 -0700 (In reply to comment #4) > (From update of attachment 55242 [details]) > > - this.drawer.resize(); > > + if (this.drawer) > > + this.drawer.resize(); > > Why this change? Before Joe's change, setAttached could be called early (before drawer was created). And we actually need it to be called early. 221754 6 pfeldman 2010-05-06 09:49:58 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/inspector/front-end/ResourceView.js M WebCore/inspector/front-end/inspector.js M WebKit/chromium/ChangeLog M WebKit/chromium/src/js/DevTools.js Committed r58890 221779 7 webkit.review.bot 2010-05-06 10:20:28 -0700 http://trac.webkit.org/changeset/58890 might have broken Qt Linux Release 221786 8 timothy 2010-05-06 10:26:51 -0700 No. 55214 2010-05-06 01:33:28 -0700 2010-05-06 08:16:35 -0700 [PATCH] Proposed change. instant_theme text/plain 1652 pfeldman ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDliYmE3YjcuLjMyODZhODYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE0IEBACisyMDEwLTA1LTA2ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENocm9t aXVtIERldiBUb29sczogTGFyZ2UgdG9vbGJhciBpY29ucyBmbGFzaCB3aGVuIGRldiB0b29scyBp cyBvcGVuZWQgaW4gZG9ja2VkIG1vZGUuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTM4NjMxCisKKyAgICAgICAgKiBzcmMvanMvRGV2VG9vbHMuanM6 CisgICAgICAgIChkZXZ0b29scy5kb21Db250ZW50TG9hZGVkKToKKwogMjAxMC0wNS0wNCAgVmFu Z2VsaXMgS29ra2V2aXMgIDx2YW5nZWxpc0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgRGFyaW4gRmlzaGVyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3NyYy9qcy9E ZXZUb29scy5qcyBiL1dlYktpdC9jaHJvbWl1bS9zcmMvanMvRGV2VG9vbHMuanMKaW5kZXggMGI3 NTM4ZS4uZGUzMjM1ZiAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9qcy9EZXZUb29s cy5qcworKysgYi9XZWJLaXQvY2hyb21pdW0vc3JjL2pzL0RldlRvb2xzLmpzCkBAIC0xOTAsNiAr MTkwLDIzIEBAIFdlYkluc3BlY3Rvci5sb2FkZWQgPSBmdW5jdGlvbigpCiAgICAgSW5zcGVjdG9y RnJvbnRlbmRIb3N0LmxvYWRlZCgpOwogfTsKIAorZGV2dG9vbHMuZG9tQ29udGVudExvYWRlZCA9 IGZ1bmN0aW9uKCkKK3sKKyAgICB2YXIgcGFyYW1zSW5kZXggPSB3aW5kb3cubG9jYXRpb24uaHJl Zi5pbmRleE9mKCI/Iik7CisgICAgaWYgKHBhcmFtc0luZGV4ICE9PSAtMSkgeworICAgICAgICB2 YXIgcGFyYW1zID0gd2luZG93LmxvY2F0aW9uLmhyZWYuc3Vic3RyaW5nKHBhcmFtc0luZGV4ICsg MSkuc3BsaXQoIiYiKTsKKyAgICAgICAgdmFyIHBhcmFtc09iamVjdCA9IHt9OworICAgICAgICBm b3IgKHZhciBpID0gMDsgaSA8IHBhcmFtcy5sZW5ndGg7ICsraSkgeworICAgICAgICAgICAgdmFy IHBhaXIgPSBwYXJhbXNbaV0uc3BsaXQoIj0iKTsKKyAgICAgICAgICAgIHBhcmFtc09iamVjdFtw YWlyWzBdXSA9IHBhaXJbMV07CisgICAgICAgIH0KKyAgICAgICAgV2ViSW5zcGVjdG9yLnNldEF0 dGFjaGVkV2luZG93KHBhcmFtc09iamVjdC5kb2NrZWQpOworICAgICAgICBpZiAocGFyYW1zT2Jq ZWN0LnRvb2xiYXJfY29sb3IgJiYgcGFyYW1zT2JqZWN0LnRleHRfY29sb3IpCisgICAgICAgICAg ICBXZWJJbnNwZWN0b3Iuc2V0VG9vbGJhckNvbG9ycyhwYXJhbXNPYmplY3QudG9vbGJhcl9jb2xv ciwgcGFyYW1zT2JqZWN0LnRleHRfY29sb3IpOworICAgIH0KK30KK2RvY3VtZW50LmFkZEV2ZW50 TGlzdGVuZXIoIkRPTUNvbnRlbnRMb2FkZWQiLCBkZXZ0b29scy5kb21Db250ZW50TG9hZGVkLCBm YWxzZSk7CisKIAogaWYgKCF3aW5kb3cudjhTY3JpcHREZWJ1Z1NlcnZlckVuYWJsZWQpIHsKIAo= 55242 2010-05-06 08:16:35 -0700 2010-05-06 09:49:48 -0700 [PATCH] Review comments addressed. instant_theme text/plain 2136 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMgYi9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCmluZGV4IGRjZGMyYjcuLjVh NTgwYWYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3Iu anMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcwpAQCAtMjQ0 LDggKzI0NCw4IEBAIHZhciBXZWJJbnNwZWN0b3IgPSB7CiAgICAgICAgICAgICBib2R5LmFkZFN0 eWxlQ2xhc3MoImRldGFjaGVkIik7CiAgICAgICAgICAgICBkb2NrVG9nZ2xlQnV0dG9uLnRpdGxl ID0gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJEb2NrIHRvIG1haW4gd2luZG93LiIpOwogICAgICAg ICB9Ci0KLSAgICAgICAgdGhpcy5kcmF3ZXIucmVzaXplKCk7CisgICAgICAgIGlmICh0aGlzLmRy YXdlcikKKyAgICAgICAgICAgIHRoaXMuZHJhd2VyLnJlc2l6ZSgpOwogICAgIH0sCiAKICAgICBn ZXQgZXJyb3JzKCkKZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJL aXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4IDliYmE3YjcuLjMyODZhODYgMTAwNjQ0Ci0tLSBh L1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE0IEBACisyMDEwLTA1LTA2ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5A Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIENocm9taXVtIERldiBUb29sczogTGFyZ2UgdG9vbGJhciBpY29ucyBmbGFzaCB3aGVu IGRldiB0b29scyBpcyBvcGVuZWQgaW4gZG9ja2VkIG1vZGUuCisKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4NjMxCisKKyAgICAgICAgKiBzcmMvanMv RGV2VG9vbHMuanM6CisgICAgICAgIChkZXZ0b29scy5kb21Db250ZW50TG9hZGVkKToKKwogMjAx MC0wNS0wNCAgVmFuZ2VsaXMgS29ra2V2aXMgIDx2YW5nZWxpc0BjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9t aXVtL3NyYy9qcy9EZXZUb29scy5qcyBiL1dlYktpdC9jaHJvbWl1bS9zcmMvanMvRGV2VG9vbHMu anMKaW5kZXggMGI3NTM4ZS4uNTliODhkYiAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3Ny Yy9qcy9EZXZUb29scy5qcworKysgYi9XZWJLaXQvY2hyb21pdW0vc3JjL2pzL0RldlRvb2xzLmpz CkBAIC0xOTAsNiArMTkwLDIzIEBAIFdlYkluc3BlY3Rvci5sb2FkZWQgPSBmdW5jdGlvbigpCiAg ICAgSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmxvYWRlZCgpOwogfTsKIAorZGV2dG9vbHMuZG9tQ29u dGVudExvYWRlZCA9IGZ1bmN0aW9uKCkKK3sKKyAgICB2YXIgcXVlcnlQYXJhbXMgPSB3aW5kb3cu bG9jYXRpb24uc2VhcmNoOworICAgIGlmIChxdWVyeVBhcmFtcykgeworICAgICAgICB2YXIgcGFy YW1zID0gcXVlcnlQYXJhbXMuc3Vic3RyaW5nKDEpLnNwbGl0KCImIik7CisgICAgICAgIHZhciBw YXJhbXNPYmplY3QgPSB7fTsKKyAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBwYXJhbXMubGVu Z3RoOyArK2kpIHsKKyAgICAgICAgICAgIHZhciBwYWlyID0gcGFyYW1zW2ldLnNwbGl0KCI9Iik7 CisgICAgICAgICAgICBwYXJhbXNPYmplY3RbcGFpclswXV0gPSBwYWlyWzFdOworICAgICAgICB9 CisgICAgICAgIFdlYkluc3BlY3Rvci5zZXRBdHRhY2hlZFdpbmRvdyhwYXJhbXNPYmplY3QuZG9j a2VkKTsKKyAgICAgICAgaWYgKHBhcmFtc09iamVjdC50b29sYmFyX2NvbG9yICYmIHBhcmFtc09i amVjdC50ZXh0X2NvbG9yKQorICAgICAgICAgICAgV2ViSW5zcGVjdG9yLnNldFRvb2xiYXJDb2xv cnMocGFyYW1zT2JqZWN0LnRvb2xiYXJfY29sb3IsIHBhcmFtc09iamVjdC50ZXh0X2NvbG9yKTsK KyAgICB9Cit9Citkb2N1bWVudC5hZGRFdmVudExpc3RlbmVyKCJET01Db250ZW50TG9hZGVkIiwg ZGV2dG9vbHMuZG9tQ29udGVudExvYWRlZCwgZmFsc2UpOworCiAKIGlmICghd2luZG93LnY4U2Ny aXB0RGVidWdTZXJ2ZXJFbmFibGVkKSB7CiAK