3862 2005-07-05 06:08:33 -0700 Bidi control characters added by the fix to bug 3545 are actually rendered 2005-11-04 00:33:13 -0800 1 1 1 Unclassified WebKit Layout and Rendering 412 Mac OS X 10.4 CLOSED FIXED P2 Normal --- 1 mitz hyatt oldest_to_newest 13977 0 mitz 2005-07-05 06:08:35 -0700 When using a font that contains glyphs for bidi control characters LRO and PDF, each run of visually- ordered Hebrew is enclosed by those glyphs. To reproduce: You need a font that contains those glyphs. For the testcase, the version of Arial that comes with Windows XP will do (disable all other versions of Arial). Open the testcase. Expected: Not to see control-character glyphs on either side of the Hebrew text (see screenshot). Actual: The Hebrew letters are enclosed by the LRO and PDF glyphs. Analysis: the fix for bug 3545 encloses each run of visually-ordered Hebrew in LRO-PDF, and adjusts the from and to members to include the LRO and PDF. It shouldn't. ATSUI will respect the LRO even if it occurs before the first character to be rendered. The patch corrects this by making the from-to range include only the original characters in the run, leaving the control characters outside. 13978 1 2813 mitz 2005-07-05 06:09:24 -0700 Created attachment 2813 Testcase 13979 2 2814 mitz 2005-07-05 06:10:40 -0700 Created attachment 2814 actual rendering 13980 3 2815 mitz 2005-07-05 06:11:47 -0700 Created attachment 2815 expected rendering 13981 4 2816 mitz 2005-07-05 06:12:40 -0700 Created attachment 2816 Proposed fix 14026 5 joost 2005-07-05 13:01:58 -0700 Confirmed, weird stuff, hebrew is nice tho :P 14291 6 2816 hyatt 2005-07-09 14:08:56 -0700 Comment on attachment 2816 Proposed fix r=me 14320 7 2816 darin 2005-07-10 06:50:10 -0700 Comment on attachment 2816 Proposed fix Looks great to me too, although I don't see the need for the cast to (int) in the expression: (int)run->length - 1 since subtracting 1 from the unsigned value is going to make it into a signed value anyway. 14323 8 mitz 2005-07-10 07:47:18 -0700 (In reply to comment #7) > (From update of attachment 2816 [edit]) > Looks great to me too, although I don't see the need for the cast to (int) in > the expression: > > (int)run->length - 1 > > since subtracting 1 from the unsigned value is going to make it into a signed > value anyway. > Tell that to the compiler. Without the case, it says "warning: signed and unsigned type in conditional expression". 15107 9 justin.garcia 2005-07-23 14:02:33 -0700 Landing a fix and adding a manual test, since our layout test font doesn't include glyphs for LRO and PDF. 2813 2005-07-05 06:09:24 -0700 2005-07-05 06:09:24 -0700 Testcase bidiControlChars.html text/html 362 mitz PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFs Ly9FTiIgCiJodHRwOi8vd3d3LnczLm9yZy9UUi9odG1sNC9sb29zZS5kdGQiPgo8aHRtbD4NCjxo ZWFkPg0KPE1FVEEgSFRUUC1FUVVJVj0iQ29udGVudC1UeXBlIiBjb250ZW50PSJ0ZXh0L2h0bWw7 IGNoYXJzZXQ9aXNvLTg4NTktOCI+Cjx0aXRsZT5JbnRlcm5hbCBiaWRpIGNvbnRyb2wgY2hhcmFj dGVycyBhcmUgdmlzaWJsZTwvdGl0bGU+DQo8L2hlYWQ+DQo8Ym9keT4KPHAgc3R5bGU9ImZvbnQt ZmFtaWx5OkFyaWFsOyBmb250LXNpemU6MzZwdDsiPiYjeDA1ZDI7JiN4MDVkMTsmI3gwNWQwOzwv cD4KPC9ib2R5Pgo8L2h0bWw+DQo= 2814 2005-07-05 06:10:40 -0700 2005-07-05 06:10:40 -0700 actual rendering actual.png image/png 2203 mitz iVBORw0KGgoAAAANSUhEUgAAAFkAAAAuCAIAAADMTiKBAAABy2lDQ1BJQ0MgUHJvZmlsZQAAeJyt kc9rE1EQxz9vQ2NBiSIrvfSwB60e0hIapVVBUnMQ0UJoI2YDUjZv1ySQ3Tw2L6mCB/8BETwVKUUQ oQhePBV7aAQPgqgUUbx68uJN6cUf6+EZAkLw4sDAZ74ww8x3IDXpKdWygDDS8dKF807FrTr73pPm IBOc5YwnO2qhVLrMyNj7gAB4N+0p1dp8U3j8PPVq+dPOsfs/1rbc0X0AZOKKWwWRBey64QJg1wyX AXtVKw2iAdiy4fkgbgHZuLxUBLEJZOqGt4BMzfBLINOTdQ3iI5CL/GYE1jgw7wcdCVYBWPE7MgTr AXA0DNs+WC+AE1LFGqwvwHTFrTpm5d5nOLcB1t2h5tbgyWk4MjfUpu6APQfb3lD7dg8BiImNzvX8 LABi/wqMXUuSr/OQfgu/TibJ96dJ8nMNUnuwsyu7ce+PX0K8hn/V5mZTw64e0Cg2vgCQg4d9uApc 6sN6H6ZW4fA2lApQBiufH6TxEICx5qI34P8WYas7mCmAA0F0ZRkYByZpsoiHNP8CSB+C9eMAz2Ye 3f57lg5uaIBiW92Mm/WGdhaUagVOsR2qrg7irHMxkjNZZzaXOwXwG5j4hmLqSByQAAAGi0lEQVRo ge1aX0xTZxQ/LlRbFoiAnRvMgAEduHHdIKToAFfmEhsT6wOZmzSZfRiYPUi3OEjNwkMfRmr8VxKT ig+YCGYLL15ewIdChG22c5eMQoDxR2u0FcuoWoa3chvvHvrvfvfe9t7LYMDW39v33fN93zm/e+45 5zvtJpqmIQkAAHhtrRVYR0hyEUMKAAAEh25cuD76LFOh4BUiSZ9i92fGE6qUf1O1FYBEu2iapmm/ VS24r9lHbziIsAuzRO0KM7IlHQBAa7TqSrKWlpY4K5Y276jMEKRr/SFkVyJkbYk6O+L1ms+/qCmW r4ZOGwJI7HxJkWulx3pAMo/EkOQiBoSLLbKNljRXFIjxEyNjD1K3kRTFnPR7JodHJx96nwVfvSJJ EgAy3yos27dfta84Iw51Tz0zj2Y97kdPZh97vM+fv3xGRuOQQrH1jR1v78ovzM/fmZMdbwPOhjMO x9Ti5s2R8dLS1qKPSnIThPnghGPAtUiO/ynugBDCeVgrZU0YmKnTTvJkdarHIHIHtdGCu/zCdYIL 5+5oGOc7O1ZZYCJVsEbrixAXJG5QAxYBw1oMw3bvSFRYYCYbxVHEadWJJCO0h8U2LcQGhRs4xhlw 7tERuM1olZW9612WXSFTMUNXlFLg2YcktAAAWrufpmmasAj4jJVgV6Tj7ZK4AADQWe0CbJDjdZxV xh4Xv7CfQJVW27xsu7jg/2DTAABABgAAb763H8OgunpPZiY8mrS3dfSzhE+a8OM3T6QxZnJKKwA6 MEydtTM9Z/v2balZCgWQ8w/vTznxfifviR0ny4vf9zaqlHHZkheec7a3YXrmXItGf9DbV81dFFxE x+mvy9l28YDXL3QAAFqCjz/KN85xFK4kRVH8/kuRvmnCZjHyOQ5mcsdzigh4nFRt8XLE/E4rKmSY pgTsouN9I4nX0L4Blkbt4yICIArKPcD1ebOdaxcLXjPnuqW1EGwhmxnly+oXYdeyaq2Msk/R9+p/ EZS6R0p25WUXzoqHTT/cEdpI2djRw1qFN5ReG1lgzjwc/YU5xNS70kAYy6s75cUVkqMjFym5R35s R53j0rBbcFn2oe5O9ul67PREIDpacPbhzKflRbli9FmZGjx9uQVr4eFjqMsTswtxRCNYmOn9rraD M91WZOwO+5Tn54sIFXDggxwxyqwMF35K8jcShjK/HN1pMZBoq8BMd0WBhssEAMAlbXOvB+Bpq06D 5iqDKlGFGsOa380ydyNxuH/0XnzHCEw0FGj5czIAALRocvbuzWxAk76usz5fnNeuORccxM3+0Gc6 1ia02smiSmttPV4o8uT1x0U8BEbaW1BDtVYf7bUk6mjWOa/Xi29NbhguAlMEGibUtqv1GaA8xUmx YWBGwnelWEwujWCZXFAvhcL9SsNF3EHGdV9VhUrv7EPduJEjrrY7vi+R2K2WxEVgwtF79kz90eq9 pQ1I1lr9JlBgctjOHOv2vRM9MvdIcxe7hu2vM/VKzW1iuZjpu1K9SVFUrmlqaePer34iXBLPlQrK dx85tAzLY4zkNRaCVX45WzQXBucknSGKi6Fr9QUfn2TfTxnouEms7jcTcN9By6f0VFRAXtJqt7AW NVV96Xgq4RBhLuYGz5bqhXIZfnNsdcmgXiBDHZbHjooZqlMD7HsbXq6/Jl4vIS4Whr6pakKnMKtt mqYp9BPFb49JeQUxsMsJ3tATfPIH+7OkuFJQ2dhuYt/b9KdvTIhURSDmDV46jWYyrGvaUZMvB4Cy w0Zoa4k+6L092qiqBACAwIMJl8gfnWSyuWHU+YeI32dSlRQFFMjyCvLTUgAASP88woW2Is7FM9fY jTfnIZVsW+2xTz4kanJFRHeee3z0nn/PxmLZZGN0W7xoYsfM4Wd+u/AP1eJgjnQP3T1o1mQ0bLkY 7+Q0RjCT6x/2L+5e/hp5G3Vd31Znx4bK0lomGc5OpycIACCTiboVikD0RjX/YIw5rz1alqB0KDx+ jt1vdTbrzw4KHpeAi9nz55lUYPiZo+h1T3mglumNzlu/hZsPKx5G57x+KeJpJ1rtrM5bf1NV668C ES0BF+4pxkBtvHiE88ntOahhDu8/ngcAANl2AV1FAtuWGvoPSeAv3zzzQbVqp8DSDNXVATNrrqG5 N8ArHEWieCG5ibm+sSr9zv8oklzEkOQihiQXMfBxQVFuAAA/X5m7kSFk1yaa5z/QCyODd+dAWVYp qS20/iFgFy8X/1Mk40UMfwOK5cWCjTPG0wAAAABJRU5ErkJggg== 2815 2005-07-05 06:11:47 -0700 2005-07-05 06:11:47 -0700 expected rendering 3862 expected.png image/png 1907 mitz iVBORw0KGgoAAAANSUhEUgAAAFkAAAAqCAIAAABX32CXAAABy2lDQ1BJQ0MgUHJvZmlsZQAAeJyt kc9rE1EQxz9vQ2NBiSIrvfSwB60e0hIapVVBUnMQ0UJoI2YDUjZv1ySQ3Tw2L6mCB/8BETwVKUUQ oQhePBV7aAQPgqgUUbx68uJN6cUf6+EZAkLw4sDAZ74ww8x3IDXpKdWygDDS8dKF807FrTr73pPm IBOc5YwnO2qhVLrMyNj7gAB4N+0p1dp8U3j8PPVq+dPOsfs/1rbc0X0AZOKKWwWRBey64QJg1wyX AXtVKw2iAdiy4fkgbgHZuLxUBLEJZOqGt4BMzfBLINOTdQ3iI5CL/GYE1jgw7wcdCVYBWPE7MgTr AXA0DNs+WC+AE1LFGqwvwHTFrTpm5d5nOLcB1t2h5tbgyWk4MjfUpu6APQfb3lD7dg8BiImNzvX8 LABi/wqMXUuSr/OQfgu/TibJ96dJ8nMNUnuwsyu7ce+PX0K8hn/V5mZTw64e0Cg2vgCQg4d9uApc 6sN6H6ZW4fA2lApQBiufH6TxEICx5qI34P8WYas7mCmAA0F0ZRkYByZpsoiHNP8CSB+C9eMAz2Ye 3f57lg5uaIBiW92Mm/WGdhaUagVOsR2qrg7irHMxkjNZZzaXOwXwG5j4hmLqSByQAAAFY0lEQVRo ge1aQUwbRxT9qeIUqECBhNKGVgQ5UUlUtm2iyCElpEapVBQpziESUvAhXEzUQ+NWEZGjioMPRa4q Jea0dQ4+FNoDly4X6GGD4qqqrXajxlQ1BbsxKibECJOYonVYS9MD2Luzs94dW6gl0r6TZ2f+/D9v /vz/Z+Q9CCEwAQAAL/3fBuwimFzIMLmQYXIhw+RChsmFDJMLGXsNR6wtzER+mZn7K7H8VBRFEQAa Xm871XHG1tFeX0J6bSmxuLyUWnyy/Hgp/ezZ86eiWOiqrt7/6ptvHLW2Wa2tzYdKTUBMmIhE5jf2 7Su0Nzf3H/vgREtVaYn8bCSU3IBtiU1osXVZDbUhA2SDjlKijHcsLGqISJNuuiWC3ePnklkjExBK cuSM7piW7qLZLION9oUzhloMuUDRoFNnNYyXl0gRVk+EnMPPx42skDg3o5Zzc6TqAlI+OzbWL+wE F4K/pGNsgSXUxHTp04STDRvYIcZchJRnMqk9OCvgRtv5tOFCkfGBfe3tMwwD3d3HGxpgcS4cGJ1W Dbjm5a58f7VW8aX5ZCfAKMPYD7TWNTc1Haw5UF0N4urfj+aj3HRUU8votdPt76YHbY0l7ahq+yoa DDD9ym/DPf3n0/e6SaH8Bt6ue0UnthRhTBcOKRMjHMUhqM+8JEna/iuJmbjA+z1ajsN4U0baNZzU 7ie3PBtl8UHueOnjVETZXCCEUCaksigYowiAOKRUiPR5X9jQldOqQAAADr+gHsT7cL5YGvsq4gKJ Y/i+0kQmElKSU8dDvXBYQGqSiKIQjGKLVbkP4+Vp7KmMC3WmqIwLhFAsqHIOb4lgiCE5Rh4xlyLF qusA17hhnkIIoZ2pO+sslEWTGm0XenGXF5bXDUTWE1Of940SnwPHPBP5rZ9LP93msL5z7zXTGLMz XGSlfIWSjdbT+EwbOb2pcomJziM9JBMAAHccQ1NLAGsjzh48V7ltehWqApX59k6dEdKf/ToFolaJ oQJDxBLnWIzSlN13N7OU7Lnn7Q0YSUdV5YuDHbnSRql593FRCrmZ4DC+UAebQWk/kWIVcEW/Gain 1vDCcJGbF/AwYefvDtRD4yejGikWAIDxCJmv22s1+7RRIRfSc6Nwv9NICj9jbdfHXVul96GPJjgP Mdwejnxxgt4lAKBMLnKzkakvbw1c6n7n5HUsa71caU6lVz33MKxsOzveKqpsuTg0rg6q0y7vVNm5 jTLGxnlW52A6g1HKeQgQeUQ7JZHD8KpaFMjyyxeiuJwqQMWFoK4OCTiCZV9ItkHHBZFNyRtQJuwn zaJ4wZFhzEU65CN0aJARrpAMSi6i+LY7Ba1HrZDGva2MTTKKF+sPPuu6iX9iWD6OkIQfUe7+H2sU lJFQlxOaoSf/5E/1s4ekMdfZwaBXlVS4/hvfzlKaYhDzfrxzA89kzHg8ctlaBQCnLnggMFzsmLr/ +6DtLAAA5BZmkyJQwWJZeYjfHR4IvyVqGiUJJLAcPmKt3QsAIGZXMS4cnUe1k2WLZ4IbOox5WqCv 98P3hcstFNFdz2nSvIplL694bUnjiZ3xbfdlw3rlTznwFc5LahLPmnZWJw7ExojoxlBdf/W44D04 Fa5x/JCmfTgZkykJIe2QXhmKsSPKYltNPt7gyJLvrXZfyJCLkvEivzDxKVbzMtytS/h1r/Fcn9LE 6A+/prZ+7XgdtpLOljO89upIWPXyNn2zaySyoi9Wkov49LiSCbvn9kXiyB0/36NsPnq8CgAAliZD a6nAHKypBgCA3D+ZVWVHt63VQLTedpdIf9c93+mTsQeZ/8sp4IW5m/0HMLmQYXIhw+RChsmFDJML GSYXMv4FefLlTC1dt1wAAAAASUVORK5CYII= 2816 2005-07-05 06:12:40 -0700 2005-07-09 14:08:56 -0700 Proposed fix 3862_patch_r1.txt text/plain 1253 mitz SW5kZXg6IFdlYlRleHRSZW5kZXJlci5tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9X ZWJLaXQvV2ViQ29yZVN1cHBvcnQuc3VicHJvai9XZWJUZXh0UmVuZGVyZXIubSx2CnJldHJpZXZp bmcgcmV2aXNpb24gMS4xNzYKZGlmZiAtdSAtcCAtcjEuMTc2IFdlYlRleHRSZW5kZXJlci5tCi0t LSBXZWJUZXh0UmVuZGVyZXIubQkyMDA1LzA2LzMwIDAxOjI4OjM2CTEuMTc2CisrKyBXZWJUZXh0 UmVuZGVyZXIubQkyMDA1LzA3LzA1IDEyOjQ1OjQ5CkBAIC0xNTc2LDExICsxNTc2LDExIEBAIHN0 YXRpYyBXZWJDb3JlVGV4dFJ1biByZXZlcnNlQ2hhcmFjdGVyc0kKICAgICAKICAgICBVbmlDaGFy ICpzd2FwcGVkQ2hhcmFjdGVycyA9IChVbmlDaGFyICopbWFsbG9jKHNpemVvZihVbmlDaGFyKSoo cnVuLT5sZW5ndGgrMikpOwogICAgIG1lbWNweShzd2FwcGVkQ2hhcmFjdGVycysxLCBydW4tPmNo YXJhY3RlcnMsIHNpemVvZihVbmlDaGFyKSpydW4tPmxlbmd0aCk7Ci0gICAgc3dhcHBlZFJ1bi5m cm9tID0gcnVuLT5mcm9tOwotICAgIHN3YXBwZWRSdW4udG8gPSAocnVuLT50byA9PSAtMSA/IC0x IDogcnVuLT50bysyKTsKKyAgICBzd2FwcGVkUnVuLmZyb20gPSAocnVuLT5mcm9tID09IC0xID8g MCA6IHJ1bi0+ZnJvbSkgKyAxOworICAgIHN3YXBwZWRSdW4udG8gPSAocnVuLT50byA9PSAtMSA/ IChpbnQpcnVuLT5sZW5ndGggLSAxIDogcnVuLT50byArIDEpOwogICAgIHN3YXBwZWRSdW4ubGVu Z3RoID0gcnVuLT5sZW5ndGgrMjsKLSAgICBzd2FwcGVkQ2hhcmFjdGVyc1soc3dhcHBlZFJ1bi5m cm9tID09IC0xID8gMCA6IHN3YXBwZWRSdW4uZnJvbSldID0gTEVGVF9UT19SSUdIVF9PVkVSUklE RTsKLSAgICBzd2FwcGVkQ2hhcmFjdGVyc1soc3dhcHBlZFJ1bi50byA9PSAtMSA/IHN3YXBwZWRS dW4ubGVuZ3RoIDogKHVuc2lnbmVkKXN3YXBwZWRSdW4udG8pIC0gMV0gPSBQT1BfRElSRUNUSU9O QUxfRk9STUFUVElORzsKKyAgICBzd2FwcGVkQ2hhcmFjdGVyc1tzd2FwcGVkUnVuLmZyb20gLSAx XSA9IExFRlRfVE9fUklHSFRfT1ZFUlJJREU7CisgICAgc3dhcHBlZENoYXJhY3RlcnNbc3dhcHBl ZFJ1bi50b10gPSBQT1BfRElSRUNUSU9OQUxfRk9STUFUVElORzsKICAgICBzd2FwcGVkUnVuLmNo YXJhY3RlcnMgPSBzd2FwcGVkQ2hhcmFjdGVyczsKIAogICAgIHJldHVybiBzd2FwcGVkUnVuOwo=