38604 2010-05-05 13:30:22 -0700 workers-gc2 crashing on Qt 2010-05-05 23:18:59 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 barraclough barraclough darin ossy oldest_to_newest 221254 0 barraclough 2010-05-05 13:30:22 -0700 This appears to be due to a couple of issues. (1) When the atomic string table is deleted it does not clear the 'inTable' bit on AtomicStrings – it implicitly assumes that all AtomicStrings have already been deleted at this point (otherwise they will crash in their destructor when they try to remove themselves from the atomic string table). (2) We don't fix the ordering in which WTF::WTFThreadData and WebCore::ThreadGlobalData are destructed. We should make sure that ThreadGlobalData is cleaned up before worker threads terminate and WTF::WTFThreadData is destroyed, and we should clear the inTable bit of members on atomic string table destruction. 221259 1 55150 barraclough 2010-05-05 13:40:08 -0700 Created attachment 55150 The patch 221280 2 55150 darin 2010-05-05 14:13:59 -0700 Comment on attachment 55150 The patch > + on AtomicStrings – it implicitly assumes that all AtomicStrings have already You should stick to ASCII for ChangeLog. > + void setIsAtomic(bool isIdentifier) > + { > + ASSERT(!isStatic()); > + if (isIdentifier) > + m_refCountAndFlags |= s_refCountFlagIsAtomic; > + else > + m_refCountAndFlags &= s_refCountFlagIsAtomic; > + } Maybe a set/clear pair of functions instead of one that takes a bool would be better. 221281 3 darin 2010-05-05 14:14:20 -0700 (In reply to comment #2) > Maybe a set/clear pair of functions instead of one that takes a bool would be > better. Just to be clear, I’m not asking you to change this right away, just kind of “musing” about it. 221282 4 barraclough 2010-05-05 14:16:18 -0700 (In reply to comment #3) > Just to be clear, I’m not asking you to change this right away, just kind of > “musing” about it. I agree - I did it this way for now to match the setIsIdentifier method. I may switch to set/clear methods for both as a separate patch. 221407 5 barraclough 2010-05-05 18:12:22 -0700 This should be fixed in r58851. 55150 2010-05-05 13:40:08 -0700 2010-05-05 14:13:58 -0700 The patch patch.threaddestructbetter.txt text/plain 9719 barraclough SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU4ODM4KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMzggQEAKKzIwMTAtMDUtMDUgIEdhdmluIEJh cnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAzODYwNCAtIHdvcmtlcnMtZ2MyIGNyYXNo aW5nIG9uIFF0CisKKyAgICAgICAgVGhpcyBhcHBlYXJzIHRvIGJlIGR1ZSB0byBhIGNvdXBsZSBv ZiBpc3N1ZXMuCisgICAgICAgICgxKSBXaGVuIHRoZSBhdG9taWMgc3RyaW5nIHRhYmxlIGlzIGRl bGV0ZWQgaXQgZG9lcyBub3QgY2xlYXIgdGhlICdpblRhYmxlJyBiaXQKKyAgICAgICAgb24gQXRv bWljU3RyaW5ncyDigJMgaXQgaW1wbGljaXRseSBhc3N1bWVzIHRoYXQgYWxsIEF0b21pY1N0cmlu Z3MgaGF2ZSBhbHJlYWR5CisgICAgICAgIGJlZW4gZGVsZXRlZCBhdCB0aGlzIHBvaW50IChvdGhl cndpc2UgdGhleSB3aWxsIGNyYXNoIGluIHRoZWlyIGRlc3RydWN0b3Igd2hlbgorICAgICAgICB0 aGV5IHRyeSB0byByZW1vdmUgdGhlbXNlbHZlcyBmcm9tIHRoZSBhdG9taWMgc3RyaW5nIHRhYmxl KS4KKyAgICAgICAgKDIpIFdlIGRvbid0IGZpeCB0aGUgb3JkZXJpbmcgaW4gd2hpY2ggV1RGOjpX VEZUaHJlYWREYXRhIGFuZAorICAgICAgICBXZWJDb3JlOjpUaHJlYWRHbG9iYWxEYXRhIGFyZSBk ZXN0cnVjdGVkLgorCisgICAgICAgIFdlIHNob3VsZCBtYWtlIHN1cmUgdGhhdCBUaHJlYWRHbG9i YWxEYXRhIGlzIGNsZWFuZWQgdXAgYmVmb3JlIHdvcmtlciB0aHJlYWRzCisgICAgICAgIHRlcm1p bmF0ZSBhbmQgV1RGOjpXVEZUaHJlYWREYXRhIGlzIGRlc3Ryb3llZCwgYW5kIHdlIHNob3VsZCBj bGVhciB0aGUgaW5UYWJsZQorICAgICAgICBiaXQgb2YgbWVtYmVycyBvbiBhdG9taWMgc3RyaW5n IHRhYmxlIGRlc3RydWN0aW9uLgorCisgICAgICAgIFdURiBjaGFuZ2VzIChmaXggaXNzdWUgMSwg YWJvdmUpIC0gZW5zdXJlIGluVGFibGUgcHJvcGVydHkgaXMgY2xlYXJlZCB3aGVuIHRoZQorICAg ICAgICBhdG9taWMgc3RyaW5nIHRhYmxlIGlzIGRlc3Ryb3llZCAoYWxzbywgcmVuYW1lIEluVGFi bGUgdG8gSXNBdG9taWMsIHRvIG1ha2UgaXQKKyAgICAgICAgY2xlYXIgd2hpY2ggdGFibGUgd2Ug YXJlIHJlZmVyaW5nIHRvISkKKworICAgICAgICAqIHd0Zi90ZXh0L0F0b21pY1N0cmluZy5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpBdG9taWNTdHJpbmdUYWJsZTo6ZGVzdHJveSk6CisgICAgICAg IChXZWJDb3JlOjpDU3RyaW5nVHJhbnNsYXRvcjo6dHJhbnNsYXRlKToKKyAgICAgICAgKFdlYkNv cmU6OlVDaGFyQnVmZmVyVHJhbnNsYXRvcjo6dHJhbnNsYXRlKToKKyAgICAgICAgKFdlYkNvcmU6 Okhhc2hBbmRDaGFyYWN0ZXJzVHJhbnNsYXRvcjo6dHJhbnNsYXRlKToKKyAgICAgICAgKFdlYkNv cmU6OkF0b21pY1N0cmluZzo6YWRkKToKKyAgICAgICAgKiB3dGYvdGV4dC9TdHJpbmdJbXBsLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlN0cmluZ0ltcGw6On5TdHJpbmdJbXBsKToKKyAgICAgICAg KiB3dGYvdGV4dC9TdHJpbmdJbXBsLmg6CisgICAgICAgIChXZWJDb3JlOjpTdHJpbmdJbXBsOjpp c0F0b21pYyk6CisgICAgICAgIChXZWJDb3JlOjpTdHJpbmdJbXBsOjpzZXRJc0F0b21pYyk6Cisg ICAgICAgICogd3RmL3RleHQvU3RyaW5nSW1wbEJhc2UuaDoKKwogMjAxMC0wNS0wNSAgT2xpdmVy IEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdlb2ZmcmV5 IEdhcmVuLgpJbmRleDogSmF2YVNjcmlwdENvcmUvd3RmL3RleHQvQXRvbWljU3RyaW5nLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9BdG9taWNTdHJpbmcuY3BwCShy ZXZpc2lvbiA1ODgzOCkKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L0F0b21pY1N0cmluZy5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTU1LDYgKzU1LDkgQEAgcHVibGljOgogcHJpdmF0ZToKICAg ICBzdGF0aWMgdm9pZCBkZXN0cm95KEF0b21pY1N0cmluZ1RhYmxlKiB0YWJsZSkKICAgICB7Cisg ICAgICAgIEhhc2hTZXQ8U3RyaW5nSW1wbCo+OjppdGVyYXRvciBlbmQgPSB0YWJsZS0+bV90YWJs ZS5lbmQoKTsKKyAgICAgICAgZm9yIChIYXNoU2V0PFN0cmluZ0ltcGwqPjo6aXRlcmF0b3IgaXRl ciA9IHRhYmxlLT5tX3RhYmxlLmJlZ2luKCk7IGl0ZXIgIT0gZW5kOyArK2l0ZXIpCisgICAgICAg ICAgICAoKml0ZXIpLT5zZXRJc0F0b21pYyhmYWxzZSk7CiAgICAgICAgIGRlbGV0ZSB0YWJsZTsK ICAgICB9CiAKQEAgLTkyLDcgKzk1LDcgQEAgc3RydWN0IENTdHJpbmdUcmFuc2xhdG9yIHsKICAg ICB7CiAgICAgICAgIGxvY2F0aW9uID0gU3RyaW5nSW1wbDo6Y3JlYXRlKGMpLnJlbGVhc2VSZWYo KTsgCiAgICAgICAgIGxvY2F0aW9uLT5zZXRIYXNoKGhhc2gpOwotICAgICAgICBsb2NhdGlvbi0+ c2V0SW5UYWJsZSgpOworICAgICAgICBsb2NhdGlvbi0+c2V0SXNBdG9taWModHJ1ZSk7CiAgICAg fQogfTsKIApAQCAtMTcxLDcgKzE3NCw3IEBAIHN0cnVjdCBVQ2hhckJ1ZmZlclRyYW5zbGF0b3Ig ewogICAgIHsKICAgICAgICAgbG9jYXRpb24gPSBTdHJpbmdJbXBsOjpjcmVhdGUoYnVmLnMsIGJ1 Zi5sZW5ndGgpLnJlbGVhc2VSZWYoKTsgCiAgICAgICAgIGxvY2F0aW9uLT5zZXRIYXNoKGhhc2gp OwotICAgICAgICBsb2NhdGlvbi0+c2V0SW5UYWJsZSgpOworICAgICAgICBsb2NhdGlvbi0+c2V0 SXNBdG9taWModHJ1ZSk7CiAgICAgfQogfTsKIApAQCAtMTk3LDcgKzIwMCw3IEBAIHN0cnVjdCBI YXNoQW5kQ2hhcmFjdGVyc1RyYW5zbGF0b3IgewogICAgIHsKICAgICAgICAgbG9jYXRpb24gPSBT dHJpbmdJbXBsOjpjcmVhdGUoYnVmZmVyLmNoYXJhY3RlcnMsIGJ1ZmZlci5sZW5ndGgpLnJlbGVh c2VSZWYoKTsKICAgICAgICAgbG9jYXRpb24tPnNldEhhc2goaGFzaCk7Ci0gICAgICAgIGxvY2F0 aW9uLT5zZXRJblRhYmxlKCk7CisgICAgICAgIGxvY2F0aW9uLT5zZXRJc0F0b21pYyh0cnVlKTsK ICAgICB9CiB9OwogCkBAIC0yNTQsNyArMjU3LDcgQEAgUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBB dG9taWNTdHJpbmc6OmFkZAogCiBQYXNzUmVmUHRyPFN0cmluZ0ltcGw+IEF0b21pY1N0cmluZzo6 YWRkKFN0cmluZ0ltcGwqIHIpCiB7Ci0gICAgaWYgKCFyIHx8IHItPmluVGFibGUoKSkKKyAgICBp ZiAoIXIgfHwgci0+aXNBdG9taWMoKSkKICAgICAgICAgcmV0dXJuIHI7CiAKICAgICBpZiAoci0+ bGVuZ3RoKCkgPT0gMCkKQEAgLTI2Miw3ICsyNjUsNyBAQCBQYXNzUmVmUHRyPFN0cmluZ0ltcGw+ IEF0b21pY1N0cmluZzo6YWRkCiAgICAgCiAgICAgU3RyaW5nSW1wbCogcmVzdWx0ID0gKnN0cmlu Z1RhYmxlKCkuYWRkKHIpLmZpcnN0OwogICAgIGlmIChyZXN1bHQgPT0gcikKLSAgICAgICAgci0+ c2V0SW5UYWJsZSgpOworICAgICAgICByLT5zZXRJc0F0b21pYyh0cnVlKTsKICAgICByZXR1cm4g cmVzdWx0OwogfQogCkluZGV4OiBKYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9TdHJpbmdJbXBsLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9TdHJpbmdJbXBsLmNwcAko cmV2aXNpb24gNTg4MzgpCisrKyBKYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9TdHJpbmdJbXBsLmNw cAkod29ya2luZyBjb3B5KQpAQCAtNDIsNyArNDIsNyBAQCBTdHJpbmdJbXBsOjp+U3RyaW5nSW1w bCgpCiB7CiAgICAgQVNTRVJUKCFpc1N0YXRpYygpKTsKIAotICAgIGlmIChpblRhYmxlKCkpCisg ICAgaWYgKGlzQXRvbWljKCkpCiAgICAgICAgIEF0b21pY1N0cmluZzo6cmVtb3ZlKHRoaXMpOwog I2lmIFVTRShKU0MpCiAgICAgaWYgKGlzSWRlbnRpZmllcigpKQpJbmRleDogSmF2YVNjcmlwdENv cmUvd3RmL3RleHQvU3RyaW5nSW1wbC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3d0 Zi90ZXh0L1N0cmluZ0ltcGwuaAkocmV2aXNpb24gNTg4MzgpCisrKyBKYXZhU2NyaXB0Q29yZS93 dGYvdGV4dC9TdHJpbmdJbXBsLmgJKHdvcmtpbmcgY29weSkKQEAgLTIyMyw4ICsyMjMsMTUgQEAg cHVibGljOgogCiAgICAgYm9vbCBoYXNUZXJtaW5hdGluZ051bGxDaGFyYWN0ZXIoKSBjb25zdCB7 IHJldHVybiBtX3JlZkNvdW50QW5kRmxhZ3MgJiBzX3JlZkNvdW50RmxhZ0hhc1Rlcm1pbmF0aW5n TnVsbENoYXJhY3RlcjsgfQogCi0gICAgYm9vbCBpblRhYmxlKCkgY29uc3QgeyByZXR1cm4gbV9y ZWZDb3VudEFuZEZsYWdzICYgc19yZWZDb3VudEZsYWdJblRhYmxlOyB9Ci0gICAgdm9pZCBzZXRJ blRhYmxlKCkgeyBtX3JlZkNvdW50QW5kRmxhZ3MgfD0gc19yZWZDb3VudEZsYWdJblRhYmxlOyB9 CisgICAgYm9vbCBpc0F0b21pYygpIGNvbnN0IHsgcmV0dXJuIG1fcmVmQ291bnRBbmRGbGFncyAm IHNfcmVmQ291bnRGbGFnSXNBdG9taWM7IH0KKyAgICB2b2lkIHNldElzQXRvbWljKGJvb2wgaXNJ ZGVudGlmaWVyKQorICAgIHsKKyAgICAgICAgQVNTRVJUKCFpc1N0YXRpYygpKTsKKyAgICAgICAg aWYgKGlzSWRlbnRpZmllcikKKyAgICAgICAgICAgIG1fcmVmQ291bnRBbmRGbGFncyB8PSBzX3Jl ZkNvdW50RmxhZ0lzQXRvbWljOworICAgICAgICBlbHNlCisgICAgICAgICAgICBtX3JlZkNvdW50 QW5kRmxhZ3MgJj0gc19yZWZDb3VudEZsYWdJc0F0b21pYzsKKyAgICB9CiAKICAgICB1bnNpZ25l ZCBoYXNoKCkgY29uc3QgeyBpZiAoIW1faGFzaCkgbV9oYXNoID0gY29tcHV0ZUhhc2gobV9kYXRh LCBtX2xlbmd0aCk7IHJldHVybiBtX2hhc2g7IH0KICAgICB1bnNpZ25lZCBleGlzdGluZ0hhc2go KSBjb25zdCB7IEFTU0VSVChtX2hhc2gpOyByZXR1cm4gbV9oYXNoOyB9CkluZGV4OiBKYXZhU2Ny aXB0Q29yZS93dGYvdGV4dC9TdHJpbmdJbXBsQmFzZS5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3Jp cHRDb3JlL3d0Zi90ZXh0L1N0cmluZ0ltcGxCYXNlLmgJKHJldmlzaW9uIDU4ODM4KQorKysgSmF2 YVNjcmlwdENvcmUvd3RmL3RleHQvU3RyaW5nSW1wbEJhc2UuaAkod29ya2luZyBjb3B5KQpAQCAt ODMsNyArODMsNyBAQCBwcm90ZWN0ZWQ6CiAgICAgc3RhdGljIGNvbnN0IHVuc2lnbmVkIHNfcmVm Q291bnRJbmNyZW1lbnQgPSAweDgwOwogICAgIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBzX3JlZkNv dW50RmxhZ1N0YXRpYyA9IDB4NDA7CiAgICAgc3RhdGljIGNvbnN0IHVuc2lnbmVkIHNfcmVmQ291 bnRGbGFnSGFzVGVybWluYXRpbmdOdWxsQ2hhcmFjdGVyID0gMHgyMDsKLSAgICBzdGF0aWMgY29u c3QgdW5zaWduZWQgc19yZWZDb3VudEZsYWdJblRhYmxlID0gMHgxMDsKKyAgICBzdGF0aWMgY29u c3QgdW5zaWduZWQgc19yZWZDb3VudEZsYWdJc0F0b21pYyA9IDB4MTA7CiAgICAgc3RhdGljIGNv bnN0IHVuc2lnbmVkIHNfcmVmQ291bnRGbGFnU2hvdWxkUmVwb3J0ZWRDb3N0ID0gMHg4OwogICAg IHN0YXRpYyBjb25zdCB1bnNpZ25lZCBzX3JlZkNvdW50RmxhZ0lzSWRlbnRpZmllciA9IDB4NDsK ICAgICBzdGF0aWMgY29uc3QgdW5zaWduZWQgc19yZWZDb3VudE1hc2tCdWZmZXJPd25lcnNoaXAg PSAweDM7CkluZGV4OiBXZWJjb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJjb3JlL0No YW5nZUxvZwkocmV2aXNpb24gNTg4MzgpCisrKyBXZWJjb3JlL0NoYW5nZUxvZwkod29ya2luZyBj b3B5KQpAQCAtMSwzICsxLDMwIEBACisyMDEwLTA1LTA1ICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJh cnJhY2xvdWdoQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBCdWcgMzg2MDQgLSB3b3JrZXJzLWdjMiBjcmFzaGluZyBvbiBRdAorCisg ICAgICAgIFRoaXMgYXBwZWFycyB0byBiZSBkdWUgdG8gYSBjb3VwbGUgb2YgaXNzdWVzLgorICAg ICAgICAoMSkgV2hlbiB0aGUgYXRvbWljIHN0cmluZyB0YWJsZSBpcyBkZWxldGVkIGl0IGRvZXMg bm90IGNsZWFyIHRoZSAnaW5UYWJsZScgYml0CisgICAgICAgIG9uIEF0b21pY1N0cmluZ3Mg4oCT IGl0IGltcGxpY2l0bHkgYXNzdW1lcyB0aGF0IGFsbCBBdG9taWNTdHJpbmdzIGhhdmUgYWxyZWFk eQorICAgICAgICBiZWVuIGRlbGV0ZWQgYXQgdGhpcyBwb2ludCAob3RoZXJ3aXNlIHRoZXkgd2ls bCBjcmFzaCBpbiB0aGVpciBkZXN0cnVjdG9yIHdoZW4KKyAgICAgICAgdGhleSB0cnkgdG8gcmVt b3ZlIHRoZW1zZWx2ZXMgZnJvbSB0aGUgYXRvbWljIHN0cmluZyB0YWJsZSkuCisgICAgICAgICgy KSBXZSBkb24ndCBmaXggdGhlIG9yZGVyaW5nIGluIHdoaWNoIFdURjo6V1RGVGhyZWFkRGF0YSBh bmQKKyAgICAgICAgV2ViQ29yZTo6VGhyZWFkR2xvYmFsRGF0YSBhcmUgZGVzdHJ1Y3RlZC4KKwor ICAgICAgICBXZSBzaG91bGQgbWFrZSBzdXJlIHRoYXQgVGhyZWFkR2xvYmFsRGF0YSBpcyBjbGVh bmVkIHVwIGJlZm9yZSB3b3JrZXIgdGhyZWFkcworICAgICAgICB0ZXJtaW5hdGUgYW5kIFdURjo6 V1RGVGhyZWFkRGF0YSBpcyBkZXN0cm95ZWQsIGFuZCB3ZSBzaG91bGQgY2xlYXIgdGhlIGluVGFi bGUKKyAgICAgICAgYml0IG9mIG1lbWJlcnMgb24gYXRvbWljIHN0cmluZyB0YWJsZSBkZXN0cnVj dGlvbi4KKworICAgICAgICBXVEYgY2hhbmdlcyAoZml4IGlzc3VlIDIsIGFib3ZlKSAtIGNsZWFu IHVwIHRoZSB0aHJlYWQgZGF0YSBvbiB3b3JrZXIgdGVybWluYXRpb24uCisKKyAgICAgICAgKiBw bGF0Zm9ybS9UaHJlYWRHbG9iYWxEYXRhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRocmVhZEds b2JhbERhdGE6On5UaHJlYWRHbG9iYWxEYXRhKToKKyAgICAgICAgKFdlYkNvcmU6OlRocmVhZEds b2JhbERhdGE6OmRlc3Ryb3kpOgorICAgICAgICAqIHBsYXRmb3JtL1RocmVhZEdsb2JhbERhdGEu aDoKKyAgICAgICAgKiB3b3JrZXJzL1dvcmtlclRocmVhZC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpXb3JrZXJUaHJlYWQ6OndvcmtlclRocmVhZCk6CisKIDIwMTAtMDUtMDUgIEFsZXhleSBQcm9z a3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgUm9sbCBvdXQgcjU4ODMwIGZvciBi cmVha2luZyB0ZXN0cy4KSW5kZXg6IFdlYmNvcmUvcGxhdGZvcm0vVGhyZWFkR2xvYmFsRGF0YS5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViY29yZS9wbGF0Zm9ybS9UaHJlYWRHbG9iYWxEYXRhLmNwcAko cmV2aXNpb24gNTg4MzgpCisrKyBXZWJjb3JlL3BsYXRmb3JtL1RocmVhZEdsb2JhbERhdGEuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC03OCwxNCArNzgsMjUgQEAgVGhyZWFkR2xvYmFsRGF0YTo6VGhy ZWFkR2xvYmFsRGF0YSgpCiAKIFRocmVhZEdsb2JhbERhdGE6On5UaHJlYWRHbG9iYWxEYXRhKCkK IHsKKyAgICBkZXN0cm95KCk7Cit9CisKK3ZvaWQgVGhyZWFkR2xvYmFsRGF0YTo6ZGVzdHJveSgp Cit7CiAjaWYgUExBVEZPUk0oTUFDKQogICAgIGRlbGV0ZSBtX2NhY2hlZENvbnZlcnRlclRFQzsK KyAgICBtX2NhY2hlZENvbnZlcnRlclRFQyA9IDA7CiAjZW5kaWYKKwogI2lmIFVTRShJQ1VfVU5J Q09ERSkKICAgICBkZWxldGUgbV9jYWNoZWRDb252ZXJ0ZXJJQ1U7CisgICAgbV9jYWNoZWRDb252 ZXJ0ZXJJQ1UgPSAwOwogI2VuZGlmCisKICAgICBkZWxldGUgbV9ldmVudE5hbWVzOworICAgIG1f ZXZlbnROYW1lcyA9IDA7CiAgICAgZGVsZXRlIG1fdGhyZWFkVGltZXJzOworICAgIG1fdGhyZWFk VGltZXJzID0gMDsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpJbmRleDogV2ViY29yZS9w bGF0Zm9ybS9UaHJlYWRHbG9iYWxEYXRhLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViY29yZS9wbGF0Zm9y bS9UaHJlYWRHbG9iYWxEYXRhLmgJKHJldmlzaW9uIDU4ODM4KQorKysgV2ViY29yZS9wbGF0Zm9y bS9UaHJlYWRHbG9iYWxEYXRhLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ5LDYgKzQ5LDcgQEAgbmFt ZXNwYWNlIFdlYkNvcmUgewogICAgIHB1YmxpYzoKICAgICAgICAgVGhyZWFkR2xvYmFsRGF0YSgp OwogICAgICAgICB+VGhyZWFkR2xvYmFsRGF0YSgpOworICAgICAgICB2b2lkIGRlc3Ryb3koKTsg Ly8gY2FsbGVkIG9uIHdvcmtlcnMgdG8gY2xlYW4gdXAgdGhlIFRocmVhZEdsb2JhbERhdGEgYmVm b3JlIHRoZSB0aHJlYWQgZXhpdHMuCiAKICAgICAgICAgRXZlbnROYW1lcyYgZXZlbnROYW1lcygp IHsgcmV0dXJuICptX2V2ZW50TmFtZXM7IH0KICAgICAgICAgVGhyZWFkVGltZXJzJiB0aHJlYWRU aW1lcnMoKSB7IHJldHVybiAqbV90aHJlYWRUaW1lcnM7IH0KSW5kZXg6IFdlYmNvcmUvd29ya2Vy cy9Xb3JrZXJUaHJlYWQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYmNvcmUvd29ya2Vycy9Xb3JrZXJU aHJlYWQuY3BwCShyZXZpc2lvbiA1ODgzOCkKKysrIFdlYmNvcmUvd29ya2Vycy9Xb3JrZXJUaHJl YWQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNiw2ICszNiw3IEBACiAjaW5jbHVkZSAiUGxhdGZv cm1TdHJpbmcuaCIKICNpbmNsdWRlICJTY3JpcHRTb3VyY2VDb2RlLmgiCiAjaW5jbHVkZSAiU2Ny aXB0VmFsdWUuaCIKKyNpbmNsdWRlICJUaHJlYWRHbG9iYWxEYXRhLmgiCiAKICNpbmNsdWRlIDx1 dGlsaXR5PgogI2luY2x1ZGUgPHd0Zi9Ob25jb3B5YWJsZS5oPgpAQCAtMTQxLDcgKzE0MiwxMCBA QCB2b2lkKiBXb3JrZXJUaHJlYWQ6OndvcmtlclRocmVhZCgpCiAgICAgLy8gVGhlIGJlbG93IGFz c2lnbm1lbnQgd2lsbCBkZXN0cm95IHRoZSBjb250ZXh0LCB3aGljaCB3aWxsIGluIHR1cm4gbm90 aWZ5IG1lc3NhZ2luZyBwcm94eS4KICAgICAvLyBXZSBjYW5ub3QgbGV0IGFueSBvYmplY3RzIHN1 cnZpdmUgcGFzdCB0aHJlYWQgZXhpdCwgYmVjYXVzZSBubyBvdGhlciB0aHJlYWQgd2lsbCBydW4g R0Mgb3Igb3RoZXJ3aXNlIGRlc3Ryb3kgdGhlbS4KICAgICBtX3dvcmtlckNvbnRleHQgPSAwOwot ICAgIAorCisgICAgLy8gQ2xlYW4gdXAgV2ViQ29yZTo6VGhyZWFkR2xvYmFsRGF0YSBiZWZvcmUg V1RGOjpXVEZUaHJlYWREYXRhIGdvZXMgYXdheSEKKyAgICB0aHJlYWRHbG9iYWxEYXRhKCkuZGVz dHJveSgpOworCiAgICAgLy8gVGhlIHRocmVhZCBvYmplY3QgbWF5IGJlIGFscmVhZHkgZGVzdHJv eWVkIGZyb20gbm90aWZpY2F0aW9uIG5vdywgZG9uJ3QgdHJ5IHRvIGFjY2VzcyAidGhpcyIuCiAg ICAgZGV0YWNoVGhyZWFkKHRocmVhZElEKTsKIAo=