38589 2010-05-05 08:54:45 -0700 [chromium] Add quota parameter to WebStorageNamespace::createSessionStorageNamespace 2010-05-05 11:14:41 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) All All RESOLVED FIXED P2 Enhancement --- 0 hans webkit-unassigned commit-queue jorlow oldest_to_newest 221130 0 hans 2010-05-05 08:54:45 -0700 Add quota parameter to WebStorageNamespace::createSessionStorageNamespace. See http://crbug.com/42740. 221168 1 55133 hans 2010-05-05 10:13:04 -0700 Created attachment 55133 Patch 221170 2 55133 jorlow 2010-05-05 10:17:54 -0700 Comment on attachment 55133 Patch Please fix and upload another patch. I'll commit queue + that one (so it'll get committed to WebKit). > diff --git a/WebKit/chromium/ChangeL > // If path is empty, data will not persist. You should call delete on the returned > // object when you're finished. > WEBKIT_API static WebStorageNamespace* createLocalStorageNamespace(const WebString& backingDirectoryPath, unsigned quota); > - WEBKIT_API static WebStorageNamespace* createSessionStorageNamespace(); > + Don't need this newline. > + WEBKIT_API static WebStorageNamespace* createSessionStorageNamespace(unsigned quota); > + Don't need this new lines. 221173 3 55134 hans 2010-05-05 10:23:50 -0700 Created attachment 55134 Patch 221176 4 55134 jorlow 2010-05-05 10:26:38 -0700 Comment on attachment 55134 Patch r=me 221200 5 55134 commit-queue 2010-05-05 11:14:35 -0700 Comment on attachment 55134 Patch Clearing flags on attachment: 55134 Committed r58828: <http://trac.webkit.org/changeset/58828> 221201 6 commit-queue 2010-05-05 11:14:41 -0700 All reviewed patches have been landed. Closing bug. 55133 2010-05-05 10:13:04 -0700 2010-05-05 10:23:45 -0700 Patch bug-38589-20100505181302.patch text/plain 2774 hans ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDliYmE3Yjc1YzI3YThiYTgxYjMzOGZjODdjMGFhYjgxMzBkM2Q4MjQu LjE4ZTQ1ZDk4YzAzZjZlNjc3ZWFiNzAzMzFjNjMxOTgxMTg2MzRjZjYgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDEwLTA1LTA1ICBIYW5zIFdlbm5ib3JnICA8aGFuc0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg W2Nocm9taXVtXSBBZGQgcXVvdGEgcGFyYW1ldGVyIHRvICBXZWJTdG9yYWdlTmFtZXNwYWNlOjpj cmVhdGVTZXNzaW9uU3RvcmFnZU5hbWVzcGFjZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg1ODkKKworICAgICAgICAqIHB1YmxpYy9XZWJTdG9yYWdl TmFtZXNwYWNlLmg6CisgICAgICAgIChXZWJLaXQ6OldlYlN0b3JhZ2VOYW1lc3BhY2U6OmNyZWF0 ZVNlc3Npb25TdG9yYWdlTmFtZXNwYWNlKToKKyAgICAgICAgKiBzcmMvV2ViU3RvcmFnZU5hbWVz cGFjZUltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJTdG9yYWdlTmFtZXNwYWNlOjpjcmVh dGVTZXNzaW9uU3RvcmFnZU5hbWVzcGFjZSk6CisKIDIwMTAtMDUtMDQgIFZhbmdlbGlzIEtva2tl dmlzICA8dmFuZ2VsaXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmlu IEZpc2hlci4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViU3RvcmFnZU5h bWVzcGFjZS5oIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTdG9yYWdlTmFtZXNwYWNlLmgK aW5kZXggZGE5MmE3NzJmNDk3MGFmNGZjZTE2MTY0NzNlMWVhYTNjYjNiZWZmNi4uYTZiZDY2ZGZj ZDM3MGQ1MTJhMzljZmQxNDJkOWZmNzFkZmZiNDJhNSAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJTdG9yYWdlTmFtZXNwYWNlLmgKKysrIGIvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJTdG9yYWdlTmFtZXNwYWNlLmgKQEAgLTQ4LDcgKzQ4LDEzIEBAIHB1YmxpYzoKICAg ICAvLyBJZiBwYXRoIGlzIGVtcHR5LCBkYXRhIHdpbGwgbm90IHBlcnNpc3QuIFlvdSBzaG91bGQg Y2FsbCBkZWxldGUgb24gdGhlIHJldHVybmVkCiAgICAgLy8gb2JqZWN0IHdoZW4geW91J3JlIGZp bmlzaGVkLgogICAgIFdFQktJVF9BUEkgc3RhdGljIFdlYlN0b3JhZ2VOYW1lc3BhY2UqIGNyZWF0 ZUxvY2FsU3RvcmFnZU5hbWVzcGFjZShjb25zdCBXZWJTdHJpbmcmIGJhY2tpbmdEaXJlY3RvcnlQ YXRoLCB1bnNpZ25lZCBxdW90YSk7Ci0gICAgV0VCS0lUX0FQSSBzdGF0aWMgV2ViU3RvcmFnZU5h bWVzcGFjZSogY3JlYXRlU2Vzc2lvblN0b3JhZ2VOYW1lc3BhY2UoKTsKKworICAgIFdFQktJVF9B UEkgc3RhdGljIFdlYlN0b3JhZ2VOYW1lc3BhY2UqIGNyZWF0ZVNlc3Npb25TdG9yYWdlTmFtZXNw YWNlKHVuc2lnbmVkIHF1b3RhKTsKKworICAgIFdFQktJVF9BUEkgc3RhdGljIFdlYlN0b3JhZ2VO YW1lc3BhY2UqIGNyZWF0ZVNlc3Npb25TdG9yYWdlTmFtZXNwYWNlKCkKKyAgICB7CisgICAgICAg IHJldHVybiBjcmVhdGVTZXNzaW9uU3RvcmFnZU5hbWVzcGFjZShub1F1b3RhKTsKKyAgICB9CiAK ICAgICBzdGF0aWMgY29uc3QgdW5zaWduZWQgbm9RdW90YSA9IFVJTlRfTUFYOwogCmRpZmYgLS1n aXQgYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlN0b3JhZ2VOYW1lc3BhY2VJbXBsLmNwcCBiL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViU3RvcmFnZU5hbWVzcGFjZUltcGwuY3BwCmluZGV4IDY2YmUw MjcxZjZhYzFkODdkMzgwN2Y4NWJmZmUxZTEyYWVmNTIzYTguLjVmYzZlMTZjMWY1ZmYzMzVjMzZh YmE1NDRlM2Y5YWE5OTQ5MWY0NGYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi U3RvcmFnZU5hbWVzcGFjZUltcGwuY3BwCisrKyBiL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU3Rv cmFnZU5hbWVzcGFjZUltcGwuY3BwCkBAIC00NSw5ICs0NSw5IEBAIFdlYlN0b3JhZ2VOYW1lc3Bh Y2UqIFdlYlN0b3JhZ2VOYW1lc3BhY2U6OmNyZWF0ZUxvY2FsU3RvcmFnZU5hbWVzcGFjZShjb25z dCBXZWJTCiAgICAgcmV0dXJuIG5ldyBXZWJTdG9yYWdlTmFtZXNwYWNlSW1wbChXZWJDb3JlOjpT dG9yYWdlTmFtZXNwYWNlSW1wbDo6bG9jYWxTdG9yYWdlTmFtZXNwYWNlKHBhdGgsIHF1b3RhKSk7 CiB9CiAKLVdlYlN0b3JhZ2VOYW1lc3BhY2UqIFdlYlN0b3JhZ2VOYW1lc3BhY2U6OmNyZWF0ZVNl c3Npb25TdG9yYWdlTmFtZXNwYWNlKCkKK1dlYlN0b3JhZ2VOYW1lc3BhY2UqIFdlYlN0b3JhZ2VO YW1lc3BhY2U6OmNyZWF0ZVNlc3Npb25TdG9yYWdlTmFtZXNwYWNlKHVuc2lnbmVkIHF1b3RhKQog ewotICAgIHJldHVybiBuZXcgV2ViU3RvcmFnZU5hbWVzcGFjZUltcGwoV2ViQ29yZTo6U3RvcmFn ZU5hbWVzcGFjZUltcGw6OnNlc3Npb25TdG9yYWdlTmFtZXNwYWNlKG5vUXVvdGEpKTsKKyAgICBy ZXR1cm4gbmV3IFdlYlN0b3JhZ2VOYW1lc3BhY2VJbXBsKFdlYkNvcmU6OlN0b3JhZ2VOYW1lc3Bh Y2VJbXBsOjpzZXNzaW9uU3RvcmFnZU5hbWVzcGFjZShxdW90YSkpOwogfQogCiBXZWJTdG9yYWdl TmFtZXNwYWNlSW1wbDo6V2ViU3RvcmFnZU5hbWVzcGFjZUltcGwoUGFzc1JlZlB0cjxXZWJDb3Jl OjpTdG9yYWdlTmFtZXNwYWNlPiBzdG9yYWdlTmFtZXNwYWNlKQo= 55134 2010-05-05 10:23:50 -0700 2010-05-05 11:14:34 -0700 Patch bug-38589-20100505182348.patch text/plain 2770 hans ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDliYmE3Yjc1YzI3YThiYTgxYjMzOGZjODdjMGFhYjgxMzBkM2Q4MjQu LjE4ZTQ1ZDk4YzAzZjZlNjc3ZWFiNzAzMzFjNjMxOTgxMTg2MzRjZjYgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDEwLTA1LTA1ICBIYW5zIFdlbm5ib3JnICA8aGFuc0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg W2Nocm9taXVtXSBBZGQgcXVvdGEgcGFyYW1ldGVyIHRvICBXZWJTdG9yYWdlTmFtZXNwYWNlOjpj cmVhdGVTZXNzaW9uU3RvcmFnZU5hbWVzcGFjZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg1ODkKKworICAgICAgICAqIHB1YmxpYy9XZWJTdG9yYWdl TmFtZXNwYWNlLmg6CisgICAgICAgIChXZWJLaXQ6OldlYlN0b3JhZ2VOYW1lc3BhY2U6OmNyZWF0 ZVNlc3Npb25TdG9yYWdlTmFtZXNwYWNlKToKKyAgICAgICAgKiBzcmMvV2ViU3RvcmFnZU5hbWVz cGFjZUltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJTdG9yYWdlTmFtZXNwYWNlOjpjcmVh dGVTZXNzaW9uU3RvcmFnZU5hbWVzcGFjZSk6CisKIDIwMTAtMDUtMDQgIFZhbmdlbGlzIEtva2tl dmlzICA8dmFuZ2VsaXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmlu IEZpc2hlci4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViU3RvcmFnZU5h bWVzcGFjZS5oIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTdG9yYWdlTmFtZXNwYWNlLmgK aW5kZXggZGE5MmE3NzJmNDk3MGFmNGZjZTE2MTY0NzNlMWVhYTNjYjNiZWZmNi4uNGI2NDhkNDNh NjM2MjJkZDViMTQ5YWY1ODg3MTU4NzllZTFmNDAzYSAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJTdG9yYWdlTmFtZXNwYWNlLmgKKysrIGIvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJTdG9yYWdlTmFtZXNwYWNlLmgKQEAgLTQ4LDcgKzQ4LDExIEBAIHB1YmxpYzoKICAg ICAvLyBJZiBwYXRoIGlzIGVtcHR5LCBkYXRhIHdpbGwgbm90IHBlcnNpc3QuIFlvdSBzaG91bGQg Y2FsbCBkZWxldGUgb24gdGhlIHJldHVybmVkCiAgICAgLy8gb2JqZWN0IHdoZW4geW91J3JlIGZp bmlzaGVkLgogICAgIFdFQktJVF9BUEkgc3RhdGljIFdlYlN0b3JhZ2VOYW1lc3BhY2UqIGNyZWF0 ZUxvY2FsU3RvcmFnZU5hbWVzcGFjZShjb25zdCBXZWJTdHJpbmcmIGJhY2tpbmdEaXJlY3RvcnlQ YXRoLCB1bnNpZ25lZCBxdW90YSk7Ci0gICAgV0VCS0lUX0FQSSBzdGF0aWMgV2ViU3RvcmFnZU5h bWVzcGFjZSogY3JlYXRlU2Vzc2lvblN0b3JhZ2VOYW1lc3BhY2UoKTsKKyAgICBXRUJLSVRfQVBJ IHN0YXRpYyBXZWJTdG9yYWdlTmFtZXNwYWNlKiBjcmVhdGVTZXNzaW9uU3RvcmFnZU5hbWVzcGFj ZSh1bnNpZ25lZCBxdW90YSk7CisgICAgV0VCS0lUX0FQSSBzdGF0aWMgV2ViU3RvcmFnZU5hbWVz cGFjZSogY3JlYXRlU2Vzc2lvblN0b3JhZ2VOYW1lc3BhY2UoKQorICAgIHsKKyAgICAgICAgcmV0 dXJuIGNyZWF0ZVNlc3Npb25TdG9yYWdlTmFtZXNwYWNlKG5vUXVvdGEpOworICAgIH0KIAogICAg IHN0YXRpYyBjb25zdCB1bnNpZ25lZCBub1F1b3RhID0gVUlOVF9NQVg7CiAKZGlmZiAtLWdpdCBh L1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU3RvcmFnZU5hbWVzcGFjZUltcGwuY3BwIGIvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJTdG9yYWdlTmFtZXNwYWNlSW1wbC5jcHAKaW5kZXggNjZiZTAyNzFm NmFjMWQ4N2QzODA3Zjg1YmZmZTFlMTJhZWY1MjNhOC4uNWZjNmUxNmMxZjVmZjMzNWMzNmFiYTU0 NGUzZjlhYTk5NDkxZjQ0ZiAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTdG9y YWdlTmFtZXNwYWNlSW1wbC5jcHAKKysrIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTdG9yYWdl TmFtZXNwYWNlSW1wbC5jcHAKQEAgLTQ1LDkgKzQ1LDkgQEAgV2ViU3RvcmFnZU5hbWVzcGFjZSog V2ViU3RvcmFnZU5hbWVzcGFjZTo6Y3JlYXRlTG9jYWxTdG9yYWdlTmFtZXNwYWNlKGNvbnN0IFdl YlMKICAgICByZXR1cm4gbmV3IFdlYlN0b3JhZ2VOYW1lc3BhY2VJbXBsKFdlYkNvcmU6OlN0b3Jh Z2VOYW1lc3BhY2VJbXBsOjpsb2NhbFN0b3JhZ2VOYW1lc3BhY2UocGF0aCwgcXVvdGEpKTsKIH0K IAotV2ViU3RvcmFnZU5hbWVzcGFjZSogV2ViU3RvcmFnZU5hbWVzcGFjZTo6Y3JlYXRlU2Vzc2lv blN0b3JhZ2VOYW1lc3BhY2UoKQorV2ViU3RvcmFnZU5hbWVzcGFjZSogV2ViU3RvcmFnZU5hbWVz cGFjZTo6Y3JlYXRlU2Vzc2lvblN0b3JhZ2VOYW1lc3BhY2UodW5zaWduZWQgcXVvdGEpCiB7Ci0g ICAgcmV0dXJuIG5ldyBXZWJTdG9yYWdlTmFtZXNwYWNlSW1wbChXZWJDb3JlOjpTdG9yYWdlTmFt ZXNwYWNlSW1wbDo6c2Vzc2lvblN0b3JhZ2VOYW1lc3BhY2Uobm9RdW90YSkpOworICAgIHJldHVy biBuZXcgV2ViU3RvcmFnZU5hbWVzcGFjZUltcGwoV2ViQ29yZTo6U3RvcmFnZU5hbWVzcGFjZUlt cGw6OnNlc3Npb25TdG9yYWdlTmFtZXNwYWNlKHF1b3RhKSk7CiB9CiAKIFdlYlN0b3JhZ2VOYW1l c3BhY2VJbXBsOjpXZWJTdG9yYWdlTmFtZXNwYWNlSW1wbChQYXNzUmVmUHRyPFdlYkNvcmU6OlN0 b3JhZ2VOYW1lc3BhY2U+IHN0b3JhZ2VOYW1lc3BhY2UpCg==