38564 2010-05-04 22:36:39 -0700 Caret keeps blinking during forward-delete 2011-12-09 11:36:44 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED P2 Normal --- 1 mitz webkit-unassigned ap darin rniwa vanlam webkit.review.bot oldest_to_newest 220964 0 mitz 2010-05-04 22:36:39 -0700 Steps to reproduce: 1. Type something in one of the text fields in this page 2. Move the caret to the beginning of the field 3. Hold down the (forward) delete key The caret does not stop blinking as it should. Compare with (backwards) delete or ordinary typing. 459873 1 105823 vanlam 2011-08-31 13:42:21 -0700 Created attachment 105823 Proposed fix 460077 2 105823 darin 2011-08-31 16:51:30 -0700 Comment on attachment 105823 Proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=105823&action=review r=me, but I think this could be slightly improved coding-style-wise I also would like to see us come up with a way to test. > Source/WebCore/editing/FrameSelection.cpp:1604 > + bool shouldStopBlinkingDueToTypingCommand = (m_frame && (lastEditCommand = m_frame->editor()->lastEditCommand())) ? > + lastEditCommand->shouldStopCaretBlinking() : false; The last part of this should also be written using && rather than ? : Also, this is hard to read with the assignment in the middle of it. I think it would be clearer like this: EditCommand* lastEditCommand = m_frame ? m_frame->editor()->lastEditCommand() : 0; bool shouldStopBlinkingDueToTypingCommand = lastEditCommand && lastEditCommand->shouldStopCaretBlinking(); > Source/WebCore/editing/TypingCommand.h:73 > + bool shouldStopCaretBlinking() const { return true; } This override could, and should, be private rather than public. It would be a programming mistake to call this on a TypingCommand*. 460078 3 105823 darin 2011-08-31 16:51:55 -0700 Comment on attachment 105823 Proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=105823&action=review >> Source/WebCore/editing/TypingCommand.h:73 >> + bool shouldStopCaretBlinking() const { return true; } > > This override could, and should, be private rather than public. It would be a programming mistake to call this on a TypingCommand*. Also, WebKit coding style is to always explicitly say virtual on a virtual function override like this one. 460159 4 105880 vanlam 2011-08-31 18:58:16 -0700 Created attachment 105880 Updated patch Thanks for the review, Darin. After thinking about how to test this change, I'm unsure on how the blinking caret is exposed such that we can test it. Any ideas anyone? 462908 5 105823 eric 2011-09-06 15:28:30 -0700 Comment on attachment 105823 Proposed fix Cleared Darin Adler's review+ from obsolete attachment 105823 so that this bug does not appear in http://webkit.org/pending-commit. 517973 6 rniwa 2011-12-08 17:35:21 -0800 (In reply to comment #4) > Thanks for the review, Darin. After thinking about how to test this change, I'm unsure on how the blinking caret is exposed such that we can test it. Any ideas anyone? Unfortunately, there isn't a way to test this. But the patch looks seems valuable as is so let's just land this. 518013 7 105880 webkit.review.bot 2011-12-08 18:28:42 -0800 Comment on attachment 105880 Updated patch Clearing flags on attachment: 105880 Committed r102413: <http://trac.webkit.org/changeset/102413> 518014 8 webkit.review.bot 2011-12-08 18:28:46 -0800 All reviewed patches have been landed. Closing bug. 518360 9 darin 2011-12-09 11:36:44 -0800 A manual test would be possible; automated tests are not the only valuable ones. Please, someone, make a manual test for the manual tests directory. 105823 2011-08-31 13:42:21 -0700 2011-09-06 15:28:30 -0700 Proposed fix vanlam-forwarddelete text/plain 3785 vanlam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk0MjIyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMzEgQEAKKzIwMTEtMDgtMzEgIFZhbiBMYW0g IDx2YW5sYW1AZ29vZ2xlLmNvbT4KKworICAgICAgICBDYXJldCBrZWVwcyBibGlua2luZyBkdXJp bmcgZm9yd2FyZC1kZWxldGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTM4NTY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQ3VycmVudGx5IHVwZGF0ZUFwcGVhcmFuY2UgZGV0ZXJtaW5lcyBpZiB0aGUgY2Fy ZXQgc2hvdWxkIHN0b3AgYmxpbmtpbmcKKyAgICAgICAgYmFzZWQgb24gd2hldGhlciBvciBub3Qg dGhlIGVkaXRpbmcgb3BlcmF0aW9uIGNoYW5nZWQgdGhlIHBvc2l0aW9uIG9mCisgICAgICAgIHRo ZSBjYXJldDsgc28gdGhlIGNhcmV0IHN0b3BzIGJsaW5raW5nIGluIGNhc2Ugb2YgdHlwaW5nIHRl eHQgYW5kCisgICAgICAgIGJhY2t3YXJkcyBkZWxldGUgKHdoaWNoIGFsd2F5cyBkaXNwbGFjZSB0 aGUgY2FyZXQpIGJ1dCBkb2VzIG5vdCBzdG9wCisgICAgICAgIGJsaW5raW5nIGluIHRoZSBjYXNl IG9mIGZvcndhcmQgZGVsZXRlICh3aGljaCBkb2VzIG5vdCBkaXNwbGFjZSB0aGUKKyAgICAgICAg Y2FyZXQpLgorCisgICAgICAgIEFkZGVkIGEgYm9vbGVhbiBtZW1iZXIgZnVuY3Rpb24gc2hvdWxk U3RvcENhcmV0QmxpbmtpbmcgaW4gRWRpdENvbW1hbmQKKyAgICAgICAgd2hpY2ggd2lsbCByZXR1 cm4gdHJ1ZSBpZiB0aGUgb2JqZWN0IGlzIGEgVHlwaW5nQ29tbWFuZCAobXkKKyAgICAgICAgdW5k ZXJzdGFuZGluZyBoZXJlIGlzIHRoYXQgYWxsIFR5cGluZ0NvbW1hbmRzIHNob3VsZCBzdG9wIHRo ZSBjYXJldAorICAgICAgICBmcm9tIGJsaW5raW5nIGZvciBhIGN5Y2xlLCBjdXJyZW50bHkgMC41 IHNlY29uZHMpLiBUaGVuIHVzZWQgdGhpcworICAgICAgICBmdW5jdGlvbiB0byBzdG9wIHRoZSBj YXJldCBmcm9tIGJsaW5raW5nIGlmIHRoZSBsYXN0IGVkaXRpbmcgY29tbWFuZAorICAgICAgICBp cyBhIFR5cGluZ0NvbW1hbmQuCisKKyAgICAgICAgKiBlZGl0aW5nL0VkaXRDb21tYW5kLmg6Cisg ICAgICAgIChXZWJDb3JlOjpFZGl0Q29tbWFuZDo6c2hvdWxkU3RvcENhcmV0QmxpbmtpbmcpOgor ICAgICAgICAqIGVkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6 RnJhbWVTZWxlY3Rpb246OnVwZGF0ZUFwcGVhcmFuY2UpOgorICAgICAgICAqIGVkaXRpbmcvVHlw aW5nQ29tbWFuZC5oOgorICAgICAgICAoV2ViQ29yZTo6VHlwaW5nQ29tbWFuZDo6c2hvdWxkU3Rv cENhcmV0QmxpbmtpbmcpOgorCiAyMDExLTA4LTMxICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFz ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIENyYXNoIHdpdGggLXdlYmtpdC1yYWRpYWwtZ3JhZGll bnQodG9wKSBncmFkaWVudApJbmRleDogU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0Q29tbWFu ZC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdENvbW1hbmQuaAko cmV2aXNpb24gOTQyMjIpCisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRDb21tYW5kLmgJ KHdvcmtpbmcgY29weSkKQEAgLTYyLDYgKzYyLDcgQEAgcHVibGljOgogCiAgICAgdmlydHVhbCBi b29sIHNob3VsZFJldGFpbkF1dG9jb3JyZWN0aW9uSW5kaWNhdG9yKCkgY29uc3Q7CiAgICAgdmly dHVhbCB2b2lkIHNldFNob3VsZFJldGFpbkF1dG9jb3JyZWN0aW9uSW5kaWNhdG9yKGJvb2wpOwor ICAgIHZpcnR1YWwgYm9vbCBzaG91bGRTdG9wQ2FyZXRCbGlua2luZygpIGNvbnN0IHsgcmV0dXJu IGZhbHNlOyB9CiAKIHByb3RlY3RlZDoKICAgICBFZGl0Q29tbWFuZChEb2N1bWVudCopOwpJbmRl eDogU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHAJKHJldmlzaW9uIDk0 MjIyKQorKysgU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTE1OTgsMTAgKzE1OTgsMTQgQEAgdm9pZCBGcmFtZVNlbGVjdGlvbjo6dXBk YXRlQXBwZWFyYW5jZSgpCiAKICAgICBib29sIGNhcmV0QnJvd3NpbmcgPSBtX2ZyYW1lLT5zZXR0 aW5ncygpICYmIG1fZnJhbWUtPnNldHRpbmdzKCktPmNhcmV0QnJvd3NpbmdFbmFibGVkKCk7CiAg ICAgYm9vbCBzaG91bGRCbGluayA9IGNhcmV0SXNWaXNpYmxlKCkgJiYgaXNDYXJldCgpICYmIChp c0NvbnRlbnRFZGl0YWJsZSgpIHx8IGNhcmV0QnJvd3NpbmcpOworICAgIAorICAgIEVkaXRDb21t YW5kKiBsYXN0RWRpdENvbW1hbmQ7CisgICAgYm9vbCBzaG91bGRTdG9wQmxpbmtpbmdEdWVUb1R5 cGluZ0NvbW1hbmQgPSAobV9mcmFtZSAmJiAobGFzdEVkaXRDb21tYW5kID0gbV9mcmFtZS0+ZWRp dG9yKCktPmxhc3RFZGl0Q29tbWFuZCgpKSkgPworICAgICAgICBsYXN0RWRpdENvbW1hbmQtPnNo b3VsZFN0b3BDYXJldEJsaW5raW5nKCkgOiBmYWxzZTsKIAogICAgIC8vIElmIHRoZSBjYXJldCBt b3ZlZCwgc3RvcCB0aGUgYmxpbmsgdGltZXIgc28gd2UgY2FuIHJlc3RhcnQgd2l0aCBhCiAgICAg Ly8gYmxhY2sgY2FyZXQgaW4gdGhlIG5ldyBsb2NhdGlvbi4KLSAgICBpZiAoY2FyZXRSZWN0Q2hh bmdlZCB8fCAhc2hvdWxkQmxpbmspCisgICAgaWYgKGNhcmV0UmVjdENoYW5nZWQgfHwgIXNob3Vs ZEJsaW5rIHx8IHNob3VsZFN0b3BCbGlua2luZ0R1ZVRvVHlwaW5nQ29tbWFuZCkKICAgICAgICAg bV9jYXJldEJsaW5rVGltZXIuc3RvcCgpOwogCiAgICAgLy8gU3RhcnQgYmxpbmtpbmcgd2l0aCBh IGJsYWNrIGNhcmV0LiBCZSBzdXJlIG5vdCB0byByZXN0YXJ0IGlmIHdlJ3JlCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9lZGl0aW5nL1R5cGluZ0NvbW1hbmQuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9lZGl0aW5nL1R5cGluZ0NvbW1hbmQuaAkocmV2aXNpb24gOTQyMjIpCisrKyBTb3Vy Y2UvV2ViQ29yZS9lZGl0aW5nL1R5cGluZ0NvbW1hbmQuaAkod29ya2luZyBjb3B5KQpAQCAtNzAs NiArNzAsNyBAQCBwdWJsaWM6CiAgICAgCiAgICAgYm9vbCBpc09wZW5Gb3JNb3JlVHlwaW5nKCkg Y29uc3QgeyByZXR1cm4gbV9vcGVuRm9yTW9yZVR5cGluZzsgfQogICAgIHZvaWQgY2xvc2VUeXBp bmcoKSB7IG1fb3BlbkZvck1vcmVUeXBpbmcgPSBmYWxzZTsgfQorICAgIGJvb2wgc2hvdWxkU3Rv cENhcmV0QmxpbmtpbmcoKSBjb25zdCB7IHJldHVybiB0cnVlOyB9CiAKICAgICB2b2lkIGluc2Vy dFRleHQoY29uc3QgU3RyaW5nICZ0ZXh0LCBib29sIHNlbGVjdEluc2VydGVkVGV4dCk7CiAgICAg dm9pZCBpbnNlcnRUZXh0UnVuV2l0aG91dE5ld2xpbmVzKGNvbnN0IFN0cmluZyAmdGV4dCwgYm9v bCBzZWxlY3RJbnNlcnRlZFRleHQpOwo= 105880 2011-08-31 18:58:16 -0700 2011-12-08 18:28:42 -0800 Updated patch vanlam-forwarddelete text/plain 3994 vanlam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk0MjIyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMzEgQEAKKzIwMTEtMDgtMzEgIFZhbiBMYW0g IDx2YW5sYW1AZ29vZ2xlLmNvbT4KKworICAgICAgICBDYXJldCBrZWVwcyBibGlua2luZyBkdXJp bmcgZm9yd2FyZC1kZWxldGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTM4NTY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAg ICAgICAgQ3VycmVudGx5IHVwZGF0ZUFwcGVhcmFuY2UgZGV0ZXJtaW5lcyBpZiB0aGUgY2FyZXQg c2hvdWxkIHN0b3AgYmxpbmtpbmcKKyAgICAgICAgYmFzZWQgb24gd2hldGhlciBvciBub3QgdGhl IGVkaXRpbmcgb3BlcmF0aW9uIGNoYW5nZWQgdGhlIHBvc2l0aW9uIG9mCisgICAgICAgIHRoZSBj YXJldDsgc28gdGhlIGNhcmV0IHN0b3BzIGJsaW5raW5nIGluIGNhc2Ugb2YgdHlwaW5nIHRleHQg YW5kCisgICAgICAgIGJhY2t3YXJkcyBkZWxldGUgKHdoaWNoIGFsd2F5cyBkaXNwbGFjZSB0aGUg Y2FyZXQpIGJ1dCBkb2VzIG5vdCBzdG9wCisgICAgICAgIGJsaW5raW5nIGluIHRoZSBjYXNlIG9m IGZvcndhcmQgZGVsZXRlICh3aGljaCBkb2VzIG5vdCBkaXNwbGFjZSB0aGUKKyAgICAgICAgY2Fy ZXQpLgorCisgICAgICAgIEFkZGVkIGEgYm9vbGVhbiBtZW1iZXIgZnVuY3Rpb24gc2hvdWxkU3Rv cENhcmV0QmxpbmtpbmcgaW4gRWRpdENvbW1hbmQKKyAgICAgICAgd2hpY2ggd2lsbCByZXR1cm4g dHJ1ZSBpZiB0aGUgb2JqZWN0IGlzIGEgVHlwaW5nQ29tbWFuZCAobXkKKyAgICAgICAgdW5kZXJz dGFuZGluZyBoZXJlIGlzIHRoYXQgYWxsIFR5cGluZ0NvbW1hbmRzIHNob3VsZCBzdG9wIHRoZSBj YXJldAorICAgICAgICBmcm9tIGJsaW5raW5nIGZvciBhIGN5Y2xlLCBjdXJyZW50bHkgMC41IHNl Y29uZHMpLiBUaGVuIHVzZWQgdGhpcworICAgICAgICBmdW5jdGlvbiB0byBzdG9wIHRoZSBjYXJl dCBmcm9tIGJsaW5raW5nIGlmIHRoZSBsYXN0IGVkaXRpbmcgY29tbWFuZAorICAgICAgICBpcyBh IFR5cGluZ0NvbW1hbmQuCisKKyAgICAgICAgKiBlZGl0aW5nL0VkaXRDb21tYW5kLmg6CisgICAg ICAgIChXZWJDb3JlOjpFZGl0Q29tbWFuZDo6c2hvdWxkU3RvcENhcmV0QmxpbmtpbmcpOgorICAg ICAgICAqIGVkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJh bWVTZWxlY3Rpb246OnVwZGF0ZUFwcGVhcmFuY2UpOgorICAgICAgICAqIGVkaXRpbmcvVHlwaW5n Q29tbWFuZC5oOgorICAgICAgICAoV2ViQ29yZTo6VHlwaW5nQ29tbWFuZDo6c2hvdWxkU3RvcENh cmV0QmxpbmtpbmcpOgorCiAyMDExLTA4LTMxICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJA YXBwbGUuY29tPgogCiAgICAgICAgIENyYXNoIHdpdGggLXdlYmtpdC1yYWRpYWwtZ3JhZGllbnQo dG9wKSBncmFkaWVudApJbmRleDogU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0Q29tbWFuZC5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdENvbW1hbmQuaAkocmV2 aXNpb24gOTQyMjIpCisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRDb21tYW5kLmgJKHdv cmtpbmcgY29weSkKQEAgLTYyLDYgKzYyLDcgQEAgcHVibGljOgogCiAgICAgdmlydHVhbCBib29s IHNob3VsZFJldGFpbkF1dG9jb3JyZWN0aW9uSW5kaWNhdG9yKCkgY29uc3Q7CiAgICAgdmlydHVh bCB2b2lkIHNldFNob3VsZFJldGFpbkF1dG9jb3JyZWN0aW9uSW5kaWNhdG9yKGJvb2wpOworICAg IHZpcnR1YWwgYm9vbCBzaG91bGRTdG9wQ2FyZXRCbGlua2luZygpIGNvbnN0IHsgcmV0dXJuIGZh bHNlOyB9CiAKIHByb3RlY3RlZDoKICAgICBFZGl0Q29tbWFuZChEb2N1bWVudCopOwpJbmRleDog U291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHAJKHJldmlzaW9uIDk0MjIy KQorKysgU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTE1OTgsMTAgKzE1OTgsMTMgQEAgdm9pZCBGcmFtZVNlbGVjdGlvbjo6dXBkYXRl QXBwZWFyYW5jZSgpCiAKICAgICBib29sIGNhcmV0QnJvd3NpbmcgPSBtX2ZyYW1lLT5zZXR0aW5n cygpICYmIG1fZnJhbWUtPnNldHRpbmdzKCktPmNhcmV0QnJvd3NpbmdFbmFibGVkKCk7CiAgICAg Ym9vbCBzaG91bGRCbGluayA9IGNhcmV0SXNWaXNpYmxlKCkgJiYgaXNDYXJldCgpICYmIChpc0Nv bnRlbnRFZGl0YWJsZSgpIHx8IGNhcmV0QnJvd3NpbmcpOworICAgIAorICAgIEVkaXRDb21tYW5k KiBsYXN0RWRpdENvbW1hbmQgPSBtX2ZyYW1lID8gbV9mcmFtZS0+ZWRpdG9yKCktPmxhc3RFZGl0 Q29tbWFuZCgpIDogMDsKKyAgICBib29sIHNob3VsZFN0b3BCbGlua2luZ0R1ZVRvVHlwaW5nQ29t bWFuZCA9IGxhc3RFZGl0Q29tbWFuZCAmJiBsYXN0RWRpdENvbW1hbmQtPnNob3VsZFN0b3BDYXJl dEJsaW5raW5nKCk7CiAKICAgICAvLyBJZiB0aGUgY2FyZXQgbW92ZWQsIHN0b3AgdGhlIGJsaW5r IHRpbWVyIHNvIHdlIGNhbiByZXN0YXJ0IHdpdGggYQogICAgIC8vIGJsYWNrIGNhcmV0IGluIHRo ZSBuZXcgbG9jYXRpb24uCi0gICAgaWYgKGNhcmV0UmVjdENoYW5nZWQgfHwgIXNob3VsZEJsaW5r KQorICAgIGlmIChjYXJldFJlY3RDaGFuZ2VkIHx8ICFzaG91bGRCbGluayB8fCBzaG91bGRTdG9w QmxpbmtpbmdEdWVUb1R5cGluZ0NvbW1hbmQpCiAgICAgICAgIG1fY2FyZXRCbGlua1RpbWVyLnN0 b3AoKTsKIAogICAgIC8vIFN0YXJ0IGJsaW5raW5nIHdpdGggYSBibGFjayBjYXJldC4gQmUgc3Vy ZSBub3QgdG8gcmVzdGFydCBpZiB3ZSdyZQpJbmRleDogU291cmNlL1dlYkNvcmUvZWRpdGluZy9U eXBpbmdDb21tYW5kLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZWRpdGluZy9UeXBp bmdDb21tYW5kLmgJKHJldmlzaW9uIDk0MjIyKQorKysgU291cmNlL1dlYkNvcmUvZWRpdGluZy9U eXBpbmdDb21tYW5kLmgJKHdvcmtpbmcgY29weSkKQEAgLTEwMyw2ICsxMDMsNyBAQCBwcml2YXRl OgogICAgIHZpcnR1YWwgYm9vbCBwcmVzZXJ2ZXNUeXBpbmdTdHlsZSgpIGNvbnN0IHsgcmV0dXJu IG1fcHJlc2VydmVzVHlwaW5nU3R5bGU7IH0KICAgICB2aXJ0dWFsIGJvb2wgc2hvdWxkUmV0YWlu QXV0b2NvcnJlY3Rpb25JbmRpY2F0b3IoKSBjb25zdCB7IHJldHVybiBtX3Nob3VsZFJldGFpbkF1 dG9jb3JyZWN0aW9uSW5kaWNhdG9yOyB9CiAgICAgdmlydHVhbCB2b2lkIHNldFNob3VsZFJldGFp bkF1dG9jb3JyZWN0aW9uSW5kaWNhdG9yKGJvb2wgcmV0YWluKSB7IG1fc2hvdWxkUmV0YWluQXV0 b2NvcnJlY3Rpb25JbmRpY2F0b3IgPSByZXRhaW47IH0KKyAgICB2aXJ0dWFsIGJvb2wgc2hvdWxk U3RvcENhcmV0QmxpbmtpbmcoKSBjb25zdCB7IHJldHVybiB0cnVlOyB9CiAgICAgdm9pZCBzZXRT aG91bGRQcmV2ZW50U3BlbGxDaGVja2luZyhib29sIHByZXZlbnQpIHsgbV9zaG91bGRQcmV2ZW50 U3BlbGxDaGVja2luZyA9IHByZXZlbnQ7IH0KIAogICAgIHN0YXRpYyB2b2lkIHVwZGF0ZVNlbGVj dGlvbklmRGlmZmVyZW50RnJvbUN1cnJlbnRTZWxlY3Rpb24oVHlwaW5nQ29tbWFuZCosIEZyYW1l Kik7Cg==