38560 2010-05-04 18:33:20 -0700 WebGL demos show bad flicker 2010-06-18 13:51:37 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All OS X 10.6 RESOLVED FIXED http://plopbyte.net/?page_id=111/ P1 Normal --- 33416 36908 1 simon.fraser zmo cmarrin dglazkov eric kbr oldest_to_newest 220927 0 simon.fraser 2010-05-04 18:33:20 -0700 With a recent nightly, these two WebGL demos show bad flickering: http://plopbyte.net/?page_id=111/ http://www.cubicvr.org/CubicVR.js/LandscapeTest1.html 220930 1 simon.fraser 2010-05-04 18:43:39 -0700 My graphics hardware: ATI Radeon HD 2600 XT: Chipset Model: ATI Radeon HD 2600 Type: GPU Bus: PCIe Slot: Slot-1 PCIe Lane Width: x16 VRAM (Total): 256 MB Vendor: ATI (0x1002) Device ID: 0x9588 Revision ID: 0x0000 ROM Revision: 113-B1480A-252 EFI Driver Version: 01.00.252 Displays: Cinema HD Display: Resolution: 1920 x 1200 Pixel Depth: 32-Bit Color (ARGB8888) Main Display: Yes Mirror: Off Online: Yes Rotation: Supported DELL 2005FPW: Resolution: 1680 x 1050 @ 60 Hz Pixel Depth: 32-Bit Color (ARGB8888) Mirror: Off Online: Yes Rotation: Supported 220932 2 simon.fraser 2010-05-04 18:45:43 -0700 This is is particularly bad: http://www.cubicvr.org/CubicVR.js/ObjectCompositeTest.html 232015 3 simon.fraser 2010-05-28 17:03:13 -0700 This regressed in http://trac.webkit.org/changeset/56872 Performance in general on my machine is much worse after this change. 232027 4 zmo 2010-05-28 17:16:33 -0700 Can you run the demo with {antialias: false} for context attributes? And what's the performance like? 232028 5 zmo 2010-05-28 17:19:19 -0700 Forget about the previous comments. I see your card is ATI, for which the antialias is false. 232029 6 simon.fraser 2010-05-28 17:23:40 -0700 For example, when http://www.cubicvr.org/CubicVR.js/ObjectCompositeTest.html is loading, entire parts of the scene, like the walls and columns, flicker in and out, and the animation overall is jerky. That didn't happen prior to r56872. 232034 7 zmo 2010-05-28 17:35:37 -0700 I had a quick look at the patch. Seems like the difference (for your machine) is the stencil is on. Can you try the demo with {stencil: false} in context creation and let me know the performance? 232119 8 cmarrin 2010-05-29 09:50:25 -0700 This also happens for me on two different machines, both of which have different ATI chipsets. It looks like your logic for deciding how to deal with the textures is flipping frame-to-frame or something like that. This needs to be fixed ASAP. If you can't determine the root cause, please disable whatever is causing the flicker on ATI cards in Safari. 232142 9 zmo 2010-05-29 14:04:31 -0700 I don't have access to a machine with ATI card, so if anyone with ATI card can run the demo with {stensil: false} at content creation and let me know if it solves the performance issue, then I'll know what to do. 233514 10 zmo 2010-06-02 17:17:47 -0700 See https://bugs.webkit.org/show_bug.cgi?id=40090. Hopefully the landing of a patch there will resolve this issue. 233746 11 cmarrin 2010-06-03 07:06:33 -0700 Yes, that patch may resolve the issue, but I assume the problem would return if you turn on stencil in your content. So we really need to understand why stencil being on causes the flicker 233837 12 zmo 2010-06-03 11:11:28 -0700 (In reply to comment #11) > Yes, that patch may resolve the issue, but I assume the problem would return if you turn on stencil in your content. So we really need to understand why stencil being on causes the flicker I tried on kbr's Mac which has ATI card and couldn't reproduce the flicking. When the patch lands and either you or Simon can confirm it does resolve the issue, then we should file a driver bug to Apple. 233841 13 zmo 2010-06-03 11:17:32 -0700 (In reply to comment #11) > Yes, that patch may resolve the issue, but I assume the problem would return if you turn on stencil in your content. So we really need to understand why stencil being on causes the flicker One thing we could do is use something other than GL_DEPTH24_STENCIL8_EXT for certain ATI cards when a user requests stencil buffer. 234418 14 zmo 2010-06-04 16:18:50 -0700 Patch for https://bugs.webkit.org/show_bug.cgi?id=40090 landed last night. Please verify if the flicking is gone. We couldn't reproduce it on our side. 237148 15 simon.fraser 2010-06-11 16:50:24 -0700 There is no improvement in the flickering. 237149 16 simon.fraser 2010-06-11 16:53:11 -0700 http://www.cubicvr.org/CubicVR.js/ObjectCompositeTest.html doesn't work at all for me in a recent nightly. 238087 17 zmo 2010-06-14 15:27:17 -0700 (In reply to comment #15) > There is no improvement in the flickering. That's really weird. Because with antialias==false and stencil==false, WebGL should be the same with/without http://trac.webkit.org/changeset/56872. 238089 18 zmo 2010-06-14 15:28:36 -0700 (In reply to comment #17) > (In reply to comment #15) > > There is no improvement in the flickering. > > That's really weird. Because with antialias==false and stencil==false, WebGL should be the same with/without http://trac.webkit.org/changeset/56872. (In reply to comment #16) > http://www.cubicvr.org/CubicVR.js/ObjectCompositeTest.html doesn't work at all for me in a recent nightly. This is also weird. I just synced with the codebase and built webkit. The demo worked fine on my side. 238114 19 kbr 2010-06-14 15:56:56 -0700 FYI, we're trying to schedule some time in the Apple Compatibility Lab to diagnose this on the hardware in questions. 240070 20 kbr 2010-06-18 12:04:32 -0700 zmo and I tracked down the regression to the moving of the ensureContext call in GraphicsContext3D::prepareTexture (GraphicsContext3DMac.mm) into the "if (m_attrs.antialias)" block in bug 33416. Bug 36908 fixed part of this regression (the moving of a glFinish call into the same block) but not this part. svn diff follows; a patch will be filed shortly. Index: WebCore/platform/graphics/mac/GraphicsContext3DMac.mm =================================================================== --- WebCore/platform/graphics/mac/GraphicsContext3DMac.mm (revision 61422) +++ WebCore/platform/graphics/mac/GraphicsContext3DMac.mm (working copy) @@ -383,8 +383,8 @@ void GraphicsContext3D::prepareTexture() { + ensureContext(m_contextObj); if (m_attrs.antialias) { - ensureContext(m_contextObj); ::glBindFramebufferEXT(GL_READ_FRAMEBUFFER_EXT, m_multisampleFBO); ::glBindFramebufferEXT(GL_DRAW_FRAMEBUFFER_EXT, m_fbo); ::glBlitFramebufferEXT(0, 0, m_currentWidth, m_currentHeight, 0, 0, m_currentWidth, m_currentHeight, GL_COLOR_BUFFER_BIT, GL_LINEAR); 240105 21 59149 zmo 2010-06-18 13:32:39 -0700 Created attachment 59149 patch 240111 22 kbr 2010-06-18 13:44:36 -0700 Looks good. 240113 23 zmo 2010-06-18 13:47:11 -0700 Committed manually: http://trac.webkit.org/changeset/61432 240115 24 eric 2010-06-18 13:51:37 -0700 Please copy the ChangeLog into the commit message. Tools like "webkit-patch land" can help do that for you. 59149 2010-06-18 13:32:39 -0700 2010-06-18 13:36:12 -0700 patch fix.patch text/plain 1398 zmo SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MTQzMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDYtMTggIFpoZW55YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJHTCBk ZW1vcyBzaG93IGJhZCBmbGlja2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zODU2MAorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0dy YXBoaWNzQ29udGV4dDNETWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0 M0Q6OnByZXBhcmVUZXh0dXJlKTogTW92ZSBlbnN1cmVDb250ZXh0KCkgb3V0IG9mIGlmLWJsb2Nr IHNvIGl0J3MgYWx3YXlzIGV4ZWN1dGVkLgorCiAyMDEwLTA2LTE4ICBBbmRlcnMgQ2FybHNzb24g IDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4K SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0dyYXBoaWNzQ29udGV4dDNETWFj Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0dyYXBoaWNz Q29udGV4dDNETWFjLm1tCShyZXZpc2lvbiA2MTMzOSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvbWFjL0dyYXBoaWNzQ29udGV4dDNETWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zODMs OCArMzgzLDggQEAgc3RhdGljIGlubGluZSB2b2lkIGVuc3VyZUNvbnRleHQoQ0dMQ29udAogCiB2 b2lkIEdyYXBoaWNzQ29udGV4dDNEOjpwcmVwYXJlVGV4dHVyZSgpCiB7CisgICAgZW5zdXJlQ29u dGV4dChtX2NvbnRleHRPYmopOwogICAgIGlmIChtX2F0dHJzLmFudGlhbGlhcykgewotICAgICAg ICBlbnN1cmVDb250ZXh0KG1fY29udGV4dE9iaik7CiAgICAgICAgIDo6Z2xCaW5kRnJhbWVidWZm ZXJFWFQoR0xfUkVBRF9GUkFNRUJVRkZFUl9FWFQsIG1fbXVsdGlzYW1wbGVGQk8pOwogICAgICAg ICA6OmdsQmluZEZyYW1lYnVmZmVyRVhUKEdMX0RSQVdfRlJBTUVCVUZGRVJfRVhULCBtX2Zibyk7 CiAgICAgICAgIDo6Z2xCbGl0RnJhbWVidWZmZXJFWFQoMCwgMCwgbV9jdXJyZW50V2lkdGgsIG1f Y3VycmVudEhlaWdodCwgMCwgMCwgbV9jdXJyZW50V2lkdGgsIG1fY3VycmVudEhlaWdodCwgR0xf Q09MT1JfQlVGRkVSX0JJVCwgR0xfTElORUFSKTsK