38549 2010-05-04 14:19:53 -0700 [WebKit2] The web process doesn't need to paint when the web view is hidden. 2010-05-04 15:24:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca webkit-unassigned oldest_to_newest 220780 0 andersca 2010-05-04 14:19:53 -0700 [WebKit2] The web process doesn't need to paint when the web view is hidden. 220788 1 55050 andersca 2010-05-04 14:26:47 -0700 Created attachment 55050 Patch 220800 2 55050 mitz 2010-05-04 14:46:23 -0700 Comment on attachment 55050 Patch > +void DrawingAreaUpdateChunk::suspendPainting() > +{ > + ASSERT(m_shouldPaint); Do you really want to assert this? > +void DrawingAreaUpdateChunk::resumePainting() > +{ > + ASSERT(!m_shouldPaint); Do you really want to assert this? r=me if you change “paint” to “update” and “painting” to “updating”. 220802 3 andersca 2010-05-04 14:56:57 -0700 (In reply to comment #2) > (From update of attachment 55050 [details]) > > +void DrawingAreaUpdateChunk::suspendPainting() > > +{ > > + ASSERT(m_shouldPaint); > > Do you really want to assert this? > I figured it wouldn't hurt! If it's a problem we can always remove it later. > > +void DrawingAreaUpdateChunk::resumePainting() > > +{ > > + ASSERT(!m_shouldPaint); > > Do you really want to assert this? > I figured it wouldn't hurt! If it's a problem we can always remove it later. > r=me if you change “paint” to “update” and “painting” to “updating”. Will do, thanks! 220813 4 andersca 2010-05-04 15:24:25 -0700 Committed r58781: <http://trac.webkit.org/changeset/58781> 55050 2010-05-04 14:26:47 -0700 2010-05-04 14:46:22 -0700 Patch bug-38549-20100504142646.patch text/plain 6556 andersca SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA1ODc3NSkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsNDIgQEAKKzIwMTAtMDUtMDQgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbV2ViS2l0Ml0gVGhlIHdlYiBwcm9jZXNzIGRvZXNuJ3QgbmVlZCB0byBwYWludCB3aGVuIHRo ZSB3ZWIgdmlldyBpcyBoaWRkZW4uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zODU0OQorCisgICAgICAgICogU2hhcmVkL0NvcmVJUENTdXBwb3J0L0Ry YXdpbmdBcmVhTWVzc2FnZUtpbmRzLmg6CisgICAgICAgIChEcmF3aW5nQXJlYU1lc3NhZ2U6Oik6 CisgICAgICAgIEFkZCBTdXNwZW5kUGFpbnRpbmcvUmVzdW1lUGFpbnRpbmcgbWVzc2FnZXMuCisg ICAgICAgIAorICAgICAgICAqIFVJUHJvY2Vzcy9EcmF3aW5nQXJlYVByb3h5VXBkYXRlQ2h1bmsu Y3BwOgorICAgICAgICAoV2ViS2l0OjpEcmF3aW5nQXJlYVByb3h5VXBkYXRlQ2h1bms6OnNldFBh Z2VJc1Zpc2libGUpOgorICAgICAgICBTdXNwZW5kIGFuZCByZXN1bWUgcGFpbnRpbmcgYWNjb3Jk aW5nbHkuCisgICAgICAgIAorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9EcmF3aW5nQXJl YVVwZGF0ZUNodW5rLmNwcDoKKyAgICAgICAgKFdlYktpdDo6RHJhd2luZ0FyZWFVcGRhdGVDaHVu azo6RHJhd2luZ0FyZWFVcGRhdGVDaHVuayk6CisgICAgICAgIEluaXRpYWxpemUgbV9zaG91bGRQ YWludCB0byB0cnVlLgorICAgICAgICAKKyAgICAgICAgKFdlYktpdDo6RHJhd2luZ0FyZWFVcGRh dGVDaHVuazo6ZGlzcGxheSk6CisgICAgICAgIFJldHVybiBpZiBtX3Nob3VsZFBhaW50IGlzIGZh bHNlLgorICAgICAgICAKKyAgICAgICAgKFdlYktpdDo6RHJhd2luZ0FyZWFVcGRhdGVDaHVuazo6 c2NoZWR1bGVEaXNwbGF5KToKKyAgICAgICAgRGl0dG8uCisgICAgICAgIAorICAgICAgICAoV2Vi S2l0OjpEcmF3aW5nQXJlYVVwZGF0ZUNodW5rOjpzZXRTaXplKToKKyAgICAgICAgQXNzZXJ0IHRo YXQgd2Ugc2hvdWxkIHBhaW50IGhlcmUuCisKKyAgICAgICAgKFdlYktpdDo6RHJhd2luZ0FyZWFV cGRhdGVDaHVuazo6c3VzcGVuZFBhaW50aW5nKToKKyAgICAgICAgU2V0IG1fc2hvdWxkUGFpbnQg dG8gZmFsc2UgYW5kIHN0b3AgdGhlIHRpbWVyLgorICAgICAgICAKKyAgICAgICAgKFdlYktpdDo6 RHJhd2luZ0FyZWFVcGRhdGVDaHVuazo6cmVzdW1lUGFpbnRpbmcpOgorICAgICAgICBTZXQgbV9z aG91bGRQYWludCB0byB0cnVlIGFuZCBwYWludCBpZiBuZWVkZWQuCisKKyAgICAgICAgKFdlYktp dDo6RHJhd2luZ0FyZWFVcGRhdGVDaHVuazo6ZGlkUmVjZWl2ZU1lc3NhZ2UpOgorICAgICAgICBo YW5kbGUgU3VzcGVuZFBhaW50aW5nL1Jlc3VtZVBhaW50aW5nIG1lc3NhZ2VzLgorCisgICAgICAg ICogV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhVXBkYXRlQ2h1bmsuaDoKKwogMjAxMC0w NS0wMyAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEpvbiBIb25leWN1dHQuCkluZGV4OiBXZWJLaXQyL1NoYXJlZC9Db3JlSVBDU3Vw cG9ydC9EcmF3aW5nQXJlYU1lc3NhZ2VLaW5kcy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvU2hh cmVkL0NvcmVJUENTdXBwb3J0L0RyYXdpbmdBcmVhTWVzc2FnZUtpbmRzLmgJKHJldmlzaW9uIDU4 NzY4KQorKysgV2ViS2l0Mi9TaGFyZWQvQ29yZUlQQ1N1cHBvcnQvRHJhd2luZ0FyZWFNZXNzYWdl S2luZHMuaAkod29ya2luZyBjb3B5KQpAQCAtMzMsOSArMzMsMTUgQEAKIG5hbWVzcGFjZSBEcmF3 aW5nQXJlYU1lc3NhZ2UgewogCiBlbnVtIEtpbmQgewotICAgIEluaXRpYWxpemUsCisgICAgLy8g Q2FsbGVkIHdoZW5ldmVyIHRoZSBzaXplIG9mIHRoZSBkcmF3aW5nIGFyZWEgbmVlZHMgdG8gYmUg dXBkYXRlZC4KICAgICBTZXRTaXplLAotICAgIAorCisgICAgLy8gQ2FsbGVkIHdoZW4gdGhlIGRy YXdpbmcgYXJlYSBzaG91bGQgc3RvcCBwYWludGluZy4KKyAgICBTdXNwZW5kUGFpbnRpbmcsCisK KyAgICAvLyBDYWxsZWQgd2hlbiB0aGUgZHJhd2luZyBhcmVhIHNob3VsZCBzdGFydCBwYWludGlu ZyBhZ2Fpbi4KKyAgICBSZXN1bWVQYWludGluZywKKwogICAgIC8vIENhbGxlZCB3aGVuIGFuIHVw ZGF0ZSBjaHVuayBzZW50IHRvIHRoZSBkcmF3aW5nIGFyZWEgaGFzIGJlZW4KICAgICAvLyBpbmNv cnBvcmF0ZWQgaW50byB0aGUgYmFja2luZyBzdG9yZS4KICAgICBEaWRVcGRhdGUsCkluZGV4OiBX ZWJLaXQyL1VJUHJvY2Vzcy9EcmF3aW5nQXJlYVByb3h5VXBkYXRlQ2h1bmsuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYktpdDIvVUlQcm9jZXNzL0RyYXdpbmdBcmVhUHJveHlVcGRhdGVDaHVuay5jcHAJ KHJldmlzaW9uIDU4NzY4KQorKysgV2ViS2l0Mi9VSVByb2Nlc3MvRHJhd2luZ0FyZWFQcm94eVVw ZGF0ZUNodW5rLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTQsOCArOTQsMTcgQEAgdm9pZCBEcmF3 aW5nQXJlYVByb3h5VXBkYXRlQ2h1bms6OnNldFBhZwogICAgIG1faXNWaXNpYmxlID0gaXNWaXNp YmxlOwogICAgIGlmICghcGFnZS0+aXNWYWxpZCgpKQogICAgICAgICByZXR1cm47CisKKyAgICBp ZiAoIW1faXNWaXNpYmxlKSB7CisgICAgICAgIC8vIFRlbGwgdGhlIHdlYiBwcm9jZXNzIHRoYXQg aXQgZG9lc24ndCBuZWVkIHRvIHBhaW50IGFueXRoaW5nIGZvciBub3cuCisgICAgICAgIHBhZ2Ut PnByb2Nlc3MoKS0+Y29ubmVjdGlvbigpLT5zZW5kKERyYXdpbmdBcmVhTWVzc2FnZTo6U3VzcGVu ZFBhaW50aW5nLCBwYWdlLT5wYWdlSUQoKSwgQ29yZUlQQzo6SW4oKSk7CisgICAgICAgIHJldHVy bjsKKyAgICB9CisgICAgCisgICAgLy8gVGhlIHBhZ2UgaXMgbm93IHZpc2libGUuCisgICAgcGFn ZS0+cHJvY2VzcygpLT5jb25uZWN0aW9uKCktPnNlbmQoRHJhd2luZ0FyZWFNZXNzYWdlOjpSZXN1 bWVQYWludGluZywgcGFnZS0+cGFnZUlEKCksIENvcmVJUEM6OkluKCkpOwogICAgIAotICAgIC8v IEZJWE1FOiBBY3R1YWxseSBub3RpZnkgdGhlIHdlYiBwcm9jZXNzIHRoYXQgdGhlIHZpc2liaWxp dHkgaGFzIGNoYW5nZWQuCisgICAgLy8gRklYTUU6IFdlIHNob3VsZCByZXF1ZXN0IGEgZnVsbCBy ZXBhaW50IGhlcmUgaWYgbmVlZGVkLgogfQogICAgIAogdm9pZCBEcmF3aW5nQXJlYVByb3h5VXBk YXRlQ2h1bms6OmRpZFNldFNpemUoVXBkYXRlQ2h1bmsqIHVwZGF0ZUNodW5rKQpJbmRleDogV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWFVcGRhdGVDaHVuay5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWFVcGRhdGVDaHVu ay5jcHAJKHJldmlzaW9uIDU4NzY4KQorKysgV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJh d2luZ0FyZWFVcGRhdGVDaHVuay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQwLDYgKzQwLDcgQEAg bmFtZXNwYWNlIFdlYktpdCB7CiBEcmF3aW5nQXJlYVVwZGF0ZUNodW5rOjpEcmF3aW5nQXJlYVVw ZGF0ZUNodW5rKFdlYlBhZ2UqIHdlYlBhZ2UpCiAgICAgOiBEcmF3aW5nQXJlYShEcmF3aW5nQXJl YVVwZGF0ZUNodW5rVHlwZSwgd2ViUGFnZSkKICAgICAsIG1faXNXYWl0aW5nRm9yVXBkYXRlKGZh bHNlKQorICAgICwgbV9zaG91bGRQYWludCh0cnVlKQogICAgICwgbV9kaXNwbGF5VGltZXIoV2Vi UHJvY2Vzczo6c2hhcmVkKCkucnVuTG9vcCgpLCB0aGlzLCAmRHJhd2luZ0FyZWFVcGRhdGVDaHVu azo6ZGlzcGxheSkKIHsKIH0KQEAgLTc5LDYgKzgwLDkgQEAgdm9pZCBEcmF3aW5nQXJlYVVwZGF0 ZUNodW5rOjpzZXROZWVkc0Rpcwogdm9pZCBEcmF3aW5nQXJlYVVwZGF0ZUNodW5rOjpkaXNwbGF5 KCkKIHsKICAgICBBU1NFUlQoIW1faXNXYWl0aW5nRm9yVXBkYXRlKTsKKyAKKyAgICBpZiAoIW1f c2hvdWxkUGFpbnQpCisgICAgICAgIHJldHVybjsKIAogICAgIGlmIChtX2RpcnR5UmVjdC5pc0Vt cHR5KCkpCiAgICAgICAgIHJldHVybjsKQEAgLTEwMSw2ICsxMDUsOSBAQCB2b2lkIERyYXdpbmdB cmVhVXBkYXRlQ2h1bms6OmRpc3BsYXkoKQogCiB2b2lkIERyYXdpbmdBcmVhVXBkYXRlQ2h1bms6 OnNjaGVkdWxlRGlzcGxheSgpCiB7CisgICAgaWYgKCFtX3Nob3VsZFBhaW50KQorICAgICAgICBy ZXR1cm47CisKICAgICBpZiAobV9pc1dhaXRpbmdGb3JVcGRhdGUpCiAgICAgICAgIHJldHVybjsK ICAgICAKQEAgLTExMiw2ICsxMTksNyBAQCB2b2lkIERyYXdpbmdBcmVhVXBkYXRlQ2h1bms6OnNj aGVkdWxlRGlzCiAKIHZvaWQgRHJhd2luZ0FyZWFVcGRhdGVDaHVuazo6c2V0U2l6ZShjb25zdCBJ bnRTaXplJiB2aWV3U2l6ZSkKIHsKKyAgICBBU1NFUlQobV9zaG91bGRQYWludCk7CiAgICAgQVNT RVJUX0FSRyh2aWV3U2l6ZSwgIXZpZXdTaXplLmlzRW1wdHkoKSk7CiAKICAgICAvLyBXZSBkb24n dCB3YW50IHRvIHdhaXQgZm9yIGFuIHVwZGF0ZSB1bnRpbCB3ZSBkaXNwbGF5LgpAQCAtMTMxLDYg KzEzOSwyNCBAQCB2b2lkIERyYXdpbmdBcmVhVXBkYXRlQ2h1bms6OnNldFNpemUoY29uCiAgICAg V2ViUHJvY2Vzczo6c2hhcmVkKCkuY29ubmVjdGlvbigpLT5zZW5kKERyYXdpbmdBcmVhUHJveHlN ZXNzYWdlOjpEaWRTZXRTaXplLCBtX3dlYlBhZ2UtPnBhZ2VJRCgpLCBDb3JlSVBDOjpJbih1cGRh dGVDaHVuaykpOwogfQogCit2b2lkIERyYXdpbmdBcmVhVXBkYXRlQ2h1bms6OnN1c3BlbmRQYWlu dGluZygpCit7CisgICAgQVNTRVJUKG1fc2hvdWxkUGFpbnQpOworICAgIAorICAgIG1fc2hvdWxk UGFpbnQgPSBmYWxzZTsKKyAgICBtX2Rpc3BsYXlUaW1lci5zdG9wKCk7Cit9CisKK3ZvaWQgRHJh d2luZ0FyZWFVcGRhdGVDaHVuazo6cmVzdW1lUGFpbnRpbmcoKQoreworICAgIEFTU0VSVCghbV9z aG91bGRQYWludCk7CisgICAgCisgICAgbV9zaG91bGRQYWludCA9IHRydWU7CisgICAgCisgICAg Ly8gRGlzcGxheSBpZiBuZWVkZWQuCisgICAgZGlzcGxheSgpOworfQorCiB2b2lkIERyYXdpbmdB cmVhVXBkYXRlQ2h1bms6OmRpZFVwZGF0ZSgpCiB7CiAgICAgbV9pc1dhaXRpbmdGb3JVcGRhdGUg PSBmYWxzZTsKQEAgLTE1MSw2ICsxNzcsMTQgQEAgdm9pZCBEcmF3aW5nQXJlYVVwZGF0ZUNodW5r OjpkaWRSZWNlaXZlTQogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KICAgICAgICAgCisg ICAgICAgIGNhc2UgRHJhd2luZ0FyZWFNZXNzYWdlOjpTdXNwZW5kUGFpbnRpbmc6CisgICAgICAg ICAgICBzdXNwZW5kUGFpbnRpbmcoKTsKKyAgICAgICAgICAgIGJyZWFrOworCisgICAgICAgIGNh c2UgRHJhd2luZ0FyZWFNZXNzYWdlOjpSZXN1bWVQYWludGluZzoKKyAgICAgICAgICAgIHJlc3Vt ZVBhaW50aW5nKCk7CisgICAgICAgICAgICBicmVhazsKKwogICAgICAgICBjYXNlIERyYXdpbmdB cmVhTWVzc2FnZTo6RGlkVXBkYXRlOgogICAgICAgICAgICAgZGlkVXBkYXRlKCk7CiAgICAgICAg ICAgICBicmVhazsKSW5kZXg6IFdlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVh VXBkYXRlQ2h1bmsuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9E cmF3aW5nQXJlYVVwZGF0ZUNodW5rLmgJKHJldmlzaW9uIDU4NzY4KQorKysgV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWFVcGRhdGVDaHVuay5oCSh3b3JraW5nIGNvcHkpCkBA IC01MCw4ICs1MCwxMSBAQCBwdWJsaWM6CiAKIHByaXZhdGU6CiAgICAgdm9pZCBzY2hlZHVsZURp c3BsYXkoKTsKKyAgICAKKyAgICAvLyBDb3JlSVBDIG1lc3NhZ2UgaGFuZGxlcnMuCiAgICAgdm9p ZCBzZXRTaXplKGNvbnN0IFdlYkNvcmU6OkludFNpemUmIHZpZXdTaXplKTsKLQorICAgIHZvaWQg c3VzcGVuZFBhaW50aW5nKCk7CisgICAgdm9pZCByZXN1bWVQYWludGluZygpOwogICAgIHZvaWQg ZGlkVXBkYXRlKCk7CiAKICAgICAvLyBQbGF0Zm9ybSBvdmVycmlkZXMKQEAgLTU5LDYgKzYyLDcg QEAgcHJpdmF0ZToKIAogICAgIFdlYkNvcmU6OkludFJlY3QgbV9kaXJ0eVJlY3Q7CiAgICAgYm9v bCBtX2lzV2FpdGluZ0ZvclVwZGF0ZTsKKyAgICBib29sIG1fc2hvdWxkUGFpbnQ7CiAgICAgUnVu TG9vcDo6VGltZXI8RHJhd2luZ0FyZWFVcGRhdGVDaHVuaz4gbV9kaXNwbGF5VGltZXI7CiB9Owog Cg==