38537 2010-05-04 11:43:30 -0700 [Qt] Failed at http://philip.html5.org/tests/canvas/suite/tests/2d.path.arc.angle.3.html 2010-06-04 01:21:11 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Linux RESOLVED FIXED Qt, QtTriaged P3 Normal --- 1 qi.2.zhang qi.2.zhang commit-queue cshu darin eric kenneth kling laszlo.gombos webkit.review.bot oldest_to_newest 220691 0 qi.2.zhang 2010-05-04 11:43:30 -0700 also failed at : http://philip.html5.org/tests/canvas/suite/tests/2d.path.arc.angle.5.html http://philip.html5.org/tests/canvas/suite/tests/2d.path.arc.empty.html 220701 1 55035 qi.2.zhang 2010-05-04 12:00:21 -0700 Created attachment 55035 patch For path.arc, there are some special case need to handle: 1> If the anticlockwise argument is false and endAngle-startAngle is equal to or greater than 2π, or, if the anticlockwise argument is true and startAngle-endAngle is equal to or greater than 2π, then the arc is the whole circumference of this circle. Otherwise, the arc is the path along the circumference of this circle from the start point to the end point, going anti-clockwise if the anticlockwise argument is true, and clockwise otherwise. Since the points are on the circle, as opposed to being simply angles from zero, the arc can never cover an angle greater than 2π radians. Currently, our span can be bigger than 2π, this is wrong. 2> If the context has any subpaths, then the method must add a straight line from the last point in the subpath to the start point of the arc. Currently, we always add a line, didn't check if has any subpaths. 3> When span is 0, QPainterPath still draw something, the behavior is different with required. 220703 2 webkit.review.bot 2010-05-04 12:06:18 -0700 Attachment 55035 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/platform/graphics/qt/PathQt.cpp:302: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 220706 3 55036 qi.2.zhang 2010-05-04 12:27:30 -0700 Created attachment 55036 patch fix style issue 220712 4 55036 darin 2010-05-04 12:34:39 -0700 Comment on attachment 55036 patch Patches that fix bugs need to include regression tests for the WebKit regression test system. 221232 5 laszlo.gombos 2010-05-05 12:34:28 -0700 *** Bug 38526 has been marked as a duplicate of this bug. *** 221487 6 55036 eric 2010-05-05 21:59:35 -0700 Comment on attachment 55036 patch r- for lack of test. 221488 7 eric 2010-05-05 22:00:10 -0700 Seems we should import philip's tests into LayoutTests. I'm cetain we already have a bugs.webkit.org bug about doing just that. 221641 8 qi.2.zhang 2010-05-06 06:31:11 -0700 (In reply to comment #7) > Seems we should import philip's tests into LayoutTests. I'm cetain we already > have a bugs.webkit.org bug about doing just that. Eric, What's your means about "I'm cetain we already have a bugs.webkit.org bug about doing just that."? Is that Laszlo talked Bug 38526? Actually in this patch I try to fix 3 issues. Just because they are all in one function, so I make one patch. Bug 38526 is one of the 3 issues. Actually, I think Bug 38526 fix is not correct. Based on HTML5 spec: The arc(x, y, radius, startAngle, endAngle, anticlockwise) method draws an arc. If the context has any subpaths, then the method must add a straight line from the last point in the subpath to the start point of the arc. Basically, if there are some elements before the arc, we need add a line from that point to the arc start point, otherwise we don’t. Currently, we always add a line to the arc, even there is no element before the arc, by default it will add a line from (0,0) to the arc, that's wrong. See my change. I want to know what I need to do. This patch is not need any more? or I need to create a layout test for it? or else.. 233344 9 57668 qi.2.zhang 2010-06-02 11:14:41 -0700 Created attachment 57668 patch3 233347 10 qi.2.zhang 2010-06-02 11:16:54 -0700 Since Bug 38526 is fixed, I changed my patch to only fix the following issue: 1> If the anticlockwise argument is false and endAngle-startAngle is equal to or greater than 2π, or, if the anticlockwise argument is true and startAngle-endAngle is equal to or greater than 2π, then the arc is the whole circumference of this circle. Otherwise, the arc is the path along the circumference of this circle from the start point to the end point, going anti-clockwise if the anticlockwise argument is true, and clockwise otherwise. Since the points are on the circle, as opposed to being simply angles from zero, the arc can never cover an angle greater than 2π radians. Currently, our span can be bigger than 2π, this is wrong. This patch will fix canvas/philp/tests/2d.path.arc.angle.3.html and canvas/philp/tests/2d.path.arc.angle.5.html 233757 11 57767 qi.2.zhang 2010-06-03 07:56:58 -0700 Created attachment 57767 patch4 fix comments issue. 233779 12 57767 laszlo.gombos 2010-06-03 09:01:50 -0700 Comment on attachment 57767 patch4 looks good to me, r+. 234098 13 57767 commit-queue 2010-06-04 01:21:01 -0700 Comment on attachment 57767 patch4 Clearing flags on attachment: 57767 Committed r60663: <http://trac.webkit.org/changeset/60663> 234099 14 commit-queue 2010-06-04 01:21:11 -0700 All reviewed patches have been landed. Closing bug. 55035 2010-05-04 12:00:21 -0700 2010-05-04 12:10:26 -0700 patch bug38537.patch text/plain 2999 qi.2.zhang SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1ODc2NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDUtMDQgIFFpIFpoYW5nICA8cWkuMi56aGFuZ0Bub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0 XSBmYWlsZWQgYXQgaHR0cDovL3BoaWxpcC5odG1sNS5vcmcvdGVzdHMvY2FudmFzL3N1aXRlL3Rl c3RzLzJkLnBhdGguYXJjLmFuZ2xlLjMuaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg1MzcKKworICAgICAgICBGb3IgcGF0aC5hcmMgZnVuY3Rp b24gaGFuZGxlIAorICAgICAgICAxIHNwYW4gPiAyUEkgOyAyIHNwYW4gPSAwOyAzIGVtcHR5IHBh dGg7IAorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvUGF0aFF0LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlBhdGg6OmFkZEFyYyk6CisKIDIwMTAtMDUtMDQgIFN0ZXZlbiBMYWkgIDxz dGV2ZW5fbGFpQGFzaWEuYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFk bGVyLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9QYXRoUXQuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvUGF0aFF0LmNwcAkocmV2aXNp b24gNTg2NzApCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L1BhdGhRdC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTI4NiwyNCArMjg2LDM2IEBAIHZvaWQgUGF0aDo6YWRkQXJjKGNvbnN0 IEZsb2F0UG9pbnQmIHAsIGYKICAgICBkb3VibGUgd2lkdGggID0gcmFkaXVzKjI7CiAgICAgZG91 YmxlIGhlaWdodCA9IHJhZGl1cyoyOwogCi0gICAgaWYgKCFhbnRpY2xvY2t3aXNlICYmIChlYSA8 IHNhKSkKLSAgICAgICAgc3BhbiArPSAzNjA7Ci0gICAgZWxzZSBpZiAoYW50aWNsb2Nrd2lzZSAm JiAoc2EgPCBlYSkpCi0gICAgICAgIHNwYW4gLT0gMzYwOwotCi0gICAgLy8gdGhpcyBpcyBhbHNv IGR1ZSB0byBzd2l0Y2hlZCBjb29yZGluYXRlIHN5c3RlbQotICAgIC8vIHdlIHdvdWxkIGVuZCB1 cCB3aXRoIGEgMCBzcGFuIGluc3RlYWQgb2YgMzYwCi0gICAgaWYgKCEocUZ1enp5Q29tcGFyZShz cGFuICsgKGVhIC0gc2EpICsgMSwgMS4wKSAmJgotICAgICAgICAgIHFGdXp6eUNvbXBhcmUocUFi cyhzcGFuKSwgMzYwLjApKSkgewotICAgICAgICBzcGFuICs9IGVhIC0gc2E7CisgICAgaWYgKCgh YW50aWNsb2Nrd2lzZSAmJiAoZWEgLSBzYSA+PSAzNjApKSB8fCAoYW50aWNsb2Nrd2lzZSAmJiAo c2EgLSBlYSA+PSAzNjApKSkKKyAgICAgICAgLy8gSWYgdGhlIGFudGljbG9ja3dpc2UgYXJndW1l bnQgaXMgZmFsc2UgYW5kIGVuZEFuZ2xlLXN0YXJ0QW5nbGUgaXMgZXF1YWwgdG8gb3IgZ3JlYXRl ciB0aGFuIDIsIG9yLCBpZiB0aGUKKyAgICAgICAgLy8gYW50aWNsb2Nrd2lzZSBhcmd1bWVudCBp cyB0cnVlIGFuZCBzdGFydEFuZ2xlLWVuZEFuZ2xlIGlzIGVxdWFsIHRvIG9yIGdyZWF0ZXIgdGhh biAyLCB0aGVuIHRoZSBhcmMgaXMgdGhlIHdob2xlCisgICAgICAgIC8vIGNpcmN1bWZlcmVuY2Ug b2YgdGhpcyBjaXJjbGUuCisgICAgICAgIHNwYW4gPSAzNjA7CisgICAgZWxzZSB7CisgICAgICAg IGlmICghYW50aWNsb2Nrd2lzZSAmJiAoZWEgPCBzYSkpCisgICAgICAgICAgICBzcGFuICs9IDM2 MDsKKyAgICAgICAgZWxzZSBpZiAoYW50aWNsb2Nrd2lzZSAmJiAoc2EgPCBlYSkpCisgICAgICAg ICAgICBzcGFuIC09IDM2MDsKKworICAgICAgICAvLyB0aGlzIGlzIGFsc28gZHVlIHRvIHN3aXRj aGVkIGNvb3JkaW5hdGUgc3lzdGVtCisgICAgICAgIC8vIHdlIHdvdWxkIGVuZCB1cCB3aXRoIGEg MCBzcGFuIGluc3RlYWQgb2YgMzYwCisgICAgICAgIGlmICghKHFGdXp6eUNvbXBhcmUoc3BhbiAr IChlYSAtIHNhKSArIDEsIDEuMCkgJiYKKyAgICAgICAgICAgICBxRnV6enlDb21wYXJlKHFBYnMo c3BhbiksIDM2MC4wKSkpIHsKKyAgICAgICAgICAgIC8vIG1vZCAzNjAKKyAgICAgICAgICAgIHNw YW4gKz0gKGVhIC0gc2EpIC0gKChpbnQpICgoZWEgLSBzYSkgLyAzNjApKSAqIDM2MDsKKyAgICAg ICAgfQorICAgICAgICBpZiAoc3BhbiA9PSAzNjAgfHwgc3BhbiA9PSAtMzYwKQorICAgICAgICAg ICAgc3BhbiA9IDA7CisgICAgfQorICAgIGlmIChtX3BhdGguZWxlbWVudENvdW50KCkpIHsKKyAg ICAgICAgLy8gY29ubmVjdCB0byB0aGUgcHJldmlvdXMgcG9pbnQgYnkgYSBzdHJhaWdodCBsaW5l IGlmIGhhcyBhbnkgc3VicGF0aAorICAgICAgICBtX3BhdGgubGluZVRvKFFQb2ludEYoeGMgKyBy YWRpdXMgICogY29zKHNhciksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB5YyAtIHJh ZGl1cyAgKiBzaW4oc2FyKSkpOworICAgIH0KKyAgICBpZiAoc3BhbikgeworICAgICAgICAvLyBR UGFpbnRlclBhdGggc3RpbGwgZHJhdyBzb21ldGhpbmcgd2hlbiBzcGFuIGlzIDAKKyAgICAgICAg bV9wYXRoLmFyY1RvKHhzLCB5cywgd2lkdGgsIGhlaWdodCwgc2EsIHNwYW4pOwogICAgIH0KLQot ICAgIC8vIGNvbm5lY3QgdG8gdGhlIHByZXZpb3VzIHBvaW50IGJ5IGEgc3RyYWlnaHQgbGluZQot ICAgIG1fcGF0aC5saW5lVG8oUVBvaW50Rih4YyArIHJhZGl1cyAgKiBjb3Moc2FyKSwKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgeWMgLSByYWRpdXMgICogc2luKHNhcikpKTsKLQotICAgIG1f cGF0aC5hcmNUbyh4cywgeXMsIHdpZHRoLCBoZWlnaHQsIHNhLCBzcGFuKTsKLQogfQogCiB2b2lk IFBhdGg6OmFkZFJlY3QoY29uc3QgRmxvYXRSZWN0JiByKQo= 55036 2010-05-04 12:27:30 -0700 2010-06-03 07:56:58 -0700 patch bug38537_2.patch text/plain 2999 qi.2.zhang SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1ODc2NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDUtMDQgIFFpIFpoYW5nICA8cWkuMi56aGFuZ0Bub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0 XSBmYWlsZWQgYXQgaHR0cDovL3BoaWxpcC5odG1sNS5vcmcvdGVzdHMvY2FudmFzL3N1aXRlL3Rl c3RzLzJkLnBhdGguYXJjLmFuZ2xlLjMuaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg1MzcKKworICAgICAgICBGb3IgcGF0aC5hcmMgZnVuY3Rp b24gaGFuZGxlIAorICAgICAgICAxIHNwYW4gPiAyUEkgOyAyIHNwYW4gPSAwOyAzIGVtcHR5IHBh dGg7IAorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvUGF0aFF0LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlBhdGg6OmFkZEFyYyk6CisKIDIwMTAtMDUtMDQgIFN0ZXZlbiBMYWkgIDxz dGV2ZW5fbGFpQGFzaWEuYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFk bGVyLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9QYXRoUXQuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvUGF0aFF0LmNwcAkocmV2aXNp b24gNTg2NzApCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L1BhdGhRdC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTI4NiwyNCArMjg2LDM2IEBAIHZvaWQgUGF0aDo6YWRkQXJjKGNvbnN0 IEZsb2F0UG9pbnQmIHAsIGYKICAgICBkb3VibGUgd2lkdGggID0gcmFkaXVzKjI7CiAgICAgZG91 YmxlIGhlaWdodCA9IHJhZGl1cyoyOwogCi0gICAgaWYgKCFhbnRpY2xvY2t3aXNlICYmIChlYSA8 IHNhKSkKLSAgICAgICAgc3BhbiArPSAzNjA7Ci0gICAgZWxzZSBpZiAoYW50aWNsb2Nrd2lzZSAm JiAoc2EgPCBlYSkpCi0gICAgICAgIHNwYW4gLT0gMzYwOwotCi0gICAgLy8gdGhpcyBpcyBhbHNv IGR1ZSB0byBzd2l0Y2hlZCBjb29yZGluYXRlIHN5c3RlbQotICAgIC8vIHdlIHdvdWxkIGVuZCB1 cCB3aXRoIGEgMCBzcGFuIGluc3RlYWQgb2YgMzYwCi0gICAgaWYgKCEocUZ1enp5Q29tcGFyZShz cGFuICsgKGVhIC0gc2EpICsgMSwgMS4wKSAmJgotICAgICAgICAgIHFGdXp6eUNvbXBhcmUocUFi cyhzcGFuKSwgMzYwLjApKSkgewotICAgICAgICBzcGFuICs9IGVhIC0gc2E7CisgICAgaWYgKCgh YW50aWNsb2Nrd2lzZSAmJiAoZWEgLSBzYSA+PSAzNjApKSB8fCAoYW50aWNsb2Nrd2lzZSAmJiAo c2EgLSBlYSA+PSAzNjApKSkKKyAgICAgICAgLy8gSWYgdGhlIGFudGljbG9ja3dpc2UgYXJndW1l bnQgaXMgZmFsc2UgYW5kIGVuZEFuZ2xlLXN0YXJ0QW5nbGUgaXMgZXF1YWwgdG8gb3IgZ3JlYXRl ciB0aGFuIDIsIG9yLCBpZiB0aGUKKyAgICAgICAgLy8gYW50aWNsb2Nrd2lzZSBhcmd1bWVudCBp cyB0cnVlIGFuZCBzdGFydEFuZ2xlLWVuZEFuZ2xlIGlzIGVxdWFsIHRvIG9yIGdyZWF0ZXIgdGhh biAyLCB0aGVuIHRoZSBhcmMgaXMgdGhlIHdob2xlCisgICAgICAgIC8vIGNpcmN1bWZlcmVuY2Ug b2YgdGhpcyBjaXJjbGUuCisgICAgICAgIHNwYW4gPSAzNjA7CisgICAgZWxzZSB7CisgICAgICAg IGlmICghYW50aWNsb2Nrd2lzZSAmJiAoZWEgPCBzYSkpCisgICAgICAgICAgICBzcGFuICs9IDM2 MDsKKyAgICAgICAgZWxzZSBpZiAoYW50aWNsb2Nrd2lzZSAmJiAoc2EgPCBlYSkpCisgICAgICAg ICAgICBzcGFuIC09IDM2MDsKKworICAgICAgICAvLyB0aGlzIGlzIGFsc28gZHVlIHRvIHN3aXRj aGVkIGNvb3JkaW5hdGUgc3lzdGVtCisgICAgICAgIC8vIHdlIHdvdWxkIGVuZCB1cCB3aXRoIGEg MCBzcGFuIGluc3RlYWQgb2YgMzYwCisgICAgICAgIGlmICghKHFGdXp6eUNvbXBhcmUoc3BhbiAr IChlYSAtIHNhKSArIDEsIDEuMCkgCisgICAgICAgICAgICAmJiBxRnV6enlDb21wYXJlKHFBYnMo c3BhbiksIDM2MC4wKSkpIHsKKyAgICAgICAgICAgIC8vIG1vZCAzNjAKKyAgICAgICAgICAgIHNw YW4gKz0gKGVhIC0gc2EpIC0gKChpbnQpICgoZWEgLSBzYSkgLyAzNjApKSAqIDM2MDsKKyAgICAg ICAgfQorICAgICAgICBpZiAoc3BhbiA9PSAzNjAgfHwgc3BhbiA9PSAtMzYwKQorICAgICAgICAg ICAgc3BhbiA9IDA7CisgICAgfQorICAgIGlmIChtX3BhdGguZWxlbWVudENvdW50KCkpIHsKKyAg ICAgICAgLy8gY29ubmVjdCB0byB0aGUgcHJldmlvdXMgcG9pbnQgYnkgYSBzdHJhaWdodCBsaW5l IGlmIGhhcyBhbnkgc3VicGF0aAorICAgICAgICBtX3BhdGgubGluZVRvKFFQb2ludEYoeGMgKyBy YWRpdXMgICogY29zKHNhciksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB5YyAtIHJh ZGl1cyAgKiBzaW4oc2FyKSkpOworICAgIH0KKyAgICBpZiAoc3BhbikgeworICAgICAgICAvLyBR UGFpbnRlclBhdGggc3RpbGwgZHJhdyBzb21ldGhpbmcgd2hlbiBzcGFuIGlzIDAKKyAgICAgICAg bV9wYXRoLmFyY1RvKHhzLCB5cywgd2lkdGgsIGhlaWdodCwgc2EsIHNwYW4pOwogICAgIH0KLQot ICAgIC8vIGNvbm5lY3QgdG8gdGhlIHByZXZpb3VzIHBvaW50IGJ5IGEgc3RyYWlnaHQgbGluZQot ICAgIG1fcGF0aC5saW5lVG8oUVBvaW50Rih4YyArIHJhZGl1cyAgKiBjb3Moc2FyKSwKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgeWMgLSByYWRpdXMgICogc2luKHNhcikpKTsKLQotICAgIG1f cGF0aC5hcmNUbyh4cywgeXMsIHdpZHRoLCBoZWlnaHQsIHNhLCBzcGFuKTsKLQogfQogCiB2b2lk IFBhdGg6OmFkZFJlY3QoY29uc3QgRmxvYXRSZWN0JiByKQo= 57668 2010-06-02 11:14:41 -0700 2010-06-03 07:56:58 -0700 patch3 bug38537_3.patch text/plain 3742 qi.2.zhang SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDU2OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDYtMDIgIFFpIFpoYW5nICA8cWkuMi56aGFuZ0Bub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0 XSBmYWlsZWQgYXQgaHR0cDovL3BoaWxpcC5odG1sNS5vcmcvdGVzdHMvY2FudmFzL3N1aXRlL3Rl c3RzLzJkLnBhdGguYXJjLmFuZ2xlLjMuaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg1MzcKKworICAgICAgICBGb3IgcGF0aC5hcmMgZnVuY3Rp b24gaGFuZGxlIHNwYW4gPiAyUEkKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L1Bh dGhRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYXRoOjphZGRBcmMpOgorCiAyMDEwLTA2LTAy ICBZYWVsIEFoYXJvbiAgPHlhZWwuYWhhcm9uQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvUGF0 aFF0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L1BhdGhR dC5jcHAJKHJldmlzaW9uIDYwNTYxKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9Q YXRoUXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yODYsMTYgKzI4NiwyNCBAQCB2b2lkIFBhdGg6 OmFkZEFyYyhjb25zdCBGbG9hdFBvaW50JiBwLCBmCiAgICAgZG91YmxlIHdpZHRoICA9IHJhZGl1 cyoyOwogICAgIGRvdWJsZSBoZWlnaHQgPSByYWRpdXMqMjsKIAotICAgIGlmICghYW50aWNsb2Nr d2lzZSAmJiAoZWEgPCBzYSkpCi0gICAgICAgIHNwYW4gKz0gMzYwOwotICAgIGVsc2UgaWYgKGFu dGljbG9ja3dpc2UgJiYgKHNhIDwgZWEpKQotICAgICAgICBzcGFuIC09IDM2MDsKLQotICAgIC8v IHRoaXMgaXMgYWxzbyBkdWUgdG8gc3dpdGNoZWQgY29vcmRpbmF0ZSBzeXN0ZW0KLSAgICAvLyB3 ZSB3b3VsZCBlbmQgdXAgd2l0aCBhIDAgc3BhbiBpbnN0ZWFkIG9mIDM2MAotICAgIGlmICghKHFG dXp6eUNvbXBhcmUoc3BhbiArIChlYSAtIHNhKSArIDEsIDEuMCkgJiYKLSAgICAgICAgICBxRnV6 enlDb21wYXJlKHFBYnMoc3BhbiksIDM2MC4wKSkpIHsKLSAgICAgICAgc3BhbiArPSBlYSAtIHNh OworICAgIGlmICgoIWFudGljbG9ja3dpc2UgJiYgKGVhIC0gc2EgPj0gMzYwKSkgfHwgKGFudGlj bG9ja3dpc2UgJiYgKHNhIC0gZWEgPj0gMzYwKSkpCisgICAgICAgIC8vIElmIHRoZSBhbnRpY2xv Y2t3aXNlIGFyZ3VtZW50IGlzIGZhbHNlIGFuZCBlbmRBbmdsZS1zdGFydEFuZ2xlIGlzIGVxdWFs IHRvIG9yIGdyZWF0ZXIgdGhhbiAyLCBvciwgaWYgdGhlCisgICAgICAgIC8vIGFudGljbG9ja3dp c2UgYXJndW1lbnQgaXMgdHJ1ZSBhbmQgc3RhcnRBbmdsZS1lbmRBbmdsZSBpcyBlcXVhbCB0byBv ciBncmVhdGVyIHRoYW4gMiwgdGhlbiB0aGUgYXJjIGlzIHRoZSB3aG9sZQorICAgICAgICAvLyBj aXJjdW1mZXJlbmNlIG9mIHRoaXMgY2lyY2xlLgorICAgICAgICBzcGFuID0gMzYwOworICAgIGVs c2UgeworICAgICAgICBpZiAoIWFudGljbG9ja3dpc2UgJiYgKGVhIDwgc2EpKQorICAgICAgICAg ICAgc3BhbiArPSAzNjA7CisgICAgICAgIGVsc2UgaWYgKGFudGljbG9ja3dpc2UgJiYgKHNhIDwg ZWEpKQorICAgICAgICAgICAgc3BhbiAtPSAzNjA7CisKKyAgICAgICAgLy8gdGhpcyBpcyBhbHNv IGR1ZSB0byBzd2l0Y2hlZCBjb29yZGluYXRlIHN5c3RlbQorICAgICAgICAvLyB3ZSB3b3VsZCBl bmQgdXAgd2l0aCBhIDAgc3BhbiBpbnN0ZWFkIG9mIDM2MAorICAgICAgICBpZiAoIShxRnV6enlD b21wYXJlKHNwYW4gKyAoZWEgLSBzYSkgKyAxLCAxLjApCisgICAgICAgICAgICAmJiBxRnV6enlD b21wYXJlKHFBYnMoc3BhbiksIDM2MC4wKSkpIHsKKyAgICAgICAgICAgIC8vIG1vZCAzNjAKKyAg ICAgICAgICAgIHNwYW4gKz0gKGVhIC0gc2EpIC0gKHN0YXRpY19jYXN0PGludD4oKGVhIC0gc2Ep IC8gMzYwKSkgKiAzNjA7CisgICAgICAgIH0KICAgICB9CiAKICAgICAvLyBJZiB0aGUgcGF0aCBp cyBlbXB0eSwgbW92ZSB0byB3aGVyZSB0aGUgYXJjIHdpbGwgc3RhcnQgdG8gYXZvaWQgcGFpbnRp bmcgYSBsaW5lIGZyb20gKDAsMCkKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDYwNTY5KQorKysgTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDYt MDIgIFFpIFpoYW5nICA8cWkuMi56aGFuZ0Bub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBmYWlsZWQgYXQgaHR0cDovL3BoaWxp cC5odG1sNS5vcmcvdGVzdHMvY2FudmFzL3N1aXRlL3Rlc3RzLzJkLnBhdGguYXJjLmFuZ2xlLjMu aHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg1 MzcKKworICAgICAgICBSZW1vdmUgY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5wYXRoLmFyY1RvLjJk LnBhdGguYXJjLmFuZ2xlLjMuaHRtbCBhbmQKKyAgICAgICAgY2FudmFzL3BoaWxpcC90ZXN0cy8y ZC5wYXRoLmFyY1RvLjJkLnBhdGguYXJjLmFuZ2xlLjUuaHRtbCBmcm9tIFNraXBwZWQuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOgorCiAyMDEwLTA2LTAyICBNaWtoYWlsIE5hZ2Fu b3YgIDxtbmFnYW5vdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWXVyeSBT ZW1pa2hhdHNreS4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAkocmV2aXNpb24gNjA1NjEp CisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCSh3b3JraW5nIGNvcHkpCkBAIC01 MTM0LDggKzUxMzQsNiBAQCBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmxpbmUuam9pbi5vcGVuLmh0 CiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmxpbmUuam9pbi5wYXJhbGxlbC5odG1sCiBjYW52YXMv cGhpbGlwL3Rlc3RzLzJkLmxpbmUubWl0ZXIubGluZWVkZ2UuaHRtbAogY2FudmFzL3BoaWxpcC90 ZXN0cy8yZC5taXNzaW5nYXJncy5odG1sCi1jYW52YXMvcGhpbGlwL3Rlc3RzLzJkLnBhdGguYXJj LmFuZ2xlLjMuaHRtbAotY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5wYXRoLmFyYy5hbmdsZS41Lmh0 bWwKIGNhbnZhcy9waGlsaXAvdGVzdHMvMmQucGF0aC5hcmMudHdvcGllLjMuaHRtbAogY2FudmFz L3BoaWxpcC90ZXN0cy8yZC5wYXRoLmFyYy56ZXJvcmFkaXVzLmh0bWwKIGNhbnZhcy9waGlsaXAv dGVzdHMvMmQucGF0aC5hcmNUby5jb2xsaW5lYXIuMi5odG1sCg== 57767 2010-06-03 07:56:58 -0700 2010-06-04 01:21:00 -0700 patch4 bug38537_4.patch text/plain 3760 qi.2.zhang SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDYyMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDYtMDMgIFFpIFpoYW5nICA8cWkuMi56aGFuZ0Bub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0 XSBmYWlsZWQgYXQgaHR0cDovL3BoaWxpcC5odG1sNS5vcmcvdGVzdHMvY2FudmFzL3N1aXRlL3Rl c3RzLzJkLnBhdGguYXJjLmFuZ2xlLjMuaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg1MzcKKworICAgICAgICBGb3IgcGF0aC5hcmMgZnVuY3Rp b24gaGFuZGxlIHNwYW4gPiAyUEkKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L1Bh dGhRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYXRoOjphZGRBcmMpOgorCiAyMDEwLTA2LTAz ICBUb3IgQXJuZSBWZXN0YsO4ICA8dG9yLmFybmUudmVzdGJvQG5va2lhLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvcXQvUGF0aFF0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3F0L1BhdGhRdC5jcHAJKHJldmlzaW9uIDYwNTYxKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9xdC9QYXRoUXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yODYsMTYgKzI4NiwyNCBA QCB2b2lkIFBhdGg6OmFkZEFyYyhjb25zdCBGbG9hdFBvaW50JiBwLCBmCiAgICAgZG91YmxlIHdp ZHRoICA9IHJhZGl1cyoyOwogICAgIGRvdWJsZSBoZWlnaHQgPSByYWRpdXMqMjsKIAotICAgIGlm ICghYW50aWNsb2Nrd2lzZSAmJiAoZWEgPCBzYSkpCi0gICAgICAgIHNwYW4gKz0gMzYwOwotICAg IGVsc2UgaWYgKGFudGljbG9ja3dpc2UgJiYgKHNhIDwgZWEpKQotICAgICAgICBzcGFuIC09IDM2 MDsKLQotICAgIC8vIHRoaXMgaXMgYWxzbyBkdWUgdG8gc3dpdGNoZWQgY29vcmRpbmF0ZSBzeXN0 ZW0KLSAgICAvLyB3ZSB3b3VsZCBlbmQgdXAgd2l0aCBhIDAgc3BhbiBpbnN0ZWFkIG9mIDM2MAot ICAgIGlmICghKHFGdXp6eUNvbXBhcmUoc3BhbiArIChlYSAtIHNhKSArIDEsIDEuMCkgJiYKLSAg ICAgICAgICBxRnV6enlDb21wYXJlKHFBYnMoc3BhbiksIDM2MC4wKSkpIHsKLSAgICAgICAgc3Bh biArPSBlYSAtIHNhOworICAgIGlmICgoIWFudGljbG9ja3dpc2UgJiYgKGVhIC0gc2EgPj0gMzYw KSkgfHwgKGFudGljbG9ja3dpc2UgJiYgKHNhIC0gZWEgPj0gMzYwKSkpCisgICAgICAgIC8vIElm IHRoZSBhbnRpY2xvY2t3aXNlIGFyZ3VtZW50IGlzIGZhbHNlIGFuZCBlbmRBbmdsZS1zdGFydEFu Z2xlIGlzIGVxdWFsIHRvIG9yIGdyZWF0ZXIgdGhhbiAyKlBJLCBvciwgaWYgdGhlCisgICAgICAg IC8vIGFudGljbG9ja3dpc2UgYXJndW1lbnQgaXMgdHJ1ZSBhbmQgc3RhcnRBbmdsZS1lbmRBbmds ZSBpcyBlcXVhbCB0byBvciBncmVhdGVyIHRoYW4gMipQSSwgdGhlbiB0aGUgYXJjIGlzIHRoZSB3 aG9sZQorICAgICAgICAvLyBjaXJjdW1mZXJlbmNlIG9mIHRoaXMgY2lyY2xlLgorICAgICAgICBz cGFuID0gMzYwOworICAgIGVsc2UgeworICAgICAgICBpZiAoIWFudGljbG9ja3dpc2UgJiYgKGVh IDwgc2EpKQorICAgICAgICAgICAgc3BhbiArPSAzNjA7CisgICAgICAgIGVsc2UgaWYgKGFudGlj bG9ja3dpc2UgJiYgKHNhIDwgZWEpKQorICAgICAgICAgICAgc3BhbiAtPSAzNjA7CisKKyAgICAg ICAgLy8gdGhpcyBpcyBhbHNvIGR1ZSB0byBzd2l0Y2hlZCBjb29yZGluYXRlIHN5c3RlbQorICAg ICAgICAvLyB3ZSB3b3VsZCBlbmQgdXAgd2l0aCBhIDAgc3BhbiBpbnN0ZWFkIG9mIDM2MAorICAg ICAgICBpZiAoIShxRnV6enlDb21wYXJlKHNwYW4gKyAoZWEgLSBzYSkgKyAxLCAxLjApCisgICAg ICAgICAgICAmJiBxRnV6enlDb21wYXJlKHFBYnMoc3BhbiksIDM2MC4wKSkpIHsKKyAgICAgICAg ICAgIC8vIG1vZCAzNjAKKyAgICAgICAgICAgIHNwYW4gKz0gKGVhIC0gc2EpIC0gKHN0YXRpY19j YXN0PGludD4oKGVhIC0gc2EpIC8gMzYwKSkgKiAzNjA7CisgICAgICAgIH0KICAgICB9CiAKICAg ICAvLyBJZiB0aGUgcGF0aCBpcyBlbXB0eSwgbW92ZSB0byB3aGVyZSB0aGUgYXJjIHdpbGwgc3Rh cnQgdG8gYXZvaWQgcGFpbnRpbmcgYSBsaW5lIGZyb20gKDAsMCkKSW5kZXg6IExheW91dFRlc3Rz L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9u IDYwNjIxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTAtMDYtMDMgIFFpIFpoYW5nICA8cWkuMi56aGFuZ0Bub2tpYS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBmYWls ZWQgYXQgaHR0cDovL3BoaWxpcC5odG1sNS5vcmcvdGVzdHMvY2FudmFzL3N1aXRlL3Rlc3RzLzJk LnBhdGguYXJjLmFuZ2xlLjMuaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9Mzg1MzcKKworICAgICAgICBSZW1vdmUgY2FudmFzL3BoaWxpcC90ZXN0 cy8yZC5wYXRoLmFyY1RvLjJkLnBhdGguYXJjLmFuZ2xlLjMuaHRtbCBhbmQKKyAgICAgICAgY2Fu dmFzL3BoaWxpcC90ZXN0cy8yZC5wYXRoLmFyY1RvLjJkLnBhdGguYXJjLmFuZ2xlLjUuaHRtbCBm cm9tIFNraXBwZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOgorCiAyMDEwLTA2 LTAzICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmll d2VkLiBUZXN0IGV4cGVjdGF0aW9uIHVwZGF0ZS4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3Jt L3F0L1NraXBwZWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBl ZAkocmV2aXNpb24gNjA1NjEpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCSh3 b3JraW5nIGNvcHkpCkBAIC01MTM0LDggKzUxMzQsNiBAQCBjYW52YXMvcGhpbGlwL3Rlc3RzLzJk LmxpbmUuam9pbi5vcGVuLmh0CiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmxpbmUuam9pbi5wYXJh bGxlbC5odG1sCiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmxpbmUubWl0ZXIubGluZWVkZ2UuaHRt bAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5taXNzaW5nYXJncy5odG1sCi1jYW52YXMvcGhpbGlw L3Rlc3RzLzJkLnBhdGguYXJjLmFuZ2xlLjMuaHRtbAotY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5w YXRoLmFyYy5hbmdsZS41Lmh0bWwKIGNhbnZhcy9waGlsaXAvdGVzdHMvMmQucGF0aC5hcmMudHdv cGllLjMuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5wYXRoLmFyYy56ZXJvcmFkaXVzLmh0 bWwKIGNhbnZhcy9waGlsaXAvdGVzdHMvMmQucGF0aC5hcmNUby5jb2xsaW5lYXIuMi5odG1sCg==