38528 2010-05-04 10:17:10 -0700 [Qt] WebGL viewport does not show up on N900 2010-06-17 01:20:15 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Other Linux RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 jarkko.j.sakkinen jarkko.j.sakkinen commit-queue hausmann jesus kbr laszlo.gombos oldest_to_newest 220642 0 jarkko.j.sakkinen 2010-05-04 10:17:10 -0700 WebGL viewport does not show up anymore on N900 when tested with QtLauncher. 220985 1 jarkko.j.sakkinen 2010-05-05 00:20:53 -0700 Issue here is simple. Higher-level WebGL code does not handle precision arguments yet (I suppose) and WebGL applications do not usually define precisions. 220988 2 jarkko.j.sakkinen 2010-05-05 00:27:55 -0700 Verified that there is no code that handles shader precisions. 220990 3 jarkko.j.sakkinen 2010-05-05 00:31:47 -0700 https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/doc/spec/WebGL-spec.html#4.4 Issue here is that most of the WebGL pages do not respect that at all :) Shaders are not ES GLSL compatible. They don't define precision arguments. 220992 4 jarkko.j.sakkinen 2010-05-05 00:33:41 -0700 QGLContext::drawTexture functions do not work in Maemo version. Tweaked qgl.cpp a little bit: diff --git a/src/opengl/qgl.cpp b/src/opengl/qgl.cpp index 644a737..da61e61 100644 --- a/src/opengl/qgl.cpp +++ b/src/opengl/qgl.cpp @@ -2706,7 +2706,7 @@ void QGLContext::drawTexture(const QRectF &target, QMacCompatGLuint textureId, Q void QGLContext::drawTexture(const QPointF &point, GLuint textureId, GLenum textureTarget) { // this would be ok on OpenGL ES 2.0, but currently we don't have a define for that -#ifdef QT_OPENGL_ES +#if !defined(QT_OPENGL_ES_2) && defined(QT_OPENGL_ES) Q_UNUSED(point); Q_UNUSED(textureId); Q_UNUSED(textureTarget); Let's how that helps. 220996 5 jarkko.j.sakkinen 2010-05-05 00:51:20 -0700 Kenneth, Simon says that you have some ideas on handling the precision argument in shader code. Can you elaborate a bit what you have in mind? :) I think I'll add the following work-around to Qt backend: - QtWebKit is compiled for a desktop system: define precision arguments as empty macros so that shaders still compile (similar idea as in http://doc.qt.nokia.com/4.6-snapshot/qglshaderprogram.html) - QtWebKit is compiled for a mobile device: define default precisions and append to the beginning of shader code. When something more higher-level comes out this workaround can be dropped. Simon, I don't find that too hackish, what do you think? 221043 6 jarkko.j.sakkinen 2010-05-05 03:43:19 -0700 Added new bugreport to Qt Jira: http://bugreports.qt.nokia.com/browse/QTBUG-10420 221133 7 jarkko.j.sakkinen 2010-05-05 09:04:53 -0700 See my comment on Qt Jira. I think point version of drawTexture() is really impossible to make work ES 2.0 but I don't actually can't figure out why rect version is only available for ES versions less than 2.0. 221142 8 jarkko.j.sakkinen 2010-05-05 09:27:39 -0700 Ok that first "patch snippet" was completely crap but now I have patch candidate for rect version, let's see if it works :) 221144 9 kbr 2010-05-05 09:31:29 -0700 (In reply to comment #5) > Kenneth, Simon says that you have some ideas on handling the precision argument > in shader code. Can you elaborate a bit what you have in mind? :) In the context of the ANGLE project ( http://code.google.com/p/angleproject/ ) a GLSL ES -> GLSL translator is being developed. Once this is complete, we hope to work with all browser vendors developing WebGL on the desktop to integrate it simultaneously, because as you've discovered, none of the shaders in the WebGL content currently on the web are GLSL ES compliant. > I think I'll add the following work-around to Qt backend: > - QtWebKit is compiled for a desktop system: define precision arguments as > empty macros so that shaders still compile (similar idea as in > http://doc.qt.nokia.com/4.6-snapshot/qglshaderprogram.html) > - QtWebKit is compiled for a mobile device: define default precisions and > append to the beginning of shader code. > > When something more higher-level comes out this workaround can be dropped. > Simon, I don't find that too hackish, what do you think? This sounds like the best short-term workaround. 223795 10 jarkko.j.sakkinen 2010-05-11 00:24:32 -0700 drawTexture() issue is now fixed by Qt people: http://bugreports.qt.nokia.com/browse/QTBUG-10420. Great :) I'm submitting soon patch with workaround for shaders. 224579 11 jesus 2010-05-12 06:57:42 -0700 Please remember to block the 2.0 release meta-bug if you want this to be cherry-picked when the patch is ready. 225721 12 jarkko.j.sakkinen 2010-05-14 02:00:47 -0700 Still waiting for the drawTexture() fix to arrive to Qt public repositories. 225739 13 hausmann 2010-05-14 03:42:10 -0700 (In reply to comment #12) > Still waiting for the drawTexture() fix to arrive to Qt public repositories. Sounds like we should also make WebGL only available when compiling against Qt 4.7? 225744 14 jarkko.j.sakkinen 2010-05-14 03:59:54 -0700 Depends. If we want to keep readPixels as a fallback for 4.6 then we can support both. I don't really have an opinnion on this, I'll let others to decide this :) Simon, have you already created bug for dropping readPixels? We already discussed about readPixels support but does everyone else share the opinnion that WebGL should be only supported with GL viewport? drawTexture() can be used for both cases (AC enabled/disabled) when GL viewport is active. I have already fix for this in my gitorious repository and I'm planning to add that change to this patch. 228361 15 56592 jarkko.j.sakkinen 2010-05-20 07:01:49 -0700 Created attachment 56592 Fixes shader issues with OGLES2, improves drawTexture usage a bit. 239190 16 56592 commit-queue 2010-06-16 19:55:20 -0700 Comment on attachment 56592 Fixes shader issues with OGLES2, improves drawTexture usage a bit. Clearing flags on attachment: 56592 Committed r61301: <http://trac.webkit.org/changeset/61301> 239191 17 commit-queue 2010-06-16 19:55:26 -0700 All reviewed patches have been landed. Closing bug. 239280 18 hausmann 2010-06-17 01:20:15 -0700 WebGL is not part of the QtWebKit 2.0 release, so removing from the blocker bug. 56592 2010-05-20 07:01:49 -0700 2010-06-16 19:55:20 -0700 Fixes shader issues with OGLES2, improves drawTexture usage a bit. 38528-1.patch text/plain 3688 jarkko.j.sakkinen ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZWRiZmI3Ni4uMmEzOGRiOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wNS0yMCAgSmFya2tvIFNha2tp bmVuICA8amFya2tvLmouc2Fra2luZW5AZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gV2ViR0wgdmlld3BvcnQgZG9lcyBub3Qg c2hvdyB1cCBvbiBOOTAwICAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTM4NTI4CisKKyAgICAgICAgV2l0aCBPR0xFUzIgYWRkIGRlZmF1bHQgcHJlY2lz aW9uIHRvIHRoZSBzaGFkZXIgY29kZS4KKyAgICAgICAgVXNlIEdMc2l6ZWlwdHIgYW5kIEdMaW50 cHRyIHdpdGggT0dMRVMyLgorICAgICAgICBDYWxsIHBhaW50KCkgaW4gYmVnaW5QYWludCgpIHNv IHRoYXQgZHJhd1RleHR1cmUoKSBpcyB1c2VkIAorICAgICAgICB3aGVuZXZlciBwb3NzaWJsZS4K KworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dDNEUXQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0M0Q6OmJlZ2luUGFpbnQpOgorICAg ICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0M0Q6OnBhaW50KToKKyAgICAgICAgKFdlYkNv cmU6OkdyYXBoaWNzQ29udGV4dDNEOjpzaGFkZXJTb3VyY2UpOgorCiAyMDEwLTA1LTIwICBDaHJp cyBKZXJkb25layAgPGNqZXJkb25la0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9H cmFwaGljc0NvbnRleHQzRFF0LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3Jh cGhpY3NDb250ZXh0M0RRdC5jcHAKaW5kZXggYWQ0MzkwOC4uMDljZWExZSAxMDA2NDQKLS0tIGEv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQzRFF0LmNwcAorKysg Yi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dDNEUXQuY3BwCkBA IC01NSw4ICs1NSwxMyBAQCB0eXBlZGVmIGNoYXIgR0xjaGFyOwogI2RlZmluZSBBUElFTlRSWQog I2VuZGlmCiAKKyNpZmRlZiBRVF9PUEVOR0xfRVNfMgordHlwZWRlZiBHTHNpemVpcHRyIEdMc2l6 ZWlwdHJUeXBlOwordHlwZWRlZiBHTGludHB0ciBHTGludHB0clR5cGU7CisjZWxzZQogdHlwZWRl ZiBwdHJkaWZmX3QgR0xzaXplaXB0clR5cGU7CiB0eXBlZGVmIHB0cmRpZmZfdCBHTGludHB0clR5 cGU7CisjZW5kaWYKIAogdHlwZWRlZiB2b2lkIChBUElFTlRSWSogZ2xBY3RpdmVUZXh0dXJlVHlw ZSkgKEdMZW51bSk7CiB0eXBlZGVmIHZvaWQgKEFQSUVOVFJZKiBnbEF0dGFjaFNoYWRlclR5cGUp IChHTHVpbnQsIEdMdWludCk7CkBAIC01MTYsMTggKzUyMSwxMCBAQCB2b2lkIEdyYXBoaWNzQ29u dGV4dDNEOjptYWtlQ29udGV4dEN1cnJlbnQoKQogdm9pZCBHcmFwaGljc0NvbnRleHQzRDo6YmVn aW5QYWludChXZWJHTFJlbmRlcmluZ0NvbnRleHQqIGNvbnRleHQpCiB7CiAgICAgbV9pbnRlcm5h bC0+bV9nbFdpZGdldC0+bWFrZUN1cnJlbnQoKTsKLQogICAgIEhUTUxDYW52YXNFbGVtZW50KiBj YW52YXMgPSBjb250ZXh0LT5jYW52YXMoKTsKICAgICBJbWFnZUJ1ZmZlciogaW1hZ2VCdWZmZXIg PSBjYW52YXMtPmJ1ZmZlcigpOwotCi0gICAgbV9pbnRlcm5hbC0+YmluZEZyYW1lYnVmZmVyKEdy YXBoaWNzQ29udGV4dDNEOjpGUkFNRUJVRkZFUiwgbV9pbnRlcm5hbC0+bV9tYWluRmJvKTsKLQot ICAgIGdsUmVhZFBpeGVscygvKiB4ICovIDAsIC8qIHkgKi8gMCwgbV9jdXJyZW50V2lkdGgsIG1f Y3VycmVudEhlaWdodCwgR3JhcGhpY3NDb250ZXh0M0Q6OlJHQkEsIEdyYXBoaWNzQ29udGV4dDNE OjpVTlNJR05FRF9CWVRFLCBtX2ludGVybmFsLT5tX3BpeGVscy5iaXRzKCkpOwotCi0gICAgUVBh aW50ZXIqIHAgPSBpbWFnZUJ1ZmZlci0+Y29udGV4dCgpLT5wbGF0Zm9ybUNvbnRleHQoKTsKLSAg ICBwLT5kcmF3SW1hZ2UoLyogeCAqLyAwLCAvKiB5ICovIDAsIG1faW50ZXJuYWwtPm1fcGl4ZWxz LnJnYlN3YXBwZWQoKS50cmFuc2Zvcm1lZChRTWF0cml4KCkucm90YXRlKDE4MCkpKTsKLQotICAg IG1faW50ZXJuYWwtPmJpbmRGcmFtZWJ1ZmZlcihHcmFwaGljc0NvbnRleHQzRDo6RlJBTUVCVUZG RVIsIG1faW50ZXJuYWwtPm1fY3VycmVudEZibyk7CisgICAgUVBhaW50ZXIqIHBhaW50ZXIgPSBp bWFnZUJ1ZmZlci0+Y29udGV4dCgpLT5wbGF0Zm9ybUNvbnRleHQoKTsKKyAgICBwYWludChwYWlu dGVyLCBRUmVjdChRUG9pbnQoMCwgMCksIFFTaXplKG1fY3VycmVudFdpZHRoLCBtX2N1cnJlbnRI ZWlnaHQpKSk7CiB9CiAKIHZvaWQgR3JhcGhpY3NDb250ZXh0M0Q6OmVuZFBhaW50KCkKQEAgLTU0 MCw3ICs1MzcsNyBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDNEOjpwYWludChRUGFpbnRlciogcGFp bnRlciwgY29uc3QgUVJlY3QmIHJlY3QpIGNvbnN0CiAgICAgUVdlYlBhZ2VDbGllbnQqIHdlYlBh Z2VDbGllbnQgPSBtX2ludGVybmFsLT5tX2hvc3RXaW5kb3ctPnBsYXRmb3JtUGFnZUNsaWVudCgp OwogICAgIFFHTFdpZGdldCogb3duZXJHTFdpZGdldCAgPSBtX2ludGVybmFsLT5nZXRPd25lckdM V2lkZ2V0KHdlYlBhZ2VDbGllbnQpOwogICAgIGlmIChvd25lckdMV2lkZ2V0KSB7Ci0gICAgICAg IG93bmVyR0xXaWRnZXQtPmRyYXdUZXh0dXJlKFFQb2ludEYoMCwgMCksIG1faW50ZXJuYWwtPm1f dGV4dHVyZSk7CisgICAgICAgIG93bmVyR0xXaWRnZXQtPmRyYXdUZXh0dXJlKHJlY3QsIG1faW50 ZXJuYWwtPm1fdGV4dHVyZSk7CiAgICAgICAgIHJldHVybjsKICAgICB9IAogI2VuZGlmCkBAIC0x MDgxLDEyICsxMDc4LDIwIEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0M0Q6OnNjaXNzb3IobG9uZyB4 LCBsb25nIHksIHVuc2lnbmVkIGxvbmcgd2lkdGgsIHVuc2lnbmVkIGxvCiB2b2lkIEdyYXBoaWNz Q29udGV4dDNEOjpzaGFkZXJTb3VyY2UoV2ViR0xTaGFkZXIqIHNoYWRlciwgY29uc3QgU3RyaW5n JiBzb3VyY2UpCiB7CiAgICAgQVNTRVJUKHNoYWRlcik7Ci0gICAgCisKICAgICBtX2ludGVybmFs LT5tX2dsV2lkZ2V0LT5tYWtlQ3VycmVudCgpOwogCi0gICAgQ1N0cmluZyBzb3VyY2VDUyA9IHNv dXJjZS51dGY4KCk7CisgICAgU3RyaW5nIHByZWZpeGVkU291cmNlOworCisjaWYgZGVmaW5lZCAo UVRfT1BFTkdMX0VTXzIpCisgICAgcHJlZml4ZWRTb3VyY2UuYXBwZW5kKCJwcmVjaXNpb24gbWVk aXVtcCBmbG9hdDtcbiIpOworI2VuZGlmCisKKyAgICBwcmVmaXhlZFNvdXJjZS5hcHBlbmQoc291 cmNlKTsKKworICAgIENTdHJpbmcgc291cmNlQ1MgPSBwcmVmaXhlZFNvdXJjZS51dGY4KCk7CiAg ICAgY29uc3QgY2hhciogZGF0YSA9IHNvdXJjZUNTLmRhdGEoKTsKLSAgICBpbnQgbGVuZ3RoID0g c291cmNlLmxlbmd0aCgpOworICAgIGludCBsZW5ndGggPSBwcmVmaXhlZFNvdXJjZS5sZW5ndGgo KTsKICAgICBtX2ludGVybmFsLT5zaGFkZXJTb3VyY2UoKEdMdWludCkgc2hhZGVyLT5vYmplY3Qo KSwgLyogY291bnQgKi8gMSwgJmRhdGEsICZsZW5ndGgpOwogfQogCg==