38522 2010-05-04 08:22:47 -0700 Web Inspector: restore main and sidebar scroller positions when switching between panels. 2010-05-04 11:50:55 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman bweinstein joepeck keishi pfeldman pmuellr rik timothy yurys oldest_to_newest 220598 0 pfeldman 2010-05-04 08:22:47 -0700 We would still need to store scroll top for views once this lands. 220599 1 55019 pfeldman 2010-05-04 08:28:32 -0700 Created attachment 55019 [PATCH] Proposed change. 220604 2 55019 timothy 2010-05-04 08:32:08 -0700 Comment on attachment 55019 [PATCH] Proposed change. WebCore/inspector/front-end/Panel.js:403 + container.__scrollTop = container.scrollTop; I think _storedScrollTop would be clearer than __scrollTop. Nice solution! 220697 3 pfeldman 2010-05-04 11:50:55 -0700 Landed with comments addressed. Reason I used __ was that it was not a private field, but rather a custom property on a node wrapper (i.e. accessible from other parts of the frontend). I thought we were using __ for that, but I now realize that was the inspected page side where we used __ before. Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/ElementsPanel.js M WebCore/inspector/front-end/Panel.js M WebCore/inspector/front-end/ResourcesPanel.js M WebCore/inspector/front-end/ScriptsPanel.js Committed r58768 55019 2010-05-04 08:28:32 -0700 2010-05-04 08:32:08 -0700 [PATCH] Proposed change. scroller_top text/plain 4751 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YWNhNWVjOS4uYjZlYmU5YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyOSBAQAorMjAxMC0wNS0wNCAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiByZXN0b3JlIG1haW4gYW5kIHNpZGVi YXIgc2Nyb2xsZXIgcG9zaXRpb25zIHdoZW4gc3dpdGNoaW5nIGJldHdlZW4gcGFuZWxzLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODUyMgorCisg ICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1BhbmVsLmpzOgorICAgICAgICAo V2ViSW5zcGVjdG9yLkVsZW1lbnRzUGFuZWwucHJvdG90eXBlLl9ub2RlU2VhcmNoQnV0dG9uQ2xp Y2tlZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRWxlbWVudHNQYW5lbC5wcm90b3R5cGUuZWxl bWVudHNUb1Jlc3RvcmVTY3JvbGxQb3NpdGlvbnNGb3IpOgorICAgICAgICAqIGluc3BlY3Rvci9m cm9udC1lbmQvUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUGFuZWwucHJvdG90eXBl LnNob3cpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlBhbmVsLnByb3RvdHlwZS5oaWRlKToKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5QYW5lbC5wcm90b3R5cGUuc2VhcmNoSXRlcmF0ZXNPdmVyVmll d3MpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlBhbmVsLnByb3RvdHlwZS5lbGVtZW50c1RvUmVz dG9yZVNjcm9sbFBvc2l0aW9uc0Zvcik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUGFuZWwucHJv dG90eXBlLl9zdG9yZVNjcm9sbFBvc2l0aW9ucyk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUGFu ZWwucHJvdG90eXBlLl9yZXN0b3JlU2Nyb2xsUG9zaXRpb25zKToKKyAgICAgICAgKiBpbnNwZWN0 b3IvZnJvbnQtZW5kL1Jlc291cmNlc1BhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlJl c291cmNlc1BhbmVsLnByb3RvdHlwZS5zaG93U291cmNlTGluZSk6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuUmVzb3VyY2VzUGFuZWwucHJvdG90eXBlLnNlYXJjaEl0ZXJhdGVzT3ZlclZpZXdzKToK KyAgICAgICAgKFdlYkluc3BlY3Rvci5SZXNvdXJjZXNQYW5lbC5wcm90b3R5cGUuZWxlbWVudHNU b1Jlc3RvcmVTY3JvbGxQb3NpdGlvbnNGb3IpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1l bmQvU2NyaXB0c1BhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNjcmlwdHNQYW5lbC5w cm90b3R5cGUuX3RvZ2dsZUJyZWFrcG9pbnRzQ2xpY2tlZCk6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuU2NyaXB0c1BhbmVsLnByb3RvdHlwZS5lbGVtZW50c1RvUmVzdG9yZVNjcm9sbFBvc2l0aW9u c0Zvcik6CisKIDIwMTAtMDUtMDMgIFRob21hcyBaYW5kZXIgPHQuemFuZGVyQG5va2lhLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KZGlmZiAtLWdpdCBhL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1BhbmVsLmpzIGIvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL0VsZW1lbnRzUGFuZWwuanMKaW5kZXggMGQ0ZGQ5MS4uN2VkYjdiOSAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzUGFuZWwuanMKKysr IGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzUGFuZWwuanMKQEAgLTExMjUs NiArMTEyNSwxMSBAQCBXZWJJbnNwZWN0b3IuRWxlbWVudHNQYW5lbC5wcm90b3R5cGUgPSB7CiAg ICAgICAgICAgICBJbnNwZWN0b3JCYWNrZW5kLmVuYWJsZVNlYXJjaGluZ0Zvck5vZGUoKTsKICAg ICAgICAgZWxzZQogICAgICAgICAgICAgSW5zcGVjdG9yQmFja2VuZC5kaXNhYmxlU2VhcmNoaW5n Rm9yTm9kZSgpOworICAgIH0sCisKKyAgICBlbGVtZW50c1RvUmVzdG9yZVNjcm9sbFBvc2l0aW9u c0ZvcjogZnVuY3Rpb24oKQorICAgIHsKKyAgICAgICAgcmV0dXJuIFsgdGhpcy5jb250ZW50RWxl bWVudCwgdGhpcy5zaWRlYmFyRWxlbWVudCBdOwogICAgIH0KIH0KIApkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1BhbmVsLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL1BhbmVsLmpzCmluZGV4IGI5MTY3MDguLjZkNjU4YjYgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9QYW5lbC5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvUGFuZWwuanMKQEAgLTg0LDEwICs4NCwxMiBAQCBXZWJJbnNwZWN0b3IuUGFuZWwu cHJvdG90eXBlID0gewogICAgICAgICBXZWJJbnNwZWN0b3IuY3VycmVudEZvY3VzRWxlbWVudCA9 IHRoaXMuZGVmYXVsdEZvY3VzZWRFbGVtZW50OwogCiAgICAgICAgIHRoaXMudXBkYXRlU2lkZWJh cldpZHRoKCk7CisgICAgICAgIHRoaXMuX3Jlc3RvcmVTY3JvbGxQb3NpdGlvbnMoKTsKICAgICB9 LAogCiAgICAgaGlkZTogZnVuY3Rpb24oKQogICAgIHsKKyAgICAgICAgdGhpcy5fc3RvcmVTY3Jv bGxQb3NpdGlvbnMoKTsKICAgICAgICAgV2ViSW5zcGVjdG9yLlZpZXcucHJvdG90eXBlLmhpZGUu Y2FsbCh0aGlzKTsKIAogICAgICAgICBpZiAodGhpcy5fc3RhdHVzQmFySXRlbUNvbnRhaW5lciAm JiB0aGlzLl9zdGF0dXNCYXJJdGVtQ29udGFpbmVyLnBhcmVudE5vZGUpCkBAIC0zODYsNiArMzg4 LDMwIEBAIFdlYkluc3BlY3Rvci5QYW5lbC5wcm90b3R5cGUgPSB7CiAgICAgc2VhcmNoSXRlcmF0 ZXNPdmVyVmlld3M6IGZ1bmN0aW9uKCkKICAgICB7CiAgICAgICAgIHJldHVybiBmYWxzZTsKKyAg ICB9LAorCisgICAgZWxlbWVudHNUb1Jlc3RvcmVTY3JvbGxQb3NpdGlvbnNGb3I6IGZ1bmN0aW9u KCkKKyAgICB7CisgICAgICAgIHJldHVybiBbXTsKKyAgICB9LAorCisgICAgX3N0b3JlU2Nyb2xs UG9zaXRpb25zOiBmdW5jdGlvbigpCisgICAgeworICAgICAgICB2YXIgZWxlbWVudHMgPSB0aGlz LmVsZW1lbnRzVG9SZXN0b3JlU2Nyb2xsUG9zaXRpb25zRm9yKCk7CisgICAgICAgIGZvciAodmFy IGkgPSAwOyBpIDwgZWxlbWVudHMubGVuZ3RoOyArK2kpIHsKKyAgICAgICAgICAgIHZhciBjb250 YWluZXIgPSBlbGVtZW50c1tpXTsKKyAgICAgICAgICAgIGNvbnRhaW5lci5fX3Njcm9sbFRvcCA9 IGNvbnRhaW5lci5zY3JvbGxUb3A7CisgICAgICAgIH0KKyAgICB9LAorCisgICAgX3Jlc3RvcmVT Y3JvbGxQb3NpdGlvbnM6IGZ1bmN0aW9uKCkKKyAgICB7CisgICAgICAgIHZhciBlbGVtZW50cyA9 IHRoaXMuZWxlbWVudHNUb1Jlc3RvcmVTY3JvbGxQb3NpdGlvbnNGb3IoKTsKKyAgICAgICAgZm9y ICh2YXIgaSA9IDA7IGkgPCBlbGVtZW50cy5sZW5ndGg7ICsraSkgeworICAgICAgICAgICAgdmFy IGNvbnRhaW5lciA9IGVsZW1lbnRzW2ldOworICAgICAgICAgICAgaWYgKGNvbnRhaW5lci5fX3Nj cm9sbFRvcCkKKyAgICAgICAgICAgICAgICBjb250YWluZXIuc2Nyb2xsVG9wID0gY29udGFpbmVy Ll9fc2Nyb2xsVG9wOworICAgICAgICB9CiAgICAgfQogfQogCmRpZmYgLS1naXQgYS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2VzUGFuZWwuanMgYi9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvUmVzb3VyY2VzUGFuZWwuanMKaW5kZXggMTk3MTYwMy4uNzg1ZjM1MCAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlc1BhbmVsLmpzCisr KyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZXNQYW5lbC5qcwpAQCAtNzI1 LDYgKzcyNSwxMSBAQCBXZWJJbnNwZWN0b3IuUmVzb3VyY2VzUGFuZWwucHJvdG90eXBlID0gewog ICAgIHNlYXJjaEl0ZXJhdGVzT3ZlclZpZXdzOiBmdW5jdGlvbigpCiAgICAgewogICAgICAgICBy ZXR1cm4gdHJ1ZTsKKyAgICB9LAorCisgICAgZWxlbWVudHNUb1Jlc3RvcmVTY3JvbGxQb3NpdGlv bnNGb3I6IGZ1bmN0aW9uKCkKKyAgICB7CisgICAgICAgIHJldHVybiBbIHRoaXMuY29udGFpbmVy RWxlbWVudCBdOwogICAgIH0KIH0KIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL1NjcmlwdHNQYW5lbC5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3Jp cHRzUGFuZWwuanMKaW5kZXggMDk2ZmRhMC4uNjM0NDU1NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpzCkBAIC05OTgsNiArOTk4LDExIEBAIFdlYkluc3Bl Y3Rvci5TY3JpcHRzUGFuZWwucHJvdG90eXBlID0gewogICAgICAgICAgICAgdGhpcy50b2dnbGVC cmVha3BvaW50c0J1dHRvbi50aXRsZSA9IFdlYkluc3BlY3Rvci5VSVN0cmluZygiQWN0aXZhdGUg YWxsIGJyZWFrcG9pbnRzLiIpOwogICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo Im1haW4tcGFuZWxzIikuYWRkU3R5bGVDbGFzcygiYnJlYWtwb2ludHMtZGVhY3RpdmF0ZWQiKTsK ICAgICAgICAgfQorICAgIH0sCisKKyAgICBlbGVtZW50c1RvUmVzdG9yZVNjcm9sbFBvc2l0aW9u c0ZvcjogZnVuY3Rpb24oKQorICAgIHsKKyAgICAgICAgcmV0dXJuIFsgdGhpcy5zaWRlYmFyRWxl bWVudCBdOwogICAgIH0KIH0KIAo=