38517 2010-05-04 07:09:31 -0700 Commit and Review policy should encourage unofficial reviews 2010-05-05 10:53:58 -0700 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 hamaji webkit-unassigned oldest_to_newest 220577 0 hamaji 2010-05-04 07:09:31 -0700 It would be better to encourage unofficial reviews in http://webkit.org/coding/commit-review-policy.html 220579 1 55017 hamaji 2010-05-04 07:10:39 -0700 Created attachment 55017 Patch v1 221167 2 55017 abarth 2010-05-05 10:12:06 -0700 Comment on attachment 55017 Patch v1 LGTM. 221193 3 55017 hamaji 2010-05-05 10:53:51 -0700 Comment on attachment 55017 Patch v1 Clearing flags on attachment: 55017 Committed r58827: <http://trac.webkit.org/changeset/58827> 221194 4 hamaji 2010-05-05 10:53:58 -0700 All reviewed patches have been landed. Closing bug. 55017 2010-05-04 07:10:39 -0700 2010-05-05 10:53:51 -0700 Patch v1 bug-38517-20100504231037.patch text/plain 1384 hamaji ZGlmZiAtLWdpdCBhL1dlYktpdFNpdGUvQ2hhbmdlTG9nIGIvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cK aW5kZXggNmJiM2IyODUzMWY3MmNhMTA3ZTkwNjJkZmU1NzZjZmQ1NWUxZWFjMS4uYzFkNmZhYmFh M2QwOWM5YTJjMGFhMDI0ZWRlZDA0ZTQ1ZDY3YTY0NyAxMDA2NDQKLS0tIGEvV2ViS2l0U2l0ZS9D aGFuZ2VMb2cKKysrIGIvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAx MC0wNS0wNCAgU2hpbmljaGlybyBIYW1hamkgIDxoYW1hamlAY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvbW1pdCBhbmQgUmV2 aWV3IHBvbGljeSBzaG91bGQgZW5jb3VyYWdlIHVub2ZmaWNpYWwgcmV2aWV3cworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg1MTcKKworICAgICAgICAq IGNvZGluZy9jb21taXQtcmV2aWV3LXBvbGljeS5odG1sOgorCiAyMDEwLTA1LTAyICBEaXJrIFNj aHVsemUgIDxrcml0QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTmlrb2xhcyBa aW1tZXJtYW5uLgpkaWZmIC0tZ2l0IGEvV2ViS2l0U2l0ZS9jb2RpbmcvY29tbWl0LXJldmlldy1w b2xpY3kuaHRtbCBiL1dlYktpdFNpdGUvY29kaW5nL2NvbW1pdC1yZXZpZXctcG9saWN5Lmh0bWwK aW5kZXggMWQxODY4OGU5ZmZmNDQzZTUzODk1ZWQxNzNmMTRmM2ExMTEzZjQ5YS4uYzc4YjdkYWMy ZjkwZGYwZDRhOTEyNTdiMjE2MDA3NDMzZTk0MjVjNiAxMDA2NDQKLS0tIGEvV2ViS2l0U2l0ZS9j b2RpbmcvY29tbWl0LXJldmlldy1wb2xpY3kuaHRtbAorKysgYi9XZWJLaXRTaXRlL2NvZGluZy9j b21taXQtcmV2aWV3LXBvbGljeS5odG1sCkBAIC04Nyw3ICs4NywxMCBAQCBhcmVhcy48L3A+CiAK IDxwPkEgcGVyc29uIHdobyBzdWJtaXRzIG1hbnkgcGF0Y2hlcyBidXQgZG9lcyBub3Qgc2hvdyBn b29kCiBjb2xsYWJvcmF0aW9uIHNraWxscywgY29kZSB1bmRlcnN0YW5kaW5nIG9yIHVuZGVyc3Rh bmRpbmcgb2YgcHJvamVjdAotcG9saWNpZXMgbWF5IG5ldmVyIGJlIG5vbWluYXRlZC48L3A+Citw b2xpY2llcyBtYXkgbmV2ZXIgYmUgbm9taW5hdGVkLiBNYWtpbmcgdW5vZmZpY2lhbCByZXZpZXdz IGJlZm9yZSB5b3UKK2JlY29tZSBhIHJldmlld2VyIGlzIGVuY291cmFnZWQuIFRoaXMgaXMgYW4g ZXhjZWxsZW50IHdheSB0byBzaG93IHlvdXIKK3NraWxscy4gTm90ZSB0aGF0IHlvdSBzaG91bGQg bm90IHB1dCByKyBub3Igci0gb24gcGF0Y2hlcyBpbiBzdWNoCit1bm9mZmljaWFsIHJldmlld3Mu PC9wPgogCiA8cD5Gb3IgUmV2aWV3ZXIgc3RhdHVzLCB0aGVyZSBpcyBubyBzdXBlcnZpc2lvbiBl eGNlcHRpb24uPC9wPgogCg==