38511 2010-05-04 02:01:59 -0700 [Qt] Remove WinCE endian dedection. 2010-05-17 01:43:33 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 37434 1 paroga paroga abarth commit-queue eric laszlo.gombos ossy skyul webkit.review.bot oldest_to_newest 220526 0 paroga 2010-05-04 02:01:59 -0700 See patch. 220527 1 55003 paroga 2010-05-04 02:03:20 -0700 Created attachment 55003 The patch 220655 2 laszlo.gombos 2010-05-04 10:43:01 -0700 Patrick, the change looks good to me. Have you had a chance to test it on WinCE? 220660 3 paroga 2010-05-04 10:48:38 -0700 (In reply to comment #2) > Patrick, the change looks good to me. Have you had a chance to test it on > WinCE? No, I didn't. (It takes sooo much time) I can compile it with this patch if it's necessary, but I don't think so. ;-) 220667 4 laszlo.gombos 2010-05-04 10:59:09 -0700 As we do not have a buildbot for WinCE I would feel better if we could actually test this build change. Only the QtWebKit port on WinCE is impacted. Should we find someone else to test this with QtWebKit ? 220668 5 paroga 2010-05-04 11:03:20 -0700 (In reply to comment #4) > As we do not have a buildbot for WinCE I would feel better if we could actually > test this build change. Only the QtWebKit port on WinCE is impacted. > > Should we find someone else to test this with QtWebKit ? I'll try to get it running, but I had many troubles compiling QtWebKit for WinCE directly from svn trunk the last time. It doesn't work as nice as from a Qt release. ;-) 221244 6 55003 laszlo.gombos 2010-05-05 13:09:22 -0700 Comment on attachment 55003 The patch r+ for the patch, but cq- until it is confirmed that this does not breaks the build. Thanks for the clean-up, this moves the code to the right direction. 224573 7 jesus 2010-05-12 06:49:24 -0700 Triaged but I'm not adding it as QtWebKit 2.0 blocker as I don't know if you want this. 225724 8 55003 paroga 2010-05-14 02:21:01 -0700 Comment on attachment 55003 The patch It took a lot of time to compile it out of trunk for WinCE, but it works with this patch. 226671 9 55003 commit-queue 2010-05-17 01:11:21 -0700 Comment on attachment 55003 The patch Clearing flags on attachment: 55003 Committed r59600: <http://trac.webkit.org/changeset/59600> 226672 10 commit-queue 2010-05-17 01:11:26 -0700 All reviewed patches have been landed. Closing bug. 226685 11 webkit.review.bot 2010-05-17 01:40:54 -0700 http://trac.webkit.org/changeset/59600 might have broken Qt Linux ARMv7 Release The following changes are on the blame list: http://trac.webkit.org/changeset/59600 http://trac.webkit.org/changeset/59599 226692 12 eric 2010-05-17 01:43:33 -0700 Sorry. The qt builders just got disconnected. I think we may need to remove them from the sheriff-bot watch until they can get a better internet connection. 55003 2010-05-04 02:03:20 -0700 2010-05-17 01:11:20 -0700 The patch bug-38511.patch text/plain 1462 paroga SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU4NzQzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDUtMDQgIFBhdHJpY2sg R2Fuc3RlcmVyICA8cGFyb2dhQHBhcm9nYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBSZW1vdmUgV2luQ0UgZW5kaWFuIGRlZGVjdGlv bi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4NTEx CisKKyAgICAgICAgV2luZG93cyBDRSBzdXBwb3J0cyBsaXR0bGUtZW5kaWFuIGZvcm1hdCBvbmx5 LgorICAgICAgICBDb3JyZWN0IGRlZGVjdGlvbiB3YXMgYWRkZWQgaW4gcjU3ODA0LgorCisgICAg ICAgICogd3RmL1BsYXRmb3JtLmg6CisKIDIwMTAtMDUtMDQgIEFkYW0gQmFydGggIDxhYmFydGhA d2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYWNpZWogU3RhY2hvd2lhay4KSW5k ZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3Jp cHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCShyZXZpc2lvbiA1ODc0MykKKysrIEphdmFTY3JpcHRDb3Jl L3d0Zi9QbGF0Zm9ybS5oCSh3b3JraW5nIGNvcHkpCkBAIC01MTUsMjAgKzUxNSw4IEBACiAjZW5k aWYKIAogCi0vKiBPUyhXSU5DRSkgJiYgUExBVEZPUk0oUVQpCi0gICBXZSBjYW4gbm90IGRldGVy bWluZSB0aGUgZW5kaWFuZXNzIGF0IGNvbXBpbGUgdGltZS4gRm9yCi0gICBRdCBmb3IgV2luZG93 cyBDRSB0aGUgZW5kaWFuZXNzIGlzIHNwZWNpZmllZCBpbiB0aGUKLSAgIGRldmljZSBzcGVjaWZp YyBtYWtlc3BlYwotKi8KICNpZiBPUyhXSU5DRSkgJiYgUExBVEZPUk0oUVQpCi0jICAgaW5jbHVk ZSA8UXRHbG9iYWw+Ci0jICAgdW5kZWYgV1RGX0NQVV9CSUdfRU5ESUFOCi0jICAgdW5kZWYgV1RG X0NQVV9NSURETEVfRU5ESUFOCi0jICAgaWYgUV9CWVRFX09SREVSID09IFFfQklHX0VORElBTgot IyAgICAgICBkZWZpbmUgV1RGX0NQVV9CSUdfRU5ESUFOIDEKLSMgICBlbmRpZgotCi0jICAgaW5j bHVkZSA8Y2VfdGltZS5oPgorI2luY2x1ZGUgPGNlX3RpbWUuaD4KICNlbmRpZgogCiAjaWYgKFBM QVRGT1JNKElQSE9ORSkgfHwgUExBVEZPUk0oTUFDKSB8fCBQTEFURk9STShXSU4pIHx8IChQTEFU Rk9STShRVCkgJiYgT1MoREFSV0lOKSAmJiAhRU5BQkxFKFNJTkdMRV9USFJFQURFRCkpKSAmJiAh ZGVmaW5lZChFTkFCTEVfSlNDX01VTFRJUExFX1RIUkVBRFMpCg==