38508 2010-05-03 23:16:42 -0700 [chromium] WebViewClient should have a notification when a new node gets the focus 2010-05-15 10:34:54 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 jcivelli webkit-unassigned abarth commit-queue dglazkov eric fishd oldest_to_newest 220484 0 jcivelli 2010-05-03 23:16:42 -0700 Right now the ChromeClient focus method is called every time a new node gets the focus, without specifying which node got focused. We should have a notification on the WebViewClient when a node gets focus, which specify that node. 220487 1 54998 jcivelli 2010-05-03 23:22:57 -0700 Created attachment 54998 Adding a notification on WebViewClient for focus change events. 221848 2 54998 fishd 2010-05-06 11:36:39 -0700 Comment on attachment 54998 Adding a notification on WebViewClient for focus change events. WebKit/chromium/public/WebViewClient.h:106 + virtual void focusNodeChanged(const WebNode&) { } How about moving this down near the other focus related methods? (In the UI section.) WebKit/chromium/src/ChromeClientImpl.cpp:218 + m_webView->client()->focusNodeChanged(WebNode(node)); focusedNodeChanged seems like a better name for this method. 222070 3 55322 jcivelli 2010-05-06 17:09:57 -0700 Created attachment 55322 Applying fishd's comments 222937 4 55322 commit-queue 2010-05-08 13:35:30 -0700 Comment on attachment 55322 Applying fishd's comments Rejecting patch 55322 from commit-queue. Unexpected failure when landing patch! Please file a bug against webkit-patch. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--test', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 55322, '--parent-command=commit-queue', '--no-update']" exit_code: 1 Logging in as eseidel@chromium.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=55322&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=38508&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Processing patch 55322 from bug 38508. ERROR: /Users/eseidel/Projects/CommitQueue/WebKit/chromium/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). 226174 5 56143 abarth 2010-05-15 00:01:43 -0700 Created attachment 56143 Patch for landing 226176 6 abarth 2010-05-15 00:02:48 -0700 In the future, please do not remove the Reviewed by NOBODY line from the ChangeLog. It is used by the automated tools to fill in the reviewer properly. 226278 7 56143 commit-queue 2010-05-15 10:34:47 -0700 Comment on attachment 56143 Patch for landing Clearing flags on attachment: 56143 Committed r59543: <http://trac.webkit.org/changeset/59543> 226279 8 commit-queue 2010-05-15 10:34:54 -0700 All reviewed patches have been landed. Closing bug. 54998 2010-05-03 23:22:57 -0700 2010-05-06 17:09:57 -0700 Adding a notification on WebViewClient for focus change events. focus_notific.patch text/plain 2084 jcivelli SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA1ODczNSkKKysrIFdlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNS0wMyAgSmF5 IENpdmVsbGkgIDxqY2l2ZWxsaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBBZGRpbmcgYSBub3RpZmljYXRp b24gb24gV2ViVmlld0NsaWVudCB3aGVuIGEgbmV3IAorICAgICAgICBub2RlIGdldHMgZm9jdXNl ZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4NTA4 CisKKyAgICAgICAgKiBwdWJsaWMvV2ViVmlld0NsaWVudC5oOgorICAgICAgICAoV2ViS2l0OjpX ZWJWaWV3Q2xpZW50Ojpmb2N1c05vZGVDaGFuZ2VkKToKKyAgICAgICAgKiBzcmMvQ2hyb21lQ2xp ZW50SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNocm9tZUNsaWVudEltcGw6OmZvY3VzZWRO b2RlQ2hhbmdlZCk6CisKIDIwMTAtMDUtMDMgIEFiaGlzaGVrIEFyeWEgIDxpbmZlcm5vQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogV2ViS2l0 L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3Q2xpZW50LmgNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYlZpZXdDbGllbnQuaAkocmV2aXNpb24gNTg2NzcpCisrKyBXZWJL aXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXdDbGllbnQuaAkod29ya2luZyBjb3B5KQpAQCAtMTAy LDYgKzEwMiw4IEBAIHB1YmxpYzoKICAgICAvLyBDYWxsZWQgdG8gcmV0cmlldmUgdGhlIHByb3Zp ZGVyIG9mIGRlc2t0b3Agbm90aWZpY2F0aW9ucy4KICAgICB2aXJ0dWFsIFdlYk5vdGlmaWNhdGlv blByZXNlbnRlciogbm90aWZpY2F0aW9uUHJlc2VudGVyKCkgeyByZXR1cm4gMDsgfQogCisgICAg Ly8gQ2FsbGVkIHdoZW4gYSBuZXcgbm9kZSBnZXRzIGZvY3VzZWQuCisgICAgdmlydHVhbCB2b2lk IGZvY3VzTm9kZUNoYW5nZWQoY29uc3QgV2ViTm9kZSYpIHsgfQogCiAgICAgLy8gTmF2aWdhdGlv bmFsIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tCiAKSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHANCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0NCi0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwCShy ZXZpc2lvbiA1ODY3NykKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTY2LDYgKzY2LDcgQEAKICNpbmNsdWRlICJXZWJGcmFtZUlt cGwuaCIKICNpbmNsdWRlICJXZWJJbnB1dEV2ZW50LmgiCiAjaW5jbHVkZSAiV2ViS2l0LmgiCisj aW5jbHVkZSAiV2ViTm9kZS5oIgogI2luY2x1ZGUgIldlYlBvcHVwTWVudUltcGwuaCIKICNpbmNs dWRlICJXZWJQb3B1cE1lbnVJbmZvLmgiCiAjaW5jbHVkZSAiV2ViUG9wdXBUeXBlLmgiCkBAIC0y MTQsNiArMjE1LDggQEAgdm9pZCBDaHJvbWVDbGllbnRJbXBsOjp0YWtlRm9jdXMoRm9jdXNEaQog CiB2b2lkIENocm9tZUNsaWVudEltcGw6OmZvY3VzZWROb2RlQ2hhbmdlZChOb2RlKiBub2RlKQog eworICAgIG1fd2ViVmlldy0+Y2xpZW50KCktPmZvY3VzTm9kZUNoYW5nZWQoV2ViTm9kZShub2Rl KSk7CisKICAgICBXZWJVUkwgZm9jdXNfdXJsOwogICAgIGlmIChub2RlICYmIG5vZGUtPmlzTGlu aygpKSB7CiAgICAgICAgIC8vIFRoaXMgSGl0VGVzdFJlc3VsdCBoYWNrIGlzIHRoZSBlYXNpZXN0 IHdheSB0byBnZXQgYSBsaW5rIFVSTCBvdXQgb2YgYQo= 55322 2010-05-06 17:09:57 -0700 2010-05-15 00:01:32 -0700 Applying fishd's comments focus_notific.patch text/plain 1982 jcivelli SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTg5MjIpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDUtMDYgIEpheSBD aXZlbGxpICA8amNpdmVsbGlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gQWRk aW5nIGEgbm90aWZpY2F0aW9uIG9uIFdlYlZpZXdDbGllbnQgd2hlbiBhIG5ldyAKKyAgICAgICAg bm9kZSBnZXRzIGZvY3VzZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zODUwOAorCisgICAgICAgICogcHVibGljL1dlYlZpZXdDbGllbnQuaDoKKyAg ICAgICAgKFdlYktpdDo6V2ViVmlld0NsaWVudDo6Zm9jdXNlZE5vZGVDaGFuZ2VkKToKKyAgICAg ICAgKiBzcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNocm9tZUNs aWVudEltcGw6OmZvY3VzZWROb2RlQ2hhbmdlZCk6CisKIDIwMTAtMDUtMDYgIFBhdmVsIEZlbGRt YW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgVGltb3Ro eSBIYXRjaGVyLgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3Q2xpZW50LmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3Q2xpZW50LmgJKHJl dmlzaW9uIDU4OTIwKQorKysgV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3Q2xpZW50LmgJ KHdvcmtpbmcgY29weSkKQEAgLTIzNCw2ICsyMzQsOSBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2 b2lkIGZvY3VzTmV4dCgpIHsgfQogICAgIHZpcnR1YWwgdm9pZCBmb2N1c1ByZXZpb3VzKCkgeyB9 CiAKKyAgICAvLyBDYWxsZWQgd2hlbiBhIG5ldyBub2RlIGdldHMgZm9jdXNlZC4KKyAgICB2aXJ0 dWFsIHZvaWQgZm9jdXNlZE5vZGVDaGFuZ2VkKGNvbnN0IFdlYk5vZGUmKSB7IH0KKwogCiAgICAg Ly8gU2Vzc2lvbiBoaXN0b3J5IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tCiAKSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50 SW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJ bXBsLmNwcAkocmV2aXNpb24gNTg5MjApCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNs aWVudEltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02Niw2ICs2Niw3IEBACiAjaW5jbHVkZSAi V2ViRnJhbWVJbXBsLmgiCiAjaW5jbHVkZSAiV2ViSW5wdXRFdmVudC5oIgogI2luY2x1ZGUgIldl YktpdC5oIgorI2luY2x1ZGUgIldlYk5vZGUuaCIKICNpbmNsdWRlICJXZWJQb3B1cE1lbnVJbXBs LmgiCiAjaW5jbHVkZSAiV2ViUG9wdXBNZW51SW5mby5oIgogI2luY2x1ZGUgIldlYlBvcHVwVHlw ZS5oIgpAQCAtMjE0LDYgKzIxNSw4IEBAIHZvaWQgQ2hyb21lQ2xpZW50SW1wbDo6dGFrZUZvY3Vz KEZvY3VzRGkKIAogdm9pZCBDaHJvbWVDbGllbnRJbXBsOjpmb2N1c2VkTm9kZUNoYW5nZWQoTm9k ZSogbm9kZSkKIHsKKyAgICBtX3dlYlZpZXctPmNsaWVudCgpLT5mb2N1c2VkTm9kZUNoYW5nZWQo V2ViTm9kZShub2RlKSk7CisKICAgICBXZWJVUkwgZm9jdXNfdXJsOwogICAgIGlmIChub2RlICYm IG5vZGUtPmlzTGluaygpKSB7CiAgICAgICAgIC8vIFRoaXMgSGl0VGVzdFJlc3VsdCBoYWNrIGlz IHRoZSBlYXNpZXN0IHdheSB0byBnZXQgYSBsaW5rIFVSTCBvdXQgb2YgYQo= 56143 2010-05-15 00:01:43 -0700 2010-05-15 10:34:47 -0700 Patch for landing bug-38508-20100515000141.patch text/plain 2163 abarth ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDRhMDBjODdlYjdiZWY5ZmViZTEyOTAxOGMwMTIxOGJmNTUzN2E1ODEu Ljc5YmI0YTY2MzA0NWQwMWFiY2VlNzU5NjcwNDIwYzQwODNkZTk4NTAgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE2IEBACisyMDEwLTA1LTE1ICBKYXkgQ2l2ZWxsaSAgPGpjaXZlbGxpQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCisKKyAgICAgICAg W2Nocm9taXVtXSBBZGRpbmcgYSBub3RpZmljYXRpb24gb24gV2ViVmlld0NsaWVudCB3aGVuIGEg bmV3IAorICAgICAgICBub2RlIGdldHMgZm9jdXNlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4NTA4CisKKyAgICAgICAgKiBwdWJsaWMvV2ViVmll d0NsaWVudC5oOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3Q2xpZW50Ojpmb2N1c2VkTm9kZUNo YW5nZWQpOgorICAgICAgICAqIHNyYy9DaHJvbWVDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdl YktpdDo6Q2hyb21lQ2xpZW50SW1wbDo6Zm9jdXNlZE5vZGVDaGFuZ2VkKToKKwogMjAxMC0wNS0x NCAgRGFyaW4gRmlzaGVyICA8ZGFyaW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViVmlld0NsaWVudC5oIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3Q2xpZW50LmgK aW5kZXggN2JjNzFiODNmY2U1ODk5YTFhODVkMWU3M2NkNDI5MjdmY2QyZTQwZC4uOTQ3OGRmOTQ2 YjI4NTRjNDgyMDhlNWMxZmQ4NmI2OWVjYjM2Mjc0NCAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJWaWV3Q2xpZW50LmgKKysrIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJWaWV3Q2xpZW50LmgKQEAgLTIzNCw2ICsyMzQsOSBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2 b2lkIGZvY3VzTmV4dCgpIHsgfQogICAgIHZpcnR1YWwgdm9pZCBmb2N1c1ByZXZpb3VzKCkgeyB9 CiAKKyAgICAvLyBDYWxsZWQgd2hlbiBhIG5ldyBub2RlIGdldHMgZm9jdXNlZC4KKyAgICB2aXJ0 dWFsIHZvaWQgZm9jdXNlZE5vZGVDaGFuZ2VkKGNvbnN0IFdlYk5vZGUmKSB7IH0KKwogCiAgICAg Ly8gU2Vzc2lvbiBoaXN0b3J5IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tCiAKZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21l Q2xpZW50SW1wbC5jcHAgYi9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3Bw CmluZGV4IDgyZmRlZmNiZDE3M2QwYTliOTUwZmYwNmY3MDkzZGJlOWNlYjYwOTEuLjFhMzY2YmM4 Yzg0MzE3ZDExZmNmZDAzZTMxNzVhNzI2YTliODc5OTcgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAKKysrIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9D aHJvbWVDbGllbnRJbXBsLmNwcApAQCAtNjYsNiArNjYsNyBAQAogI2luY2x1ZGUgIldlYkZyYW1l SW1wbC5oIgogI2luY2x1ZGUgIldlYklucHV0RXZlbnQuaCIKICNpbmNsdWRlICJXZWJLaXQuaCIK KyNpbmNsdWRlICJXZWJOb2RlLmgiCiAjaW5jbHVkZSAiV2ViUG9wdXBNZW51SW1wbC5oIgogI2lu Y2x1ZGUgIldlYlBvcHVwTWVudUluZm8uaCIKICNpbmNsdWRlICJXZWJQb3B1cFR5cGUuaCIKQEAg LTIxNCw2ICsyMTUsOCBAQCB2b2lkIENocm9tZUNsaWVudEltcGw6OnRha2VGb2N1cyhGb2N1c0Rp cmVjdGlvbiBkaXJlY3Rpb24pCiAKIHZvaWQgQ2hyb21lQ2xpZW50SW1wbDo6Zm9jdXNlZE5vZGVD aGFuZ2VkKE5vZGUqIG5vZGUpCiB7CisgICAgbV93ZWJWaWV3LT5jbGllbnQoKS0+Zm9jdXNlZE5v ZGVDaGFuZ2VkKFdlYk5vZGUobm9kZSkpOworCiAgICAgV2ViVVJMIGZvY3VzX3VybDsKICAgICBp ZiAobm9kZSAmJiBub2RlLT5pc0xpbmsoKSkgewogICAgICAgICAvLyBUaGlzIEhpdFRlc3RSZXN1 bHQgaGFjayBpcyB0aGUgZWFzaWVzdCB3YXkgdG8gZ2V0IGEgbGluayBVUkwgb3V0IG9mIGEK