38504 2010-05-03 19:51:35 -0700 new-run-webkit-tests: --verbose is not printing everything 2010-05-04 13:09:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke cjerdonek eric ojan oldest_to_newest 220427 0 dpranke 2010-05-03 19:51:35 -0700 new-run-webkit-tests: --verbose is not printing everything 220428 1 54985 dpranke 2010-05-03 19:52:45 -0700 Created attachment 54985 Patch 220429 2 dpranke 2010-05-03 19:53:42 -0700 Committed r58731: <http://trac.webkit.org/changeset/58731> 220434 3 54985 eric 2010-05-03 20:20:08 -0700 Comment on attachment 54985 Patch I see you've already landed... but this really should have a unit test to confirm that self.switches is set to the same thing as --print everything would. 220435 4 dpranke 2010-05-03 20:27:46 -0700 Yeah, I sort of wanted to get feedback on this bug on what the right fix should be before I wrote unit tests for it. Should --print override --verbose (which is what this patch does), or vice versa? Admittedly, landing before figuring this out is a bad thing, but the bots were already borked, so I figured it was a lesser of two evils thing (and I didn't want to back out the offending change). 220436 5 eric 2010-05-03 20:30:32 -0700 I think --print should probably override --verbose. Otherwise you can't add verbosity. Then again, --verbose could just imply --print=verbose which was the set of settings enabled by default for verbose. :) 220639 6 ojan 2010-05-04 10:16:19 -0700 I don't see why we should worry about overriding. Lets just throw an error if you try to specify both. 220727 7 dpranke 2010-05-04 13:09:08 -0700 (In reply to comment #6) > I don't see why we should worry about overriding. Lets just throw an error if > you try to specify both. The only real advantage I could see to allowing both would be if you wanted the equivalent of --print everything,trace-everything (i.e., verbose + tracing) 54985 2010-05-03 19:52:45 -0700 2010-05-03 20:20:08 -0700 Patch bug-38504-20100503195244.patch text/plain 3708 dpranke ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA5MGNhYmE2NjdiOWM4MDIyOGMzMzEyMmFlNmVkNDc1MDU3NTI0OGJiLi42MTBiNGZk MjIwNTNjOWExYzBlZmQ1YTFhZDM5M2U5OGFiM2ZhNDU2IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMjIgQEAK IAogICAgICAgICBVbnJldmlld2VkLCBidWlsZCBmaXguCiAKKyAgICAgICAgbmV3LXJ1bi13ZWJr aXQtdGVzdHM6IHI1ODcyOCBicm9rZSB0aGUgYnVpbGRib3QgbG9naWMgZm9yIHBhcnNpbmcgdGhl CisgICAgICAgIG91dHB1dCBvZiB0aGUgbG9nOyBzcGVjaWZ5aW5nIC0tdmVyYm9zZSBzaG91bGQg YmFzaWNhbGx5IGJlIGVxdWl2YWxlbnQKKyAgICAgICAgdG8gLS1wcmludCBldmVyeXRoaW5nLCBi dXQgaW5zdGVhZCBpdCB3YXMgZXF1aXZhbGVudCB0byBub3Qgc3BlY2lmeWluZworICAgICAgICAt LXByaW50IGFuZCBnZXR0aW5nIHRoZSBkZWZhdWx0IHNldC4gTm93LCAtLXZlcmJvc2UgYWN0cyBh cyBpZgorICAgICAgICAtLXByaW50IGV2ZXJ5dGhpbmcgd2FzIGltcGxpY2l0bHkgc3BlY2lmaWVk IGFzIHRoZSBkZWZhdWx0ICh5b3UgY2FuCisgICAgICAgIHN0aWxsIG92ZXJyaWRlIGl0IGlmIHlv dSBzcGVjaWZ5IGJvdGg7IHRoaXMgaXMgYSBzb21ld2hhdCBkZWJhdGFibGUKKyAgICAgICAgY2Fs bCkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4 NTA0CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFj a2FnZS9wcmludGluZy5weToKKworMjAxMC0wNS0wMyAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNo cm9taXVtLm9yZz4KKworICAgICAgICBVbnJldmlld2VkLCBidWlsZCBmaXguCisKICAgICAgICAg bmV3LXJ1bi13ZWJraXQtdGVzdHM6IEZpeCBtaW5vciBwcmVjZWRlbmNlIGJ1ZyBpbnRyb2R1Y2Vk IGluIHI1ODcyOCB3aGVyZSB3ZSBwcmludGVkCiAgICAgICAgICItXG4iIDc4IHRpbWVzIGluc3Rl YWQgb2YgIi0iIDc4IHRpbWVzIGZvbGxvd2VkIGJ5IGEgc2luZ2xlICJcbiIuCiAKZGlmZiAtLWdp dCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNr YWdlL3ByaW50aW5nLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvbGF5b3V0X3BhY2thZ2UvcHJpbnRpbmcucHkKaW5kZXggOTY0M2E5MGJlZGVjNTk4NDhkYzhl MGQ4MzhhYzc0MjFjYTEyNTg1OS4uZTM5ZDQxMDg3MDc3ZmRlYThlMjlkYWMyZDY4MTBkMjBlM2Fl OWIzMyAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvbGF5b3V0X3BhY2thZ2UvcHJpbnRpbmcucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2UvcHJpbnRpbmcucHkKQEAgLTk0LDYg Kzk0LDEwIEBAIE5vdGVzOgogICAgIC0gSWYgYm90aCAnZGV0YWlsZWQtcHJvZ3Jlc3MnIGFuZCAn b25lLWxpbmUtcHJvZ3Jlc3MnIGFyZSBzcGVjaWZpZWQgKGFuZAogICAgICAgYm90aCBhcmUgcG9z c2libGUpLCAnZGV0YWlsZWQtcHJvZ3Jlc3MnIHdpbGwgYmUgdXNlZC4KICAgICAtIElmICdub3Ro aW5nJyBpcyBzcGVjaWZpZWQsIGl0IG92ZXJyaWRlcyBhbGwgb2YgdGhlIG90aGVyIG9wdGlvbnMu CisgICAgLSBTcGVjaWZ5aW5nIC0tdmVyYm9zZSBpcyBlcXVpdmFsZW50IHRvIC0tcHJpbnQgZXZl cnl0aGluZyBwbHVzIGl0CisgICAgICBjaGFuZ2VzIHRoZSBmb3JtYXQgb2YgdGhlIGxvZyBtZXNz YWdlcyB0byBhZGQgdGltZXN0YW1wcyBhbmQgb3RoZXIKKyAgICAgIGluZm9ybWF0aW9uLiBJZiB5 b3Ugc3BlY2lmeSAtLXZlcmJvc2UgYW5kIC0tcHJpbnQgWCwgdGhlbiBYIG92ZXJyaWRlcworICAg ICAgdGhlIC0tcHJpbnQgZXZlcnl0aGluZyBpbXBsaWVkIGJ5IC0tdmVyYm9zZS4KIAogLS1wcmlu dCAnZXZlcnl0aGluZycgaXMgZXF1aXZhbGVudCB0byAtLXByaW50ICclKGV2ZXJ5dGhpbmcpcycu CiAKQEAgLTEwNyw3ICsxMTEsNiBAQCBkZWYgcHJpbnRfb3B0aW9ucygpOgogICAgICAgICAjIE5v dGU6IHdlIHVzZSBwcmludF9vcHRpb25zIHJhdGhlciB0aGFuIGp1c3QgJ3ByaW50JyBiZWNhdXNl IHByaW50CiAgICAgICAgICMgaXMgYSByZXNlcnZlZCB3b3JkLgogICAgICAgICBvcHRwYXJzZS5t YWtlX29wdGlvbigiLS1wcmludCIsIGRlc3Q9InByaW50X29wdGlvbnMiLAotICAgICAgICAgICAg ZGVmYXVsdD1QUklOVF9ERUZBVUxULAogICAgICAgICAgICAgaGVscD0oImNvbnRyb2xzIHByaW50 IG91dHB1dCBvZiB0ZXN0IHJ1bi4gIgogICAgICAgICAgICAgICAgICAgIlVzZSAtLWhlbHAtcHJp bnRpbmcgZm9yIG1vcmUuIikpLAogICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLS1oZWxw LXByaW50aW5nIiwgYWN0aW9uPSJzdG9yZV90cnVlIiwKQEAgLTEzNywxNCArMTQwLDIwIEBAIGRl ZiBjb25maWd1cmVfbG9nZ2luZyhvcHRpb25zLCBtZXRlcik6CiAgICAgICAgICAgICAgICAgICAg ICAgICBkYXRlZm10PWxvZ19kYXRlZm10LCBzdHJlYW09bWV0ZXIpCiAKIAotZGVmIHBhcnNlX3By aW50X29wdGlvbnMocHJpbnRfb3B0aW9ucywgY2hpbGRfcHJvY2Vzc2VzLCBpc19mdWxseV9wYXJh bGxlbCk6CitkZWYgcGFyc2VfcHJpbnRfb3B0aW9ucyhwcmludF9vcHRpb25zLCB2ZXJib3NlLCBj aGlsZF9wcm9jZXNzZXMsCisgICAgICAgICAgICAgICAgICAgICAgICBpc19mdWxseV9wYXJhbGxl bCk6CiAgICAgIiIiUGFyc2UgdGhlIG9wdGlvbnMgcHJvdmlkZWQgdG8gLS1wcmludCBhbmQgZGVk dXAgYW5kIHJhbmsgdGhlbS4KIAogICAgIFJldHVybnMKICAgICAgICAgYSBzZXQoKSBvZiBzd2l0 Y2hlcyB0aGF0IGdvdmVybiBob3cgbG9nZ2luZyBpcyBkb25lCiAKICAgICAiIiIKLSAgICBzd2l0 Y2hlcyA9IHNldChwcmludF9vcHRpb25zLnNwbGl0KCcsJykpCisgICAgaWYgcHJpbnRfb3B0aW9u czoKKyAgICAgICAgc3dpdGNoZXMgPSBzZXQocHJpbnRfb3B0aW9ucy5zcGxpdCgnLCcpKQorICAg IGVsaWYgdmVyYm9zZToKKyAgICAgICAgc3dpdGNoZXMgPSBzZXQoUFJJTlRfRVZFUllUSElORy5z cGxpdCgnLCcpKQorICAgIGVsc2U6CisgICAgICAgIHN3aXRjaGVzID0gc2V0KFBSSU5UX0RFRkFV TFQuc3BsaXQoJywnKSkKIAogICAgIGlmICdub3RoaW5nJyBpbiBzd2l0Y2hlczoKICAgICAgICAg cmV0dXJuIHNldCgpCkBAIC0yMjcsNyArMjM2LDcgQEAgY2xhc3MgUHJpbnRlcihvYmplY3QpOgog ICAgICAgICBjb25maWd1cmVfbG9nZ2luZyhzZWxmLl9vcHRpb25zLCBzZWxmLl9tZXRlcikKIAog ICAgICAgICBzZWxmLnN3aXRjaGVzID0gcGFyc2VfcHJpbnRfb3B0aW9ucyhvcHRpb25zLnByaW50 X29wdGlvbnMsCi0gICAgICAgICAgICBjaGlsZF9wcm9jZXNzZXMsIGlzX2Z1bGx5X3BhcmFsbGVs KQorICAgICAgICAgICAgb3B0aW9ucy52ZXJib3NlLCBjaGlsZF9wcm9jZXNzZXMsIGlzX2Z1bGx5 X3BhcmFsbGVsKQogCiAgICAgIyBUaGVzZSB0d28gcm91dGluZXMganVzdCBoaWRlIHRoZSBpbXBs bWVudGF0aW9uIG9mIHRoZSBzd2l0Y2hlcy4KICAgICBkZWYgZGlzYWJsZWQoc2VsZiwgb3B0aW9u KToK