38500 2010-05-03 17:45:58 -0700 [chromium] use glyphDataForCharacter so we hit the glyphdata cache 2010-05-08 23:18:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 evan evan agl ap eric mitz oldest_to_newest 220393 0 evan 2010-05-03 17:45:58 -0700 [chromium] use glyphDataForCharacter so we hit the glyphdata cache 220397 1 54980 evan 2010-05-03 17:58:44 -0700 Created attachment 54980 Patch 220406 2 evan 2010-05-03 18:16:05 -0700 Before/after numbers: [ OK ] PageCyclerReferenceTest.Intl2File (86605 ms) [ OK ] PageCyclerTest.Intl2File (51034 ms) 41% performance improvement. 220589 3 agl 2010-05-04 08:01:58 -0700 What about the m_iterateBackwards case? Isn't the same thing needed there? 220616 4 evan 2010-05-04 08:42:18 -0700 Yes, and this is also incorrect for surrogate pairs. I intend (after getting the bold Bengali patch through, sigh) to revisit this. Either I'll make it solely in terms of iterating through characters (what my new for loop adds) or we'll have Harfbuzz-ng in a state where the iteration will likely be different in some other way. 220620 5 agl 2010-05-04 08:49:02 -0700 ok, LGTM then. 220958 6 54980 fishd 2010-05-04 22:02:12 -0700 Comment on attachment 54980 Patch WebCore/ChangeLog:18 + Tests: fast/text/international/danda-space.html spacing changes slightly did you intend to include new baselines? 220972 7 evan 2010-05-04 23:25:30 -0700 There were minor antialiasing differences that I was hoping were due to 64-bit/32-bit issues, so my plan was to pull them off the buildbot. 221492 8 54980 eric 2010-05-05 22:04:51 -0700 Comment on attachment 54980 Patch OK. 221493 9 eric 2010-05-05 22:05:25 -0700 CCing international text gurus mitz and ap just in case they're care to see this pass by. 222970 10 eric 2010-05-08 23:15:39 -0700 Attachment 54980 was posted by a committer and has review+, assigning to Evan Martin for commit. 222982 11 evan 2010-05-08 23:18:59 -0700 Committed this before, but webkit-patch glitched. 54980 2010-05-03 17:58:44 -0700 2010-05-05 22:04:51 -0700 Patch bug-38500-20100503175804.patch text/plain 3938 evan ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjczZWU0NTNjYTYxMDdmMWE1MDhkOTdhYjA0NjFmN2MzZDhlMTJjZC4uZTVmZGY5ZWVhMjFjZWQx YzI5MDczODU0ZmQ2Y2Y4MzhhMGFmMGU4NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyOCBAQAorMjAxMC0wNS0wMyAgRXZh biBNYXJ0aW4gIDxldmFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIHVzZSBnbHlwaERhdGFGb3JDaGFyYWN0 ZXIgc28gd2UgaGl0IHRoZSBnbHlwaGRhdGEgY2FjaGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4NTAwCisKKyAgICAgICAgQ2FsbGluZyBmb250RGF0 YUZvckNoYXJhY3RlcnMoKSB3aGlsZSByZW5kZXJpbmcgdGV4dCBpcyBleHBlbnNpdmUuCisgICAg ICAgIEV4YW1pbmluZyB0aGUgcmVsZXZhbnQgTWFjIGNvZGUgaW4gV2ViS2l0IHJldmVhbGVkIHRo YXQgY2FsbGluZyB0aGUKKyAgICAgICAgc2ltaWxhcmx5LW5hbWVkIGdseXBoRGF0YUZvckNoYXJh Y3RlcnMoKSByZXN1bHRzIGluIGNhY2hpbmcgdGhlIGZvbnQKKyAgICAgICAgZGF0YSBvbiBhIHBl ci1nbHlwaCBiYXNpcy4KKworICAgICAgICBTaW5jZSB3ZSBub3cgY2hvb3NlIGEgZm9udCBiYXNl ZCBvbiB0aGUgZmlyc3QgY2hhcmFjdGVyIGluIGEgcnVuLCB3ZQorICAgICAgICBuZWVkIHRvIGJl IGNhcmVmdWwgdGhhdCBhbGwgdGhlIGdseXBocyB3aXRoaW4gdGhlIHJ1biB1c2UgdGhlIHNhbWUg Zm9udC4KKyAgICAgICAgVGhpcyBpcyBhbHNvIHNpbWlsYXIgdG8gdGhlIFdlYktpdCBNYWMgY29k ZS4gIFdlIG5lZWQgdG8gcmVtb3ZlIGFsbCBvZgorICAgICAgICB0aGUgc2NyaXB0IHJ1biBiaXRz IGV2ZW50dWFsbHkgYW5kIHRoaXMgaXMgYSBzdGVwIGluIHRoYXQgZGlyZWN0aW9uLgorCisgICAg ICAgIFRlc3RzOiBmYXN0L3RleHQvaW50ZXJuYXRpb25hbC9kYW5kYS1zcGFjZS5odG1sIHNwYWNp bmcgY2hhbmdlcyBzbGlnaHRseQorICAgICAgICAobm93IG1hdGNoZXMgRmlyZWZveCBiZXR0ZXIp IGFuZCBmYXN0L3RleHQvaW50ZXJuYXRpb25hbC90aGFpLWJhaHQtc3BhY2UuaHRtbAorICAgICAg ICBub3cgcGlja3MgdGhlIGNvcnJlY3QgKHNlcmlmKSBmb250IGZvciB0aGUgZGlnaXRzLgorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udExpbnV4LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlRleHRSdW5XYWxrZXI6Om5leHRTY3JpcHRSdW4pOgorICAgICAgICAoV2Vi Q29yZTo6VGV4dFJ1bldhbGtlcjo6c2V0dXBGb250Rm9yU2NyaXB0UnVuKToKKwogMjAxMC0wNS0w MyAgSmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jaHJvbWl1bS9Gb250TGludXguY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJv bWl1bS9Gb250TGludXguY3BwCmluZGV4IGZhNTQ5Y2QwOWE1OWExMDE3MGMxYTZlMWJmYTc5Mzg4 MGUwMTQxN2YuLjRiNDAyYTNiNDhmMTQ0ZWI4ZTkwYmQzNDFiYTZkMzFiMzAwZWE0Y2MgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udExpbnV4LmNwcAor KysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRMaW51eC5jcHAKQEAg LTIzOCw2ICsyMzgsMjMgQEAgcHVibGljOgogICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAg aWYgKCFoYl91dGYxNl9zY3JpcHRfcnVuX25leHQoJm1fbnVtQ29kZVBvaW50cywgJm1faXRlbS5p dGVtLCBtX3J1bi5jaGFyYWN0ZXJzKCksIG1fcnVuLmxlbmd0aCgpLCAmbV9pbmRleE9mTmV4dFNj cmlwdFJ1bikpCiAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgICAgICAgICAv LyBJdCBpcyBhY3R1YWxseSB3cm9uZyB0byBjb25zaWRlciBzY3JpcHQgcnVucyBhdCBhbGwgaW4g dGhpcyBjb2RlLgorICAgICAgICAgICAgLy8gT3RoZXIgV2ViS2l0IGNvZGUgKGUuZy4gTWFjKSBz ZWdtZW50cyBjb21wbGV4IHRleHQganVzdCBieSBmaW5kaW5nCisgICAgICAgICAgICAvLyB0aGUg bG9uZ2VzdCBzcGFuIG9mIHRleHQgY292ZXJlZCBieSBhIHNpbmdsZSBmb250LgorICAgICAgICAg ICAgLy8gQnV0IHdlIGN1cnJlbnRseSBuZWVkIHRvIGNhbGwgaGJfdXRmMTZfc2NyaXB0X3J1bl9u ZXh0IGFueXdheSB0byBmaWxsCisgICAgICAgICAgICAvLyBpbiB0aGUgaGFyZmJ1enogZGF0YSBz dHJ1Y3R1cmVzIHRvIGUuZy4gcGljayB0aGUgY29ycmVjdCBzY3JpcHQncyBzaGFwZXIuCisgICAg ICAgICAgICAvLyBTbyB3ZSBhbGxvdyB0aGF0IHRvIHJ1biBmaXJzdCwgdGhlbiBkbyBhIHNlY29u ZCBwYXNzIG92ZXIgdGhlIHJhbmdlIGl0CisgICAgICAgICAgICAvLyBmb3VuZCBhbmQgdGFrZSB0 aGUgbGFyZ2VzdCBzdWJyZWdpb24gdGhhdCBzdGF5cyB3aXRoaW4gYSBzaW5nbGUgZm9udC4KKyAg ICAgICAgICAgIGNvbnN0IEZvbnREYXRhKiBnbHlwaERhdGEgPSBtX2ZvbnQtPmdseXBoRGF0YUZv ckNoYXJhY3RlcihtX2l0ZW0uc3RyaW5nW21faXRlbS5pdGVtLnBvc10sIGZhbHNlLCBmYWxzZSku Zm9udERhdGE7CisgICAgICAgICAgICBpbnQgZW5kT2ZSdW47CisgICAgICAgICAgICBmb3IgKGVu ZE9mUnVuID0gMTsgZW5kT2ZSdW4gPCBtX2l0ZW0uaXRlbS5sZW5ndGg7ICsrZW5kT2ZSdW4pIHsK KyAgICAgICAgICAgICAgICBjb25zdCBGb250RGF0YSogbmV4dEdseXBoRGF0YSA9IG1fZm9udC0+ Z2x5cGhEYXRhRm9yQ2hhcmFjdGVyKG1faXRlbS5zdHJpbmdbbV9pdGVtLml0ZW0ucG9zICsgZW5k T2ZSdW5dLCBmYWxzZSwgZmFsc2UpLmZvbnREYXRhOworICAgICAgICAgICAgICAgIGlmIChuZXh0 R2x5cGhEYXRhICE9IGdseXBoRGF0YSkKKyAgICAgICAgICAgICAgICAgICAgYnJlYWs7CisgICAg ICAgICAgICB9CisgICAgICAgICAgICBtX2l0ZW0uaXRlbS5sZW5ndGggPSBlbmRPZlJ1bjsKKyAg ICAgICAgICAgIG1faW5kZXhPZk5leHRTY3JpcHRSdW4gPSBtX2l0ZW0uaXRlbS5wb3MgKyBlbmRP ZlJ1bjsKICAgICAgICAgfQogCiAgICAgICAgIHNldHVwRm9udEZvclNjcmlwdFJ1bigpOwpAQCAt MzU4LDkgKzM3NSw3IEBAIHByaXZhdGU6CiAKICAgICB2b2lkIHNldHVwRm9udEZvclNjcmlwdFJ1 bigpCiAgICAgewotICAgICAgICBjb25zdCBGb250RGF0YSogZm9udERhdGEgPSBtX2ZvbnQtPmZv bnREYXRhQXQoMCk7Ci0gICAgICAgIGlmICghZm9udERhdGEtPmNvbnRhaW5zQ2hhcmFjdGVycyht X2l0ZW0uc3RyaW5nICsgbV9pdGVtLml0ZW0ucG9zLCBtX2l0ZW0uaXRlbS5sZW5ndGgpKQotICAg ICAgICAgICAgZm9udERhdGEgPSBtX2ZvbnQtPmZvbnREYXRhRm9yQ2hhcmFjdGVycyhtX2l0ZW0u c3RyaW5nICsgbV9pdGVtLml0ZW0ucG9zLCBtX2l0ZW0uaXRlbS5sZW5ndGgpOworICAgICAgICBj b25zdCBGb250RGF0YSogZm9udERhdGEgPSBtX2ZvbnQtPmdseXBoRGF0YUZvckNoYXJhY3Rlciht X2l0ZW0uc3RyaW5nW21faXRlbS5pdGVtLnBvc10sIGZhbHNlLCBmYWxzZSkuZm9udERhdGE7CiAg ICAgICAgIGNvbnN0IEZvbnRQbGF0Zm9ybURhdGEmIHBsYXRmb3JtRGF0YSA9IGZvbnREYXRhLT5m b250RGF0YUZvckNoYXJhY3RlcignICcpLT5wbGF0Zm9ybURhdGEoKTsKICAgICAgICAgbV9pdGVt LmZhY2UgPSBwbGF0Zm9ybURhdGEuaGFyZmJ1enpGYWNlKCk7CiAgICAgICAgIHZvaWQqIG9wYXF1 ZVBsYXRmb3JtRGF0YSA9IGNvbnN0X2Nhc3Q8Rm9udFBsYXRmb3JtRGF0YSo+KCZwbGF0Zm9ybURh dGEpOwo=