38496 2010-05-03 16:50:05 -0700 [WebKit2] WKView should respond to WM_SHOWWINDOW messages 2010-05-03 17:16:24 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca webkit-unassigned oldest_to_newest 220365 0 andersca 2010-05-03 16:50:05 -0700 [WebKit2] WKView should respond to WM_SHOWWINDOW messages 220370 1 54975 andersca 2010-05-03 16:55:46 -0700 Created attachment 54975 Patch 220379 2 54975 jhoneycutt 2010-05-03 17:11:27 -0700 Comment on attachment 54975 Patch > Index: WebKit2/ChangeLog > =================================================================== > --- WebKit2/ChangeLog (revision 58716) > +++ WebKit2/ChangeLog (working copy) > @@ -1,3 +1,19 @@ > +2010-05-03 Anders Carlsson <andersca@apple.com> > + > + Reviewed by NOBODY (OOPS!). > + > + [WebKit2] WKView should respond to WM_SHOWWINDOW messages > + https://bugs.webkit.org/show_bug.cgi?id=38496 > + > + * UIProcess/win/WebView.cpp: > + (WebKit::WebView::wndProc): > + Add case for WM_SHOWWINDOW. > + > + (WebKit::WebView::onShowWindowEvent): > + Update the page visibility.accordingly. Typo. > > +LRESULT WebView::onShowWindowEvent(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam, bool& handled) > +{ > + // lParam is 0 when the message is sent because of a ShowWindow call. > + if (!lParam) { > + bool isVisible = wParam; > + > + // Notify the drawing area that the visibility changed. > + m_page->drawingArea()->setPageIsVisible(isVisible); What happens if you call ShowWindow on a WKView that is the child of a hidden window? Does it still receive WM_SHOWWINDOW? Do you want to set "page is visible" in that case? r=me 220380 3 andersca 2010-05-03 17:16:24 -0700 Committed r58720: <http://trac.webkit.org/changeset/58720> 54975 2010-05-03 16:55:46 -0700 2010-05-03 17:11:27 -0700 Patch bug-38496-20100503165546.patch text/plain 3322 andersca SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA1ODcxNikKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDUtMDMgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbV2ViS2l0Ml0gV0tWaWV3IHNob3VsZCByZXNwb25kIHRvIFdNX1NIT1dXSU5ET1cgbWVzc2Fn ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4NDk2 CisKKyAgICAgICAgKiBVSVByb2Nlc3Mvd2luL1dlYlZpZXcuY3BwOgorICAgICAgICAoV2ViS2l0 OjpXZWJWaWV3Ojp3bmRQcm9jKToKKyAgICAgICAgQWRkIGNhc2UgZm9yIFdNX1NIT1dXSU5ET1cu CisKKyAgICAgICAgKFdlYktpdDo6V2ViVmlldzo6b25TaG93V2luZG93RXZlbnQpOgorICAgICAg ICBVcGRhdGUgdGhlIHBhZ2UgdmlzaWJpbGl0eS5hY2NvcmRpbmdseS4KKworICAgICAgICAqIFVJ UHJvY2Vzcy93aW4vV2ViVmlldy5oOgorCiAyMDEwLTA1LTAzICBBbmRlcnMgQ2FybHNzb24gIDxh bmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4K SW5kZXg6IFdlYktpdDIvVUlQcm9jZXNzL3dpbi9XZWJWaWV3LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJLaXQyL1VJUHJvY2Vzcy93aW4vV2ViVmlldy5jcHAJKHJldmlzaW9uIDU4NzE0KQorKysgV2Vi S2l0Mi9VSVByb2Nlc3Mvd2luL1dlYlZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjIsNiAr MTIyLDkgQEAgTFJFU1VMVCBXZWJWaWV3Ojp3bmRQcm9jKEhXTkQgaFduZCwgVUlOVAogICAgICAg ICBjYXNlIFdNX1RJTUVSOgogICAgICAgICAgICAgbFJlc3VsdCA9IG9uVGltZXJFdmVudChoV25k LCBtZXNzYWdlLCB3UGFyYW0sIGxQYXJhbSwgaGFuZGxlZCk7CiAgICAgICAgICAgICBicmVhazsK KyAgICAgICAgY2FzZSBXTV9TSE9XV0lORE9XOgorICAgICAgICAgICAgbFJlc3VsdCA9IG9uU2hv d1dpbmRvd0V2ZW50KGhXbmQsIG1lc3NhZ2UsIHdQYXJhbSwgbFBhcmFtLCBoYW5kbGVkKTsKKyAg ICAgICAgICAgIGJyZWFrOwogICAgICAgICBkZWZhdWx0OgogICAgICAgICAgICAgaGFuZGxlZCA9 IGZhbHNlOwogICAgICAgICAgICAgYnJlYWs7CkBAIC0zNjIsNiArMzY1LDIxIEBAIExSRVNVTFQg V2ViVmlldzo6b25UaW1lckV2ZW50KEhXTkQgaFduZCwKICAgICByZXR1cm4gMDsKIH0KIAorTFJF U1VMVCBXZWJWaWV3OjpvblNob3dXaW5kb3dFdmVudChIV05EIGhXbmQsIFVJTlQgbWVzc2FnZSwg V1BBUkFNIHdQYXJhbSwgTFBBUkFNIGxQYXJhbSwgYm9vbCYgaGFuZGxlZCkKK3sKKyAgICAvLyBs UGFyYW0gaXMgMCB3aGVuIHRoZSBtZXNzYWdlIGlzIHNlbnQgYmVjYXVzZSBvZiBhIFNob3dXaW5k b3cgY2FsbC4KKyAgICBpZiAoIWxQYXJhbSkgeworICAgICAgICBib29sIGlzVmlzaWJsZSA9IHdQ YXJhbTsKKworICAgICAgICAvLyBOb3RpZnkgdGhlIGRyYXdpbmcgYXJlYSB0aGF0IHRoZSB2aXNp YmlsaXR5IGNoYW5nZWQuCisgICAgICAgIG1fcGFnZS0+ZHJhd2luZ0FyZWEoKS0+c2V0UGFnZUlz VmlzaWJsZShpc1Zpc2libGUpOworCisgICAgICAgIGhhbmRsZWQgPSB0cnVlOworICAgIH0KKwor ICAgIHJldHVybiAwOworfQorCiBib29sIFdlYlZpZXc6OmlzQWN0aXZlKCkKIHsKICAgICBIV05E IGFjdGl2ZVdpbmRvdyA9IDo6R2V0QWN0aXZlV2luZG93KCk7CkBAIC00ODEsMTIgKzQ5OSw2IEBA IHZvaWQgV2ViVmlldzo6dG9vbFRpcENoYW5nZWQoY29uc3QgU3RyaW4KICAgICA6OlNlbmRNZXNz YWdlKG1fdG9vbFRpcFdpbmRvdywgVFRNX0FDVElWQVRFLCAhbmV3VG9vbFRpcC5pc0VtcHR5KCks IDApOwogfQogCi1ib29sIFdlYlZpZXc6OmlzUGFnZVZpc2libGUoKQotewotICAgIC8vIEZJWE1F OiBXZSBzaG91bGQgcHJvYmFibHkgY2hlY2sgaWYgdGhlIHdpbmRvdyBoYXMgYSBwYXJlbnQvYW5j ZXN0b3IgdG9vLgotICAgIHJldHVybiA6OklzV2luZG93VmlzaWJsZShtX3dpbmRvdyk7Ci19Ci0K IC8vIFdlYkNvcmU6OldpbmRvd01lc3NhZ2VMaXN0ZW5lcgogCiB2b2lkIFdlYlZpZXc6OndpbmRv d1JlY2VpdmVkTWVzc2FnZShIV05ELCBVSU5UIG1lc3NhZ2UsIFdQQVJBTSB3UGFyYW0sIExQQVJB TSkKSW5kZXg6IFdlYktpdDIvVUlQcm9jZXNzL3dpbi9XZWJWaWV3LmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViS2l0Mi9VSVByb2Nlc3Mvd2luL1dlYlZpZXcuaAkocmV2aXNpb24gNTg3MTQpCisrKyBXZWJL aXQyL1VJUHJvY2Vzcy93aW4vV2ViVmlldy5oCSh3b3JraW5nIGNvcHkpCkBAIC03Nyw2ICs3Nyw3 IEBAIHByaXZhdGU6CiAgICAgTFJFU1VMVCBvblNldEZvY3VzRXZlbnQoSFdORCBoV25kLCBVSU5U IG1lc3NhZ2UsIFdQQVJBTSwgTFBBUkFNLCBib29sJiBoYW5kbGVkKTsKICAgICBMUkVTVUxUIG9u S2lsbEZvY3VzRXZlbnQoSFdORCBoV25kLCBVSU5UIG1lc3NhZ2UsIFdQQVJBTSwgTFBBUkFNLCBi b29sJiBoYW5kbGVkKTsKICAgICBMUkVTVUxUIG9uVGltZXJFdmVudChIV05EIGhXbmQsIFVJTlQg bWVzc2FnZSwgV1BBUkFNLCBMUEFSQU0sIGJvb2wmIGhhbmRsZWQpOworICAgIExSRVNVTFQgb25T aG93V2luZG93RXZlbnQoSFdORCBoV25kLCBVSU5UIG1lc3NhZ2UsIFdQQVJBTSwgTFBBUkFNLCBi b29sJiBoYW5kbGVkKTsKIAogICAgIGJvb2wgaXNBY3RpdmUoKTsKICAgICB2b2lkIHVwZGF0ZUFj dGl2ZVN0YXRlKCk7CkBAIC05Miw3ICs5Myw2IEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCB2b2lk IHByb2Nlc3NEaWRSZXZpdmUoKTsKICAgICB2aXJ0dWFsIHZvaWQgdGFrZUZvY3VzKGJvb2wgZGly ZWN0aW9uKTsKICAgICB2aXJ0dWFsIHZvaWQgdG9vbFRpcENoYW5nZWQoY29uc3QgV2ViQ29yZTo6 U3RyaW5nJiwgY29uc3QgV2ViQ29yZTo6U3RyaW5nJik7Ci0gICAgdmlydHVhbCBib29sIGlzUGFn ZVZpc2libGUoKTsKIAogICAgIC8vIFdlYkNvcmU6OldpbmRvd01lc3NhZ2VMaXN0ZW5lcgogICAg IHZpcnR1YWwgdm9pZCB3aW5kb3dSZWNlaXZlZE1lc3NhZ2UoSFdORCwgVUlOVCBtZXNzYWdlLCBX UEFSQU0sIExQQVJBTSk7Cg==