38493 2010-05-03 15:19:09 -0700 Get rid of PageClient::isPageVisible and pass visibility directly in setPageIsVisible 2010-05-03 16:09:56 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca webkit-unassigned oldest_to_newest 220323 0 andersca 2010-05-03 15:19:09 -0700 Get rid of PageClient::isPageVisible and pass visibility directly in didChangeVisibility 220327 1 54967 andersca 2010-05-03 15:27:19 -0700 Created attachment 54967 Patch 220342 2 54967 mitz 2010-05-03 15:54:43 -0700 Comment on attachment 54967 Patch r=me only if you rename didChangeVisibility() to setPageIsVisible(). Perhaps m_isVisible should be renamed too. 220348 3 andersca 2010-05-03 16:09:56 -0700 Committed r58714: <http://trac.webkit.org/changeset/58714> 54967 2010-05-03 15:27:19 -0700 2010-05-03 15:54:43 -0700 Patch bug-38493-20100503152717.patch text/plain 7348 andersca SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA1ODcwNSkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsNDIgQEAKKzIwMTAtMDUtMDMgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBHZXQgcmlkIG9mIFBhZ2VDbGllbnQ6OmlzUGFnZVZpc2libGUgYW5kIHBhc3MgdmlzaWJpbGl0 eSBkaXJlY3RseSBpbiBkaWRDaGFuZ2VWaXNpYmlsaXR5CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODQ5MworCisgICAgICAgICogVUlQcm9jZXNzL0FQ SS9tYWMvUGFnZUNsaWVudEltcGwuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9QYWdl Q2xpZW50SW1wbC5tbToKKyAgICAgICAgUmVtb3ZlIGlzUGFnZVZpc2libGUuCisgICAgICAgIAor ICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbToKKyAgICAgICAgKGlzVmlld1Zp c2libGUpOgorICAgICAgICBOZXcgZnVuY3Rpb24gKG1vdmVkIGhlcmUgZnJvbSBQYWdlQ2xpZW50 SW1wbCkuCisgICAgICAgIAorICAgICAgICAoLVtXS1ZpZXcgX3VwZGF0ZVZpc2liaWxpdHldKToK KyAgICAgICAgQ2FsbCBkaWRDaGFuZ2VWaXNpYmlsaXR5LgorICAgICAgICAKKyAgICAgICAgKC1b V0tWaWV3IHZpZXdEaWRNb3ZlVG9XaW5kb3ddKToKKyAgICAgICAgKC1bV0tWaWV3IHZpZXdEaWRI aWRlXSk6CisgICAgICAgICgtW1dLVmlldyB2aWV3RGlkVW5oaWRlXSk6CisgICAgICAgIENhbGwg X3VwZGF0ZVZpc2liaWxpdHkuCisgICAgICAgIAorICAgICAgICAqIFVJUHJvY2Vzcy9EcmF3aW5n QXJlYVByb3h5Lmg6CisgICAgICAgIEFkZCBhbiBpc1Zpc2libGUgcGFyYW1ldGVyIHRvIGRpZENo YW5nZVZpc2liaWxpdHkuCisgICAgICAgIAorICAgICAgICAqIFVJUHJvY2Vzcy9EcmF3aW5nQXJl YVByb3h5VXBkYXRlQ2h1bmsuY3BwOgorICAgICAgICAoV2ViS2l0OjpEcmF3aW5nQXJlYVByb3h5 VXBkYXRlQ2h1bms6OmRpZENoYW5nZVZpc2liaWxpdHkpOgorICAgICAgICBEb24ndCBjYWxsIFdl YlBhZ2VQcm94eTo6aXNWaXNpYmxlLgorCisgICAgICAgICogVUlQcm9jZXNzL0RyYXdpbmdBcmVh UHJveHlVcGRhdGVDaHVuay5oOgorICAgICAgICAKKyAgICAgICAgKiBVSVByb2Nlc3MvUGFnZUNs aWVudC5oOgorICAgICAgICBSZW1vdmUgaXNQYWdlVmlzaWJsZS4KKworICAgICAgICAqIFVJUHJv Y2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHku aDoKKyAgICAgICAgUmVtb3ZlIGlzVmlzaWJsZS4KKwogMjAxMC0wNS0wMyAgQW5kZXJzIENhcmxz c29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gUm9i ZW4uCkluZGV4OiBXZWJLaXQyL1VJUHJvY2Vzcy9EcmF3aW5nQXJlYVByb3h5LmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViS2l0Mi9VSVByb2Nlc3MvRHJhd2luZ0FyZWFQcm94eS5oCShyZXZpc2lvbiA1ODY5 MykKKysrIFdlYktpdDIvVUlQcm9jZXNzL0RyYXdpbmdBcmVhUHJveHkuaAkod29ya2luZyBjb3B5 KQpAQCAtNjIsNyArNjIsNyBAQCBwdWJsaWM6CiAKICAgICAvLyBDYWxsZWQgd2hlbmV2ZXIgdGhl IHZpZXcgdmlzaWJpbGl0eSBjaGFuZ2VzLCB0aGlzIGNhbiBoYXBwZW4gZm9yIGEgbnVtYmVyIG9m IHJlYXNvbnMsIHN1Y2ggYXMKICAgICAvLyB0aGUgdmlldyBiZWluZyBoaWRkZW4sIHRoZSB3aW5k b3cgbWluaW1pemVkLCBldGMuCi0gICAgdmlydHVhbCB2b2lkIGRpZENoYW5nZVZpc2liaWxpdHko KSA9IDA7CisgICAgdmlydHVhbCB2b2lkIGRpZENoYW5nZVZpc2liaWxpdHkoYm9vbCBpc1Zpc2li bGUpID0gMDsKICAgICAKICAgICAvLyBUaGUgRHJhd2luZ0FyZWFQcm94eSBzaG91bGQgbmV2ZXIg YmUgZGVjb2RlZCBpdHNlbGYuIEluc3RlYWQsIHRoZSBEcmF3aW5nQXJlYSBzaG91bGQgYmUgZGVj b2RlZC4KICAgICB2aXJ0dWFsIHZvaWQgZW5jb2RlKENvcmVJUEM6OkFyZ3VtZW50RW5jb2RlciYg ZW5jb2RlcikgY29uc3QKSW5kZXg6IFdlYktpdDIvVUlQcm9jZXNzL0RyYXdpbmdBcmVhUHJveHlV cGRhdGVDaHVuay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0Mi9VSVByb2Nlc3MvRHJhd2luZ0Fy ZWFQcm94eVVwZGF0ZUNodW5rLmNwcAkocmV2aXNpb24gNTg2OTMpCisrKyBXZWJLaXQyL1VJUHJv Y2Vzcy9EcmF3aW5nQXJlYVByb3h5VXBkYXRlQ2h1bmsuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04 NCwxMSArODQsMTAgQEAgdm9pZCBEcmF3aW5nQXJlYVByb3h5VXBkYXRlQ2h1bms6OnNldFNpegog ICAgIHBhZ2UtPnByb2Nlc3MoKS0+Y29ubmVjdGlvbigpLT5zZW5kKERyYXdpbmdBcmVhTWVzc2Fn ZTo6U2V0U2l6ZSwgcGFnZS0+cGFnZUlEKCksIENvcmVJUEM6OkluKHZpZXdTaXplKSk7CiB9CiAK LXZvaWQgRHJhd2luZ0FyZWFQcm94eVVwZGF0ZUNodW5rOjpkaWRDaGFuZ2VWaXNpYmlsaXR5KCkK K3ZvaWQgRHJhd2luZ0FyZWFQcm94eVVwZGF0ZUNodW5rOjpkaWRDaGFuZ2VWaXNpYmlsaXR5KGJv b2wgaXNWaXNpYmxlKQogewogICAgIFdlYlBhZ2VQcm94eSogcGFnZSA9IHRoaXMtPnBhZ2UoKTsK LSAgICBib29sIGlzVmlzaWJsZSA9IHBhZ2UtPmlzVmlzaWJsZSgpOwotICAgIAorCiAgICAgaWYg KGlzVmlzaWJsZSA9PSBtX2lzVmlzaWJsZSkKICAgICAgICAgcmV0dXJuOwogICAgIApJbmRleDog V2ViS2l0Mi9VSVByb2Nlc3MvRHJhd2luZ0FyZWFQcm94eVVwZGF0ZUNodW5rLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViS2l0Mi9VSVByb2Nlc3MvRHJhd2luZ0FyZWFQcm94eVVwZGF0ZUNodW5rLmgJKHJl dmlzaW9uIDU4NjkzKQorKysgV2ViS2l0Mi9VSVByb2Nlc3MvRHJhd2luZ0FyZWFQcm94eVVwZGF0 ZUNodW5rLmgJKHdvcmtpbmcgY29weSkKQEAgLTY4LDcgKzY4LDcgQEAgcHJpdmF0ZToKICAgICB2 aXJ0dWFsIHZvaWQgZGlkUmVjZWl2ZU1lc3NhZ2UoQ29yZUlQQzo6Q29ubmVjdGlvbiosIENvcmVJ UEM6Ok1lc3NhZ2VJRCwgQ29yZUlQQzo6QXJndW1lbnREZWNvZGVyJik7CiAgICAgdmlydHVhbCB2 b2lkIHBhaW50KGNvbnN0IFdlYkNvcmU6OkludFJlY3QmLCBQbGF0Zm9ybURyYXdpbmdDb250ZXh0 KTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0U2l6ZShjb25zdCBXZWJDb3JlOjpJbnRTaXplJik7Ci0g ICAgdmlydHVhbCB2b2lkIGRpZENoYW5nZVZpc2liaWxpdHkoKTsKKyAgICB2aXJ0dWFsIHZvaWQg ZGlkQ2hhbmdlVmlzaWJpbGl0eShib29sIGlzVmlzaWJsZSk7CiAgICAgCiAgICAgdm9pZCBlbnN1 cmVCYWNraW5nU3RvcmUoKTsKICAgICB2b2lkIGludmFsaWRhdGVCYWNraW5nU3RvcmUoKTsKSW5k ZXg6IFdlYktpdDIvVUlQcm9jZXNzL1BhZ2VDbGllbnQuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQy L1VJUHJvY2Vzcy9QYWdlQ2xpZW50LmgJKHJldmlzaW9uIDU4NjkzKQorKysgV2ViS2l0Mi9VSVBy b2Nlc3MvUGFnZUNsaWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC00MSw4ICs0MSw2IEBAIHB1Ymxp YzoKIAogICAgIHZpcnR1YWwgdm9pZCB0YWtlRm9jdXMoYm9vbCBkaXJlY3Rpb24pID0gMDsKICAg ICB2aXJ0dWFsIHZvaWQgdG9vbFRpcENoYW5nZWQoY29uc3QgV2ViQ29yZTo6U3RyaW5nJiwgY29u c3QgV2ViQ29yZTo6U3RyaW5nJikgPSAwOwotICAgIAotICAgIHZpcnR1YWwgYm9vbCBpc1BhZ2VW aXNpYmxlKCkgeyByZXR1cm4gdHJ1ZTsgfTsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdApJ bmRleDogV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCShyZXZpc2lvbiA1ODY5MykKKysrIFdl YktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMyMiwx MSArMzIyLDYgQEAgdm9pZCBXZWJQYWdlUHJveHk6OmdldFN0YXRpc3RpY3MoV0tDb250ZQogICAg IHN0YXRpc3RpY3MtPm51bWJlck9mV0tGcmFtZXMgKz0gbV9mcmFtZU1hcC5zaXplKCk7CiB9CiAK LWJvb2wgV2ViUGFnZVByb3h5Ojppc1Zpc2libGUoKQotewotICAgIHJldHVybiBtX3BhZ2VDbGll bnQtPmlzUGFnZVZpc2libGUoKTsKLX0KLQogV2ViRnJhbWVQcm94eSogV2ViUGFnZVByb3h5Ojp3 ZWJGcmFtZSh1aW50NjRfdCBmcmFtZUlEKSBjb25zdAogewogICAgIHJldHVybiBtX2ZyYW1lTWFw LmdldChmcmFtZUlEKS5nZXQoKTsKSW5kZXg6IFdlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94 eS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCShyZXZp c2lvbiA1ODY5MykKKysrIFdlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCSh3b3JraW5n IGNvcHkpCkBAIC0xNDMsOCArMTQzLDYgQEAgcHVibGljOgogCiAgICAgdm9pZCBnZXRTdGF0aXN0 aWNzKFdLQ29udGV4dFN0YXRpc3RpY3MqKTsKIAotICAgIGJvb2wgaXNWaXNpYmxlKCk7Ci0KIHBy aXZhdGU6CiAgICAgV2ViUGFnZVByb3h5KFdlYlBhZ2VOYW1lc3BhY2UqLCB1aW50NjRfdCBwYWdl SUQpOwogCkluZGV4OiBXZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1BhZ2VDbGllbnRJbXBsLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9QYWdlQ2xpZW50SW1wbC5o CShyZXZpc2lvbiA1ODY5MykKKysrIFdlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvUGFnZUNsaWVu dEltcGwuaAkod29ya2luZyBjb3B5KQpAQCAtNDIsNyArNDIsNiBAQCBwcml2YXRlOgogICAgIHZp cnR1YWwgdm9pZCBwcm9jZXNzRGlkUmV2aXZlKCk7CiAgICAgdmlydHVhbCB2b2lkIHRha2VGb2N1 cyhib29sIGRpcmVjdGlvbik7CiAgICAgdmlydHVhbCB2b2lkIHRvb2xUaXBDaGFuZ2VkKGNvbnN0 IFdlYkNvcmU6OlN0cmluZyYgb2xkVG9vbFRpcCwgY29uc3QgV2ViQ29yZTo6U3RyaW5nJiBuZXdU b29sVGlwKTsKLSAgICB2aXJ0dWFsIGJvb2wgaXNQYWdlVmlzaWJsZSgpOwogICAgIAogICAgIFdL VmlldyogbV93a1ZpZXc7CiB9OwpJbmRleDogV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9QYWdl Q2xpZW50SW1wbC5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1Bh Z2VDbGllbnRJbXBsLm1tCShyZXZpc2lvbiA1ODY5MykKKysrIFdlYktpdDIvVUlQcm9jZXNzL0FQ SS9tYWMvUGFnZUNsaWVudEltcGwubW0JKHdvcmtpbmcgY29weSkKQEAgLTYxLDE1ICs2MSw0IEBA IHZvaWQgUGFnZUNsaWVudEltcGw6OnRvb2xUaXBDaGFuZ2VkKGNvbnMKICAgICBbbV93a1ZpZXcg X3Rvb2xUaXBDaGFuZ2VkRnJvbTooTlNTdHJpbmcgKilvbGRUb29sVGlwIHRvOihOU1N0cmluZyAq KW5ld1Rvb2xUaXBdOwogfQogCi1ib29sIFBhZ2VDbGllbnRJbXBsOjppc1BhZ2VWaXNpYmxlKCkK LXsKLSAgICBpZiAoIVttX3drVmlldyB3aW5kb3ddKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0K LSAgICBpZiAoW21fd2tWaWV3IGlzSGlkZGVuT3JIYXNIaWRkZW5BbmNlc3Rvcl0pCi0gICAgICAg IHJldHVybiBmYWxzZTsKLQotICAgIHJldHVybiB0cnVlOwotfQotCiB9IC8vIG5hbWVzcGFjZSBX ZWJLaXQKSW5kZXg6IFdlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCShyZXZpc2lvbiA1ODY5 MykKKysrIFdlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCSh3b3JraW5nIGNvcHkp CkBAIC0yMTQsNiArMjE0LDIyIEBAIC0gKHZvaWQpcmVtb3ZlV2luZG93T2JzZXJ2ZXJzCiAgICAg fQogfQogCitzdGF0aWMgYm9vbCBpc1ZpZXdWaXNpYmxlKE5TVmlldyAqdmlldykKK3sKKyAgICBp ZiAoIVt2aWV3IHdpbmRvd10pCisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAKKyAgICBpZiAo W3ZpZXcgaXNIaWRkZW5Pckhhc0hpZGRlbkFuY2VzdG9yXSkKKyAgICAgICAgcmV0dXJuIGZhbHNl OworICAgIAorICAgIHJldHVybiB0cnVlOworfQorCistICh2b2lkKV91cGRhdGVWaXNpYmlsaXR5 Cit7CisgICAgX2RhdGEtPl9wYWdlLT5kcmF3aW5nQXJlYSgpLT5kaWRDaGFuZ2VWaXNpYmlsaXR5 KGlzVmlld1Zpc2libGUoc2VsZikpOworfQorCiAtICh2b2lkKXZpZXdXaWxsTW92ZVRvV2luZG93 OihOU1dpbmRvdyAqKXdpbmRvdwogewogICAgIGlmICh3aW5kb3cgIT0gW3NlbGYgd2luZG93XSkg ewpAQCAtMjI0LDggKzI0MCw3IEBAIC0gKHZvaWQpdmlld1dpbGxNb3ZlVG9XaW5kb3c6KE5TV2lu ZG93ICoKIAogLSAodm9pZCl2aWV3RGlkTW92ZVRvV2luZG93CiB7Ci0gICAgX2RhdGEtPl9wYWdl LT5kcmF3aW5nQXJlYSgpLT5kaWRDaGFuZ2VWaXNpYmlsaXR5KCk7Ci0KKyAgICBbc2VsZiBfdXBk YXRlVmlzaWJpbGl0eV07CiAgICAgW3NlbGYgX3VwZGF0ZUFjdGl2ZVN0YXRlXTsKIH0KIApAQCAt MjYyLDEyICsyNzcsMTIgQEAgLSAoQk9PTClpc09wYXF1ZSAKIAogLSAodm9pZCl2aWV3RGlkSGlk ZQogewotICAgIF9kYXRhLT5fcGFnZS0+ZHJhd2luZ0FyZWEoKS0+ZGlkQ2hhbmdlVmlzaWJpbGl0 eSgpOworICAgIFtzZWxmIF91cGRhdGVWaXNpYmlsaXR5XTsKIH0KIAogLSAodm9pZCl2aWV3RGlk VW5oaWRlCiB7Ci0gICAgX2RhdGEtPl9wYWdlLT5kcmF3aW5nQXJlYSgpLT5kaWRDaGFuZ2VWaXNp YmlsaXR5KCk7CisgICAgW3NlbGYgX3VwZGF0ZVZpc2liaWxpdHldOwogfQogCiBAZW5kCg==