38486 2010-05-03 14:13:01 -0700 Maui MiniBrowser: Add an option to show/hide the web view 2010-05-03 14:35:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca webkit-unassigned oldest_to_newest 220282 0 andersca 2010-05-03 14:13:01 -0700 Maui MiniBrowser: Add an option to show/hide the web view 220284 1 54960 andersca 2010-05-03 14:17:58 -0700 Created attachment 54960 Patch 220286 2 54960 aroben 2010-05-03 14:22:32 -0700 Comment on attachment 54960 Patch > + * MiniBrowser/win/BrowserWindow.cpp: > + (BrowserWindow::createWindow): > + (BrowserWindow::onCommand): > + * MiniBrowser/win/MiniBrowser.rc: > + * MiniBrowser/win/resource.h: More details, please! > + case ID_DEBUG_SHOW_WEB_VIEW: { > + HMENU menu = ::GetMenu(m_window); > + bool isChecked = ::GetMenuState(menu, ID_DEBUG_SHOW_WEB_VIEW, MF_BYCOMMAND) & MF_CHECKED; I would call this variable shouldHide. Or reverse it and call it shouldShow. r=me 220293 3 andersca 2010-05-03 14:35:29 -0700 Committed r58701: <http://trac.webkit.org/changeset/58701> 54960 2010-05-03 14:17:58 -0700 2010-05-03 14:22:32 -0700 Patch bug-38486-20100503141758.patch text/plain 4917 andersca SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU4Njk5KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDUtMDMgIEFuZGVycyBDYXJsc3NvbiAg PGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBNYXVpIE1pbmlCcm93c2VyOiBBZGQgYW4gb3B0aW9uIHRvIHNob3cvaGlk ZSB0aGUgd2ViIHZpZXcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM4NDg2CisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci93aW4vQnJvd3NlcldpbmRvdy5j cHA6CisgICAgICAgIChCcm93c2VyV2luZG93OjpjcmVhdGVXaW5kb3cpOgorICAgICAgICAoQnJv d3NlcldpbmRvdzo6b25Db21tYW5kKToKKyAgICAgICAgKiBNaW5pQnJvd3Nlci93aW4vTWluaUJy b3dzZXIucmM6CisgICAgICAgICogTWluaUJyb3dzZXIvd2luL3Jlc291cmNlLmg6CisKIDIwMTAt MDUtMDMgIENocmlzIEplcmRvbmVrICA8Y2plcmRvbmVrQHdlYmtpdC5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgRGFuaWVsIEJhdGVzLgpJbmRleDogV2ViS2l0VG9vbHMvTWluaUJyb3dzZXIv d2luL0Jyb3dzZXJXaW5kb3cuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL01pbmlCcm93 c2VyL3dpbi9Ccm93c2VyV2luZG93LmNwcAkocmV2aXNpb24gNTg2OTIpCisrKyBXZWJLaXRUb29s cy9NaW5pQnJvd3Nlci93aW4vQnJvd3NlcldpbmRvdy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEw OSw3ICsxMDksNyBAQCB2b2lkIEJyb3dzZXJXaW5kb3c6OmNyZWF0ZVdpbmRvdyhpbnQgeCwgCiAg ICAgd2luZG93Q2xhc3MuaEluc3RhbmNlID0gTWluaUJyb3dzZXI6OnNoYXJlZCgpLmluc3RhbmNl KCk7CiAgICAgd2luZG93Q2xhc3MuaEljb24gPSAwOwogICAgIHdpbmRvd0NsYXNzLmhDdXJzb3Ig PSA6OkxvYWRDdXJzb3IoMCwgSURDX0FSUk9XKTsKLSAgICB3aW5kb3dDbGFzcy5oYnJCYWNrZ3Jv dW5kID0gMDsKKyAgICB3aW5kb3dDbGFzcy5oYnJCYWNrZ3JvdW5kID0gKEhCUlVTSCk6OkdldFN0 b2NrT2JqZWN0KFdISVRFX0JSVVNIKTsKICAgICB3aW5kb3dDbGFzcy5scHN6TWVudU5hbWUgPSBN QUtFSU5UUkVTT1VSQ0UoSURSX01BSU5GUkFNRSk7CiAgICAgd2luZG93Q2xhc3MubHBzekNsYXNz TmFtZSA9IEwiTWluaUJyb3dzZXIiOwogICAgIHdpbmRvd0NsYXNzLmhJY29uU20gPSAwOwpAQCAt MjA3LDYgKzIwNywxNyBAQCBMUkVTVUxUIEJyb3dzZXJXaW5kb3c6Om9uQ29tbWFuZChpbnQgY29t CiAgICAgY2FzZSBJRF9GSUxFX0NMT1NFOgogICAgICAgICA6OlBvc3RNZXNzYWdlKG1fd2luZG93 LCBXTV9DTE9TRSwgMCwgMCk7CiAgICAgICAgIGJyZWFrOworICAgIGNhc2UgSURfREVCVUdfU0hP V19XRUJfVklFVzogeworICAgICAgICBITUVOVSBtZW51ID0gOjpHZXRNZW51KG1fd2luZG93KTsK KyAgICAgICAgYm9vbCBpc0NoZWNrZWQgPSA6OkdldE1lbnVTdGF0ZShtZW51LCBJRF9ERUJVR19T SE9XX1dFQl9WSUVXLCBNRl9CWUNPTU1BTkQpICYgTUZfQ0hFQ0tFRDsKKworICAgICAgICA6OkNo ZWNrTWVudUl0ZW0obWVudSwgSURfREVCVUdfU0hPV19XRUJfVklFVywgTUZfQllDT01NQU5EIHwg KGlzQ2hlY2tlZCA/IE1GX1VOQ0hFQ0tFRCA6IE1GX0NIRUNLRUQpKTsKKworICAgICAgICAvLyBT aG93IG9yIGhpZGUgdGhlIHdlYiB2aWV3LgorICAgICAgICBIV05EIHdlYlZpZXdXaW5kb3cgPSBX S1ZpZXdHZXRXaW5kb3cobV9icm93c2VyVmlldy53ZWJWaWV3KCkpOworICAgICAgICA6OlNob3dX aW5kb3cod2ViVmlld1dpbmRvdywgaXNDaGVja2VkID8gU1dfSElERSA6IFNXX1NIT1cpOworICAg ICAgICBicmVhazsKKyAgICB9CiAgICAgZGVmYXVsdDoKICAgICAgICAgaGFuZGxlZCA9IGZhbHNl OwogICAgIH0KSW5kZXg6IFdlYktpdFRvb2xzL01pbmlCcm93c2VyL3dpbi9NaW5pQnJvd3Nlci5y Ywo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9NaW5pQnJvd3Nlci93aW4vTWluaUJyb3dzZXIu cmMJKHJldmlzaW9uIDU4NjkyKQorKysgV2ViS2l0VG9vbHMvTWluaUJyb3dzZXIvd2luL01pbmlC cm93c2VyLnJjCSh3b3JraW5nIGNvcHkpCkBAIC0xLDEzICsxLDMxIEBACiAvLyBNaWNyb3NvZnQg VmlzdWFsIEMrKyBnZW5lcmF0ZWQgcmVzb3VyY2Ugc2NyaXB0Lg0KIC8vDQogI2luY2x1ZGUgInJl c291cmNlLmgiDQotI2luY2x1ZGUgIndpbnJlc3JjLmgiDQogDQorI2RlZmluZSBBUFNUVURJT19S RUFET05MWV9TWU1CT0xTDQorLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8NCisvLw0KKy8vIEdlbmVyYXRl ZCBmcm9tIHRoZSBURVhUSU5DTFVERSAyIHJlc291cmNlLg0KKy8vDQorI2luY2x1ZGUgImFmeHJl cy5oIg0KKw0KKy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vDQorI3VuZGVmIEFQU1RVRElPX1JFQURPTkxZ X1NZTUJPTFMNCisNCisvLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLw0KKy8vIEVuZ2xpc2ggKFUuUy4pIHJl c291cmNlcw0KKw0KKyNpZiAhZGVmaW5lZChBRlhfUkVTT1VSQ0VfRExMKSB8fCBkZWZpbmVkKEFG WF9UQVJHX0VOVSkNCiAjaWZkZWYgX1dJTjMyDQogTEFOR1VBR0UgTEFOR19FTkdMSVNILCBTVUJM QU5HX0VOR0xJU0hfVVMNCiAjcHJhZ21hIGNvZGVfcGFnZSgxMjUyKQ0KICNlbmRpZiAvL19XSU4z Mg0KIA0KKy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vDQorLy8NCisvLyBNZW51DQorLy8NCisNCiBJRFJf TUFJTkZSQU1FIE1FTlUgDQogQkVHSU4NCiAgICAgUE9QVVAgIiZGaWxlIg0KQEAgLTE2LDYgKzM0 LDEwIEBAIEJFR0lODQogICAgICAgICBNRU5VSVRFTSBTRVBBUkFUT1INCiAgICAgICAgIE1FTlVJ VEVNICImQ2xvc2UiLCAgICAgICAgICAgICAgICAgICAgICBJRF9GSUxFX0NMT1NFDQogICAgIEVO RA0KKyAgICBQT1BVUCAiJkRlYnVnIg0KKyAgICBCRUdJTg0KKyAgICAgICAgTUVOVUlURU0gIiZT aG93IFdlYlZpZXciLCAgICAgICAgICAgICAgIElEX0RFQlVHX1NIT1dfV0VCX1ZJRVcsIENIRUNL RUQNCisgICAgRU5EDQogRU5EDQogDQogDQpAQCAtMjYsNSArNDgsNDEgQEAgRU5EDQogDQogSURS X01BSU5GUkFNRV9BQ0NFTCBBQ0NFTEVSQVRPUlMgDQogQkVHSU4NCi0gICAgIk4iLCAgICAgICAg ICAgIElEX0ZJTEVfTkVXX1dJTkRPVywgICAgICAgICAgIFZJUlRLRVksIENPTlRST0wsIE5PSU5W RVJUDQorICAgICJOIiwgICAgICAgICAgICBJRF9GSUxFX05FV19XSU5ET1csICAgICBWSVJUS0VZ LCBDT05UUk9MLCBOT0lOVkVSVA0KIEVORA0KKw0KKw0KKyNpZmRlZiBBUFNUVURJT19JTlZPS0VE DQorLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8NCisvLw0KKy8vIFRFWFRJTkNMVURFDQorLy8NCisNCisx IFRFWFRJTkNMVURFIA0KK0JFR0lODQorICAgICJyZXNvdXJjZS5cMCINCitFTkQNCisNCisNCisz IFRFWFRJTkNMVURFIA0KK0JFR0lODQorICAgICJcclwwIg0KK0VORA0KKw0KKyNlbmRpZiAgICAv LyBBUFNUVURJT19JTlZPS0VEDQorDQorI2VuZGlmICAgIC8vIEVuZ2xpc2ggKFUuUy4pIHJlc291 cmNlcw0KKy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vDQorDQorDQorDQorI2lmbmRlZiBBUFNUVURJT19J TlZPS0VEDQorLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8NCisvLw0KKy8vIEdlbmVyYXRlZCBmcm9tIHRo ZSBURVhUSU5DTFVERSAzIHJlc291cmNlLg0KKy8vDQorDQorDQorLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8NCisjZW5kaWYgICAgLy8gbm90IEFQU1RVRElPX0lOVk9LRUQNCisNCkluZGV4OiBXZWJLaXRU b29scy9NaW5pQnJvd3Nlci93aW4vcmVzb3VyY2UuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29s cy9NaW5pQnJvd3Nlci93aW4vcmVzb3VyY2UuaAkocmV2aXNpb24gNTg2OTIpCisrKyBXZWJLaXRU b29scy9NaW5pQnJvd3Nlci93aW4vcmVzb3VyY2UuaAkod29ya2luZyBjb3B5KQpAQCAtNiw2ICs2 LDcgQEAKICNkZWZpbmUgSURfRklMRV9ORVdfV0lORE9XICAgICAgICAgICAgICAzMjc3MAogI2Rl ZmluZSBJRF9GSUxFX09QRU4gICAgICAgICAgICAgICAgICAgIDMyNzcxCiAjZGVmaW5lIElEX0ZJ TEVfQ0xPU0UgICAgICAgICAgICAgICAgICAgMzI3NzIKKyNkZWZpbmUgSURfREVCVUdfU0hPV19X RUJfVklFVyAgICAgICAgICAzMjc3MwogCiAjZGVmaW5lIElEUl9NQUlORlJBTUUgICAgICAgICAg ICAgICAgICAgMTI4CiAK