38483 2010-05-03 13:00:03 -0700 Implement PageClient::isPageVisible on Windows. 2010-05-03 13:19:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca webkit-unassigned oldest_to_newest 220253 0 andersca 2010-05-03 13:00:03 -0700 Implement PageClient::isPageVisible on Windows. 220259 1 54956 andersca 2010-05-03 13:06:00 -0700 Created attachment 54956 Patch 220260 2 54956 aroben 2010-05-03 13:10:16 -0700 Comment on attachment 54956 Patch Is it possible for m_window to be null? The FIXME seems incorrect if it's possible for m_window to be a top-level window. You could add a FIXME about checking if the window is clipped out of view. r=me 220261 3 andersca 2010-05-03 13:11:59 -0700 (In reply to comment #2) > (From update of attachment 54956 [details]) > Is it possible for m_window to be null? > Nope. > The FIXME seems incorrect if it's possible for m_window to be a top-level > window. It will never be a top-level window. > > You could add a FIXME about checking if the window is clipped out of view. In that case I think we might still want to update the backing store; this is more to stop updates from web views in hidden tabs from happening. > > r=me Thanks! 220262 4 andersca 2010-05-03 13:19:58 -0700 Committed r58697: <http://trac.webkit.org/changeset/58697> 54956 2010-05-03 13:06:00 -0700 2010-05-03 13:10:16 -0700 Patch bug-38483-20100503130559.patch text/plain 2321 andersca SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA1ODY5NCkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDUtMDMgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBJbXBsZW1lbnQgUGFnZUNsaWVudDo6aXNQYWdlVmlzaWJsZSBvbiBXaW5kb3dzLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg0ODMKKworICAgICAg ICAqIFVJUHJvY2Vzcy9QYWdlQ2xpZW50Lmg6CisgICAgICAgICogVUlQcm9jZXNzL3dpbi9XZWJW aWV3LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmlldzo6aXNQYWdlVmlzaWJsZSk6CisgICAg ICAgICogVUlQcm9jZXNzL3dpbi9XZWJWaWV3Lmg6CisKIDIwMTAtMDUtMDMgIEFuZGVycyBDYXJs c3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggV2luZG93cyBidWlsZC4K SW5kZXg6IFdlYktpdDIvVUlQcm9jZXNzL1BhZ2VDbGllbnQuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJL aXQyL1VJUHJvY2Vzcy9QYWdlQ2xpZW50LmgJKHJldmlzaW9uIDU4NjkyKQorKysgV2ViS2l0Mi9V SVByb2Nlc3MvUGFnZUNsaWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC00MSw4ICs0MSw4IEBAIHB1 YmxpYzoKIAogICAgIHZpcnR1YWwgdm9pZCB0YWtlRm9jdXMoYm9vbCBkaXJlY3Rpb24pID0gMDsK ICAgICB2aXJ0dWFsIHZvaWQgdG9vbFRpcENoYW5nZWQoY29uc3QgV2ViQ29yZTo6U3RyaW5nJiwg Y29uc3QgV2ViQ29yZTo6U3RyaW5nJikgPSAwOwotICAgIAotICAgIHZpcnR1YWwgYm9vbCBpc1Bh Z2VWaXNpYmxlKCkgeyByZXR1cm4gdHJ1ZTsgfTsKKworICAgIHZpcnR1YWwgYm9vbCBpc1BhZ2VW aXNpYmxlKCkgPSAwOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CkluZGV4OiBXZWJLaXQy L1VJUHJvY2Vzcy93aW4vV2ViVmlldy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0Mi9VSVByb2Nl c3Mvd2luL1dlYlZpZXcuY3BwCShyZXZpc2lvbiA1ODY5MikKKysrIFdlYktpdDIvVUlQcm9jZXNz L3dpbi9XZWJWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDgxLDYgKzQ4MSwxMiBAQCB2b2lk IFdlYlZpZXc6OnRvb2xUaXBDaGFuZ2VkKGNvbnN0IFN0cmluCiAgICAgOjpTZW5kTWVzc2FnZSht X3Rvb2xUaXBXaW5kb3csIFRUTV9BQ1RJVkFURSwgIW5ld1Rvb2xUaXAuaXNFbXB0eSgpLCAwKTsK IH0KIAorYm9vbCBXZWJWaWV3Ojppc1BhZ2VWaXNpYmxlKCkKK3sKKyAgICAvLyBGSVhNRTogV2Ug c2hvdWxkIHByb2JhYmx5IGNoZWNrIGlmIHRoZSB3aW5kb3cgaGFzIGEgcGFyZW50L2FuY2VzdG9y IHRvby4KKyAgICByZXR1cm4gOjpJc1dpbmRvd1Zpc2libGUobV93aW5kb3cpOworfQorCiAvLyBX ZWJDb3JlOjpXaW5kb3dNZXNzYWdlTGlzdGVuZXIKIAogdm9pZCBXZWJWaWV3Ojp3aW5kb3dSZWNl aXZlZE1lc3NhZ2UoSFdORCwgVUlOVCBtZXNzYWdlLCBXUEFSQU0gd1BhcmFtLCBMUEFSQU0pCklu ZGV4OiBXZWJLaXQyL1VJUHJvY2Vzcy93aW4vV2ViVmlldy5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktp dDIvVUlQcm9jZXNzL3dpbi9XZWJWaWV3LmgJKHJldmlzaW9uIDU4NjkyKQorKysgV2ViS2l0Mi9V SVByb2Nlc3Mvd2luL1dlYlZpZXcuaAkod29ya2luZyBjb3B5KQpAQCAtOTIsNiArOTIsNyBAQCBw cml2YXRlOgogICAgIHZpcnR1YWwgdm9pZCBwcm9jZXNzRGlkUmV2aXZlKCk7CiAgICAgdmlydHVh bCB2b2lkIHRha2VGb2N1cyhib29sIGRpcmVjdGlvbik7CiAgICAgdmlydHVhbCB2b2lkIHRvb2xU aXBDaGFuZ2VkKGNvbnN0IFdlYkNvcmU6OlN0cmluZyYsIGNvbnN0IFdlYkNvcmU6OlN0cmluZyYp OworICAgIHZpcnR1YWwgYm9vbCBpc1BhZ2VWaXNpYmxlKCk7CiAKICAgICAvLyBXZWJDb3JlOjpX aW5kb3dNZXNzYWdlTGlzdGVuZXIKICAgICB2aXJ0dWFsIHZvaWQgd2luZG93UmVjZWl2ZWRNZXNz YWdlKEhXTkQsIFVJTlQgbWVzc2FnZSwgV1BBUkFNLCBMUEFSQU0pOwo=