38480 2010-05-03 12:29:09 -0700 wx port: scheduleDispatchFunctionsOnMainThread is unimplemented 2010-05-03 15:37:56 -0700 1 1 1 Unclassified WebKit WebKit wx 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 0 kevinwatters webkit-unassigned kevino webkit.review.bot oldest_to_newest 220240 0 54953 kevinwatters 2010-05-03 12:29:09 -0700 Created attachment 54953 implements scheduleDispatchFunctionsOnMainThread The wx port needs an implementation for scheduleDispatchFunctionsOnMainThread in MainThreadWx.cpp. 220244 1 webkit.review.bot 2010-05-03 12:34:01 -0700 Attachment 54953 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 JavaScriptCore/wtf/wx/MainThreadWx.cpp:33: Alphabetical sorting problem. [build/include_order] [4] JavaScriptCore/wtf/wx/MainThreadWx.cpp:36: wxEVT_CALL_AFTER is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/wtf/wx/MainThreadWx.cpp:39: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 220246 2 kevino 2010-05-03 12:39:46 -0700 These style issues are due to conflict with wx header and naming conventions, so I'm approving this patch. 220335 3 kevino 2010-05-03 15:37:56 -0700 Landed in r58709, thanks! 54953 2010-05-03 12:29:09 -0700 2010-05-03 15:37:43 -0700 implements scheduleDispatchFunctionsOnMainThread mainthread_thunk.patch text/plain 1694 kevinwatters SW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi93eC9NYWluVGhyZWFkV3guY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIEphdmFTY3JpcHRDb3JlL3d0Zi93eC9NYWluVGhyZWFkV3guY3BwCShyZXZpc2lvbiA1ODI1 NykKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi93eC9NYWluVGhyZWFkV3guY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0yOSw2ICsyOSwyOSBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIk1h aW5UaHJlYWQuaCIKIAorI2luY2x1ZGUgPHd4L2RlZnMuaD4KKyNpbmNsdWRlIDx3eC9hcHAuaD4K KyNpbmNsdWRlIDx3eC9ldmVudC5oPgorCitjb25zdCB3eEV2ZW50VHlwZSB3eEVWVF9DQUxMX0FG VEVSID0gd3hOZXdFdmVudFR5cGUoKTsKKworY2xhc3Mgd3hDYWxsQWZ0ZXIgOiBwdWJsaWMgd3hF dnRIYW5kbGVyCit7CitwdWJsaWM6CisgICAgd3hDYWxsQWZ0ZXIoKSAKKyAgICAgICAgOiB3eEV2 dEhhbmRsZXIoKQorICAgICAgICB7CisgICAgICAgICAgICB3eFRoZUFwcC0+Q29ubmVjdCgtMSwg LTEsIHd4RVZUX0NBTExfQUZURVIsIHd4Q29tbWFuZEV2ZW50SGFuZGxlcih3eENhbGxBZnRlcjo6 T25DYWxsYmFjaykpOworICAgICAgICAgICAgd3hDb21tYW5kRXZlbnQgZXZlbnQod3hFVlRfQ0FM TF9BRlRFUik7CisgICAgICAgICAgICB3eFBvc3RFdmVudCh3eFRoZUFwcCwgZXZlbnQpOworICAg ICAgICB9CisgICAgICAgIAorICAgIHZvaWQgT25DYWxsYmFjayh3eENvbW1hbmRFdmVudCYgZXZl bnQpCisgICAgeworICAgICAgICBXVEY6OmRpc3BhdGNoRnVuY3Rpb25zRnJvbU1haW5UaHJlYWQo KTsKKyAgICB9Cit9OworCiBuYW1lc3BhY2UgV1RGIHsKIAogdm9pZCBpbml0aWFsaXplTWFpblRo cmVhZFBsYXRmb3JtKCkKQEAgLTM3LDYgKzYwLDcgQEAKIAogdm9pZCBzY2hlZHVsZURpc3BhdGNo RnVuY3Rpb25zT25NYWluVGhyZWFkKCkKIHsKKyAgICB3eENhbGxBZnRlcigpOwogfQogCiB9IC8v IG5hbWVzcGFjZSBXVEYKSW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBKYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU4MjU3KQorKysgSmF2YVNj cmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAt MDQtMjYgIEtldmluIFdhdHRlcnMgIDxrZXZpbndhdHRlcnNAZ21haWwuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFt3eF0gSW1wbGVtZW50IHNj aGVkdWxlRGlzcGF0Y2hGdW5jdGlvbnNPbk1haW5UaHJlYWQgZm9yIHd4IHBvcnQuCisKKyAgICAg ICAgKiB3dGYvd3gvTWFpblRocmVhZFd4LmNwcDoKKyAgICAgICAgKHd4Q2FsbEFmdGVyOjp3eENh bGxBZnRlcik6CisgICAgICAgICh3eENhbGxBZnRlcjo6T25DYWxsYmFjayk6CisgICAgICAgIChX VEY6OnNjaGVkdWxlRGlzcGF0Y2hGdW5jdGlvbnNPbk1haW5UaHJlYWQpOgorCiAyMDEwLTA0LTI2 ICBKZWRyemVqIE5vd2Fja2kgIDxqZWRyemVqLm5vd2Fja2lAbm9raWEuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgo=