38473 2010-05-03 11:11:00 -0700 [chromium] right clicks should not close select popup 2010-05-04 07:57:31 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 jcivelli webkit-unassigned abarth commit-queue eric webkit.review.bot oldest_to_newest 220195 0 jcivelli 2010-05-03 11:11:00 -0700 - Open a select popup - Right click in the page (or on the select itself) Expected: - the select popup stays open Actual: - the select popup is closed 220208 1 54944 jcivelli 2010-05-03 11:25:54 -0700 Created attachment 54944 Don't hide popup on right and middle mouse click 220209 2 webkit.review.bot 2010-05-03 11:27:41 -0700 Attachment 54944 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKit/chromium/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 220359 3 54944 levin 2010-05-03 16:33:49 -0700 Comment on attachment 54944 Don't hide popup on right and middle mouse click This seems fine except for the tab in the changelog noted by the stylebot, so this won't commit cleanly in this state. If you were a WebKit committer, I'd give you an r+ but due to the TAB and the non-committer status r-. 220366 4 54973 jcivelli 2010-05-03 16:50:43 -0700 Created attachment 54973 Fixing style 220575 5 54973 commit-queue 2010-05-04 07:04:56 -0700 Comment on attachment 54973 Fixing style Clearing flags on attachment: 54973 Committed r58757: <http://trac.webkit.org/changeset/58757> 220576 6 commit-queue 2010-05-04 07:05:01 -0700 All reviewed patches have been landed. Closing bug. 220588 7 webkit.review.bot 2010-05-04 07:57:31 -0700 http://trac.webkit.org/changeset/58757 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/58756 http://trac.webkit.org/changeset/58757 54944 2010-05-03 11:25:54 -0700 2010-05-03 16:50:43 -0700 Don't hide popup on right and middle mouse click select_2nd_click.patch text/plain 1513 jcivelli SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA1ODY4NykKKysrIFdlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNS0wMyAgSmF5 IENpdmVsbGkgIDxqY2l2ZWxsaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSB0aGUgc2VsZWN0IHBvcHVwIG5vdCBjbG9z ZSBvbiByaWdodC9taWRkbGUgY2xpY2tzLgorCQlodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Mzg0NzMKKworICAgICAgICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAg ICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjptb3VzZURvd24pOgorCiAyMDEwLTA1LTAzICBKZW5z IEFsZmtlICA8c25lakBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4g RmlzaGVyLgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHANCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0NCi0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAkocmV2aXNpb24g NTg2NzcpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMzI5LDkgKzMyOSwxMiBAQCB2b2lkIFdlYlZpZXdJbXBsOjptb3VzZURvd24oY29u c3QgV2ViTW91CiAgICAgLy8gSWYgdGhlcmUgaXMgYSBzZWxlY3QgcG9wdXAgb3BlbiwgY2xvc2Ug aXQgYXMgdGhlIHVzZXIgaXMgY2xpY2tpbmcgb24KICAgICAvLyB0aGUgcGFnZSAob3V0c2lkZSBv ZiB0aGUgcG9wdXApLiAgV2UgYWxzbyBzYXZlIGl0IHNvIHdlIGNhbiBwcmV2ZW50IGEKICAgICAv LyBjbGljayBvbiB0aGUgc2VsZWN0IGVsZW1lbnQgZnJvbSBpbW1lZGlhdGVseSByZW9wZW5pbmcg dGhlIHBvcHVwLgotICAgIFJlZlB0cjxXZWJDb3JlOjpQb3B1cENvbnRhaW5lcj4gc2VsZWN0UG9w dXAgPSBtX3NlbGVjdFBvcHVwOwotICAgIGhpZGVTZWxlY3RQb3B1cCgpOwotICAgIEFTU0VSVCgh bV9zZWxlY3RQb3B1cCk7CisgICAgUmVmUHRyPFdlYkNvcmU6OlBvcHVwQ29udGFpbmVyPiBzZWxl Y3RQb3B1cDsKKyAgICBpZiAoZXZlbnQuYnV0dG9uID09IFdlYk1vdXNlRXZlbnQ6OkJ1dHRvbkxl ZnQpIHsKKyAgICAgICAgc2VsZWN0UG9wdXAgPSBtX3NlbGVjdFBvcHVwOworICAgICAgICBoaWRl U2VsZWN0UG9wdXAoKTsKKyAgICAgICAgQVNTRVJUKCFtX3NlbGVjdFBvcHVwKTsKKyAgICB9CiAK ICAgICBtX2xhc3RNb3VzZURvd25Qb2ludCA9IFdlYlBvaW50KGV2ZW50LngsIGV2ZW50LnkpOwog ICAgIG1faGF2ZU1vdXNlQ2FwdHVyZSA9IHRydWU7Cg== 54973 2010-05-03 16:50:43 -0700 2010-05-04 07:04:56 -0700 Fixing style select_2nd_click.patch text/plain 1530 jcivelli SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA1ODY4NykKKysrIFdlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNS0wMyAgSmF5 IENpdmVsbGkgIDxqY2l2ZWxsaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBNYWtlIHRoZSBzZWxlY3QgcG9w dXAgbm90IGNsb3NlIG9uIHJpZ2h0L21pZGRsZSBjbGlja3MuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODQ3MworCisgICAgICAgICogc3JjL1dlYlZp ZXdJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6Om1vdXNlRG93bik6CisK IDIwMTAtMDUtMDMgIEplbnMgQWxma2UgIDxzbmVqQGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZp ZXdJbXBsLmNwcA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0lt cGwuY3BwCShyZXZpc2lvbiA1ODY3NykKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0lt cGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMjksOSArMzI5LDEyIEBAIHZvaWQgV2ViVmlld0lt cGw6Om1vdXNlRG93bihjb25zdCBXZWJNb3UKICAgICAvLyBJZiB0aGVyZSBpcyBhIHNlbGVjdCBw b3B1cCBvcGVuLCBjbG9zZSBpdCBhcyB0aGUgdXNlciBpcyBjbGlja2luZyBvbgogICAgIC8vIHRo ZSBwYWdlIChvdXRzaWRlIG9mIHRoZSBwb3B1cCkuICBXZSBhbHNvIHNhdmUgaXQgc28gd2UgY2Fu IHByZXZlbnQgYQogICAgIC8vIGNsaWNrIG9uIHRoZSBzZWxlY3QgZWxlbWVudCBmcm9tIGltbWVk aWF0ZWx5IHJlb3BlbmluZyB0aGUgcG9wdXAuCi0gICAgUmVmUHRyPFdlYkNvcmU6OlBvcHVwQ29u dGFpbmVyPiBzZWxlY3RQb3B1cCA9IG1fc2VsZWN0UG9wdXA7Ci0gICAgaGlkZVNlbGVjdFBvcHVw KCk7Ci0gICAgQVNTRVJUKCFtX3NlbGVjdFBvcHVwKTsKKyAgICBSZWZQdHI8V2ViQ29yZTo6UG9w dXBDb250YWluZXI+IHNlbGVjdFBvcHVwOworICAgIGlmIChldmVudC5idXR0b24gPT0gV2ViTW91 c2VFdmVudDo6QnV0dG9uTGVmdCkgeworICAgICAgICBzZWxlY3RQb3B1cCA9IG1fc2VsZWN0UG9w dXA7CisgICAgICAgIGhpZGVTZWxlY3RQb3B1cCgpOworICAgICAgICBBU1NFUlQoIW1fc2VsZWN0 UG9wdXApOworICAgIH0KIAogICAgIG1fbGFzdE1vdXNlRG93blBvaW50ID0gV2ViUG9pbnQoZXZl bnQueCwgZXZlbnQueSk7CiAgICAgbV9oYXZlTW91c2VDYXB0dXJlID0gdHJ1ZTsK