38465 2010-05-03 07:58:45 -0700 Misleading variable name in a11y test 2010-05-19 22:02:47 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 mario webkit-unassigned commit-queue oldest_to_newest 220108 0 mario 2010-05-03 07:58:45 -0700 In LayoutTests/accessibility/aria-controls-with-tabs.html, the variable 'body' is misleading, because it actually contain the root accessible element, not the accessible object associated to the <body> tag: var body = accessibilityController.rootElement; If you compare this with other a11y tests using the rootElement method, it's done in a different, but more understandable, way. For instance, in LayoutTests/platform/mac/accessibility/element-focus.html: var root = accessibilityController.rootElement; var body = root.childAtIndex(0); In the case of aria-controls-with-tabs.html, the test is still working fine because at the end 'body' is not being used as if it were the a11y object for body, but its parent: var body = accessibilityController.rootElement; var tabList = body.childAtIndex(0).childAtIndex(0); Hence, even though it's working fine because of the thing pointed out above, IMHO it would be better if the test was written more like LayoutTests/platform/mac/accessibility/element-focus.html 220111 1 54928 mario 2010-05-03 08:03:46 -0700 Created attachment 54928 Proposed patch Attaching a patch proposal for this 226277 2 54928 commit-queue 2010-05-15 10:23:49 -0700 Comment on attachment 54928 Proposed patch Rejecting patch 54928 from commit-queue. Unexpected failure when landing patch! Please file a bug against webkit-patch. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 54928, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1 Logging in as eseidel@chromium.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=54928&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=38465&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Processing patch 54928 from bug 38465. ERROR: /Users/eseidel/Projects/CommitQueue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). 227171 3 56331 mario 2010-05-18 00:48:52 -0700 Created attachment 56331 Proposed patch (In reply to comment #2) > (From update of attachment 54928 [details]) > Rejecting patch 54928 from commit-queue. Seems I uploaded the wrong patch, lacking the "Reviewed by NOBODY" line, sorry. Now uploading the right one. 228192 4 56331 commit-queue 2010-05-19 22:02:42 -0700 Comment on attachment 56331 Proposed patch Clearing flags on attachment: 56331 Committed r59818: <http://trac.webkit.org/changeset/59818> 228193 5 commit-queue 2010-05-19 22:02:47 -0700 All reviewed patches have been landed. Closing bug. 54928 2010-05-03 08:03:46 -0700 2010-05-18 00:48:52 -0700 Proposed patch 0001-Use-a-more-appropriate-variable-name-for-the-return.patch text/plain 1945 mario RnJvbSAwMGY0NzY3NWZkZGYxOTY1YjYzNzRmOGUwZDU4OGQ0YmZlNjRlZDhmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBNb24sIDMgTWF5IDIwMTAgMTc6MDE6MzggKzAyMDAKU3ViamVjdDogW1BBVENI XSBVc2UgYSBtb3JlIGFwcHJvcHJpYXRlIHZhcmlhYmxlIG5hbWUgZm9yIHRoZSByZXR1cm4KIHZh bHVlIG9mIGFjY2Vzc2liaWxpdHlDb250cm9sbGVyLnJvb3RFbGVtZW50CgpNaXNsZWFkaW5nIHZh cmlhYmxlIG5hbWUgaW4gYTExeSB0ZXN0Cmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zODQ2NQoKKiBhY2Nlc3NpYmlsaXR5L2FyaWEtY29udHJvbHMtd2l0aC10YWJzLmh0 bWw6Ci0tLQogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgfCAgIDEwICsrKysrKysrKysKIC4uLi9hY2Nlc3NpYmlsaXR5L2FyaWEtY29udHJvbHMtd2l0 aC10YWJzLmh0bWwgICAgIHwgICAgNSArKystLQogMiBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNlcnRp b25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBjMzA4MTc2Li44ZGMyMjI2IDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDUtMDMgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtc2FuY2hl ekBpZ2FsaWEuY29tPgorCisgICAgICAgIFVzZSBhIG1vcmUgYXBwcm9wcmlhdGUgdmFyaWFibGUg bmFtZSBmb3IgdGhlIHJldHVybgorICAgICAgICB2YWx1ZSBvZiBhY2Nlc3NpYmlsaXR5Q29udHJv bGxlci5yb290RWxlbWVudAorCisgICAgICAgIE1pc2xlYWRpbmcgdmFyaWFibGUgbmFtZSBpbiBh MTF5IHRlc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTM4NDY1CisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2FyaWEtY29udHJvbHMtd2l0aC10YWJz Lmh0bWw6CisKIDIwMTAtMDQtMjkgIEZ1bWl0b3NoaSBVa2FpICA8dWthaUBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgVW5yZXZpZXdlZCwgdGVzdCBleHBlY3RhdGlvbnMgdXBkYXRlLgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9hcmlhLWNvbnRyb2xzLXdpdGgtdGFicy5o dG1sIGIvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9hcmlhLWNvbnRyb2xzLXdpdGgtdGFicy5o dG1sCmluZGV4IDM4MmU5OWUuLmM0YzE0YzcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2FjY2Vz c2liaWxpdHkvYXJpYS1jb250cm9scy13aXRoLXRhYnMuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9h Y2Nlc3NpYmlsaXR5L2FyaWEtY29udHJvbHMtd2l0aC10YWJzLmh0bWwKQEAgLTM0LDggKzM0LDkg QEAgdmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IGZhbHNlOwogCiAgICAgaWYgKHdpbmRvdy5hY2Nl c3NpYmlsaXR5Q29udHJvbGxlcikgewogCi0gICAgICAgICAgdmFyIGJvZHkgPSBhY2Nlc3NpYmls aXR5Q29udHJvbGxlci5yb290RWxlbWVudDsKLSAgICAgICAgICB2YXIgdGFiTGlzdCA9IGJvZHku Y2hpbGRBdEluZGV4KDApLmNoaWxkQXRJbmRleCgwKTsKKyAgICAgICAgICB2YXIgcm9vdCA9IGFj Y2Vzc2liaWxpdHlDb250cm9sbGVyLnJvb3RFbGVtZW50OworICAgICAgICAgIHZhciBib2R5ID0g cm9vdC5jaGlsZEF0SW5kZXgoMCk7CisgICAgICAgICAgdmFyIHRhYkxpc3QgPSBib2R5LmNoaWxk QXRJbmRleCgwKTsKICAgICAgICAgICB2YXIgdGFiMSA9IHRhYkxpc3QuY2hpbGRBdEluZGV4KDAp OwogICAgICAgICAgIHZhciB0YWIyID0gdGFiTGlzdC5jaGlsZEF0SW5kZXgoMSk7CiAKLS0gCjEu Ny4wLjQKCg== 56331 2010-05-18 00:48:52 -0700 2010-05-19 22:02:41 -0700 Proposed patch 0001-2010-05-06-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 2117 mario RnJvbSBmNDY4MWRmOGUzMzI3YTkyNTc3ZTQwZmNlYTI0MTIxMzE1MzgwOTE3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBUaHUsIDYgTWF5IDIwMTAgMjA6Mjg6MTEgKzAyMDAKU3ViamVjdDogW1BBVENI XSAyMDEwLTA1LTA2ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4K CiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIE1pc2xlYWRpbmcg dmFyaWFibGUgbmFtZSBpbiBhMTF5IHRlc3QKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9Mzg0NjUKCiAgICAgICAgVXNlIGEgbW9yZSBhcHByb3ByaWF0ZSB2 YXJpYWJsZSBuYW1lIGZvciB0aGUgcmV0dXJuCiAgICAgICAgdmFsdWUgb2YgYWNjZXNzaWJpbGl0 eUNvbnRyb2xsZXIucm9vdEVsZW1lbnQKCiAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2FyaWEtY29u dHJvbHMtd2l0aC10YWJzLmh0bWw6Ci0tLQogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgfCAgIDEyICsrKysrKysrKysrKwogLi4uL2FjY2Vzc2liaWxp dHkvYXJpYS1jb250cm9scy13aXRoLXRhYnMuaHRtbCAgICAgfCAgICA1ICsrKy0tCiAyIGZpbGVz IGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGU3NWQ4 YjUuLjM2NjY2MGIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNS0wNiAgTWFyaW8gU2Fu Y2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWlzbGVhZGluZyB2YXJpYWJsZSBuYW1lIGluIGEx MXkgdGVzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 Mzg0NjUKKworICAgICAgICBVc2UgYSBtb3JlIGFwcHJvcHJpYXRlIHZhcmlhYmxlIG5hbWUgZm9y IHRoZSByZXR1cm4KKyAgICAgICAgdmFsdWUgb2YgYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIucm9v dEVsZW1lbnQKKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvYXJpYS1jb250cm9scy13aXRoLXRh YnMuaHRtbDoKKwogMjAxMC0wNS0wNSAgSmVyZW15IE1vc2tvdmljaCAgPGplcmVteUBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgZXhwZWN0YXRpb25zIGNoYW5nZS4KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvYXJpYS1jb250cm9scy13aXRoLXRhYnMu aHRtbCBiL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvYXJpYS1jb250cm9scy13aXRoLXRhYnMu aHRtbAppbmRleCAzODJlOTllLi5jNGMxNGM3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9hY2Nl c3NpYmlsaXR5L2FyaWEtY29udHJvbHMtd2l0aC10YWJzLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMv YWNjZXNzaWJpbGl0eS9hcmlhLWNvbnRyb2xzLXdpdGgtdGFicy5odG1sCkBAIC0zNCw4ICszNCw5 IEBAIHZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSBmYWxzZTsKIAogICAgIGlmICh3aW5kb3cuYWNj ZXNzaWJpbGl0eUNvbnRyb2xsZXIpIHsKIAotICAgICAgICAgIHZhciBib2R5ID0gYWNjZXNzaWJp bGl0eUNvbnRyb2xsZXIucm9vdEVsZW1lbnQ7Ci0gICAgICAgICAgdmFyIHRhYkxpc3QgPSBib2R5 LmNoaWxkQXRJbmRleCgwKS5jaGlsZEF0SW5kZXgoMCk7CisgICAgICAgICAgdmFyIHJvb3QgPSBh Y2Nlc3NpYmlsaXR5Q29udHJvbGxlci5yb290RWxlbWVudDsKKyAgICAgICAgICB2YXIgYm9keSA9 IHJvb3QuY2hpbGRBdEluZGV4KDApOworICAgICAgICAgIHZhciB0YWJMaXN0ID0gYm9keS5jaGls ZEF0SW5kZXgoMCk7CiAgICAgICAgICAgdmFyIHRhYjEgPSB0YWJMaXN0LmNoaWxkQXRJbmRleCgw KTsKICAgICAgICAgICB2YXIgdGFiMiA9IHRhYkxpc3QuY2hpbGRBdEluZGV4KDEpOwogCi0tIAox LjcuMC40Cgo=