38461 2010-05-03 07:19:56 -0700 [GStreamer] forgotten call to durationChanged in updateStates() 2010-05-13 02:49:54 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED INVALID P2 Normal --- 38475 1 pnormand webkit-unassigned abarth eric.carlson eric webkit.review.bot oldest_to_newest 220091 0 pnormand 2010-05-03 07:19:56 -0700 when pipeline rolls to PLAYING we do a duration query and if it succeeds we don't call durationChanged() to notify the MediaPlayer. 220100 1 54926 pnormand 2010-05-03 07:42:32 -0700 Created attachment 54926 proposed patch 220186 2 pnormand 2010-05-03 11:02:23 -0700 Landed in r58685 220200 3 eric 2010-05-03 11:17:47 -0700 This failed to update the Gtk results and is causing failures on the bots. 220202 4 webkit.review.bot 2010-05-03 11:19:35 -0700 http://trac.webkit.org/changeset/58685 might have broken GTK Linux 32-bit Release 220222 5 eric 2010-05-03 11:50:31 -0700 Reverted r58685 for reason: Broke a test on Gtk Committed r58690: <http://trac.webkit.org/changeset/58690> 220225 6 54926 eric 2010-05-03 11:52:22 -0700 Comment on attachment 54926 proposed patch r- as this was rolled out. I suspect it just needed a Gtk test update. However Phillipe seemed unsure, so I went ahead and rolled it out to re-green the tree while he and Eric decide the proper course of action. 225217 7 pnormand 2010-05-13 02:49:54 -0700 This patch was wrong indeed. durationchanged was emitted but the duration() result didn't actually change. The if changed by the patch is meant to cache the duration in a private member. BTW I noticed we could do that step when the player enters to PAUSED, it would spare some uneeded queries between PAUSED->PLAYING. Will open a new bug for this :) 54926 2010-05-03 07:42:32 -0700 2010-05-03 11:52:22 -0700 proposed patch proposed-patch.patch text/plain 1862 pnormand RnJvbSAxNWFiYjNiODU2MDk3OGE1OTlhMjQ1MjU5NThhZTdmYTBjNTUwZDEwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBNb24sIDMgTWF5IDIwMTAgMTY6NDA6NDYgKzAyMDAKU3ViamVjdDogW1BBVENIXSBw cm9wb3NlZCBwYXRjaAoKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB8ICAgMTIgKysrKysrKysrKysrCiAuLi4vZ3N0cmVhbWVyL01lZGlhUGxh eWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgICAgICB8ICAgIDQgKysrLQogMiBmaWxlcyBjaGFuZ2Vk LCAxNSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUv Q2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTE3MmY2ZS4uYjRkMWZiMSAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxMC0wNS0wMyAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxp YS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg W0dTdHJlYW1lcl0gZm9yZ290dGVuIGNhbGwgdG8gZHVyYXRpb25DaGFuZ2VkIGluIHVwZGF0ZVN0 YXRlcygpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z ODQ2MQorCisgICAgICAgIE5vdGlmeSBNZWRpYVBsYXllciBpZiBkdXJhdGlvbiBpcyBrbm93biBh ZnRlciBwbGF5YmFjayBzdGFydGVkLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0 cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6OnVwZGF0ZVN0YXRlcyk6CisKIDIwMTAtMDUt MDMgIEphbm5lIEtvc2tpbmVuICA8amFubmUucC5rb3NraW5lbkBkaWdpYS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwIGIv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0 cmVhbWVyLmNwcAppbmRleCA4ZjZjOWUwLi42N2NlMmI1IDEwMDY0NAotLS0gYS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3Bw CisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lci5jcHAKQEAgLTg4Nyw4ICs4ODcsMTAgQEAgdm9pZCBNZWRpYVBsYXllclBy aXZhdGVHU3RyZWFtZXI6OnVwZGF0ZVN0YXRlcygpCiAgICAgICAgICAgICBpZiAoIW1fbWVkaWFE dXJhdGlvbikgewogICAgICAgICAgICAgICAgIGZsb2F0IG5ld0R1cmF0aW9uID0gZHVyYXRpb24o KTsKICAgICAgICAgICAgICAgICBtX21lZGlhRHVyYXRpb25Lbm93biA9ICFpc2luZihuZXdEdXJh dGlvbik7Ci0gICAgICAgICAgICAgICAgaWYgKG1fbWVkaWFEdXJhdGlvbktub3duKQorICAgICAg ICAgICAgICAgIGlmIChtX21lZGlhRHVyYXRpb25Lbm93bikgewogICAgICAgICAgICAgICAgICAg ICBtX21lZGlhRHVyYXRpb24gPSBuZXdEdXJhdGlvbjsKKyAgICAgICAgICAgICAgICAgICAgZHVy YXRpb25DaGFuZ2VkKCk7CisgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgfQogCiAgICAg ICAgICAgICBpZiAobV9idWZmZXJpbmcpIHsKLS0gCjEuNi4zLjM=