38455 2010-05-03 05:46:42 -0700 Does not work on SPARC because of alignment issues 2010-05-07 08:20:43 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 gustavo webkit-unassigned bkoehm cjerdonek commit-queue webkit.review.bot oldest_to_newest 220065 0 gustavo 2010-05-03 05:46:42 -0700 When running a simple WebKit-based tool that generates GObject introspection files (this is part of the build process), the program crashes with a SIGBUS in pageheap_memory. Mike Hommey from Debian has a patch to fix this issue. 220066 1 54918 gustavo 2010-05-03 05:49:40 -0700 Created attachment 54918 patch from Debian Mike Hommey sent this patch to me. I took the liberty of doing the changelogging for him. 220067 2 webkit.review.bot 2010-05-03 05:51:15 -0700 Attachment 54918 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 JavaScriptCore/wtf/FastMalloc.cpp:2332: pageheap_memory is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style. 220118 3 54918 darin 2010-05-03 08:25:08 -0700 Comment on attachment 54918 patch from Debian This should use AllocAlignementInteger rather than uint64_t. 220172 4 54938 gustavo 2010-05-03 10:35:01 -0700 Created attachment 54938 patch suggested by Darin Here it is! 220175 5 webkit.review.bot 2010-05-03 10:35:48 -0700 Attachment 54938 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 JavaScriptCore/wtf/FastMalloc.cpp:2332: pageheap_memory is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style. 220449 6 54938 commit-queue 2010-05-03 21:11:55 -0700 Comment on attachment 54938 patch suggested by Darin Rejecting patch 54938 from commit-queue. Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html 220486 7 cjerdonek 2010-05-03 23:21:34 -0700 (In reply to comment #6) > (From update of attachment 54938 [details]) > Rejecting patch 54938 from commit-queue. > > Found no modified ChangeLogs, cannot create a commit message. > All changes require a ChangeLog. See: > http://webkit.org/coding/contributing.html This should work now if you cq+ it again. There was a regression in svn-apply that affected e-mailed diffs: https://bugs.webkit.org/show_bug.cgi?id=38507 220565 8 gustavo 2010-05-04 05:34:52 -0700 Landed manually as r58753. 221746 9 bkoehm 2010-05-06 09:46:11 -0700 I was observing this problem on Solaris 10 x86_64 as well, and I can confirm r58753 fixes the problem on x86_64. 222387 10 gustavo 2010-05-07 08:20:43 -0700 (In reply to comment #9) > I was observing this problem on Solaris 10 x86_64 as well, and I can confirm > r58753 fixes the problem on x86_64. Great news! =) 54918 2010-05-03 05:49:40 -0700 2010-05-03 10:35:01 -0700 patch from Debian 0001-Use-uint64_t-instead-of-void.patch text/plain 1638 gustavo RnJvbSAwMzBjMmZlMWNjMzkxY2UyMjIzMWZmMThjMmEyMDU5ZDFiMzg5NDNkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGduc0Bnbm9tZS5vcmc+ CkRhdGU6IE1vbiwgMyBNYXkgMjAxMCAwOTo0ODo1MCAtMDMwMApTdWJqZWN0OiBbUEFUQ0hdIFVz ZSB1aW50NjRfdCBpbnN0ZWFkIG9mIHZvaWQqCgotLS0KIEphdmFTY3JpcHRDb3JlL0NoYW5nZUxv ZyAgICAgICAgICB8ICAgMTIgKysrKysrKysrKysrCiBKYXZhU2NyaXB0Q29yZS93dGYvRmFzdE1h bGxvYy5jcHAgfCAgICAyICstCiAyIGZpbGVzIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDEg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDdhZGNhYzYuLjBiZTBiYTMgMTAwNjQ0Ci0tLSBh L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNS0wMyAgTWlrZSBIb21tZXkgIDxtaEBnbGFuZGl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG9l cyBub3Qgd29yayBvbiBTUEFSQyBiZWNhdXNlIG9mIGFsaWdubWVudCBpc3N1ZXMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4NDU1CisKKyAgICAgICAg QXZvaWQgY3Jhc2hpbmcgaW4gcnVudGltZSBieSB1c2luZyB0aGUgZml4ZWQtc2l6ZSB1aW50NjRf dCBpbnN0ZWFkCisgICAgICAgIG9mIHZvaWQqLgorCisgICAgICAgICogd3RmL0Zhc3RNYWxsb2Mu Y3BwOgorCiAyMDEwLTA1LTAyICBMYXN6bG8gR29tYm9zICA8bGFzemxvLjEuZ29tYm9zQG5va2lh LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL0ph dmFTY3JpcHRDb3JlL3d0Zi9GYXN0TWFsbG9jLmNwcCBiL0phdmFTY3JpcHRDb3JlL3d0Zi9GYXN0 TWFsbG9jLmNwcAppbmRleCBhNjc0MzhkLi5lMjFlNmQ5IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0 Q29yZS93dGYvRmFzdE1hbGxvYy5jcHAKKysrIGIvSmF2YVNjcmlwdENvcmUvd3RmL0Zhc3RNYWxs b2MuY3BwCkBAIC0yMzI5LDcgKzIzMjksNyBAQCBzdGF0aWMgVENNYWxsb2NfQ2VudHJhbF9GcmVl TGlzdFBhZGRlZCBjZW50cmFsX2NhY2hlW2tOdW1DbGFzc2VzXTsKIAogLy8gUGFnZS1sZXZlbCBh bGxvY2F0b3IKIHN0YXRpYyBTcGluTG9jayBwYWdlaGVhcF9sb2NrID0gU1BJTkxPQ0tfSU5JVElB TElaRVI7Ci1zdGF0aWMgdm9pZCogcGFnZWhlYXBfbWVtb3J5WyhzaXplb2YoVENNYWxsb2NfUGFn ZUhlYXApICsgc2l6ZW9mKHZvaWQqKSAtIDEpIC8gc2l6ZW9mKHZvaWQqKV07CitzdGF0aWMgdWlu dDY0X3QgcGFnZWhlYXBfbWVtb3J5WyhzaXplb2YoVENNYWxsb2NfUGFnZUhlYXApICsgc2l6ZW9m KHVpbnQ2NF90KSAtIDEpIC8gc2l6ZW9mKHVpbnQ2NF90KV07CiBzdGF0aWMgYm9vbCBwaGluaXRl ZCA9IGZhbHNlOwogCiAvLyBBdm9pZCBleHRyYSBsZXZlbCBvZiBpbmRpcmVjdGlvbiBieSBtYWtp bmcgInBhZ2VoZWFwIiBiZSBqdXN0IGFuIGFsaWFzCi0tIAoxLjcuMQoK 54938 2010-05-03 10:35:01 -0700 2010-05-03 21:11:55 -0700 patch suggested by Darin 0001-Use-AllocAlignmentInteger-instead-of-void.patch text/plain 1843 gustavo RnJvbSA4MmNjMjY1MTA2NjJjNjE0NjZhOGUyNTRmOTAwMjM2NjhlMmIwN2Y0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGduc0Bnbm9tZS5vcmc+ CkRhdGU6IE1vbiwgMyBNYXkgMjAxMCAwOTo0ODo1MCAtMDMwMApTdWJqZWN0OiBbUEFUQ0hdIFVz ZSBBbGxvY0FsaWdubWVudEludGVnZXIgaW5zdGVhZCBvZiB2b2lkKgoKLS0tCiBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgICAgICAgICAgfCAgIDEzICsrKysrKysrKysrKysKIEphdmFTY3JpcHRD b3JlL3d0Zi9GYXN0TWFsbG9jLmNwcCB8ICAgIDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTQgaW5z ZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9D aGFuZ2VMb2cgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggN2FkY2FjNi4uNzkwNTk0 YiAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEwLTA1LTAzICBHdXN0YXZvIE5vcm9u aGEgU2lsdmEgIDxndXN0YXZvLm5vcm9uaGFAY29sbGFib3JhLmNvLnVrPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvZXMgbm90IHdvcmsgb24gU1BB UkMgYmVjYXVzZSBvZiBhbGlnbm1lbnQgaXNzdWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODQ1NQorCisgICAgICAgIFVzZSBBbGxvY0FsaWdubWVu dEludGVnZXIgaW5zdGVhZCBvZiB2b2lkKiBvbiBwYWdlaGVhcF9tZW1vcnkgdG8KKyAgICAgICAg YXZvaWQgY3Jhc2hpbmcgYXQgcnVudGltZSBpbiBzb21lIGFyY2hpdGVjdHVyZXMuIEludmVzdGln YXRlZCBieQorICAgICAgICBNaWtlIEhvbW1leSA8bWhAZ2xhbmRpdW0ub3JnPiwgY2hhbmdlIHN1 Z2dlc3RlZCBieSBEYXJpbiBBZGxlci4KKworICAgICAgICAqIHd0Zi9GYXN0TWFsbG9jLmNwcDoK KwogMjAxMC0wNS0wMiAgTGFzemxvIEdvbWJvcyAgPGxhc3psby4xLmdvbWJvc0Bub2tpYS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9KYXZhU2Ny aXB0Q29yZS93dGYvRmFzdE1hbGxvYy5jcHAgYi9KYXZhU2NyaXB0Q29yZS93dGYvRmFzdE1hbGxv Yy5jcHAKaW5kZXggYTY3NDM4ZC4uOTEzZmEwNiAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUv d3RmL0Zhc3RNYWxsb2MuY3BwCisrKyBiL0phdmFTY3JpcHRDb3JlL3d0Zi9GYXN0TWFsbG9jLmNw cApAQCAtMjMyOSw3ICsyMzI5LDcgQEAgc3RhdGljIFRDTWFsbG9jX0NlbnRyYWxfRnJlZUxpc3RQ YWRkZWQgY2VudHJhbF9jYWNoZVtrTnVtQ2xhc3Nlc107CiAKIC8vIFBhZ2UtbGV2ZWwgYWxsb2Nh dG9yCiBzdGF0aWMgU3BpbkxvY2sgcGFnZWhlYXBfbG9jayA9IFNQSU5MT0NLX0lOSVRJQUxJWkVS Owotc3RhdGljIHZvaWQqIHBhZ2VoZWFwX21lbW9yeVsoc2l6ZW9mKFRDTWFsbG9jX1BhZ2VIZWFw KSArIHNpemVvZih2b2lkKikgLSAxKSAvIHNpemVvZih2b2lkKildOworc3RhdGljIEFsbG9jQWxp Z25tZW50SW50ZWdlciBwYWdlaGVhcF9tZW1vcnlbKHNpemVvZihUQ01hbGxvY19QYWdlSGVhcCkg KyBzaXplb2YoQWxsb2NBbGlnbm1lbnRJbnRlZ2VyKSAtIDEpIC8gc2l6ZW9mKEFsbG9jQWxpZ25t ZW50SW50ZWdlcildOwogc3RhdGljIGJvb2wgcGhpbml0ZWQgPSBmYWxzZTsKIAogLy8gQXZvaWQg ZXh0cmEgbGV2ZWwgb2YgaW5kaXJlY3Rpb24gYnkgbWFraW5nICJwYWdlaGVhcCIgYmUganVzdCBh biBhbGlhcwotLSAKMS43LjEKCg==