38449 2010-05-02 23:34:41 -0700 Web Inspector: build-webkit --inspector-frontend Should Exclude *.re2js 2010-05-06 00:05:24 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 joepeck webkit-unassigned bweinstein commit-queue joepeck keishi pfeldman pmuellr rik timothy yurys oldest_to_newest 220027 0 joepeck 2010-05-02 23:34:41 -0700 The *.re2js files are preprocessed to produce their *.js counterparts. There is no need for them to be copied when building. 220029 1 54906 joepeck 2010-05-02 23:36:16 -0700 Created attachment 54906 [PATCH] Proposed Fix Also, the localizedStrings file might be useful to copy over, seeing as it is used by the Inspector. 220034 2 54907 joepeck 2010-05-02 23:55:37 -0700 Created attachment 54907 [DRAFT] Copy localizedStrings.js for Mac OS X This is not up for review that copies over the localizedStrings.js file for OS X systems. Anyone know where it goes for Windows and other platforms? Maybe then it would be worth landing? 221220 3 54906 pfeldman 2010-05-05 12:09:12 -0700 Comment on attachment 54906 [PATCH] Proposed Fix Should we move re2js files out of the folder longer term? 221446 4 joepeck 2010-05-05 19:39:25 -0700 (In reply to comment #3) > (From update of attachment 54906 [details]) > Should we move re2js files out of the folder longer term? Maybe move them into WebCore/inspector instead of WebCore/inspector/front-end? 221457 5 timothy 2010-05-05 20:58:38 -0700 I think staying in WebCore/inspector/front-end is fine, it keeps them next to the generated version. 221532 6 54906 commit-queue 2010-05-06 00:05:18 -0700 Comment on attachment 54906 [PATCH] Proposed Fix Clearing flags on attachment: 54906 Committed r58868: <http://trac.webkit.org/changeset/58868> 221533 7 commit-queue 2010-05-06 00:05:24 -0700 All reviewed patches have been landed. Closing bug. 54906 2010-05-02 23:36:16 -0700 2010-05-06 00:05:17 -0700 [PATCH] Proposed Fix build.patch text/plain 1258 joepeck ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBhNGE5MWY4Li5jYmEyNDVkIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDUt MDIgIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBidWlsZC13 ZWJraXQgLS1pbnNwZWN0b3ItZnJvbnRlbmQgU2hvdWxkIEV4Y2x1ZGUgKi5yZTJqcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg0NDkKKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKwogMjAxMC0wNC0yOCAgQ2hyaXMgSmVyZG9uZWsg IDxjamVyZG9uZWtAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW5pZWwgQmF0 ZXMuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9XZWJL aXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggNmYzY2E5Ni4uNGZlY2Y2YiAxMDA2 NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1dlYktpdFRv b2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQpAQCAtMTA5OCw3ICsxMDk4LDcgQEAgc3ViIGNvcHlJ bnNwZWN0b3JGcm9udGVuZEZpbGVzCiAgICAgICAgIHByaW50ICIqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqXG4iOwogICAgICAgICBk aWU7CiAgICAgfQotICAgIHJldHVybiBzeXN0ZW0gInJzeW5jIiwgIi1hdXQiLCAiLS1leGNsdWRl PS8uRFNfU3RvcmUiLCAiLS1leGNsdWRlPS5zdm4vIiwgIWlzUXQoKSA/ICItLWV4Y2x1ZGU9L1dl YktpdC5xcmMiIDogIiIsICRzb3VyY2VJbnNwZWN0b3JQYXRoLCAkaW5zcGVjdG9yUmVzb3VyY2Vz RGlyUGF0aDsKKyAgICByZXR1cm4gc3lzdGVtICJyc3luYyIsICItYXV0IiwgIi0tZXhjbHVkZT0v LkRTX1N0b3JlIiwgIi0tZXhjbHVkZT0qLnJlMmpzIiwgIi0tZXhjbHVkZT0uc3ZuLyIsICFpc1F0 KCkgPyAiLS1leGNsdWRlPS9XZWJLaXQucXJjIiA6ICIiLCAkc291cmNlSW5zcGVjdG9yUGF0aCwg JGluc3BlY3RvclJlc291cmNlc0RpclBhdGg7CiB9CiAKIHN1YiBidWlsZFhDb2RlUHJvamVjdCgk JEApCg== 54907 2010-05-02 23:55:37 -0700 2010-05-02 23:55:37 -0700 [DRAFT] Copy localizedStrings.js for Mac OS X localized.patch text/plain 2464 joepeck ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBhNGE5MWY4Li43NWVmY2U5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDUt MDIgIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBidWlsZC13 ZWJraXQgLS1pbnNwZWN0b3ItZnJvbnRlbmQgU2hvdWxkIEV4Y2x1ZGUgKi5yZTJqcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg0NDkKKworICAgICAg ICBUaGlzIGFsc28gYXR0ZW1wdHMgdG8gY29weSBvdmVyIHRoZSBsb2NhbGl6ZWRTdHJpbmdzLmpz IGZpbGUgZm9yCisgICAgICAgIE1hYyBPUyBYIHBsYXRmb3Jtcy4KKworICAgICAgICAqIFNjcmlw dHMvd2Via2l0ZGlycy5wbToKKwogMjAxMC0wNC0yOCAgQ2hyaXMgSmVyZG9uZWsgIDxjamVyZG9u ZWtAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW5pZWwgQmF0ZXMuCmRpZmYg LS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9XZWJLaXRUb29scy9T Y3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggNmYzY2E5Ni4uMTlhNjE4OSAxMDA2NDQKLS0tIGEv V2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1dlYktpdFRvb2xzL1Njcmlw dHMvd2Via2l0ZGlycy5wbQpAQCAtMTA3MCw3ICsxMDcwLDkgQEAgc3ViIGNvcHlJbnNwZWN0b3JG cm9udGVuZEZpbGVzCiB7CiAgICAgbXkgJHByb2R1Y3REaXIgPSBwcm9kdWN0RGlyKCk7CiAgICAg bXkgJHNvdXJjZUluc3BlY3RvclBhdGggPSBzb3VyY2VEaXIoKSAuICIvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kLyI7CisgICAgbXkgJGxvY2FsaXplZFN0cmluZ3NQYXRoID0gc291cmNlRGly KCkgLiAiL1dlYkNvcmUvRW5nbGlzaC5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzIjsKICAgICBt eSAkaW5zcGVjdG9yUmVzb3VyY2VzRGlyUGF0aCA9ICRFTlZ7IldFQktJVElOU1BFQ1RPUlJFU09V UkNFU0RJUiJ9OworICAgIG15ICRsb2NhbGl6ZWRTdHJpbmdzRGVzdGluYXRpb24gPSAiIjsKIAog ICAgIGlmICghZGVmaW5lZCgkaW5zcGVjdG9yUmVzb3VyY2VzRGlyUGF0aCkpIHsKICAgICAgICAg JGluc3BlY3RvclJlc291cmNlc0RpclBhdGggPSAiIjsKQEAgLTEwNzgsNiArMTA4MCw3IEBAIHN1 YiBjb3B5SW5zcGVjdG9yRnJvbnRlbmRGaWxlcwogCiAgICAgaWYgKGlzQXBwbGVNYWNXZWJLaXQo KSkgewogICAgICAgICAkaW5zcGVjdG9yUmVzb3VyY2VzRGlyUGF0aCA9ICRwcm9kdWN0RGlyIC4g Ii9XZWJDb3JlLmZyYW1ld29yay9SZXNvdXJjZXMvaW5zcGVjdG9yIjsKKyAgICAgICAgJGxvY2Fs aXplZFN0cmluZ3NEZXN0aW5hdGlvbiA9ICRwcm9kdWN0RGlyIC4gIi9XZWJDb3JlLmZyYW1ld29y ay9SZXNvdXJjZXMvRW5nbGlzaC5scHJvaiI7CiAgICAgfSBlbHNpZiAoaXNBcHBsZVdpbldlYktp dCgpKSB7CiAgICAgICAgICRpbnNwZWN0b3JSZXNvdXJjZXNEaXJQYXRoID0gJHByb2R1Y3REaXIg LiAiL1dlYktpdC5yZXNvdXJjZXMvaW5zcGVjdG9yIjsKICAgICB9IGVsc2lmIChpc1F0KCkgfHwg aXNHdGsoKSkgewpAQCAtMTA5OCw3ICsxMTAxLDEzIEBAIHN1YiBjb3B5SW5zcGVjdG9yRnJvbnRl bmRGaWxlcwogICAgICAgICBwcmludCAiKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKlxuIjsKICAgICAgICAgZGllOwogICAgIH0KLSAg ICByZXR1cm4gc3lzdGVtICJyc3luYyIsICItYXV0IiwgIi0tZXhjbHVkZT0vLkRTX1N0b3JlIiwg Ii0tZXhjbHVkZT0uc3ZuLyIsICFpc1F0KCkgPyAiLS1leGNsdWRlPS9XZWJLaXQucXJjIiA6ICIi LCAkc291cmNlSW5zcGVjdG9yUGF0aCwgJGluc3BlY3RvclJlc291cmNlc0RpclBhdGg7CisKKyAg ICBpZiAoLWQgJGxvY2FsaXplZFN0cmluZ3NEZXN0aW5hdGlvbikgeworICAgICAgICBzeXN0ZW0g ImNwIiwgJGxvY2FsaXplZFN0cmluZ3NQYXRoLCAkbG9jYWxpemVkU3RyaW5nc0Rlc3RpbmF0aW9u OworICAgICAgICBwcmludCAiRmFpbGVkIHRvIGNvcHkgb3ZlciBsb2NhbGl6ZWRTdHJpbmdzLmpz LiIgaWYgJD8KKyAgICB9CisKKyAgICByZXR1cm4gc3lzdGVtICJyc3luYyIsICItYXV0IiwgIi0t ZXhjbHVkZT0vLkRTX1N0b3JlIiwgIi0tZXhjbHVkZT0qLnJlMmpzIiwgIi0tZXhjbHVkZT0uc3Zu LyIsICFpc1F0KCkgPyAiLS1leGNsdWRlPS9XZWJLaXQucXJjIiA6ICIiLCAkc291cmNlSW5zcGVj dG9yUGF0aCwgJGluc3BlY3RvclJlc291cmNlc0RpclBhdGg7CiB9CiAKIHN1YiBidWlsZFhDb2Rl UHJvamVjdCgkJEApCg==