38445 2010-05-02 20:47:26 -0700 REGRESSION: Infinite recursion in Position::getInlineBoxAndOffset() 2010-05-02 21:26:21 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All All RESOLVED FIXED InRadar, Regression P1 Normal --- 1 mitz webkit-unassigned oldest_to_newest 220003 0 mitz 2010-05-02 20:47:26 -0700 Another case of <rdar://problem/7552959>. Patch forthcoming. 220006 1 54901 mitz 2010-05-02 21:04:27 -0700 Created attachment 54901 Patch 220011 2 54901 simon.fraser 2010-05-02 21:13:33 -0700 Comment on attachment 54901 Patch > Index: WebCore/ChangeLog > =================================================================== > + possible, crossing any editability boudaries. Infinite recursion is avoided by advancing all the way Typo: "boudaries" > Index: WebCore/dom/Position.cpp > =================================================================== > +static Position downstreamIgnoringEditingBoundaries(Position position) Should this take a const Position&? > +static Position upstreamIgnoringEditingBoundaries(Position position) Ditto WebCore/ChangeLog:18 + test for buttons with the generic and more comprehensive canHaveChildrenForEditing(). Does this part of the change need its own testcase? r=me 220014 3 mitz 2010-05-02 21:20:56 -0700 (In reply to comment #2) > > +static Position downstreamIgnoringEditingBoundaries(Position position) > > Should this take a const Position&? It’d have to be copied anyway, and this was easier to write. > + test for buttons with the generic and more comprehensive > canHaveChildrenForEditing(). > > Does this part of the change need its own testcase? Existing tests crash without it. Thanks for the review! 220017 4 mitz 2010-05-02 21:26:21 -0700 Fixed in <http://trac.webkit.org/projects/webkit/changeset/58665>. 54901 2010-05-02 21:04:27 -0700 2010-05-02 21:13:33 -0700 Patch 7552959_r1.diff text/plain 6820 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1ODY2NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTAtMDUtMDIgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbm90 aGVyIGNhc2Ugb2YgPHJkYXI6Ly9wcm9ibGVtLzc1NTI5NTk+IFJFR1JFU1NJT046IEluZmluaXRl IHJlY3Vyc2lvbiBpbiBQb3NpdGlvbjo6Z2V0SW5saW5lQm94QW5kT2Zmc2V0KCkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4NDQ1CisKKyAgICAgICAg VGVzdDogZWRpdGluZy9zZWxlY3Rpb24vbWl4ZWQtZWRpdGFiaWxpdHktMTEuaHRtbAorCisgICAg ICAgICogZG9tL1Bvc2l0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmRvd25zdHJlYW1JZ25v cmluZ0VkaXRpbmdCb3VuZGFyaWVzKTogQWRkZWQuIFJldHVybnMgdGhlIGZ1cnRoZXN0IHZpc3Vh bGx5IGVxdWl2YWxlbnQKKyAgICAgICAgcG9zaXRpb24gZG93bnN0cmVhbSwgY3Jvc3NpbmcgYW55 IGVkaXRhYmlsaXR5IGJvdW5kYXJpZXMuCisgICAgICAgIChXZWJDb3JlOjp1cHN0cmVhbUlnbm9y aW5nRWRpdGluZ0JvdW5kYXJpZXMpOiBTaW1pbGFybHkgZm9yIHVwc3RyZWFtLgorICAgICAgICAo V2ViQ29yZTo6UG9zaXRpb246OmdldElubGluZUJveEFuZE9mZnNldCk6IENoYW5nZWQgdGhlIGxv Z2ljIGZvciBmaW5kaW5nIGFuIGlubGluZSBib3ggZm9yIHBvc2l0aW9ucworICAgICAgICB3aG9z ZSBub2RlIGlzIGEgYmxvY2sgZmxvdy4gSW5zdGVhZCBvZiB0cmF2ZXJzaW5nIHRoZSBET00sIGFk dmFuY2UgZG93bnN0cmVhbSBvciB1cHN0cmVhbSBhcyBmYXIgYXMKKyAgICAgICAgcG9zc2libGUs IGNyb3NzaW5nIGFueSBlZGl0YWJpbGl0eSBib3VkYXJpZXMuIEluZmluaXRlIHJlY3Vyc2lvbiBp cyBhdm9pZGVkIGJ5IGFkdmFuY2luZyBhbGwgdGhlIHdheQorICAgICAgICBhbmQgY2hlY2tpbmcg dGhhdCB0aGUgbmV3IHBvc2l0aW9uIGlzIGRpZmZlcmVudCBmcm9tIHRoZSBzdGFydGluZyBwb3Np dGlvbi4gQWxzbyByZXBsYWNlZCB0aGUgc3BlY2lmaWMKKyAgICAgICAgdGVzdCBmb3IgYnV0dG9u cyB3aXRoIHRoZSBnZW5lcmljIGFuZCBtb3JlIGNvbXByZWhlbnNpdmUgY2FuSGF2ZUNoaWxkcmVu Rm9yRWRpdGluZygpLgorCiAyMDEwLTA1LTAyICBUYXN1a3UgU3V6dWtpICA8dGFzdWt1LnN1enVr aUBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCkluZGV4 OiBXZWJDb3JlL2RvbS9Qb3NpdGlvbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9kb20vUG9z aXRpb24uY3BwCShyZXZpc2lvbiA1ODY1OCkKKysrIFdlYkNvcmUvZG9tL1Bvc2l0aW9uLmNwcAko d29ya2luZyBjb3B5KQpAQCAtOTg2LDI3ICs5ODYsNDYgQEAgc3RhdGljIElubGluZVRleHRCb3gq IHNlYXJjaEFoZWFkRm9yQmV0dAogICAgIHJldHVybiAwOwogfQogCitzdGF0aWMgUG9zaXRpb24g ZG93bnN0cmVhbUlnbm9yaW5nRWRpdGluZ0JvdW5kYXJpZXMoUG9zaXRpb24gcG9zaXRpb24pCit7 CisgICAgUG9zaXRpb24gbGFzdFBvc2l0aW9uOworICAgIHdoaWxlIChwb3NpdGlvbiAhPSBsYXN0 UG9zaXRpb24pIHsKKyAgICAgICAgbGFzdFBvc2l0aW9uID0gcG9zaXRpb247CisgICAgICAgIHBv c2l0aW9uID0gcG9zaXRpb24uZG93bnN0cmVhbShQb3NpdGlvbjo6Q2FuQ3Jvc3NFZGl0aW5nQm91 bmRhcnkpOworICAgIH0KKyAgICByZXR1cm4gcG9zaXRpb247Cit9CisKK3N0YXRpYyBQb3NpdGlv biB1cHN0cmVhbUlnbm9yaW5nRWRpdGluZ0JvdW5kYXJpZXMoUG9zaXRpb24gcG9zaXRpb24pCit7 CisgICAgUG9zaXRpb24gbGFzdFBvc2l0aW9uOworICAgIHdoaWxlIChwb3NpdGlvbiAhPSBsYXN0 UG9zaXRpb24pIHsKKyAgICAgICAgbGFzdFBvc2l0aW9uID0gcG9zaXRpb247CisgICAgICAgIHBv c2l0aW9uID0gcG9zaXRpb24udXBzdHJlYW0oUG9zaXRpb246OkNhbkNyb3NzRWRpdGluZ0JvdW5k YXJ5KTsKKyAgICB9CisgICAgcmV0dXJuIHBvc2l0aW9uOworfQorCiB2b2lkIFBvc2l0aW9uOjpn ZXRJbmxpbmVCb3hBbmRPZmZzZXQoRUFmZmluaXR5IGFmZmluaXR5LCBUZXh0RGlyZWN0aW9uIHBy aW1hcnlEaXJlY3Rpb24sIElubGluZUJveComIGlubGluZUJveCwgaW50JiBjYXJldE9mZnNldCkg Y29uc3QKIHsKICAgICBjYXJldE9mZnNldCA9IG1fb2Zmc2V0OwogICAgIFJlbmRlck9iamVjdCog cmVuZGVyZXIgPSBub2RlKCktPnJlbmRlcmVyKCk7Ci0gICAgICAgICAgCisKICAgICBpZiAoIXJl bmRlcmVyLT5pc1RleHQoKSkgewotICAgICAgICBpZiAoIXJlbmRlcmVyLT5pc1JlbmRlckJ1dHRv bigpICYmIHJlbmRlcmVyLT5pc0Jsb2NrRmxvdygpICYmIGhhc1JlbmRlcmVkTm9uQW5vbnltb3Vz RGVzY2VuZGFudHNXaXRoSGVpZ2h0KHJlbmRlcmVyKSkgewotICAgICAgICAgICAgYm9vbCBsYXN0 UG9zaXRpb24gPSBjYXJldE9mZnNldCA9PSBsYXN0T2Zmc2V0SW5Ob2RlKG5vZGUoKSk7Ci0gICAg ICAgICAgICBOb2RlKiBzdGFydE5vZGUgPSBsYXN0UG9zaXRpb24gPyBub2RlKCktPmNoaWxkTm9k ZShjYXJldE9mZnNldCAtIDEpIDogbm9kZSgpLT5jaGlsZE5vZGUoY2FyZXRPZmZzZXQpOwotICAg ICAgICAgICAgd2hpbGUgKHN0YXJ0Tm9kZSAmJiAoIXN0YXJ0Tm9kZS0+cmVuZGVyZXIoKSB8fCAo c3RhcnROb2RlLT5pc1RleHROb2RlKCkgJiYgdG9SZW5kZXJUZXh0KHN0YXJ0Tm9kZS0+cmVuZGVy ZXIoKSktPmlzQWxsQ29sbGFwc2libGVXaGl0ZXNwYWNlKCkpKSkKLSAgICAgICAgICAgICAgICBz dGFydE5vZGUgPSAobGFzdFBvc2l0aW9uKT8gc3RhcnROb2RlLT5wcmV2aW91c1NpYmxpbmcoKTog c3RhcnROb2RlLT5uZXh0U2libGluZygpOwotICAgICAgICAgICAgaWYgKHN0YXJ0Tm9kZSkgewot ICAgICAgICAgICAgICAgIFBvc2l0aW9uIHBvcyhzdGFydE5vZGUsIDApOwotICAgICAgICAgICAg ICAgIHBvcyA9IHBvcy5kb3duc3RyZWFtKENhbkNyb3NzRWRpdGluZ0JvdW5kYXJ5KTsKLSAgICAg ICAgICAgICAgICBwb3MuZ2V0SW5saW5lQm94QW5kT2Zmc2V0KFVQU1RSRUFNLCBwcmltYXJ5RGly ZWN0aW9uLCBpbmxpbmVCb3gsIGNhcmV0T2Zmc2V0KTsKLSAgICAgICAgICAgICAgICBpZiAobGFz dFBvc2l0aW9uICYmIGlubGluZUJveCkKLSAgICAgICAgICAgICAgICAgICAgY2FyZXRPZmZzZXQg PSBpbmxpbmVCb3gtPmNhcmV0TWF4T2Zmc2V0KCk7CisgICAgICAgIGlubGluZUJveCA9IDA7Cisg ICAgICAgIGlmIChjYW5IYXZlQ2hpbGRyZW5Gb3JFZGl0aW5nKG5vZGUoKSkgJiYgcmVuZGVyZXIt PmlzQmxvY2tGbG93KCkgJiYgaGFzUmVuZGVyZWROb25Bbm9ueW1vdXNEZXNjZW5kYW50c1dpdGhI ZWlnaHQocmVuZGVyZXIpKSB7CisgICAgICAgICAgICAvLyBUcnkgYSB2aXN1YWxseSBlcXVpdmFs ZW50IHBvc2l0aW9uIHdpdGggcG9zc2libHkgb3Bwb3NpdGUgZWRpdGFiaWxpdHkuIFRoaXMgaGVs cHMgaW4gY2FzZSB8dGhpc3wgaXMgaW4KKyAgICAgICAgICAgIC8vIGFuIGVkaXRhYmxlIGJsb2Nr IGJ1dCBzdXJyb3VuZGVkIGJ5IG5vbi1lZGl0YWJsZSBwb3NpdGlvbnMuIEl0IGFjdHMgdG8gbmVn YXRlIHRoZSBsb2dpYyBhdCB0aGUgYmVnaW5uaW5nCisgICAgICAgICAgICAvLyBvZiBSZW5kZXJP YmplY3Q6OmNyZWF0ZVZpc2libGVQb3NpdGlvbigpLgorICAgICAgICAgICAgUG9zaXRpb24gZXF1 aXZhbGVudCA9IGRvd25zdHJlYW1JZ25vcmluZ0VkaXRpbmdCb3VuZGFyaWVzKCp0aGlzKTsKKyAg ICAgICAgICAgIGlmIChlcXVpdmFsZW50ID09ICp0aGlzKQorICAgICAgICAgICAgICAgIGVxdWl2 YWxlbnQgPSB1cHN0cmVhbUlnbm9yaW5nRWRpdGluZ0JvdW5kYXJpZXMoKnRoaXMpOworICAgICAg ICAgICAgaWYgKGVxdWl2YWxlbnQgPT0gKnRoaXMpCiAgICAgICAgICAgICAgICAgcmV0dXJuOwot ICAgICAgICAgICAgfQorCisgICAgICAgICAgICBlcXVpdmFsZW50LmdldElubGluZUJveEFuZE9m ZnNldChVUFNUUkVBTSwgcHJpbWFyeURpcmVjdGlvbiwgaW5saW5lQm94LCBjYXJldE9mZnNldCk7 CisgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KLSAgICAgICAgaW5saW5lQm94ID0gMDsK ICAgICAgICAgaWYgKHJlbmRlcmVyLT5pc0JveCgpKSB7CiAgICAgICAgICAgICBpbmxpbmVCb3gg PSB0b1JlbmRlckJveChyZW5kZXJlciktPmlubGluZUJveFdyYXBwZXIoKTsKICAgICAgICAgICAg IGlmICghaW5saW5lQm94IHx8IChjYXJldE9mZnNldCA+IGlubGluZUJveC0+Y2FyZXRNaW5PZmZz ZXQoKSAmJiBjYXJldE9mZnNldCA8IGlubGluZUJveC0+Y2FyZXRNYXhPZmZzZXQoKSkpCkluZGV4 OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCShyZXZpc2lvbiA1ODY2NCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBj b3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEwLTA1LTAyICBEYW4gQmVybnN0ZWluICA8bWl0ekBh cHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQW5vdGhlciBjYXNlIG9mIDxyZGFyOi8vcHJvYmxlbS83NTUyOTU5PiBSRUdSRVNTSU9OOiBJ bmZpbml0ZSByZWN1cnNpb24gaW4gUG9zaXRpb246OmdldElubGluZUJveEFuZE9mZnNldCgpCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODQ0NQorCisg ICAgICAgICogZWRpdGluZy9zZWxlY3Rpb24vbWl4ZWQtZWRpdGFiaWxpdHktMTEtZXhwZWN0ZWQu dHh0OiBBZGRlZC4KKyAgICAgICAgKiBlZGl0aW5nL3NlbGVjdGlvbi9taXhlZC1lZGl0YWJpbGl0 eS0xMS5odG1sOiBBZGRlZC4KKwogMjAxMC0wNS0wMiAgRGlyayBTY2h1bHplICA8a3JpdEB3ZWJr aXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5pa29sYXMgWmltbWVybWFubi4KSW5kZXg6 IExheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL21peGVkLWVkaXRhYmlsaXR5LTExLWV4cGVj dGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9taXhl ZC1lZGl0YWJpbGl0eS0xMS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0 cy9lZGl0aW5nL3NlbGVjdGlvbi9taXhlZC1lZGl0YWJpbGl0eS0xMS1leHBlY3RlZC50eHQJKHJl dmlzaW9uIDApCkBAIC0wLDAgKzEsMyBAQAorVGVzdCBmb3IgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTM4NDQ1IGFub3RoZXIgY2FzZSBvZiByZGFyOi8vcHJvYmxlbS83 NTUyOTU5IFJFR1JFU1NJT046IEluZmluaXRlIHJlY3Vyc2lvbiBpbiBQb3NpdGlvbjo6Z2V0SW5s aW5lQm94QW5kT2Zmc2V0KCkuCisKK2VkaXRhYmxlCkluZGV4OiBMYXlvdXRUZXN0cy9lZGl0aW5n L3NlbGVjdGlvbi9taXhlZC1lZGl0YWJpbGl0eS0xMS5odG1sCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL21peGVkLWVkaXRhYmlsaXR5LTExLmh0bWwJKHJldmlz aW9uIDApCisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9taXhlZC1lZGl0YWJpbGl0 eS0xMS5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE1IEBACis8cD4KKyAgICBUZXN0IGZv ciA8YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg0NDUi Pmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODQ0NTwvYT4KKyAgICBh bm90aGVyIGNhc2Ugb2YgPGk+PGEgaHJlZj0icmRhcjovL3Byb2JsZW0vNzU1Mjk1OSI+cmRhcjov L3Byb2JsZW0vNzU1Mjk1OTwvYT4KKyAgICBSRUdSRVNTSU9OOiBJbmZpbml0ZSByZWN1cnNpb24g aW4gUG9zaXRpb246OmdldElubGluZUJveEFuZE9mZnNldCgpPC9pPi4KKzwvcD4KKzxkaXYgaWQ9 InRhcmdldCIgc3R5bGU9InRleHQtYWxpZ246IGNlbnRlcjsgLXdlYmtpdC11c2VyLW1vZGlmeTog cmVhZC13cml0ZSI+PHNwYW4gc3R5bGU9Ii13ZWJraXQtdXNlci1tb2RpZnk6IHJlYWQtb25seSI+ PC9zcGFuPmVkaXRhYmxlPHNwYW4gc3R5bGU9Ii13ZWJraXQtdXNlci1tb2RpZnk6IHJlYWQtb25s eSI+PC9zcGFuPjwvZGl2PgorPHNjcmlwdD4KKyAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250 cm9sbGVyKQorICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisKKyAg ICB2YXIgc2VsZWN0aW9uID0gZ2V0U2VsZWN0aW9uKCk7CisgICAgdmFyIHRhcmdldCA9IGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCJ0YXJnZXQiKTsKKyAgICBzZWxlY3Rpb24uc2V0QmFzZUFuZEV4 dGVudCh0YXJnZXQsIDMsIHRhcmdldCwgMyk7CisgICAgc2VsZWN0aW9uLnNldEJhc2VBbmRFeHRl bnQodGFyZ2V0LCAwLCB0YXJnZXQsIDApOworPC9zY3JpcHQ+Cg==