38441 2010-05-02 14:07:58 -0700 Web Inspector: Old Style trimWhitespace() should be trim() 2010-05-02 14:42:20 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 joepeck webkit-unassigned bweinstein commit-queue joepeck keishi pfeldman pmuellr rik timothy yurys oldest_to_newest 219897 0 joepeck 2010-05-02 14:07:58 -0700 Found an occurrence of trimWhitespace in SourceFrame. This would produce an error. It was removed in: Use String.trim() instead of a regex in the Web Inspector. http://trac.webkit.org/changeset/53366 It creeped back in with: Web Inspector: migrate from SourceFrame to SourceFrame2. http://trac.webkit.org/changeset/53941 219899 1 54890 joepeck 2010-05-02 14:15:59 -0700 Created attachment 54890 [PATCH] Simple Fix. I haven't actually tried to cause this to fail. I just did a simple code audit to see that the function didn't exist any more. It could be that this case isn't even reachable anymore. 219905 2 joepeck 2010-05-02 14:33:44 -0700 It looks like _evalSelectionInCallFrame is not called at all anymore? The popups cover the majority of the use cases. Should this feature be removed? If it is removed, keyboard shortcuts on the wiki will need to be updated. 219909 3 54890 commit-queue 2010-05-02 14:42:15 -0700 Comment on attachment 54890 [PATCH] Simple Fix. Clearing flags on attachment: 54890 Committed r58660: <http://trac.webkit.org/changeset/58660> 219910 4 commit-queue 2010-05-02 14:42:20 -0700 All reviewed patches have been landed. Closing bug. 54890 2010-05-02 14:15:59 -0700 2010-05-02 14:42:14 -0700 [PATCH] Simple Fix. fix.patch text/plain 1352 joepeck ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjYxYWUxOS4uMjIyMzk5MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNS0wMiAgSm9zZXBoIFBlY29y YXJvICA8am9lcGVja0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IE9sZCBTdHlsZSB0cmltV2hpdGVzcGFj ZSgpIHNob3VsZCBiZSB0cmltKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTM4NDQxCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1NvdXJj ZUZyYW1lLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNvdXJjZUZyYW1lLnByb3RvdHlwZS5f ZXZhbFNlbGVjdGlvbkluQ2FsbEZyYW1lKToKKwogMjAxMC0wNS0wMiAgUGF2ZWwgRmVsZG1hbiAg PHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBOb3QgcmV2aWV3ZWQ6IFRvdWNoIGlu c3BlY3RvciBjb250cm9sbGVyIHRvIGtpY2sgd2luZG93cyB0ZXN0cy4KZGlmZiAtLWdpdCBhL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VGcmFtZS5qcyBiL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9Tb3VyY2VGcmFtZS5qcwppbmRleCBjOGY3YjgxLi4yZGVjNjUwIDEwMDY0 NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU291cmNlRnJhbWUuanMKKysrIGIv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NvdXJjZUZyYW1lLmpzCkBAIC02ODQsNyArNjg0 LDcgQEAgV2ViSW5zcGVjdG9yLlNvdXJjZUZyYW1lLnByb3RvdHlwZSA9IHsKICAgICAgICAgaWYg KCFzZWxlY3Rpb24ucmFuZ2VDb3VudCkKICAgICAgICAgICAgIHJldHVybjsKIAotICAgICAgICB2 YXIgZXhwcmVzc2lvbiA9IHNlbGVjdGlvbi5nZXRSYW5nZUF0KDApLnRvU3RyaW5nKCkudHJpbVdo aXRlc3BhY2UoKTsKKyAgICAgICAgdmFyIGV4cHJlc3Npb24gPSBzZWxlY3Rpb24uZ2V0UmFuZ2VB dCgwKS50b1N0cmluZygpLnRyaW0oKTsKICAgICAgICAgV2ViSW5zcGVjdG9yLnBhbmVscy5zY3Jp cHRzLmV2YWx1YXRlSW5TZWxlY3RlZENhbGxGcmFtZShleHByZXNzaW9uLCBmYWxzZSwgImNvbnNv bGUiLCBmdW5jdGlvbihyZXN1bHQsIGV4Y2VwdGlvbikgewogICAgICAgICAgICAgV2ViSW5zcGVj dG9yLnNob3dDb25zb2xlKCk7CiAgICAgICAgICAgICB2YXIgY29tbWFuZE1lc3NhZ2UgPSBuZXcg V2ViSW5zcGVjdG9yLkNvbnNvbGVDb21tYW5kKGV4cHJlc3Npb24pOwo=