38440 2010-05-02 13:49:49 -0700 [Qt] use QT_MOBILE_THEME in Symbian 2010-05-14 08:41:32 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All CLOSED FIXED Qt P3 Normal --- 38439 35784 1 luiz luiz commit-queue cshu hausmann kenneth koshuin laszlo.gombos yael oldest_to_newest 219891 0 luiz 2010-05-02 13:49:49 -0700 Putting QT_MOBILE_THEME into use for Symbian. 219892 1 54889 luiz 2010-05-02 13:56:07 -0700 Created attachment 54889 patch 1 219906 2 hausmann 2010-05-02 14:34:12 -0700 (In reply to comment #1) > Created an attachment (id=54889) [details] > patch 1 rs=me :) 221082 3 koshuin 2010-05-05 06:41:23 -0700 Umm... why would we use maemo5style on Symbian ? We have s60Style that we currently use albeit yes it sucks with dissappearing check-boxes etc.. If that QT_MOBILE_THEME style/palette is considered to be the best color scheme for mobiles and is accepted by S60 LAF guides I see why not take it in. But then the class name has to be changed from maemo5style. 221087 4 yael 2010-05-05 06:48:53 -0700 (In reply to comment #3) > Umm... why would we use maemo5style on Symbian ? > > We have s60Style that we currently use albeit yes it sucks with dissappearing > check-boxes etc.. If that QT_MOBILE_THEME style/palette is considered to be the > best color scheme for mobiles and is accepted by S60 LAF guides I see why not > take it in. But then the class name has to be changed from maemo5style. Funny :-) I thought we were going to use QHbStyle in Symbian^4. 221125 5 hausmann 2010-05-05 08:32:32 -0700 (In reply to comment #3) > Umm... why would we use maemo5style on Symbian ? > > We have s60Style that we currently use albeit yes it sucks with dissappearing > check-boxes etc.. If that QT_MOBILE_THEME style/palette is considered to be the > best color scheme for mobiles and is accepted by S60 LAF guides I see why not > take it in. But then the class name has to be changed from maemo5style. Yes, the name maemo5style is confusing, but essentially this is about using the windows style plus a custom stylesheet for the rendering of form elements, instead of the native style with buttons and input fields with finger friendly sizes that break web site layout. Luiz, can you elaborate a bit on that? :) 221186 6 luiz 2010-05-05 10:40:10 -0700 (In reply to comment #5) > (In reply to comment #3) > > Umm... why would we use maemo5style on Symbian ? > > > > We have s60Style that we currently use albeit yes it sucks with dissappearing > > check-boxes etc.. If that QT_MOBILE_THEME style/palette is considered to be the > > best color scheme for mobiles and is accepted by S60 LAF guides I see why not > > take it in. But then the class name has to be changed from maemo5style. > > Yes, the name maemo5style is confusing, but essentially this is about using the > windows style plus a custom stylesheet for the rendering of form elements, > instead of the native style with buttons and input fields with finger friendly > sizes that break web site layout. > > Luiz, can you elaborate a bit on that? :) Maemo5Style is responsible for rendering radio buttons, checkboxes and combo boxes buttons. All other elements are rendered by webkit using a customized style sheet. Any other QStyle, if provided, will be ignored. What is now been enabled for Symbian is the use of Maemo5Style class, customized style sheet and replacing list boxes by combo boxes. There are some screen shots of the expected result in bug 36370. All <select> elements will be rendered as combo boxes but customized popups are not provided. To provide customized popups it is needed to create a platform plugin. See bug 38438. Yes the name Maemo5Style does not make sense now. I plan to rename files and class in future patch. I an submitting this patch and previous one (bug 38439) because I understood that it was agreed that it should be done. Please let me know if I am wrong. 221596 7 koshuin 2010-05-06 02:50:54 -0700 Hi, I know the background of the bug and I do agree that we need webstyle which is separated from user themes for visibility and usability reasons. Esp. on S60 where native controls don't fit to webpage layouts and color schemes at all. What worries here in your comments is that controls would be smaller. It is already very difficult in e.g. 5800 to use elements due to their small size. non-touch S60 UI uses popups for all of these elements (radiobutton, checkbox, combobox). I think we might need to extend the work you've done to combobox popup to apply to radiobuttons and checkboxes as well when UI style is non-touch. We have a fullscreen list for combobox type already available but this doesn't allow multiselection. How much should be put effort supporting non-touch UI is bit questionable and I don't have answer for it. Yael's concern about orbit is also valid as that is Direct single touch UI where I could see combobox being operated in-place. Anyone know if Orbit even has comboboxes? How does combobox work in DUI (Maemo6/MeeGo)? Plugin mechanism is the technical answer, now we need to find out how many plugin variations we need to implement. But let's put it in, and test it with full range of devices we have to see what are the implications. I'm fairly certain I will find this change from my mail box quite often in upcoming months :D 221690 8 55241 luiz 2010-05-06 08:16:35 -0700 Created attachment 55241 patch 2 As everyone seems to be ok with the changes I will land it and deal with the issues as they come. I will also supply a patch renaming Maemo5WebStyle to DefaultMobileWebStyle or something similar. Thanks for the comments Janne, Yael and Simon. 221932 9 55241 commit-queue 2010-05-06 13:38:15 -0700 Comment on attachment 55241 patch 2 Clearing flags on attachment: 55241 Committed r58906: <http://trac.webkit.org/changeset/58906> 221933 10 commit-queue 2010-05-06 13:38:22 -0700 All reviewed patches have been landed. Closing bug. 222236 11 hausmann 2010-05-07 01:11:10 -0700 While I agree that this is the right way forward and that the platform plugins will help to smoothen things out even further, I would like to double check if we _do_ want this change in the QtWebKit 2.0 release. The 2.0 release on Symbian is going to be used only on platforms that use Avkon and where the Browser uses Avkon appearance for the buttons, etc. in form elements. In the context of this, is the integration into the release still intentional? 222245 12 koshuin 2010-05-07 02:09:41 -0700 (In reply to comment #11) > The 2.0 release on Symbian is going to be used only on platforms that use Avkon > and where the Browser uses Avkon appearance for the buttons, etc. in form > elements. This patch doesn't touch buttons. Only checkboxes , radiobuttons and comboboxes. > In the context of this, is the integration into the release still intentional? We have no styled radiobutton nor checkboxes for Avkon base S60Style. What we have is terrible hack which doesn't work properly on white nor black background. What we would need for 2.0 release is the combobox implementation. So, yes the integration is intentional. 222283 13 yael 2010-05-07 05:12:37 -0700 (In reply to comment #11) > While I agree that this is the right way forward and that the platform plugins > will help to smoothen things out even further, I would like to double check if > we _do_ want this change in the QtWebKit 2.0 release. > > The 2.0 release on Symbian is going to be used only on platforms that use Avkon > and where the Browser uses Avkon appearance for the buttons, etc. in form > elements. > > In the context of this, is the integration into the release still intentional? Chang worked on the Avkon integration. cc'ing him as well. 222293 14 kenneth 2010-05-07 05:40:03 -0700 You probably still need to modify the CSS etc for Avkon right? 225845 15 hausmann 2010-05-14 08:41:18 -0700 Revision r58906 cherry-picked into qtwebkit-2.0 with commit c5f27fb7e594c65e12239faa6e1c316c3534817b 54889 2010-05-02 13:56:07 -0700 2010-05-06 08:16:35 -0700 patch 1 0001-Qt-use-QT_MOBILE_THEME-in-Symbian.patch text/plain 1376 luiz RnJvbSA1ZDk4OGQyZjE0ZTU0ZmY1OTBjMTVlZTc1OWRlMWYzNmRiMDdlYTg4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMdWl6IEFnb3N0aW5pIDxsdWl6LmFnb3N0aW5pQG9wZW5ib3Nz YS5vcmc+CkRhdGU6IFN1biwgMiBNYXkgMjAxMCAxNzo1MTozMSAtMDMwMApTdWJqZWN0OiBbUEFU Q0hdIFtRdF0gdXNlIFFUX01PQklMRV9USEVNRSBpbiBTeW1iaWFuCiBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg0NDAKClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgoKUHV0dGluZyBRVF9NT0JJTEVfVEhFTUUgaW50byB1c2UgZm9yIFN5bWJpYW4uCgoqIFdlYkNv cmUucHJvOgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgfCAgIDExICsrKysrKysrKysrCiBXZWJD b3JlL1dlYkNvcmUucHJvIHwgICAgMiArLQogMiBmaWxlcyBjaGFuZ2VkLCAxMiBpbnNlcnRpb25z KCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKaW5kZXggMGU0NWU5ZC4uNGJlNGFiOSAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwxNyBAQAogCiAg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogCisgICAgICAgIFtRdF0gdXNlIFFU X01PQklMRV9USEVNRSBpbiBTeW1iaWFuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zODQ0MAorCisgICAgICAgIFB1dHRpbmcgUVRfTU9CSUxFX1RIRU1F IGludG8gdXNlIGZvciBTeW1iaWFuLgorCisgICAgICAgICogV2ViQ29yZS5wcm86CisKKzIwMTAt MDUtMDIgIEx1aXogQWdvc3RpbmkgIDxsdWl6LmFnb3N0aW5pQG9wZW5ib3NzYS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKICAgICAgICAgW1F0XSBRVF9NT0JJ TEVfVEhFTUUgY29tcGlsZSB0aW1lIGZsYWcKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTM4NDM5CiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvV2ViQ29yZS5w cm8gYi9XZWJDb3JlL1dlYkNvcmUucHJvCmluZGV4IDg3NGQ1ODkuLjJiNmIxYWEgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvV2ViQ29yZS5wcm8KKysrIGIvV2ViQ29yZS9XZWJDb3JlLnBybwpAQCAtMTIz LDcgKzEyMyw3IEBAIG1hZW1vNXxzeW1iaWFufGVtYmVkZGVkIHsKICAgICBERUZJTkVTICs9IEVO QUJMRV9GQVNUX01PQklMRV9TQ1JPTExJTkc9MQogfQogCi1tYWVtbzUgeworbWFlbW81fHN5bWJp YW4gewogICAgIERFRklORVMgKz0gV1RGX1VTRV9RVF9NT0JJTEVfVEhFTUU9MQogfQogCi0tIAox LjYuMy4zCgo= 55241 2010-05-06 08:16:35 -0700 2010-05-06 13:38:15 -0700 patch 2 0001-Qt-use-QT_MOBILE_THEME-in-Symbian.patch text/plain 1328 luiz RnJvbSAwZGEwYTk2ZTQ4OGFmMjE5OTM2NWU1NGUzYzg0YjhmN2Q4YWJkMDMwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMdWl6IEFnb3N0aW5pIDxsdWl6LmFnb3N0aW5pQG9wZW5ib3Nz YS5vcmc+CkRhdGU6IFRodSwgNiBNYXkgMjAxMCAxMjowODo0MSAtMDMwMApTdWJqZWN0OiBbUEFU Q0hdIFtRdF0gdXNlIFFUX01PQklMRV9USEVNRSBpbiBTeW1iaWFuCiBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg0NDAKClJ1YmJlci1zdGFtcGVkIGJ5IFNpbW9uIEhh dXNtYW5uLgoKUHV0dGluZyBRVF9NT0JJTEVfVEhFTUUgaW50byB1c2UgZm9yIFN5bWJpYW4uCgoq IFdlYkNvcmUucHJvOgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgfCAgIDExICsrKysrKysrKysr CiBXZWJDb3JlL1dlYkNvcmUucHJvIHwgICAgMiArLQogMiBmaWxlcyBjaGFuZ2VkLCAxMiBpbnNl cnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9n IGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzc3ZTg4My4uMzEzMTE3MCAxMDA2NDQKLS0tIGEv V2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBA QAorMjAxMC0wNS0wNiAgTHVpeiBBZ29zdGluaSAgPGx1aXouYWdvc3RpbmlAb3BlbmJvc3NhLm9y Zz4KKworICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBTaW1vbiBIYXVzbWFubi4KKworICAgICAg ICBbUXRdIHVzZSBRVF9NT0JJTEVfVEhFTUUgaW4gU3ltYmlhbgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg0NDAKKworICAgICAgICBQdXR0aW5nIFFU X01PQklMRV9USEVNRSBpbnRvIHVzZSBmb3IgU3ltYmlhbi4KKworICAgICAgICAqIFdlYkNvcmUu cHJvOgorCiAyMDEwLTA1LTA2ICBTdGV2ZSBCbG9jayAgPHN0ZXZlYmxvY2tAZ29vZ2xlLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUv V2ViQ29yZS5wcm8gYi9XZWJDb3JlL1dlYkNvcmUucHJvCmluZGV4IDBlYjU4N2IuLjM0NWYyOGMg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvV2ViQ29yZS5wcm8KKysrIGIvV2ViQ29yZS9XZWJDb3JlLnBy bwpAQCAtMTIyLDcgKzEyMiw3IEBAIG1hZW1vNXxzeW1iaWFufGVtYmVkZGVkIHsKICAgICBERUZJ TkVTICs9IEVOQUJMRV9GQVNUX01PQklMRV9TQ1JPTExJTkc9MQogfQogCi1tYWVtbzUgeworbWFl bW81fHN5bWJpYW4gewogICAgIERFRklORVMgKz0gV1RGX1VTRV9RVF9NT0JJTEVfVEhFTUU9MQog fQogCi0tIAoxLjYuMy4zCgo=