38437 2010-05-02 08:27:21 -0700 Results for editing/pasteboard/5761530-1.html are wrong 2010-07-12 04:10:56 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 41394 1 robert webkit-unassigned ap commit-queue hamaji justin.garcia kenneth robert oldest_to_newest 219859 0 robert 2010-05-02 08:27:21 -0700 The expected results for editing/pasteboard/5761530-1.html are: This tests to see that tabs are put into tab spans when they are copied individually. The pasted tab should be inside of a tab span, not a style span. To run the test manually, paste and then inspect the editable region, and ensure that there is a tab span at the beginning of the editable div. <span class="Apple-tab-span" style="white-space: pre; ">[tab]</span><span class="Apple-tab-span" style="white-space:pre;">[ws]</span>xxx where [tab] is a tab, and [ws] is a single space. On Qt, the result is: This tests to see that tabs are put into tab spans when they are copied individually. The pasted tab should be inside of a tab span, not a style span. To run the test manually, paste and then inspect the editable region, and ensure that there is a tab span at the beginning of the editable div. <span class="Apple-tab-span" style="white-space: pre; ">[tab]</span><span class="Apple-tab-span" style="white-space:pre;">[tab]</span>xxx Isn't this more correct? If copying a span wouldn't you expect the tab to be copied as a tab, rather than replaced with a single space? 220023 1 justin.garcia 2010-05-02 22:44:57 -0700 > Isn't this more correct? If copying a span wouldn't you expect the tab to be > copied as a tab, rather than replaced with a single space? Definitely. When I perform the test manually everything looks OK, Paste inserts a tab and when I expect the DOM there's a tab, not a space. 220024 2 justin.garcia 2010-05-02 22:45:36 -0700 > when I expect the DOM "inspect" 240483 3 59202 robert 2010-06-20 11:16:12 -0700 Created attachment 59202 Patch 244423 4 59202 commit-queue 2010-06-29 12:26:08 -0700 Comment on attachment 59202 Patch Rejecting patch 59202 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Kenneth Rohde Christiansen', u'--force']" exit_code: 1 Last 500 characters of output: 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej patching file LayoutTests/platform/gtk/Skipped Hunk #1 FAILED at 5895. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/gtk/Skipped.rej patching file LayoutTests/platform/mac/Skipped Hunk #1 FAILED at 295. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/Skipped.rej patching file LayoutTests/platform/qt/Skipped Hunk #1 succeeded at 367 (offset -3 lines). Full output: http://webkit-commit-queue.appspot.com/results/3294972 244467 5 robert 2010-06-29 14:00:14 -0700 Committed r62146: <http://trac.webkit.org/changeset/62146> 244563 6 ap 2010-06-29 17:11:39 -0700 + * platform/mac/Skipped: Please don't skip test that don't crash on Mac. We prefer to have wrong results checked in, so that we know about unexpected changes in behavior. When there is a platform difference like this, cross-platform results should be those that we believe correct, but one can always add platform specific results to avoid skipping tests. 244602 7 kenneth 2010-06-29 19:14:15 -0700 (In reply to comment #6) > + * platform/mac/Skipped: > > Please don't skip test that don't crash on Mac. We prefer to have wrong results checked in, so that we know about unexpected changes in behavior. > > When there is a platform difference like this, cross-platform results should be those that we believe correct, but one can always add platform specific results to avoid skipping tests. Right, I will keep that in mind. Do you need a bug filled then? or what do you prefer? 244619 8 ap 2010-06-29 21:39:01 -0700 I think this changes to skip lists and updated results can be landed without review when there is no controversy. This isn't a huge issue. 249754 9 hamaji 2010-07-12 04:10:56 -0700 Committed r63068: <http://trac.webkit.org/changeset/63068> 59202 2010-06-20 11:16:12 -0700 2010-06-29 12:26:08 -0700 Patch bug-38437-20100620191609.patch text/plain 4564 robert ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyNGRlNWQ1NjU2NDMyY2Y5NjBhMWQ3YjEzODgwMzE4MDlhOGYxZTEyLi5kY2Q4ODhk Nzg0MzhhMGQ2ZGIxMzBkZGQ2MGNjNGI4NjdkNDljNDIwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjIgQEAK IDIwMTAtMDYtMjAgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgogCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlc3VsdHMgZm9yIGVkaXRp bmcvcGFzdGVib2FyZC81NzYxNTMwLTEuaHRtbCBhcmUgd3JvbmcKKworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg0MzcKKworICAgICAgICBRdCBzZWVt cyB0byBoYXZlIHRoZSBjb3JyZWN0IHJlc3VsdCBoZXJlLiBTbyB1bnNraXAgb24gUXQgYW5kCisg ICAgICAgIHNraXAgb24gb3RoZXIgcGxhdGZvcm1zIHNvIGNhbiBiZSBmaXhlZC4KKworICAgICAg ICAqIGVkaXRpbmcvcGFzdGVib2FyZC81NzYxNTMwLTEtZXhwZWN0ZWQudHh0OgorICAgICAgICAq IHBsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dDoKKyAgICAgICAgKiBwbGF0 Zm9ybS9ndGsvU2tpcHBlZDoKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvU2tpcHBlZDoKKyAgICAg ICAgKiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOgorCisyMDEwLTA2LTIwICBSb2JlcnQgSG9nYW4gIDxy b2JlcnRAd2Via2l0Lm9yZz4KKwogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4K IAogICAgICAgICBbUXRdIE5QUF9TZXRXaW5kb3cgc2VlbXMgdG8gbm90IGJlIGNhbGxlZCB3aGVu IFRlc3ROZXRzY2FwZVBsdWdpbiBpcyBtb3ZlZApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRp dGluZy9wYXN0ZWJvYXJkLzU3NjE1MzAtMS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9lZGl0 aW5nL3Bhc3RlYm9hcmQvNTc2MTUzMC0xLWV4cGVjdGVkLnR4dAppbmRleCAzMGVjZGZlZmFlNjA3 ZTc3NmYxMGVlMDVlOGIxMGE4NTBjYTNhMjlmLi5hNzYyYTcyNDgyOGQ2NTNhMDQ4NDdmNTQzZmJm Y2NhNWZlZTU4MzMwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9lZGl0aW5nL3Bhc3RlYm9hcmQv NTc2MTUzMC0xLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3Bhc3RlYm9h cmQvNTc2MTUzMC0xLWV4cGVjdGVkLnR4dApAQCAtMSwzICsxLDMgQEAKIFRoaXMgdGVzdHMgdG8g c2VlIHRoYXQgdGFicyBhcmUgcHV0IGludG8gdGFiIHNwYW5zIHdoZW4gdGhleSBhcmUgY29waWVk IGluZGl2aWR1YWxseS4gVGhlIHBhc3RlZCB0YWIgc2hvdWxkIGJlIGluc2lkZSBvZiBhIHRhYiBz cGFuLCBub3QgYSBzdHlsZSBzcGFuLiBUbyBydW4gdGhlIHRlc3QgbWFudWFsbHksIHBhc3RlIGFu ZCB0aGVuIGluc3BlY3QgdGhlIGVkaXRhYmxlIHJlZ2lvbiwgYW5kIGVuc3VyZSB0aGF0IHRoZXJl IGlzIGEgdGFiIHNwYW4gYXQgdGhlIGJlZ2lubmluZyBvZiB0aGUgZWRpdGFibGUgZGl2LgogCi08 c3BhbiBjbGFzcz0iQXBwbGUtdGFiLXNwYW4iIHN0eWxlPSJ3aGl0ZS1zcGFjZTogcHJlOyAiPgk8 L3NwYW4+PHNwYW4gY2xhc3M9IkFwcGxlLXRhYi1zcGFuIiBzdHlsZT0id2hpdGUtc3BhY2U6cHJl OyI+IDwvc3Bhbj54eHgKKzxzcGFuIGNsYXNzPSJBcHBsZS10YWItc3BhbiIgc3R5bGU9IndoaXRl LXNwYWNlOiBwcmU7ICI+CTwvc3Bhbj48c3BhbiBjbGFzcz0iQXBwbGUtdGFiLXNwYW4iIHN0eWxl PSJ3aGl0ZS1zcGFjZTpwcmU7Ij4JPC9zcGFuPnh4eApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv cGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0IGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CmluZGV4IDlkODBjYTA5MjE5YTg1 NTE3YzUxZDM3NTgyMzdmZTM0ZThiNzg5ZDIuLjBlODE5NTI3ODdiZjFmNzZkYjQxOGUzZGNlMDg1 YzE4Y2ExZGUwMjEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rl c3RfZXhwZWN0YXRpb25zLnR4dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90 ZXN0X2V4cGVjdGF0aW9ucy50eHQKQEAgLTI4NjUsMyArMjg2NSw2IEBAIEJVRzQ2OTc0IFdJTiA6 IGluc3BlY3Rvci9hdWRpdHMtcGFuZWwtZnVuY3Rpb25hbC5odG1sID0gQ1JBU0ggUEFTUwogQlVH NDY5ODkgTUFDIERFQlVHIDogZmFzdC9kb20vSFRNTE1ldGVyRWxlbWVudC9tZXRlci1hcHBlYXJh bmNlcy1jYXBhY2l0eS5odG1sID0gSU1BR0UKIEJVRzQ2OTg5IE1BQyBERUJVRyA6IGZhc3QvZG9t L0hUTUxNZXRlckVsZW1lbnQvbWV0ZXItZWxlbWVudC5odG1sID0gSU1BR0UKIEJVRzQ2OTg5IE1B QyBERUJVRyA6IGZhc3QvZG9tL0hUTUxNZXRlckVsZW1lbnQvbWV0ZXItb3B0aW11bXMuaHRtbCA9 IElNQUdFCisKKy8vIHBhc3RlcyBhIHNwYWNlIGluc3RlYWQgb2YgYSB0YWIKK0JVRyAzODQzNyBS RUxFQVNFIDogZWRpdGluZy9wYXN0ZWJvYXJkLzU3NjE1MzAtMS5odG1sID0gRkFJTApcIE5vIG5l d2xpbmUgYXQgZW5kIG9mIGZpbGUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0 ay9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKaW5kZXggZjgzMzZj N2I0MmE4YjdiNDZhNDlhNjE3ZDhiY2I4Y2Q4MDRkNzFlOS4uY2Y3Y2E3ZWE3ZmUxNTcxOTUyZDRj ZWJmMzgwYzY2ZmZlNTlhOGM5ZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3Rr L1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKQEAgLTU4OTUs MyArNTg5NSw3IEBAIGZhc3QvdGV4dC9mYWtlLWl0YWxpYy5odG1sCiAjIFRoaXMgdGVzdCBjcmFz aGVzIHJhbmRvbWx5IG9uIHNvbWUgb2Ygb3VyIGJvdHMKICMgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTQwODU5CiBtZWRpYS92aWRlby1jb250cm9scy1yZW5kZXJpbmcu aHRtbAorCisjIHBhc3RlcyBhIHNwYWNlIGluc3RlYWQgb2YgYSB0YWIKKyMgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4NDM3CitlZGl0aW5nL3Bhc3RlYm9hcmQvNTc2 MTUzMC0xLmh0bWwKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9Ta2lwcGVk IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1NraXBwZWQKaW5kZXggZWY4ZTJmZWM4ZGM5MWJj YzZlOGY4ZTBhYWUxMDI1MzMwNzZhYWJlYS4uN2JmOTFmZjhiNGFjY2JmNTUxNzQ3MzM4NmY2M2E5 N2U5N2MzMmFmYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1NraXBwZWQK KysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1NraXBwZWQKQEAgLTI5NSwzICsyOTUsNyBA QCBmYXN0L2RvbS9HZW9sb2NhdGlvbi9tYXhpbXVtLWFnZS5odG1sCiAKICMgRmlsZW5hbWVzIGFy ZW4ndCBmaWx0ZXJlZCBvdXQgZnJvbSBlZGl0IGRyYWdzIHlldCwgc2VlIGh0dHBzOi8vYnVncy53 ZWtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4ODI2CiBlZGl0aW5nL3Bhc3RlYm9hcmQvZmlsZS1k cmFnLXRvLWVkaXRhYmxlLmh0bWwKKworIyBwYXN0ZXMgYSBzcGFjZSBpbnN0ZWFkIG9mIGEgdGFi CisjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODQzNworZWRpdGlu Zy9wYXN0ZWJvYXJkLzU3NjE1MzAtMS5odG1sCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9xdC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAppbmRleCA2 NmE0MTI5ZjgxMDlmNGNhZjI1YjAzNmZkOWY2MmExMDBiOGEzNjUyLi4xZGU5NjAxM2RjYmRlNjI5 ZTc2MjUzZjdhM2ZlNjViYTMzZTA3MWM0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9xdC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKQEAgLTM3 MCw5ICszNzAsNiBAQCBlZGl0aW5nL3Bhc3RlYm9hcmQvc21hcnQtcGFzdGUtMDA4Lmh0bWwKICMt LS0tLS0gc2FmZSB0byBza2lwLiBRdCByZXN1bHRzIHNhbWUgYXMgY2hyb21pdW0ncy4gTWFjIGRy b3BzIHRoZSAnYicgaW4gdGhlIGZpbmFsIGJhciwKICMtLS0tLS0gdGhhdCBsb29rcyBsaWtlIGEg YnVnLgogZWRpdGluZy9wYXN0ZWJvYXJkL2ludGVyY2hhbmdlLW5ld2xpbmUtMi5odG1sCi0jIC0t LS0tIFdoaXRlc3BhY2UgaW5zdGVhZCBvZiB0YWI/Ci0jIC0tLS0tIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODQzNwotZWRpdGluZy9wYXN0ZWJvYXJkLzU3NjE1MzAt MS5odG1sCiAjIC0tLS0tIFJlc3VsdHMgYXBwZWFyIGNvcnJlY3QgYnV0IGhhdmUgc3VzcGljaW91 cyByZW5kZXJ0cmVlIGRpZmZlcmVuY2VzLgogZWRpdGluZy9wYXN0ZWJvYXJkL3Bhc3RpbmctdGFi cy5odG1sCiBlZGl0aW5nL3Bhc3RlYm9hcmQvbmVzdGVkLWJsb2Nrcy13aXRoLXRleHQtYXJlYS5o dG1sCg==