38434 2010-05-02 07:07:33 -0700 Use HTML5 number parsing in HTMLProgressElement 2010-05-03 11:21:42 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 yael webkit-unassigned oldest_to_newest 219842 0 yael 2010-05-02 07:07:33 -0700 Suggested in https://bugs.webkit.org/show_bug.cgi?id=38140#c12 and https://bugs.webkit.org/show_bug.cgi?id=38140#c15 to use the more strict HTML5 parsing code. 219846 1 54878 yael 2010-05-02 07:21:07 -0700 Created attachment 54878 Patch 220033 2 54878 darin 2010-05-02 23:50:28 -0700 Comment on attachment 54878 Patch > + Use parseToDoubleForNumberType instead of toDouble. Where are the tests for the behavior changes this creates? We require tests for any bug fixes. Or is this refactoring only? > + Throw an exception when the number is NaN or Infinity. All the test changes seem to be for this independent half of the patch. > + if (isnan(value) || !isfinite(value)) { The isnan check here is redundant and should be removed. The isfinite function returns false for NAN. review- because of a lack of test for the HTML5 number parsing change and because the extra check should be omitted. 220072 3 54920 yael 2010-05-03 06:05:31 -0700 Created attachment 54920 Patch addressing comment #2. Add more tests for parseToDoubleForNumberType and remove redundant isnan(). 220116 4 54920 darin 2010-05-03 08:19:18 -0700 Comment on attachment 54920 Patch addressing comment #2. > +try { > p.value = "200A"; > -p.max = 100; > -shouldBe("p.value", "0"); > -shouldBe("p.max", "100"); > -shouldBe("p.position", "0"); > +} catch (e) { > +debug(e.message); > +} The shouldThrow function is a cleaner way to do a test like this. 220204 5 yael 2010-05-03 11:21:42 -0700 Committed r58687: <http://trac.webkit.org/changeset/58687> 54878 2010-05-02 07:21:07 -0700 2010-05-03 06:05:31 -0700 Patch 38434.patch text/plain 6856 yael SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1ODY1MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTAtMDUtMDIgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFVzZSBIVE1MNSBudW1iZXIgcGFyc2luZyBpbiBIVE1MUHJvZ3Jlc3NFbGVtZW50CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODQzNAorCisgICAgICAg IFVzZSBwYXJzZVRvRG91YmxlRm9yTnVtYmVyVHlwZSBpbnN0ZWFkIG9mIHRvRG91YmxlLgorICAg ICAgICBUaHJvdyBhbiBleGNlcHRpb24gd2hlbiB0aGUgbnVtYmVyIGlzIE5hTiBvciBJbmZpbml0 eS4KKworICAgICAgICAqIGh0bWwvSFRNTFByb2dyZXNzRWxlbWVudC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpIVE1MUHJvZ3Jlc3NFbGVtZW50Ojp2YWx1ZSk6CisgICAgICAgIChXZWJDb3JlOjpI VE1MUHJvZ3Jlc3NFbGVtZW50OjpzZXRWYWx1ZSk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MUHJv Z3Jlc3NFbGVtZW50OjptYXgpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFByb2dyZXNzRWxlbWVu dDo6c2V0TWF4KToKKyAgICAgICAgKiBodG1sL0hUTUxQcm9ncmVzc0VsZW1lbnQuaDoKKyAgICAg ICAgKiBodG1sL0hUTUxQcm9ncmVzc0VsZW1lbnQuaWRsOgorCiAyMDEwLTA1LTAyICBKYXJra28g U2Fra2luZW4gIDxqYXJra28uai5zYWtraW5lbkBnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBXZWJDb3JlL2h0bWwvSFRNTFByb2dyZXNzRWxlbWVu dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1sL0hUTUxQcm9ncmVzc0VsZW1lbnQuY3Bw CShyZXZpc2lvbiA1ODYzNSkKKysrIFdlYkNvcmUvaHRtbC9IVE1MUHJvZ3Jlc3NFbGVtZW50LmNw cAkod29ya2luZyBjb3B5KQpAQCAtMjYsNiArMjYsNyBAQAogI2luY2x1ZGUgIkZvcm1EYXRhTGlz dC5oIgogI2luY2x1ZGUgIkhUTUxGb3JtRWxlbWVudC5oIgogI2luY2x1ZGUgIkhUTUxOYW1lcy5o IgorI2luY2x1ZGUgIkhUTUxQYXJzZXIuaCIKICNpbmNsdWRlICJNYXBwZWRBdHRyaWJ1dGUuaCIK ICNpbmNsdWRlICJSZW5kZXJQcm9ncmVzcy5oIgogI2luY2x1ZGUgPHd0Zi9TdGRMaWJFeHRyYXMu aD4KQEAgLTcxLDI5ICs3MiwzNyBAQCB2b2lkIEhUTUxQcm9ncmVzc0VsZW1lbnQ6OnBhcnNlTWFw cGVkQXR0CiBkb3VibGUgSFRNTFByb2dyZXNzRWxlbWVudDo6dmFsdWUoKSBjb25zdAogewogICAg IGNvbnN0IEF0b21pY1N0cmluZyYgdmFsdWVTdHJpbmcgPSBnZXRBdHRyaWJ1dGUodmFsdWVBdHRy KTsKLSAgICBib29sIG9rOwotICAgIGRvdWJsZSB2YWx1ZSA9IHZhbHVlU3RyaW5nLnRvRG91Ymxl KCZvayk7CisgICAgZG91YmxlIHZhbHVlOworICAgIGJvb2wgb2sgPSBwYXJzZVRvRG91YmxlRm9y TnVtYmVyVHlwZSh2YWx1ZVN0cmluZywgJnZhbHVlKTsKICAgICBpZiAoIW9rIHx8IHZhbHVlIDwg MCkKICAgICAgICAgcmV0dXJuIHZhbHVlU3RyaW5nLmlzTnVsbCgpID8gMSA6IDA7CiAgICAgcmV0 dXJuICh2YWx1ZSA+IG1heCgpKSA/IG1heCgpIDogdmFsdWU7CiB9CiAKLXZvaWQgSFRNTFByb2dy ZXNzRWxlbWVudDo6c2V0VmFsdWUoZG91YmxlIHZhbHVlKQordm9pZCBIVE1MUHJvZ3Jlc3NFbGVt ZW50OjpzZXRWYWx1ZShkb3VibGUgdmFsdWUsIEV4Y2VwdGlvbkNvZGUmIGVjKQogeworICAgIGlm IChpc25hbih2YWx1ZSkgfHwgIWlzZmluaXRlKHZhbHVlKSkgeworICAgICAgICBlYyA9IE5PVF9T VVBQT1JURURfRVJSOworICAgICAgICByZXR1cm47CisgICAgfQogICAgIHNldEF0dHJpYnV0ZSh2 YWx1ZUF0dHIsIFN0cmluZzo6bnVtYmVyKHZhbHVlID49IDAgPyB2YWx1ZSA6IDApKTsKIH0KIAog ZG91YmxlIEhUTUxQcm9ncmVzc0VsZW1lbnQ6Om1heCgpIGNvbnN0CiB7Ci0gICAgYm9vbCBvazsK LSAgICBkb3VibGUgbWF4ID0gZ2V0QXR0cmlidXRlKG1heEF0dHIpLnRvRG91YmxlKCZvayk7Cisg ICAgZG91YmxlIG1heDsKKyAgICBib29sIG9rID0gcGFyc2VUb0RvdWJsZUZvck51bWJlclR5cGUo Z2V0QXR0cmlidXRlKG1heEF0dHIpLCAmbWF4KTsKICAgICBpZiAoIW9rIHx8IG1heCA8PSAwKQog ICAgICAgICByZXR1cm4gMTsKICAgICByZXR1cm4gbWF4OwogfQogCi12b2lkIEhUTUxQcm9ncmVz c0VsZW1lbnQ6OnNldE1heChkb3VibGUgbWF4KQordm9pZCBIVE1MUHJvZ3Jlc3NFbGVtZW50Ojpz ZXRNYXgoZG91YmxlIG1heCwgRXhjZXB0aW9uQ29kZSYgZWMpCiB7CisgICAgaWYgKGlzbmFuKG1h eCkgfHwgIWlzZmluaXRlKG1heCkpIHsKKyAgICAgICAgZWMgPSBOT1RfU1VQUE9SVEVEX0VSUjsK KyAgICAgICAgcmV0dXJuOworICAgIH0KICAgICBzZXRBdHRyaWJ1dGUobWF4QXR0ciwgU3RyaW5n OjpudW1iZXIobWF4ID4gMCA/IG1heCA6IDEpKTsKIH0KIApJbmRleDogV2ViQ29yZS9odG1sL0hU TUxQcm9ncmVzc0VsZW1lbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0bWwvSFRNTFByb2dy ZXNzRWxlbWVudC5oCShyZXZpc2lvbiA1ODYzNSkKKysrIFdlYkNvcmUvaHRtbC9IVE1MUHJvZ3Jl c3NFbGVtZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTMxLDEwICszMSwxMCBAQCBwdWJsaWM6CiAg ICAgc3RhdGljIFBhc3NSZWZQdHI8SFRNTFByb2dyZXNzRWxlbWVudD4gY3JlYXRlKGNvbnN0IFF1 YWxpZmllZE5hbWUmLCBEb2N1bWVudCosIEhUTUxGb3JtRWxlbWVudCogPSAwKTsKIAogICAgIGRv dWJsZSB2YWx1ZSgpIGNvbnN0OwotICAgIHZvaWQgc2V0VmFsdWUoZG91YmxlKTsKKyAgICB2b2lk IHNldFZhbHVlKGRvdWJsZSwgRXhjZXB0aW9uQ29kZSYpOwogCiAgICAgZG91YmxlIG1heCgpIGNv bnN0OwotICAgIHZvaWQgc2V0TWF4KGRvdWJsZSk7CisgICAgdm9pZCBzZXRNYXgoZG91YmxlLCBF eGNlcHRpb25Db2RlJik7CiAKICAgICBkb3VibGUgcG9zaXRpb24oKSBjb25zdDsKIApJbmRleDog V2ViQ29yZS9odG1sL0hUTUxQcm9ncmVzc0VsZW1lbnQuaWRsCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvaHRtbC9IVE1MUHJvZ3Jlc3NFbGVtZW50LmlkbAkocmV2aXNpb24gNTg2MzUpCisrKyBXZWJD b3JlL2h0bWwvSFRNTFByb2dyZXNzRWxlbWVudC5pZGwJKHdvcmtpbmcgY29weSkKQEAgLTIxLDgg KzIxLDEwIEBAIG1vZHVsZSBodG1sIHsKICAgICBpbnRlcmZhY2UgWwogICAgICAgICBDb25kaXRp b25hbD1QUk9HUkVTU19UQUcKICAgICBdIEhUTUxQcm9ncmVzc0VsZW1lbnQgOiBIVE1MRWxlbWVu dCB7Ci0gICAgICAgICAgICAgICAgIGF0dHJpYnV0ZSAgZG91YmxlICAgICAgICAgICAgICAgIHZh bHVlOwotICAgICAgICAgICAgICAgICBhdHRyaWJ1dGUgIGRvdWJsZSAgICAgICAgICAgICAgICBt YXg7CisgICAgICAgICAgICAgICAgIGF0dHJpYnV0ZSAgZG91YmxlICAgICAgICAgICAgICAgIHZh bHVlCisgICAgICAgICAgICAgICAgICAgICBzZXR0ZXIgcmFpc2VzKERPTUV4Y2VwdGlvbik7Cisg ICAgICAgICAgICAgICAgIGF0dHJpYnV0ZSAgZG91YmxlICAgICAgICAgICAgICAgIG1heAorICAg ICAgICAgICAgICAgICAgICAgc2V0dGVyIHJhaXNlcyhET01FeGNlcHRpb24pOwogICAgICAgICBy ZWFkb25seSBhdHRyaWJ1dGUgIGRvdWJsZSAgICAgICAgICAgICAgICBwb3NpdGlvbjsKICAgICAg ICAgcmVhZG9ubHkgYXR0cmlidXRlICBIVE1MRm9ybUVsZW1lbnQgICAgICAgZm9ybTsKICAgICB9 OwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L0NoYW5nZUxvZwkocmV2aXNpb24gNTg2NTMpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdv cmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNS0wMiAgWWFlbCBBaGFyb24gIDx5 YWVsLmFoYXJvbkBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVXNlIEhUTUw1IG51bWJlciBwYXJzaW5nIGluIEhUTUxQcm9ncmVzc0Vs ZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4 NDM0CisKKyAgICAgICAgKiBmYXN0L2RvbS9IVE1MUHJvZ3Jlc3NFbGVtZW50L3NjcmlwdC10ZXN0 cy9zZXQtcHJvZ3Jlc3MtcHJvcGVydGllcy5qczoKKyAgICAgICAgKiBmYXN0L2RvbS9IVE1MUHJv Z3Jlc3NFbGVtZW50L3NldC1wcm9ncmVzcy1wcm9wZXJ0aWVzLWV4cGVjdGVkLnR4dDoKKwogMjAx MC0wNS0wMiAgTWFyY3VzIEJ1bGFjaCAgPGJ1bGFjaEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgSmVyZW15IE9ybG93LgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRN TFByb2dyZXNzRWxlbWVudC9zZXQtcHJvZ3Jlc3MtcHJvcGVydGllcy1leHBlY3RlZC50eHQKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTFByb2dyZXNzRWxlbWVudC9zZXQt cHJvZ3Jlc3MtcHJvcGVydGllcy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDU4NjM1KQorKysgTGF5 b3V0VGVzdHMvZmFzdC9kb20vSFRNTFByb2dyZXNzRWxlbWVudC9zZXQtcHJvZ3Jlc3MtcHJvcGVy dGllcy1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTE1LDE0ICsxNSwxNCBAQCBTZXQg dmFsdWUgYmlnZ2VyIHRoYW4gbWF4CiBQQVNTIHAudmFsdWUgaXMgMTAwCiBQQVNTIHAubWF4IGlz IDEwMAogUEFTUyBwLnBvc2l0aW9uIGlzIDEKLVNldCBpbnZhbGlkIHZhbHVlCi1QQVNTIHAudmFs dWUgaXMgMAotUEFTUyBwLm1heCBpcyAxMDAKLVBBU1MgcC5wb3NpdGlvbiBpcyAwCi1TZXQgaW52 YWxpZCBtYXgKLVBBU1MgcC52YWx1ZSBpcyAxCi1QQVNTIHAubWF4IGlzIDEKLVBBU1MgcC5wb3Np dGlvbiBpcyAxCitTZXQgaW52YWxpZCB2YWx1ZSwgc2hvdWxkIHRocm93CitOT1RfU1VQUE9SVEVE X0VSUjogRE9NIEV4Y2VwdGlvbiA5CitTZXQgaW52YWxpZCBtYXgsIHNob3VsZCB0aHJvdworTk9U X1NVUFBPUlRFRF9FUlI6IERPTSBFeGNlcHRpb24gOQorU2V0IG1heCB0byBJbmZpbml0eSwgc2hv dWxkIHRocm93CitOT1RfU1VQUE9SVEVEX0VSUjogRE9NIEV4Y2VwdGlvbiA5CitTZXQgdmFsdWUg dG8gTmFuLCBzaG91bGQgdGhyb3cKK05PVF9TVVBQT1JURURfRVJSOiBET00gRXhjZXB0aW9uIDkK IFNldCB2YWx1ZSB0byBudWxsIGFuZCBtYXggdG8gMAogUEFTUyBwLnZhbHVlIGlzIDAKIFBBU1Mg cC5tYXggaXMgMQpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTFByb2dyZXNzRWxlbWVu dC9zY3JpcHQtdGVzdHMvc2V0LXByb2dyZXNzLXByb3BlcnRpZXMuanMKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTFByb2dyZXNzRWxlbWVudC9zY3JpcHQtdGVzdHMvc2V0 LXByb2dyZXNzLXByb3BlcnRpZXMuanMJKHJldmlzaW9uIDU4NjM1KQorKysgTGF5b3V0VGVzdHMv ZmFzdC9kb20vSFRNTFByb2dyZXNzRWxlbWVudC9zY3JpcHQtdGVzdHMvc2V0LXByb2dyZXNzLXBy b3BlcnRpZXMuanMJKHdvcmtpbmcgY29weSkKQEAgLTIxLDE5ICsyMSwzMyBAQCBzaG91bGRCZSgi cC52YWx1ZSIsICIxMDAiKTsKIHNob3VsZEJlKCJwLm1heCIsICIxMDAiKTsKIHNob3VsZEJlKCJw LnBvc2l0aW9uIiwgIjEiKTsKIAotZGVidWcoIlNldCBpbnZhbGlkIHZhbHVlIik7CitkZWJ1Zygi U2V0IGludmFsaWQgdmFsdWUsIHNob3VsZCB0aHJvdyIpOwordHJ5IHsKIHAudmFsdWUgPSAiMjAw QSI7Ci1wLm1heCA9IDEwMDsKLXNob3VsZEJlKCJwLnZhbHVlIiwgIjAiKTsKLXNob3VsZEJlKCJw Lm1heCIsICIxMDAiKTsKLXNob3VsZEJlKCJwLnBvc2l0aW9uIiwgIjAiKTsKK30gY2F0Y2ggKGUp IHsKK2RlYnVnKGUubWVzc2FnZSk7Cit9CiAKLWRlYnVnKCJTZXQgaW52YWxpZCBtYXgiKTsKLXAu dmFsdWUgPSAiMjAiOworZGVidWcoIlNldCBpbnZhbGlkIG1heCwgc2hvdWxkIHRocm93Iik7Cit0 cnkgewogcC5tYXggPSAibWF4IjsKLXNob3VsZEJlKCJwLnZhbHVlIiwgIjEiKTsKLXNob3VsZEJl KCJwLm1heCIsICIxIik7Ci1zaG91bGRCZSgicC5wb3NpdGlvbiIsICIxIik7Cit9IGNhdGNoIChl KSB7CitkZWJ1ZyhlLm1lc3NhZ2UpOworfQorCitkZWJ1ZygiU2V0IG1heCB0byBJbmZpbml0eSwg c2hvdWxkIHRocm93Iik7Cit0cnkgeworcC5tYXggPSBJbmZpbml0eTsKK30gY2F0Y2ggKGUpIHsK K2RlYnVnKGUubWVzc2FnZSk7Cit9CisKK2RlYnVnKCJTZXQgdmFsdWUgdG8gTmFuLCBzaG91bGQg dGhyb3ciKTsKK3RyeSB7CitwLnZhbHVlID0gTmFOOworfSBjYXRjaCAoZSkgeworZGVidWcoZS5t ZXNzYWdlKTsKK30KIAogZGVidWcoIlNldCB2YWx1ZSB0byBudWxsIGFuZCBtYXggdG8gMCIpOwog cC52YWx1ZSA9IG51bGw7Cg== 54920 2010-05-03 06:05:31 -0700 2010-05-03 08:19:18 -0700 Patch addressing comment #2. 38434.patch text/plain 7486 yael SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1ODY1MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTAtMDUtMDIgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFVzZSBIVE1MNSBudW1iZXIgcGFyc2luZyBpbiBIVE1MUHJvZ3Jlc3NFbGVtZW50CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODQzNAorCisgICAgICAg IFVzZSBwYXJzZVRvRG91YmxlRm9yTnVtYmVyVHlwZSBpbnN0ZWFkIG9mIHRvRG91YmxlLgorICAg ICAgICBUaHJvdyBhbiBleGNlcHRpb24gd2hlbiB0aGUgbnVtYmVyIGlzIE5hTiBvciBJbmZpbml0 eS4KKworICAgICAgICAqIGh0bWwvSFRNTFByb2dyZXNzRWxlbWVudC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpIVE1MUHJvZ3Jlc3NFbGVtZW50Ojp2YWx1ZSk6CisgICAgICAgIChXZWJDb3JlOjpI VE1MUHJvZ3Jlc3NFbGVtZW50OjpzZXRWYWx1ZSk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MUHJv Z3Jlc3NFbGVtZW50OjptYXgpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFByb2dyZXNzRWxlbWVu dDo6c2V0TWF4KToKKyAgICAgICAgKiBodG1sL0hUTUxQcm9ncmVzc0VsZW1lbnQuaDoKKyAgICAg ICAgKiBodG1sL0hUTUxQcm9ncmVzc0VsZW1lbnQuaWRsOgorCiAyMDEwLTA1LTAyICBKYXJra28g U2Fra2luZW4gIDxqYXJra28uai5zYWtraW5lbkBnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBXZWJDb3JlL2h0bWwvSFRNTFByb2dyZXNzRWxlbWVu dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1sL0hUTUxQcm9ncmVzc0VsZW1lbnQuY3Bw CShyZXZpc2lvbiA1ODYzNSkKKysrIFdlYkNvcmUvaHRtbC9IVE1MUHJvZ3Jlc3NFbGVtZW50LmNw cAkod29ya2luZyBjb3B5KQpAQCAtMjYsNiArMjYsNyBAQAogI2luY2x1ZGUgIkZvcm1EYXRhTGlz dC5oIgogI2luY2x1ZGUgIkhUTUxGb3JtRWxlbWVudC5oIgogI2luY2x1ZGUgIkhUTUxOYW1lcy5o IgorI2luY2x1ZGUgIkhUTUxQYXJzZXIuaCIKICNpbmNsdWRlICJNYXBwZWRBdHRyaWJ1dGUuaCIK ICNpbmNsdWRlICJSZW5kZXJQcm9ncmVzcy5oIgogI2luY2x1ZGUgPHd0Zi9TdGRMaWJFeHRyYXMu aD4KQEAgLTcxLDI5ICs3MiwzNyBAQCB2b2lkIEhUTUxQcm9ncmVzc0VsZW1lbnQ6OnBhcnNlTWFw cGVkQXR0CiBkb3VibGUgSFRNTFByb2dyZXNzRWxlbWVudDo6dmFsdWUoKSBjb25zdAogewogICAg IGNvbnN0IEF0b21pY1N0cmluZyYgdmFsdWVTdHJpbmcgPSBnZXRBdHRyaWJ1dGUodmFsdWVBdHRy KTsKLSAgICBib29sIG9rOwotICAgIGRvdWJsZSB2YWx1ZSA9IHZhbHVlU3RyaW5nLnRvRG91Ymxl KCZvayk7CisgICAgZG91YmxlIHZhbHVlOworICAgIGJvb2wgb2sgPSBwYXJzZVRvRG91YmxlRm9y TnVtYmVyVHlwZSh2YWx1ZVN0cmluZywgJnZhbHVlKTsKICAgICBpZiAoIW9rIHx8IHZhbHVlIDwg MCkKICAgICAgICAgcmV0dXJuIHZhbHVlU3RyaW5nLmlzTnVsbCgpID8gMSA6IDA7CiAgICAgcmV0 dXJuICh2YWx1ZSA+IG1heCgpKSA/IG1heCgpIDogdmFsdWU7CiB9CiAKLXZvaWQgSFRNTFByb2dy ZXNzRWxlbWVudDo6c2V0VmFsdWUoZG91YmxlIHZhbHVlKQordm9pZCBIVE1MUHJvZ3Jlc3NFbGVt ZW50OjpzZXRWYWx1ZShkb3VibGUgdmFsdWUsIEV4Y2VwdGlvbkNvZGUmIGVjKQogeworICAgIGlm ICghaXNmaW5pdGUodmFsdWUpKSB7CisgICAgICAgIGVjID0gTk9UX1NVUFBPUlRFRF9FUlI7Cisg ICAgICAgIHJldHVybjsKKyAgICB9CiAgICAgc2V0QXR0cmlidXRlKHZhbHVlQXR0ciwgU3RyaW5n OjpudW1iZXIodmFsdWUgPj0gMCA/IHZhbHVlIDogMCkpOwogfQogCiBkb3VibGUgSFRNTFByb2dy ZXNzRWxlbWVudDo6bWF4KCkgY29uc3QKIHsKLSAgICBib29sIG9rOwotICAgIGRvdWJsZSBtYXgg PSBnZXRBdHRyaWJ1dGUobWF4QXR0cikudG9Eb3VibGUoJm9rKTsKKyAgICBkb3VibGUgbWF4Owor ICAgIGJvb2wgb2sgPSBwYXJzZVRvRG91YmxlRm9yTnVtYmVyVHlwZShnZXRBdHRyaWJ1dGUobWF4 QXR0ciksICZtYXgpOwogICAgIGlmICghb2sgfHwgbWF4IDw9IDApCiAgICAgICAgIHJldHVybiAx OwogICAgIHJldHVybiBtYXg7CiB9CiAKLXZvaWQgSFRNTFByb2dyZXNzRWxlbWVudDo6c2V0TWF4 KGRvdWJsZSBtYXgpCit2b2lkIEhUTUxQcm9ncmVzc0VsZW1lbnQ6OnNldE1heChkb3VibGUgbWF4 LCBFeGNlcHRpb25Db2RlJiBlYykKIHsKKyAgICBpZiAoIWlzZmluaXRlKG1heCkpIHsKKyAgICAg ICAgZWMgPSBOT1RfU1VQUE9SVEVEX0VSUjsKKyAgICAgICAgcmV0dXJuOworICAgIH0KICAgICBz ZXRBdHRyaWJ1dGUobWF4QXR0ciwgU3RyaW5nOjpudW1iZXIobWF4ID4gMCA/IG1heCA6IDEpKTsK IH0KIApJbmRleDogV2ViQ29yZS9odG1sL0hUTUxQcm9ncmVzc0VsZW1lbnQuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL2h0bWwvSFRNTFByb2dyZXNzRWxlbWVudC5oCShyZXZpc2lvbiA1ODYzNSkK KysrIFdlYkNvcmUvaHRtbC9IVE1MUHJvZ3Jlc3NFbGVtZW50LmgJKHdvcmtpbmcgY29weSkKQEAg LTMxLDEwICszMSwxMCBAQCBwdWJsaWM6CiAgICAgc3RhdGljIFBhc3NSZWZQdHI8SFRNTFByb2dy ZXNzRWxlbWVudD4gY3JlYXRlKGNvbnN0IFF1YWxpZmllZE5hbWUmLCBEb2N1bWVudCosIEhUTUxG b3JtRWxlbWVudCogPSAwKTsKIAogICAgIGRvdWJsZSB2YWx1ZSgpIGNvbnN0OwotICAgIHZvaWQg c2V0VmFsdWUoZG91YmxlKTsKKyAgICB2b2lkIHNldFZhbHVlKGRvdWJsZSwgRXhjZXB0aW9uQ29k ZSYpOwogCiAgICAgZG91YmxlIG1heCgpIGNvbnN0OwotICAgIHZvaWQgc2V0TWF4KGRvdWJsZSk7 CisgICAgdm9pZCBzZXRNYXgoZG91YmxlLCBFeGNlcHRpb25Db2RlJik7CiAKICAgICBkb3VibGUg cG9zaXRpb24oKSBjb25zdDsKIApJbmRleDogV2ViQ29yZS9odG1sL0hUTUxQcm9ncmVzc0VsZW1l bnQuaWRsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaHRtbC9IVE1MUHJvZ3Jlc3NFbGVtZW50Lmlk bAkocmV2aXNpb24gNTg2MzUpCisrKyBXZWJDb3JlL2h0bWwvSFRNTFByb2dyZXNzRWxlbWVudC5p ZGwJKHdvcmtpbmcgY29weSkKQEAgLTIxLDggKzIxLDEwIEBAIG1vZHVsZSBodG1sIHsKICAgICBp bnRlcmZhY2UgWwogICAgICAgICBDb25kaXRpb25hbD1QUk9HUkVTU19UQUcKICAgICBdIEhUTUxQ cm9ncmVzc0VsZW1lbnQgOiBIVE1MRWxlbWVudCB7Ci0gICAgICAgICAgICAgICAgIGF0dHJpYnV0 ZSAgZG91YmxlICAgICAgICAgICAgICAgIHZhbHVlOwotICAgICAgICAgICAgICAgICBhdHRyaWJ1 dGUgIGRvdWJsZSAgICAgICAgICAgICAgICBtYXg7CisgICAgICAgICAgICAgICAgIGF0dHJpYnV0 ZSAgZG91YmxlICAgICAgICAgICAgICAgIHZhbHVlCisgICAgICAgICAgICAgICAgICAgICBzZXR0 ZXIgcmFpc2VzKERPTUV4Y2VwdGlvbik7CisgICAgICAgICAgICAgICAgIGF0dHJpYnV0ZSAgZG91 YmxlICAgICAgICAgICAgICAgIG1heAorICAgICAgICAgICAgICAgICAgICAgc2V0dGVyIHJhaXNl cyhET01FeGNlcHRpb24pOwogICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgIGRvdWJsZSAgICAg ICAgICAgICAgICBwb3NpdGlvbjsKICAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlICBIVE1MRm9y bUVsZW1lbnQgICAgICAgZm9ybTsKICAgICB9OwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9n Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNTg2NTMpCisr KyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAor MjAxMC0wNS0wMiAgWWFlbCBBaGFyb24gIDx5YWVsLmFoYXJvbkBub2tpYS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIEhUTUw1IG51bWJl ciBwYXJzaW5nIGluIEhUTUxQcm9ncmVzc0VsZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4NDM0CisKKyAgICAgICAgKiBmYXN0L2RvbS9IVE1M UHJvZ3Jlc3NFbGVtZW50L3NjcmlwdC10ZXN0cy9zZXQtcHJvZ3Jlc3MtcHJvcGVydGllcy5qczoK KyAgICAgICAgKiBmYXN0L2RvbS9IVE1MUHJvZ3Jlc3NFbGVtZW50L3NldC1wcm9ncmVzcy1wcm9w ZXJ0aWVzLWV4cGVjdGVkLnR4dDoKKwogMjAxMC0wNS0wMiAgTWFyY3VzIEJ1bGFjaCAgPGJ1bGFj aEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSmVyZW15IE9ybG93LgpJbmRl eDogTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTFByb2dyZXNzRWxlbWVudC9zZXQtcHJvZ3Jlc3Mt cHJvcGVydGllcy1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9k b20vSFRNTFByb2dyZXNzRWxlbWVudC9zZXQtcHJvZ3Jlc3MtcHJvcGVydGllcy1leHBlY3RlZC50 eHQJKHJldmlzaW9uIDU4NjM1KQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTFByb2dyZXNz RWxlbWVudC9zZXQtcHJvZ3Jlc3MtcHJvcGVydGllcy1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29w eSkKQEAgLTE1LDE0ICsxNSwxNCBAQCBTZXQgdmFsdWUgYmlnZ2VyIHRoYW4gbWF4CiBQQVNTIHAu dmFsdWUgaXMgMTAwCiBQQVNTIHAubWF4IGlzIDEwMAogUEFTUyBwLnBvc2l0aW9uIGlzIDEKLVNl dCBpbnZhbGlkIHZhbHVlCi1QQVNTIHAudmFsdWUgaXMgMAotUEFTUyBwLm1heCBpcyAxMDAKLVBB U1MgcC5wb3NpdGlvbiBpcyAwCi1TZXQgaW52YWxpZCBtYXgKLVBBU1MgcC52YWx1ZSBpcyAxCi1Q QVNTIHAubWF4IGlzIDEKLVBBU1MgcC5wb3NpdGlvbiBpcyAxCitTZXQgaW52YWxpZCB2YWx1ZSwg c2hvdWxkIHRocm93CitOT1RfU1VQUE9SVEVEX0VSUjogRE9NIEV4Y2VwdGlvbiA5CitTZXQgaW52 YWxpZCBtYXgsIHNob3VsZCB0aHJvdworTk9UX1NVUFBPUlRFRF9FUlI6IERPTSBFeGNlcHRpb24g OQorU2V0IG1heCB0byBJbmZpbml0eSwgc2hvdWxkIHRocm93CitOT1RfU1VQUE9SVEVEX0VSUjog RE9NIEV4Y2VwdGlvbiA5CitTZXQgdmFsdWUgdG8gTmFuLCBzaG91bGQgdGhyb3cKK05PVF9TVVBQ T1JURURfRVJSOiBET00gRXhjZXB0aW9uIDkKIFNldCB2YWx1ZSB0byBudWxsIGFuZCBtYXggdG8g MAogUEFTUyBwLnZhbHVlIGlzIDAKIFBBU1MgcC5tYXggaXMgMQpAQCAtMzcsNiArMzcsMTAgQEAg UEFTUyBwLnZhbHVlIGlzIDAKIFBBU1MgcC5tYXggaXMgMQogUEFTUyBwLmdldEF0dHJpYnV0ZSgn dmFsdWUnKSBpcyAnQUJDJwogUEFTUyBwLmdldEF0dHJpYnV0ZSgnbWF4JykgaXMgJyMnCitTZXQg dmFsdWUgYW5kIG1heCB0byBudW1iZXJzIHdpdGggbGVhZGluZyBzcGFjZXMKK1BBU1MgcC52YWx1 ZSBpcyAwCitQQVNTIHAubWF4IGlzIDEKK1BBU1MgcC5wb3NpdGlvbiBpcyAwCiBQQVNTIHN1Y2Nl c3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExFVEUKSW5kZXg6IExheW91dFRlc3Rz L2Zhc3QvZG9tL0hUTUxQcm9ncmVzc0VsZW1lbnQvc2NyaXB0LXRlc3RzL3NldC1wcm9ncmVzcy1w cm9wZXJ0aWVzLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxQcm9n cmVzc0VsZW1lbnQvc2NyaXB0LXRlc3RzL3NldC1wcm9ncmVzcy1wcm9wZXJ0aWVzLmpzCShyZXZp c2lvbiA1ODYzNSkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxQcm9ncmVzc0VsZW1lbnQv c2NyaXB0LXRlc3RzL3NldC1wcm9ncmVzcy1wcm9wZXJ0aWVzLmpzCSh3b3JraW5nIGNvcHkpCkBA IC0yMSwxOSArMjEsMzMgQEAgc2hvdWxkQmUoInAudmFsdWUiLCAiMTAwIik7CiBzaG91bGRCZSgi cC5tYXgiLCAiMTAwIik7CiBzaG91bGRCZSgicC5wb3NpdGlvbiIsICIxIik7CiAKLWRlYnVnKCJT ZXQgaW52YWxpZCB2YWx1ZSIpOworZGVidWcoIlNldCBpbnZhbGlkIHZhbHVlLCBzaG91bGQgdGhy b3ciKTsKK3RyeSB7CiBwLnZhbHVlID0gIjIwMEEiOwotcC5tYXggPSAxMDA7Ci1zaG91bGRCZSgi cC52YWx1ZSIsICIwIik7Ci1zaG91bGRCZSgicC5tYXgiLCAiMTAwIik7Ci1zaG91bGRCZSgicC5w b3NpdGlvbiIsICIwIik7Cit9IGNhdGNoIChlKSB7CitkZWJ1ZyhlLm1lc3NhZ2UpOworfQogCi1k ZWJ1ZygiU2V0IGludmFsaWQgbWF4Iik7Ci1wLnZhbHVlID0gIjIwIjsKK2RlYnVnKCJTZXQgaW52 YWxpZCBtYXgsIHNob3VsZCB0aHJvdyIpOwordHJ5IHsKIHAubWF4ID0gIm1heCI7Ci1zaG91bGRC ZSgicC52YWx1ZSIsICIxIik7Ci1zaG91bGRCZSgicC5tYXgiLCAiMSIpOwotc2hvdWxkQmUoInAu cG9zaXRpb24iLCAiMSIpOworfSBjYXRjaCAoZSkgeworZGVidWcoZS5tZXNzYWdlKTsKK30KKwor ZGVidWcoIlNldCBtYXggdG8gSW5maW5pdHksIHNob3VsZCB0aHJvdyIpOwordHJ5IHsKK3AubWF4 ID0gSW5maW5pdHk7Cit9IGNhdGNoIChlKSB7CitkZWJ1ZyhlLm1lc3NhZ2UpOworfQorCitkZWJ1 ZygiU2V0IHZhbHVlIHRvIE5hbiwgc2hvdWxkIHRocm93Iik7Cit0cnkgeworcC52YWx1ZSA9IE5h TjsKK30gY2F0Y2ggKGUpIHsKK2RlYnVnKGUubWVzc2FnZSk7Cit9CiAKIGRlYnVnKCJTZXQgdmFs dWUgdG8gbnVsbCBhbmQgbWF4IHRvIDAiKTsKIHAudmFsdWUgPSBudWxsOwpAQCAtNTgsNCArNzIs MTEgQEAgc2hvdWxkQmUoInAubWF4IiwgIjEiKTsKIHNob3VsZEJlKCJwLmdldEF0dHJpYnV0ZSgn dmFsdWUnKSIsICInQUJDJyIpOwogc2hvdWxkQmUoInAuZ2V0QXR0cmlidXRlKCdtYXgnKSIsICIn IyciKTsKIAorZGVidWcoIlNldCB2YWx1ZSBhbmQgbWF4IHRvIG51bWJlcnMgd2l0aCBsZWFkaW5n IHNwYWNlcyIpOworcC5zZXRBdHRyaWJ1dGUoInZhbHVlIiwgIiA1Iik7CitwLnNldEF0dHJpYnV0 ZSgibWF4IiwgIiAxMCIpOworc2hvdWxkQmUoInAudmFsdWUiLCAiMCIpOworc2hvdWxkQmUoInAu bWF4IiwgIjEiKTsKK3Nob3VsZEJlKCJwLnBvc2l0aW9uIiwgIjAiKTsKKwogdmFyIHN1Y2Nlc3Nm dWxseVBhcnNlZCA9IHRydWU7Cg==