38423 2010-05-01 14:13:05 -0700 Add infrastructure to handle executable bit 2010-05-01 15:44:40 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dbates webkit-unassigned abarth cjerdonek eric oldest_to_newest 219748 0 dbates 2010-05-01 14:13:05 -0700 Add the infrastructure to handle the executable bit. We need to implement to parsing of the file mode information in a separate patch. 219750 1 54856 dbates 2010-05-01 14:17:11 -0700 Created attachment 54856 Patch No functionality was changed, so no new tests. This patch is part of a coordinated effort with Chris Jerdonek to implement support of the executable bit property. 219751 2 54857 dbates 2010-05-01 14:39:44 -0700 Created attachment 54857 Patch Updated patch. 219752 3 cjerdonek 2010-05-01 15:00:34 -0700 (In reply to comment #2) > Created an attachment (id=54857) [details] > +++ WebKitTools/Scripts/VCSUtils.pm (working copy) > +sub toggleExecutableBit > +{ > + my ($path, $executableBitDelta) = @_; I would rename this to something like "scmToggleExecutableBit" to indicate that this method is setting the executable bit in the source control sense. Also, I would document that this method does not error out if the file corresponding to $path does not exist. > +++ WebKitTools/Scripts/svn-apply (working copy) > + if (!$addition && !$deletion && !$isBinary && !$isGitBinary && !defined($diffHashRef->{executableBitDelta})) { Should you leave this line unchanged to allow the patch to apply? > +++ WebKitTools/Scripts/svn-unapply (working copy) > + if (!$addition && !$deletion && !$isBinary && !defined($diffHashRef->{executableBitDelta})) { Should you leave this line unchanged to allow the patch to apply? 219753 4 54858 dbates 2010-05-01 15:12:54 -0700 Created attachment 54858 Patch Corrected patch to work when the patch describes modifications to existing files. 219755 5 54859 dbates 2010-05-01 15:25:52 -0700 Created attachment 54859 Patch Updated patch based on Chris's suggestions. 219756 6 54859 cjerdonek 2010-05-01 15:29:17 -0700 Comment on attachment 54859 Patch As we discussed, LGTM. 219757 7 54859 dbates 2010-05-01 15:44:33 -0700 Comment on attachment 54859 Patch Clearing flags on attachment: 54859 Committed r58637: <http://trac.webkit.org/changeset/58637> 219758 8 dbates 2010-05-01 15:44:40 -0700 All reviewed patches have been landed. Closing bug. 54856 2010-05-01 14:17:11 -0700 2010-05-01 14:39:44 -0700 Patch Bug38423.patch text/plain 4216 dbates SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU4NjM2KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDUtMDEgIERhbmllbCBCYXRlcyAgPGRi YXRlc0ByaW0uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODQyMworCisg ICAgICAgIEFkZHMgaW5mcmFzdHJ1Y3R1cmUgdG8gY2hhbmdlIHRoZSBmaWxlIG1vZGUgb2YgYSBm aWxlIHVzaW5nCisgICAgICAgIHRoZSBhcHByb3ByaWF0ZSBTQ00tc3BlY2lmaWMgcm91dGluZXMu CisKKyAgICAgICAgTm8gZnVuY3Rpb25hbGl0eSB3YXMgY2hhbmdlZCwgc28gbm8gbmV3IHRlc3Rz LgorCisgICAgICAgICogU2NyaXB0cy9WQ1NVdGlscy5wbToKKyAgICAgICAgKiBTY3JpcHRzL3N2 bi1hcHBseToKKyAgICAgICAgKiBTY3JpcHRzL3N2bi11bmFwcGx5OgorCiAyMDEwLTA0LTMwICBD aHJpcyBNYXJyaW4gIDxjbWFycmluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBT aW1vbiBGcmFzZXIuCkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL1ZDU1V0aWxzLnBtCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvVkNTVXRpbHMucG0JKHJldmlzaW9uIDU4NjM1 KQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy9WQ1NVdGlscy5wbQkod29ya2luZyBjb3B5KQpAQCAt OTcsNiArOTcsNDIgQEAgc3ViIGV4aXRTdGF0dXMoJCkKICAgICByZXR1cm4gV0VYSVRTVEFUVVMo JHJldHVybnZhbHVlKTsKIH0KIAorc3ViIHRvZ2dsZVByb3BlcnR5Q2hhbmdlCit7CisgICAgbXkg KCRwYXRoLCAkZXhlY3V0YWJsZUJpdERlbHRhKSA9IEBfOworICAgIGlmICgkZXhlY3V0YWJsZUJp dERlbHRhID09IDEpIHsKKyAgICAgICAgc2NtQWRkRXhlY3V0YWJsZVByb3BlcnR5KCRwYXRoKTsK KyAgICB9IGVsc2lmICgkZXhlY3V0YWJsZUJpdERlbHRhID09IC0xKSB7CisgICAgICAgIHNjbVJl bW92ZUV4ZWN1dGFibGVQcm9wZXJ0eSgkcGF0aCk7CisgICAgfQorfQorCitzdWIgc2NtQWRkRXhl Y3V0YWJsZVByb3BlcnR5KCQpCit7CisgICAgbXkgKCRwYXRoKSA9IEBfOworCisgICAgcmV0dXJu IGlmICEgLWUgJHBhdGg7CisgICAgCisgICAgaWYgKGlzU1ZOKCkpIHsKKyAgICAgICAgc3lzdGVt KCJzdm4iLCAicHJvcHNldCIsICJzdm46ZXhlY3V0YWJsZSIsICJvbiIsICRwYXRoKSA9PSAwIG9y IGRpZSAiRmFpbGVkIHRvIHJ1biAnc3ZuIHByb3BzZXQgc3ZuOmV4ZWN1dGFibGUgb24gJHBhdGgn LiI7CisgICAgfSBlbHNpZiAoaXNHaXQoKSkgeworICAgICAgICBjaG1vZCgwNzU1LCAkcGF0aCk7 CisgICAgfQorfQorCitzdWIgc2NtUmVtb3ZlRXhlY3V0YWJsZVByb3BlcnR5KCQpCit7CisgICAg bXkgKCRwYXRoKSA9IEBfOworCisgICAgcmV0dXJuIGlmICEgLWUgJHBhdGg7CisKKyAgICBpZiAo aXNTVk4oKSkgeworICAgICAgICBzeXN0ZW0oInN2biIsICJwcm9wZGVsIiwgInN2bjpleGVjdXRh YmxlIiwgJHBhdGgpID09IDAgb3IgZGllICJGYWlsZWQgdG8gcnVuICdzdm4gcHJvcGRlbCBzdm46 ZXhlY3V0YWJsZSAkcGF0aCcuIjsKKyAgICB9IGVsc2lmIChpc0dpdCgpKSB7CisgICAgICAgIGNo bW9kKDA2NjQsICRwYXRoKTsKKyAgICB9Cit9CisKIHN1YiBpc0dpdERpcmVjdG9yeSgkKQogewog ICAgIG15ICgkZGlyKSA9IEBfOwpJbmRleDogV2ViS2l0VG9vbHMvU2NyaXB0cy9zdm4tYXBwbHkK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvU2NyaXB0cy9zdm4tYXBwbHkJKHJldmlzaW9uIDU4 NjM1KQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy9zdm4tYXBwbHkJKHdvcmtpbmcgY29weSkKQEAg LTMyNSw3ICszMjUsNyBAQCBzdWIgcGF0Y2goJCkKICAgICAkaXNCaW5hcnkgPSAxIGlmICRwYXRj aCA9fiAvXG5DYW5ub3QgZGlzcGxheTogZmlsZSBtYXJrZWQgYXMgYSBiaW5hcnkgdHlwZVwuLzsK ICAgICAkaXNHaXRCaW5hcnkgPSAxIGlmICRwYXRjaCA9fiAvXG5HSVQgYmluYXJ5IHBhdGNoXG4v OwogCi0gICAgaWYgKCEkYWRkaXRpb24gJiYgISRkZWxldGlvbiAmJiAhJGlzQmluYXJ5ICYmICEk aXNHaXRCaW5hcnkpIHsKKyAgICBpZiAoISRhZGRpdGlvbiAmJiAhJGRlbGV0aW9uICYmICEkaXNC aW5hcnkgJiYgISRpc0dpdEJpbmFyeSAmJiAhZGVmaW5lZCgkZGlmZkhhc2hSZWYtPntleGVjdXRh YmxlQml0RGVsdGF9KSkgewogICAgICAgICAjIFN0YW5kYXJkIHBhdGNoLCBwYXRjaCB0b29sIGNh biBoYW5kbGUgdGhpcy4KICAgICAgICAgaWYgKGJhc2VuYW1lKCRmdWxsUGF0aCkgZXEgIkNoYW5n ZUxvZyIpIHsKICAgICAgICAgICAgIG15ICRjaGFuZ2VMb2dEb3RPcmlnRXhpc3RlZCA9IC1mICIk e2Z1bGxQYXRofS5vcmlnIjsKQEAgLTM0OSw2ICszNDksOSBAQCBzdWIgcGF0Y2goJCkKICAgICAg ICAgICAgICMgRGVsZXRpb24KICAgICAgICAgICAgIGFwcGx5UGF0Y2goJHBhdGNoLCAkZnVsbFBh dGgsIFsiLS1mb3JjZSJdKTsKICAgICAgICAgICAgIHNjbVJlbW92ZSgkZnVsbFBhdGgpOworICAg ICAgICB9IGVsc2lmIChkZWZpbmVkKCRkaWZmSGFzaFJlZi0+e2V4ZWN1dGFibGVCaXREZWx0YX0p KSB7CisgICAgICAgICAgICAjIENoYW5nZSBleGVjdXRhYmxlIGJpdC4KKyAgICAgICAgICAgIHRv Z2dsZVByb3BlcnR5Q2hhbmdlKCRmdWxsUGF0aCwgJGRpZmZIYXNoUmVmLT57ZXhlY3V0YWJsZUJp dERlbHRhfSk7CiAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICAjIEFkZGl0aW9uCiAgICAg ICAgICAgICByZW5hbWUoJGZ1bGxQYXRoLCAiJGZ1bGxQYXRoLm9yaWciKSBpZiAtZSAkZnVsbFBh dGg7CkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL3N2bi11bmFwcGx5Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYktpdFRvb2xzL1NjcmlwdHMvc3ZuLXVuYXBwbHkJKHJldmlzaW9uIDU4NjM1KQorKysgV2Vi S2l0VG9vbHMvU2NyaXB0cy9zdm4tdW5hcHBseQkod29ya2luZyBjb3B5KQpAQCAtMTU5LDcgKzE1 OSw3IEBAIHN1YiBwYXRjaCgkKQogICAgICRkZWxldGlvbiA9IDEgaWYgJHBhdGNoID1+IC9cbkBA IC4qIFwrMCwwIEBALzsKICAgICAkaXNCaW5hcnkgPSAxIGlmICRwYXRjaCA9fiAvXG5DYW5ub3Qg ZGlzcGxheTogZmlsZSBtYXJrZWQgYXMgYSBiaW5hcnkgdHlwZVwuLzsKIAotICAgIGlmICghJGFk ZGl0aW9uICYmICEkZGVsZXRpb24gJiYgISRpc0JpbmFyeSkgeworICAgIGlmICghJGFkZGl0aW9u ICYmICEkZGVsZXRpb24gJiYgISRpc0JpbmFyeSAmJiAhZGVmaW5lZCgkZGlmZkhhc2hSZWYtPntl eGVjdXRhYmxlQml0RGVsdGF9KSkgewogICAgICAgICAjIFN0YW5kYXJkIHBhdGNoLCBwYXRjaCB0 b29sIGNhbiBoYW5kbGUgdGhpcy4KICAgICAgICAgaWYgKGJhc2VuYW1lKCRmdWxsUGF0aCkgZXEg IkNoYW5nZUxvZyIpIHsKICAgICAgICAgICAgIG15ICRjaGFuZ2VMb2dEb3RPcmlnRXhpc3RlZCA9 IC1mICIke2Z1bGxQYXRofS5vcmlnIjsKQEAgLTIwMSw2ICsyMDEsOSBAQCBzdWIgcGF0Y2goJCkK IAogICAgICAgICAgICAgIyBTaG93IHN0YXR1cyBpZiB0aGUgZmlsZSBpcyBtb2RpZmVkCiAgICAg ICAgICAgICBzeXN0ZW0gInN2biIsICJzdGF0IiwgJGZ1bGxQYXRoOworICAgICAgICB9IGVsc2lm IChkZWZpbmVkKCRkaWZmSGFzaFJlZi0+e2V4ZWN1dGFibGVCaXREZWx0YX0pKSB7CisgICAgICAg ICAgICAjIENoYW5nZSBleGVjdXRhYmxlIGJpdC4KKyAgICAgICAgICAgIHRvZ2dsZVByb3BlcnR5 Q2hhbmdlKCRmdWxsUGF0aCwgLTEgKiAkZGlmZkhhc2hSZWYtPntleGVjdXRhYmxlQml0RGVsdGF9 KTsKICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgICMgUmV2ZXJzZSBhZGRpdGlvbgogICAg ICAgICAgICAgdW5hcHBseVBhdGNoKCRwYXRjaCwgJGZ1bGxQYXRoLCBbIi0tZm9yY2UiXSk7Cg== 54857 2010-05-01 14:39:44 -0700 2010-05-01 15:12:54 -0700 Patch Bug38423.patch text/plain 4060 dbates SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU4NjM2KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTAtMDUtMDEgIERhbmllbCBCYXRlcyAgPGRi YXRlc0ByaW0uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODQyMworCisg ICAgICAgIEFkZHMgaW5mcmFzdHJ1Y3R1cmUgdG8gY2hhbmdlIHRoZSBmaWxlIG1vZGUgb2YgYSBm aWxlIHVzaW5nCisgICAgICAgIHRoZSBhcHByb3ByaWF0ZSBTQ00tc3BlY2lmaWMgcm91dGluZXMu CisKKyAgICAgICAgTm8gZnVuY3Rpb25hbGl0eSB3YXMgY2hhbmdlZCwgc28gbm8gbmV3IHRlc3Rz LgorCisgICAgICAgICogU2NyaXB0cy9WQ1NVdGlscy5wbTogQWRkZWQgc3Vicm91dGluZXMgdG9n Z2xlRXhlY3V0YWJsZUJpdCwKKyAgICAgICAgc2NtQWRkRXhlY3V0YWJsZUJpdCwgYW5kIHNjbVJl bW92ZUV4ZWN1dGFibGVCaXQuCisgICAgICAgICogU2NyaXB0cy9zdm4tYXBwbHk6IENoZWNrIGZv ciB0aGUgaGFzaCBrZXkgZXhlY3V0YWJsZUJpdERlbHRhCisgICAgICAgIGFuZCB0b2dnbGUgdGhl IGV4ZWN1dGFibGUgYml0LgorICAgICAgICAqIFNjcmlwdHMvc3ZuLXVuYXBwbHk6IERpdHRvLgor CiAyMDEwLTA0LTMwICBDaHJpcyBNYXJyaW4gIDxjbWFycmluQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL1ZD U1V0aWxzLnBtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvVkNTVXRpbHMucG0J KHJldmlzaW9uIDU4NjM1KQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy9WQ1NVdGlscy5wbQkod29y a2luZyBjb3B5KQpAQCAtOTcsNiArOTcsNDIgQEAgc3ViIGV4aXRTdGF0dXMoJCkKICAgICByZXR1 cm4gV0VYSVRTVEFUVVMoJHJldHVybnZhbHVlKTsKIH0KIAorc3ViIHRvZ2dsZUV4ZWN1dGFibGVC aXQKK3sKKyAgICBteSAoJHBhdGgsICRleGVjdXRhYmxlQml0RGVsdGEpID0gQF87CisgICAgaWYg KCRleGVjdXRhYmxlQml0RGVsdGEgPT0gMSkgeworICAgICAgICBzY21BZGRFeGVjdXRhYmxlQml0 KCRwYXRoKTsKKyAgICB9IGVsc2lmICgkZXhlY3V0YWJsZUJpdERlbHRhID09IC0xKSB7CisgICAg ICAgIHNjbVJlbW92ZUV4ZWN1dGFibGVCaXQoJHBhdGgpOworICAgIH0KK30KKworc3ViIHNjbUFk ZEV4ZWN1dGFibGVCaXQoJCkKK3sKKyAgICBteSAoJHBhdGgpID0gQF87CisKKyAgICByZXR1cm4g aWYgISAtZSAkcGF0aDsKKworICAgIGlmIChpc1NWTigpKSB7CisgICAgICAgIHN5c3RlbSgic3Zu IiwgInByb3BzZXQiLCAic3ZuOmV4ZWN1dGFibGUiLCAib24iLCAkcGF0aCkgPT0gMCBvciBkaWUg IkZhaWxlZCB0byBydW4gJ3N2biBwcm9wc2V0IHN2bjpleGVjdXRhYmxlIG9uICRwYXRoJy4iOwor ICAgIH0gZWxzaWYgKGlzR2l0KCkpIHsKKyAgICAgICAgY2htb2QoMDc1NSwgJHBhdGgpOworICAg IH0KK30KKworc3ViIHNjbVJlbW92ZUV4ZWN1dGFibGVCaXQoJCkKK3sKKyAgICBteSAoJHBhdGgp ID0gQF87CisKKyAgICByZXR1cm4gaWYgISAtZSAkcGF0aDsKKworICAgIGlmIChpc1NWTigpKSB7 CisgICAgICAgIHN5c3RlbSgic3ZuIiwgInByb3BkZWwiLCAic3ZuOmV4ZWN1dGFibGUiLCAkcGF0 aCkgPT0gMCBvciBkaWUgIkZhaWxlZCB0byBydW4gJ3N2biBwcm9wZGVsIHN2bjpleGVjdXRhYmxl ICRwYXRoJy4iOworICAgIH0gZWxzaWYgKGlzR2l0KCkpIHsKKyAgICAgICAgY2htb2QoMDY2NCwg JHBhdGgpOworICAgIH0KK30KKwogc3ViIGlzR2l0RGlyZWN0b3J5KCQpCiB7CiAgICAgbXkgKCRk aXIpID0gQF87CkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL3N2bi1hcHBseQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL3N2bi1hcHBseQkocmV2aXNpb24gNTg2MzUpCisrKyBX ZWJLaXRUb29scy9TY3JpcHRzL3N2bi1hcHBseQkod29ya2luZyBjb3B5KQpAQCAtMzI1LDcgKzMy NSw3IEBAIHN1YiBwYXRjaCgkKQogICAgICRpc0JpbmFyeSA9IDEgaWYgJHBhdGNoID1+IC9cbkNh bm5vdCBkaXNwbGF5OiBmaWxlIG1hcmtlZCBhcyBhIGJpbmFyeSB0eXBlXC4vOwogICAgICRpc0dp dEJpbmFyeSA9IDEgaWYgJHBhdGNoID1+IC9cbkdJVCBiaW5hcnkgcGF0Y2hcbi87CiAKLSAgICBp ZiAoISRhZGRpdGlvbiAmJiAhJGRlbGV0aW9uICYmICEkaXNCaW5hcnkgJiYgISRpc0dpdEJpbmFy eSkgeworICAgIGlmICghJGFkZGl0aW9uICYmICEkZGVsZXRpb24gJiYgISRpc0JpbmFyeSAmJiAh JGlzR2l0QmluYXJ5ICYmICFkZWZpbmVkKCRkaWZmSGFzaFJlZi0+e2V4ZWN1dGFibGVCaXREZWx0 YX0pKSB7CiAgICAgICAgICMgU3RhbmRhcmQgcGF0Y2gsIHBhdGNoIHRvb2wgY2FuIGhhbmRsZSB0 aGlzLgogICAgICAgICBpZiAoYmFzZW5hbWUoJGZ1bGxQYXRoKSBlcSAiQ2hhbmdlTG9nIikgewog ICAgICAgICAgICAgbXkgJGNoYW5nZUxvZ0RvdE9yaWdFeGlzdGVkID0gLWYgIiR7ZnVsbFBhdGh9 Lm9yaWciOwpAQCAtMzU5LDYgKzM1OSw4IEBAIHN1YiBwYXRjaCgkKQogICAgICAgICAgICAgc3lz dGVtKCJzdm4iLCAic3RhdCIsICIkZnVsbFBhdGgub3JpZyIpIGlmIGlzU1ZOKCkgJiYgLWUgIiRm dWxsUGF0aC5vcmlnIjsKICAgICAgICAgfQogICAgIH0KKworICAgIHRvZ2dsZUV4ZWN1dGFibGVC aXQoJGZ1bGxQYXRoLCAkZGlmZkhhc2hSZWYtPntleGVjdXRhYmxlQml0RGVsdGF9KSBpZiBkZWZp bmVkKCRkaWZmSGFzaFJlZi0+e2V4ZWN1dGFibGVCaXREZWx0YX0pOwogfQogCiBzdWIgcmVtb3Zl RGlyZWN0b3JpZXNJZk5lZWRlZCgpCkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL3N2bi11bmFw cGx5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvc3ZuLXVuYXBwbHkJKHJldmlz aW9uIDU4NjM1KQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy9zdm4tdW5hcHBseQkod29ya2luZyBj b3B5KQpAQCAtMTU5LDcgKzE1OSw3IEBAIHN1YiBwYXRjaCgkKQogICAgICRkZWxldGlvbiA9IDEg aWYgJHBhdGNoID1+IC9cbkBAIC4qIFwrMCwwIEBALzsKICAgICAkaXNCaW5hcnkgPSAxIGlmICRw YXRjaCA9fiAvXG5DYW5ub3QgZGlzcGxheTogZmlsZSBtYXJrZWQgYXMgYSBiaW5hcnkgdHlwZVwu LzsKIAotICAgIGlmICghJGFkZGl0aW9uICYmICEkZGVsZXRpb24gJiYgISRpc0JpbmFyeSkgewor ICAgIGlmICghJGFkZGl0aW9uICYmICEkZGVsZXRpb24gJiYgISRpc0JpbmFyeSAmJiAhZGVmaW5l ZCgkZGlmZkhhc2hSZWYtPntleGVjdXRhYmxlQml0RGVsdGF9KSkgewogICAgICAgICAjIFN0YW5k YXJkIHBhdGNoLCBwYXRjaCB0b29sIGNhbiBoYW5kbGUgdGhpcy4KICAgICAgICAgaWYgKGJhc2Vu YW1lKCRmdWxsUGF0aCkgZXEgIkNoYW5nZUxvZyIpIHsKICAgICAgICAgICAgIG15ICRjaGFuZ2VM b2dEb3RPcmlnRXhpc3RlZCA9IC1mICIke2Z1bGxQYXRofS5vcmlnIjsKQEAgLTIwOCw2ICsyMDgs OCBAQCBzdWIgcGF0Y2goJCkKICAgICAgICAgICAgIHN5c3RlbSAic3ZuIiwgInJldmVydCIsICRm dWxsUGF0aDsKICAgICAgICAgfQogICAgIH0KKworICAgIHRvZ2dsZUV4ZWN1dGFibGVCaXQoJGZ1 bGxQYXRoLCAtMSAqICRkaWZmSGFzaFJlZi0+e2V4ZWN1dGFibGVCaXREZWx0YX0pIGlmIGRlZmlu ZWQoJGRpZmZIYXNoUmVmLT57ZXhlY3V0YWJsZUJpdERlbHRhfSk7CiB9CiAKIHN1YiByZXZlcnRE aXJlY3RvcmllcygpCg== 54858 2010-05-01 15:12:54 -0700 2010-05-01 15:25:52 -0700 Patch Bug38423.patch text/plain 3115 dbates SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU4NjM2KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTAtMDUtMDEgIERhbmllbCBCYXRlcyAgPGRi YXRlc0ByaW0uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODQyMworCisg ICAgICAgIEFkZHMgaW5mcmFzdHJ1Y3R1cmUgdG8gY2hhbmdlIHRoZSBmaWxlIG1vZGUgb2YgYSBm aWxlIHVzaW5nCisgICAgICAgIHRoZSBhcHByb3ByaWF0ZSBTQ00tc3BlY2lmaWMgcm91dGluZXMu CisKKyAgICAgICAgTm8gZnVuY3Rpb25hbGl0eSB3YXMgY2hhbmdlZCwgc28gbm8gbmV3IHRlc3Rz LgorCisgICAgICAgICogU2NyaXB0cy9WQ1NVdGlscy5wbTogQWRkZWQgc3Vicm91dGluZXMgdG9n Z2xlRXhlY3V0YWJsZUJpdCwKKyAgICAgICAgc2NtQWRkRXhlY3V0YWJsZUJpdCwgYW5kIHNjbVJl bW92ZUV4ZWN1dGFibGVCaXQuCisgICAgICAgICogU2NyaXB0cy9zdm4tYXBwbHk6IENoZWNrIGZv ciB0aGUgaGFzaCBrZXkgZXhlY3V0YWJsZUJpdERlbHRhCisgICAgICAgIGFuZCB0b2dnbGUgdGhl IGV4ZWN1dGFibGUgYml0LgorICAgICAgICAqIFNjcmlwdHMvc3ZuLXVuYXBwbHk6IERpdHRvLgor CiAyMDEwLTA0LTMwICBDaHJpcyBNYXJyaW4gIDxjbWFycmluQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL1ZD U1V0aWxzLnBtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvVkNTVXRpbHMucG0J KHJldmlzaW9uIDU4NjM1KQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy9WQ1NVdGlscy5wbQkod29y a2luZyBjb3B5KQpAQCAtOTcsNiArOTcsNDAgQEAgc3ViIGV4aXRTdGF0dXMoJCkKICAgICByZXR1 cm4gV0VYSVRTVEFUVVMoJHJldHVybnZhbHVlKTsKIH0KIAorc3ViIHRvZ2dsZUV4ZWN1dGFibGVC aXQKK3sKKyAgICBteSAoJHBhdGgsICRleGVjdXRhYmxlQml0RGVsdGEpID0gQF87CisgICAgaWYg KCRleGVjdXRhYmxlQml0RGVsdGEgPT0gMSkgeworICAgICAgICBzY21BZGRFeGVjdXRhYmxlQml0 KCRwYXRoKTsKKyAgICB9IGVsc2lmICgkZXhlY3V0YWJsZUJpdERlbHRhID09IC0xKSB7CisgICAg ICAgIHNjbVJlbW92ZUV4ZWN1dGFibGVCaXQoJHBhdGgpOworICAgIH0KK30KKworc3ViIHNjbUFk ZEV4ZWN1dGFibGVCaXQoJCkKK3sKKyAgICBteSAoJHBhdGgpID0gQF87CisKKyAgICBpZiAoaXNT Vk4oKSkgeworICAgICAgICBzeXN0ZW0oInN2biIsICJwcm9wc2V0IiwgInN2bjpleGVjdXRhYmxl IiwgIm9uIiwgJHBhdGgpID09IDAgb3IgZGllICJGYWlsZWQgdG8gcnVuICdzdm4gcHJvcHNldCBz dm46ZXhlY3V0YWJsZSBvbiAkcGF0aCcuIjsKKyAgICB9IGVsc2lmIChpc0dpdCgpKSB7CisgICAg ICAgIGNobW9kKDA3NTUsICRwYXRoKTsKKyAgICB9Cit9CisKK3N1YiBzY21SZW1vdmVFeGVjdXRh YmxlQml0KCQpCit7CisgICAgbXkgKCRwYXRoKSA9IEBfOworCisgICAgcmV0dXJuIGlmICEgLWUg JHBhdGg7ICMgSWYgdGhlIGZpbGUgd2FzIHJlbW92ZWQsIHNheSBhcyBwYXJ0IG9mIHVuYXBwbHlp bmcgYSBwYXRjaCwgdGhlbiB3ZSBkbyBub3QgbmVlZCB0byB1bnNldCB0aGUgZXhlY3V0YWJsZSBi aXQuCisKKyAgICBpZiAoaXNTVk4oKSkgeworICAgICAgICBzeXN0ZW0oInN2biIsICJwcm9wZGVs IiwgInN2bjpleGVjdXRhYmxlIiwgJHBhdGgpID09IDAgb3IgZGllICJGYWlsZWQgdG8gcnVuICdz dm4gcHJvcGRlbCBzdm46ZXhlY3V0YWJsZSAkcGF0aCcuIjsKKyAgICB9IGVsc2lmIChpc0dpdCgp KSB7CisgICAgICAgIGNobW9kKDA2NjQsICRwYXRoKTsKKyAgICB9Cit9CisKIHN1YiBpc0dpdERp cmVjdG9yeSgkKQogewogICAgIG15ICgkZGlyKSA9IEBfOwpJbmRleDogV2ViS2l0VG9vbHMvU2Ny aXB0cy9zdm4tYXBwbHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvU2NyaXB0cy9zdm4tYXBw bHkJKHJldmlzaW9uIDU4NjM1KQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy9zdm4tYXBwbHkJKHdv cmtpbmcgY29weSkKQEAgLTM1OSw2ICszNTksOCBAQCBzdWIgcGF0Y2goJCkKICAgICAgICAgICAg IHN5c3RlbSgic3ZuIiwgInN0YXQiLCAiJGZ1bGxQYXRoLm9yaWciKSBpZiBpc1NWTigpICYmIC1l ICIkZnVsbFBhdGgub3JpZyI7CiAgICAgICAgIH0KICAgICB9CisKKyAgICB0b2dnbGVFeGVjdXRh YmxlQml0KCRmdWxsUGF0aCwgJGRpZmZIYXNoUmVmLT57ZXhlY3V0YWJsZUJpdERlbHRhfSkgaWYg ZGVmaW5lZCgkZGlmZkhhc2hSZWYtPntleGVjdXRhYmxlQml0RGVsdGF9KTsKIH0KIAogc3ViIHJl bW92ZURpcmVjdG9yaWVzSWZOZWVkZWQoKQpJbmRleDogV2ViS2l0VG9vbHMvU2NyaXB0cy9zdm4t dW5hcHBseQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL3N2bi11bmFwcGx5CShy ZXZpc2lvbiA1ODYzNSkKKysrIFdlYktpdFRvb2xzL1NjcmlwdHMvc3ZuLXVuYXBwbHkJKHdvcmtp bmcgY29weSkKQEAgLTIwOCw2ICsyMDgsOCBAQCBzdWIgcGF0Y2goJCkKICAgICAgICAgICAgIHN5 c3RlbSAic3ZuIiwgInJldmVydCIsICRmdWxsUGF0aDsKICAgICAgICAgfQogICAgIH0KKworICAg IHRvZ2dsZUV4ZWN1dGFibGVCaXQoJGZ1bGxQYXRoLCAtMSAqICRkaWZmSGFzaFJlZi0+e2V4ZWN1 dGFibGVCaXREZWx0YX0pIGlmIGRlZmluZWQoJGRpZmZIYXNoUmVmLT57ZXhlY3V0YWJsZUJpdERl bHRhfSk7CiB9CiAKIHN1YiByZXZlcnREaXJlY3RvcmllcygpCg== 54859 2010-05-01 15:25:52 -0700 2010-05-01 15:44:33 -0700 Patch Bug38423.patch text/plain 3104 dbates SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU4NjM2KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTAtMDUtMDEgIERhbmllbCBCYXRlcyAgPGRi YXRlc0ByaW0uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODQyMworCisg ICAgICAgIEFkZHMgaW5mcmFzdHJ1Y3R1cmUgdG8gY2hhbmdlIHRoZSBmaWxlIG1vZGUgb2YgYSBm aWxlIHVzaW5nCisgICAgICAgIHRoZSBhcHByb3ByaWF0ZSBTQ00tc3BlY2lmaWMgcm91dGluZXMu CisKKyAgICAgICAgTm8gZnVuY3Rpb25hbGl0eSB3YXMgY2hhbmdlZCwgc28gbm8gbmV3IHRlc3Rz LgorCisgICAgICAgICogU2NyaXB0cy9WQ1NVdGlscy5wbTogQWRkZWQgc3Vicm91dGluZXMgc2Nt VG9nZ2xlRXhlY3V0YWJsZUJpdCwKKyAgICAgICAgc2NtQWRkRXhlY3V0YWJsZUJpdCwgYW5kIHNj bVJlbW92ZUV4ZWN1dGFibGVCaXQuCisgICAgICAgICogU2NyaXB0cy9zdm4tYXBwbHk6IENoZWNr IGZvciB0aGUgaGFzaCBrZXkgZXhlY3V0YWJsZUJpdERlbHRhCisgICAgICAgIGFuZCB0b2dnbGUg dGhlIGV4ZWN1dGFibGUgYml0LgorICAgICAgICAqIFNjcmlwdHMvc3ZuLXVuYXBwbHk6IERpdHRv LgorCiAyMDEwLTA0LTMwICBDaHJpcyBNYXJyaW4gIDxjbWFycmluQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRz L1ZDU1V0aWxzLnBtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvVkNTVXRpbHMu cG0JKHJldmlzaW9uIDU4NjM1KQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy9WQ1NVdGlscy5wbQko d29ya2luZyBjb3B5KQpAQCAtOTcsNiArOTcsNDAgQEAgc3ViIGV4aXRTdGF0dXMoJCkKICAgICBy ZXR1cm4gV0VYSVRTVEFUVVMoJHJldHVybnZhbHVlKTsKIH0KIAorIyBOb3RlLCB0aGlzIG1ldGhv ZCB3aWxsIG5vdCBlcnJvciBpZiB0aGUgZmlsZSBjb3JyZXNwb25kaW5nIHRvIHRoZSBwYXRoIGRv ZXMgbm90IGV4aXN0Lgorc3ViIHNjbVRvZ2dsZUV4ZWN1dGFibGVCaXQKK3sKKyAgICBteSAoJHBh dGgsICRleGVjdXRhYmxlQml0RGVsdGEpID0gQF87CisgICAgcmV0dXJuIGlmICEgLWUgJHBhdGg7 CisgICAgaWYgKCRleGVjdXRhYmxlQml0RGVsdGEgPT0gMSkgeworICAgICAgICBzY21BZGRFeGVj dXRhYmxlQml0KCRwYXRoKTsKKyAgICB9IGVsc2lmICgkZXhlY3V0YWJsZUJpdERlbHRhID09IC0x KSB7CisgICAgICAgIHNjbVJlbW92ZUV4ZWN1dGFibGVCaXQoJHBhdGgpOworICAgIH0KK30KKwor c3ViIHNjbUFkZEV4ZWN1dGFibGVCaXQoJCkKK3sKKyAgICBteSAoJHBhdGgpID0gQF87CisKKyAg ICBpZiAoaXNTVk4oKSkgeworICAgICAgICBzeXN0ZW0oInN2biIsICJwcm9wc2V0IiwgInN2bjpl eGVjdXRhYmxlIiwgIm9uIiwgJHBhdGgpID09IDAgb3IgZGllICJGYWlsZWQgdG8gcnVuICdzdm4g cHJvcHNldCBzdm46ZXhlY3V0YWJsZSBvbiAkcGF0aCcuIjsKKyAgICB9IGVsc2lmIChpc0dpdCgp KSB7CisgICAgICAgIGNobW9kKDA3NTUsICRwYXRoKTsKKyAgICB9Cit9CisKK3N1YiBzY21SZW1v dmVFeGVjdXRhYmxlQml0KCQpCit7CisgICAgbXkgKCRwYXRoKSA9IEBfOworCisgICAgaWYgKGlz U1ZOKCkpIHsKKyAgICAgICAgc3lzdGVtKCJzdm4iLCAicHJvcGRlbCIsICJzdm46ZXhlY3V0YWJs ZSIsICRwYXRoKSA9PSAwIG9yIGRpZSAiRmFpbGVkIHRvIHJ1biAnc3ZuIHByb3BkZWwgc3ZuOmV4 ZWN1dGFibGUgJHBhdGgnLiI7CisgICAgfSBlbHNpZiAoaXNHaXQoKSkgeworICAgICAgICBjaG1v ZCgwNjY0LCAkcGF0aCk7CisgICAgfQorfQorCiBzdWIgaXNHaXREaXJlY3RvcnkoJCkKIHsKICAg ICBteSAoJGRpcikgPSBAXzsKSW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvc3ZuLWFwcGx5Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvc3ZuLWFwcGx5CShyZXZpc2lvbiA1ODYz NSkKKysrIFdlYktpdFRvb2xzL1NjcmlwdHMvc3ZuLWFwcGx5CSh3b3JraW5nIGNvcHkpCkBAIC0z NTksNiArMzU5LDggQEAgc3ViIHBhdGNoKCQpCiAgICAgICAgICAgICBzeXN0ZW0oInN2biIsICJz dGF0IiwgIiRmdWxsUGF0aC5vcmlnIikgaWYgaXNTVk4oKSAmJiAtZSAiJGZ1bGxQYXRoLm9yaWci OwogICAgICAgICB9CiAgICAgfQorCisgICAgc2NtVG9nZ2xlRXhlY3V0YWJsZUJpdCgkZnVsbFBh dGgsICRkaWZmSGFzaFJlZi0+e2V4ZWN1dGFibGVCaXREZWx0YX0pIGlmIGRlZmluZWQoJGRpZmZI YXNoUmVmLT57ZXhlY3V0YWJsZUJpdERlbHRhfSk7CiB9CiAKIHN1YiByZW1vdmVEaXJlY3Rvcmll c0lmTmVlZGVkKCkKSW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvc3ZuLXVuYXBwbHkKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViS2l0VG9vbHMvU2NyaXB0cy9zdm4tdW5hcHBseQkocmV2aXNpb24gNTg2MzUp CisrKyBXZWJLaXRUb29scy9TY3JpcHRzL3N2bi11bmFwcGx5CSh3b3JraW5nIGNvcHkpCkBAIC0y MDgsNiArMjA4LDggQEAgc3ViIHBhdGNoKCQpCiAgICAgICAgICAgICBzeXN0ZW0gInN2biIsICJy ZXZlcnQiLCAkZnVsbFBhdGg7CiAgICAgICAgIH0KICAgICB9CisKKyAgICBzY21Ub2dnbGVFeGVj dXRhYmxlQml0KCRmdWxsUGF0aCwgLTEgKiAkZGlmZkhhc2hSZWYtPntleGVjdXRhYmxlQml0RGVs dGF9KSBpZiBkZWZpbmVkKCRkaWZmSGFzaFJlZi0+e2V4ZWN1dGFibGVCaXREZWx0YX0pOwogfQog CiBzdWIgcmV2ZXJ0RGlyZWN0b3JpZXMoKQo=