38384 2010-04-30 02:58:19 -0700 [GStreamer] endless loop after playback ended 2010-05-03 08:20:03 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED http://blogs.gnome.org/xan/files/2010/04/woot.ogg P2 Normal --- 1 pnormand pnormand abarth atwilson eric.carlson eric webkit.review.bot oldest_to_newest 219415 0 pnormand 2010-04-30 02:58:19 -0700 Linked video will play fine but the player fails to get its duration. So when playback ends the player sets the duration to the current playback position and pause the pipeline. But duration() still returns inf because the m_mediaDurationKnown is still false. This triggers and infinite loop because HTMLMediaElement::endedPlayback will always return false (isnan(dur) check still passing). This flag needs to be set to true in didEnd() if m_mediaDuration is known. 219416 1 54790 pnormand 2010-04-30 03:07:47 -0700 Created attachment 54790 proposed patch+test 219546 2 54790 eric 2010-04-30 11:42:25 -0700 Comment on attachment 54790 proposed patch+test Looks reasonable. 220095 3 webkit.review.bot 2010-05-03 07:28:24 -0700 http://trac.webkit.org/changeset/58671 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/58672 http://trac.webkit.org/changeset/58671 220117 4 pnormand 2010-05-03 08:20:03 -0700 Landed in r58671 and skipped the test in r58674. See also https://bugs.webkit.org/show_bug.cgi?id=38466 54790 2010-04-30 03:07:47 -0700 2010-04-30 11:42:24 -0700 proposed patch+test 0001-proposed-patch-test.patch text/plain 4205 pnormand RnJvbSAxMzU0YTMyYzk0MDY1MzY5NTZhNWU5MjFiMzdkY2YzMjIzOTEyMzA2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBGcmksIDMwIEFwciAyMDEwIDEyOjA1OjUxICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2grdGVzdAoKLS0tCiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB8ICAgMTAgKysrKysKIC4uLi92aWRlby1kdXJhdGlvbi1rbm93 bi1hZnRlci1lb3MtZXhwZWN0ZWQudHh0ICAgIHwgICAgNyArKysrCiAuLi4vbWVkaWEvdmlkZW8t ZHVyYXRpb24ta25vd24tYWZ0ZXItZW9zLmh0bWwgICAgICB8ICAgMzcgKysrKysrKysrKysrKysr KysrKysKIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHwgICAxNSArKysrKysrKwogLi4uL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXIuY3BwICAgICAgfCAgICAxICsKIDUgZmlsZXMgY2hhbmdlZCwgNzAgaW5zZXJ0aW9ucygrKSwg MCBkZWxldGlvbnMoLSkKIGNyZWF0ZSBtb2RlIDEwMDY0NCBMYXlvdXRUZXN0cy9tZWRpYS92aWRl by1kdXJhdGlvbi1rbm93bi1hZnRlci1lb3MtZXhwZWN0ZWQudHh0CiBjcmVhdGUgbW9kZSAxMDA2 NDQgTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tZHVyYXRpb24ta25vd24tYWZ0ZXItZW9zLmh0bWwK CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKaW5kZXggZGI1YjE3Mi4uMDllYzE3ZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEwLTA0 LTMwICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1N0cmVhbWVyXSBlbmRsZXNz IGxvb3AgYWZ0ZXIgcGxheWJhY2sgZW5kZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTM4Mzg0CisKKyAgICAgICAgKiBtZWRpYS92aWRlby1kdXJhdGlv bi1rbm93bi1hZnRlci1lb3MtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBtZWRpYS92 aWRlby1kdXJhdGlvbi1rbm93bi1hZnRlci1lb3MuaHRtbDogQWRkZWQuCisKIDIwMTAtMDQtMzAg IEZ1bWl0b3NoaSBVa2FpICA8dWthaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdk LCB0ZXN0IGV4cGVjdGF0aW9ucyBjbGVhbnVwLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVk aWEvdmlkZW8tZHVyYXRpb24ta25vd24tYWZ0ZXItZW9zLWV4cGVjdGVkLnR4dCBiL0xheW91dFRl c3RzL21lZGlhL3ZpZGVvLWR1cmF0aW9uLWtub3duLWFmdGVyLWVvcy1leHBlY3RlZC50eHQKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZTA2N2M1MgotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLWR1cmF0aW9uLWtub3duLWFmdGVyLWVvcy1leHBl Y3RlZC50eHQKQEAgLTAsMCArMSw3IEBACitUZXN0cyB0aGF0IGR1cmF0aW9uIGlzIGtub3duIGFm dGVyIHBsYXliYWNrIGVuZGVkLgorCisKK1JVTih2aWRlby5wbGF5KCkpCitFWFBFQ1RFRCAodmlk ZW8uZHVyYXRpb24gPiAnMCcpIE9LCitFTkQgT0YgVEVTVAorCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9tZWRpYS92aWRlby1kdXJhdGlvbi1rbm93bi1hZnRlci1lb3MuaHRtbCBiL0xheW91dFRl c3RzL21lZGlhL3ZpZGVvLWR1cmF0aW9uLWtub3duLWFmdGVyLWVvcy5odG1sCm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmY3MDYwMjcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9tZWRpYS92aWRlby1kdXJhdGlvbi1rbm93bi1hZnRlci1lb3MuaHRtbApAQCAtMCww ICsxLDM3IEBACis8IURPQ1RZUEUgSFRNTD4KKworPGh0bWw+CisgICAgPGhlYWQ+CisgICAgICAg IDx0aXRsZT5sb2NhbCB2aWRlbzwvdGl0bGU+CisKKyAgICAgICAgPHNjcmlwdCBzcmM9bWVkaWEt ZmlsZS5qcz48L3NjcmlwdD4KKyAgICAgICAgPHNjcmlwdCBzcmM9dmlkZW8tdGVzdC5qcz48L3Nj cmlwdD4KKworICAgICAgICA8c2NyaXB0PgorICAgICAgICAgICAgZnVuY3Rpb24gZW5kZWQoKQor ICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgidmlkZW8uZHVyYXRp b24iLCAwLCAnPicpOworICAgICAgICAgICAgICAgIGVuZFRlc3QoKTsKKyAgICAgICAgICAgIH0K KworICAgICAgICAgICAgZnVuY3Rpb24gc3RhcnQoKQorICAgICAgICAgICAgeworICAgICAgICAg ICAgICAgIGZpbmRNZWRpYUVsZW1lbnQoKTsKKworICAgICAgICAgICAgICAgIHZpZGVvLmFkZEV2 ZW50TGlzdGVuZXIoImVuZGVkIiwgZW5kZWQpOworCisgICAgICAgICAgICAgICAgdmlkZW8uc3Jj ID0gZmluZE1lZGlhRmlsZSgidmlkZW8iLCAiY29udGVudC90ZXN0Iik7CisgICAgICAgICAgICAg ICAgY29uc29sZVdyaXRlKCIiKTsKKyAgICAgICAgICAgICAgICBydW4oInZpZGVvLnBsYXkoKSIp OworICAgICAgICAgICAgfQorCisgICAgICAgIDwvc2NyaXB0PgorICAgIDwvaGVhZD4KKyAgICA8 Ym9keT4KKyAgICAgICAgPHZpZGVvIGNvbnRyb2xzIGF1dG9idWZmZXI+PC92aWRlbz4KKyAgICAg ICAgPHA+VGVzdHMgdGhhdCBkdXJhdGlvbiBpcyBrbm93biBhZnRlciBwbGF5YmFjayBlbmRlZC48 L3A+CisgICAgICAgIDxzY3JpcHQ+c3RhcnQoKTwvc2NyaXB0PgorICAgIDwvYm9keT4KKzwvaHRt bD4KKworCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9n CmluZGV4IDM0Mzc3YzcuLjZhMmI2YjcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisr KyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDQtMzAgIFBoaWxp cHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHU3RyZWFtZXJdIGVuZGxlc3MgbG9vcCBhZnRl ciBwbGF5YmFjayBlbmRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzgzODQKKworICAgICAgICBBdCBwbGF5YmFjayBlbmQgZW5zdXJlIGR1cmF0aW9u KCkgd2lsbCByZXR1cm4gYSB2YWxpZCBkdXJhdGlvbiBpZgorICAgICAgICB3ZSBtYW5hZ2VkIHRv IGNhbGN1bGF0ZSBpdCBiYXNlZCBvbiBjdXJyZW50IHBvc2l0aW9uLgorCisgICAgICAgIFRlc3Q6 IG1lZGlhL3ZpZGVvLWR1cmF0aW9uLWtub3duLWFmdGVyLWVvcy5odG1sCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6ZGlkRW5k KToKKwogMjAxMC0wNC0zMCAgU2hpbmljaGlybyBIYW1hamkgIDxoYW1hamlAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVy LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lci5jcHAKaW5kZXggMGFmYjk3MS4uOGY2YzllMCAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVh bWVyLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBs YXllclByaXZhdGVHU3RyZWFtZXIuY3BwCkBAIC0xMTExLDYgKzExMTEsNyBAQCB2b2lkIE1lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6ZGlkRW5kKCkKICAgICBmbG9hdCBub3cgPSBjdXJyZW50 VGltZSgpOwogICAgIGlmIChub3cgPiAwKSB7CiAgICAgICAgIG1fbWVkaWFEdXJhdGlvbiA9IG5v dzsKKyAgICAgICAgbV9tZWRpYUR1cmF0aW9uS25vd24gPSB0cnVlOwogICAgICAgICBtX3BsYXll ci0+ZHVyYXRpb25DaGFuZ2VkKCk7CiAgICAgfQogCi0tIAoxLjYuMy4zCgo=