38382 2010-04-30 02:02:49 -0700 [Qt] Build error in GraphicsContext3DQt.cpp 2010-05-02 05:05:34 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 jarkko.j.sakkinen webkit-unassigned commit-queue noam oldest_to_newest 219405 0 jarkko.j.sakkinen 2010-04-30 02:02:49 -0700 - Noam made duplicate patch on isGLES2Compliant. After little thinking I think his patch does this in correct way and mine does in a wrong. Have to remove my implementation. - texImage2D/texSubImage2D API has been changed. 219406 1 jarkko.j.sakkinen 2010-04-30 02:03:48 -0700 Noam, I'm submitting patch for this ASAP. 219408 2 noam 2010-04-30 02:06:52 -0700 Thanks Jarkko... I guess we had a mid-air collision on this :) 219411 3 54789 jarkko.j.sakkinen 2010-04-30 02:33:05 -0700 Created attachment 54789 Build fixes. 219412 4 jarkko.j.sakkinen 2010-04-30 02:33:25 -0700 Yeah, np :) 219548 5 54789 eric 2010-04-30 11:43:28 -0700 Comment on attachment 54789 Build fixes. LGTM. 219823 6 54789 commit-queue 2010-05-02 05:05:29 -0700 Comment on attachment 54789 Build fixes. Clearing flags on attachment: 54789 Committed r58651: <http://trac.webkit.org/changeset/58651> 219824 7 commit-queue 2010-05-02 05:05:34 -0700 All reviewed patches have been landed. Closing bug. 54789 2010-04-30 02:33:05 -0700 2010-05-02 05:05:29 -0700 Build fixes. 38382.diff text/plain 3185 jarkko.j.sakkinen ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MjljNjZjOC4uMDM1MGVmYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNC0zMCAgSmFya2tvIFNha2tp bmVuICA8amFya2tvLmouc2Fra2luZW5AZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gQnVpbGQgZXJyb3IgaW4gR3JhcGhpY3ND b250ZXh0M0RRdC5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM4MzgyCisKKyAgICAgICAgUmVtb3ZlZCBkdXBsaWNhdGUgaW1wbGVtZW50YXRpb24g b2YgaXNHTEVTMkNvbXBsaWFudCBmcm9tCisgICAgICAgIEdyYXBoaWNzQ29udGV4dDNEUXQuY3Bw LiBSZW1vdmVkIGRlcHJlY2F0ZWQgQVBJIHN0dWZmIGZvcgorICAgICAgICB0ZXhJbWFnZTJEL3Rl eFN1YkltYWdlMkQuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250 ZXh0M0RRdC5jcHA6CisKIDIwMTAtMDQtMjkgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KIAogICAgICAgICBVbnJldmlld2VkLiAgVXBkYXRlIEpTQyBDb2RlR2VuZXJhdG9yIGJhc2Vs aW5lLiAgTm90IHN1cmUgaG93IEkgbWlzc2VkCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dDNEUXQuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQzRFF0LmNwcAppbmRleCAwODQ3OWQxLi44MzE3MGYw IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4 dDNEUXQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250 ZXh0M0RRdC5jcHAKQEAgLTU3MiwxMSArNTcyLDYgQEAgdm9pZCBHcmFwaGljc0NvbnRleHQzRDo6 cmVzaGFwZShpbnQgd2lkdGgsIGludCBoZWlnaHQpCiAgICAgZ2xGbHVzaCgpOwogfQogCi1ib29s IEdyYXBoaWNzQ29udGV4dDNEOjppc0dMRVMyQ29tcGxpYW50KCkgY29uc3QKLXsKLSAgICByZXR1 cm4gbV9pbnRlcm5hbC0+bV9nbFdpZGdldC0+cGFpbnRFbmdpbmUoKS0+dHlwZSgpID09IFFQYWlu dEVuZ2luZTo6T3BlbkdMMjsKLX0KLQogdm9pZCBHcmFwaGljc0NvbnRleHQzRDo6YWN0aXZlVGV4 dHVyZSh1bnNpZ25lZCBsb25nIHRleHR1cmUpCiB7CiAgICAgbV9pbnRlcm5hbC0+bV9nbFdpZGdl dC0+bWFrZUN1cnJlbnQoKTsKQEAgLTE0ODUsNTIgKzE0ODAsMTMgQEAgaW50IEdyYXBoaWNzQ29u dGV4dDNEOjp0ZXhJbWFnZTJEKHVuc2lnbmVkIHRhcmdldCwgdW5zaWduZWQgbGV2ZWwsIHVuc2ln bmVkIGludGUKICAgICByZXR1cm4gMDsKIH0KIAotaW50IEdyYXBoaWNzQ29udGV4dDNEOjp0ZXhJ bWFnZTJEKHVuc2lnbmVkIHRhcmdldCwgdW5zaWduZWQgbGV2ZWwsIEltYWdlKiBpbWFnZSwgYm9v bCBmbGlwWSwgYm9vbCBwcmVtdWx0aXBseUFscGhhKQotewotICAgIEFTU0VSVChpbWFnZSk7Ci0g ICAgCi0gICAgbV9pbnRlcm5hbC0+bV9nbFdpZGdldC0+bWFrZUN1cnJlbnQoKTsKLQotICAgIFZl Y3Rvcjx1aW50OF90PiBpbWFnZURhdGE7Ci0gICAgR0x1aW50IGZvcm1hdDsKLSAgICBHTHVpbnQg aW50ZXJuYWxGb3JtYXQ7Ci0KLSAgICBpZiAoIWV4dHJhY3RJbWFnZURhdGEoaW1hZ2UsIGZsaXBZ LCBwcmVtdWx0aXBseUFscGhhLCBpbWFnZURhdGEsICZmb3JtYXQsICZpbnRlcm5hbEZvcm1hdCkp IHsKLSAgICAgICAgTE9HX0VSUk9SKCJHcmFwaGljc0NvbnRleHQzRDo6dGV4SW1hZ2UyRDogY291 bGQgbm90IGV4dHJhY3QgSW1hZ2UgZGF0YSIpOwotICAgICAgICByZXR1cm4gLTE7Ci0gICAgfQot Ci0gICAgZ2xUZXhJbWFnZTJEKHRhcmdldCwgbGV2ZWwsIGludGVybmFsRm9ybWF0LCBpbWFnZS0+ d2lkdGgoKSwgaW1hZ2UtPmhlaWdodCgpLCAKLSAgICAgICAgICAgICAgICAgLyogYm9yZGVyICov IDAsIGZvcm1hdCwgR3JhcGhpY3NDb250ZXh0M0Q6OlVOU0lHTkVEX0JZVEUsIGltYWdlRGF0YS5k YXRhKCkpOwotCi0gICAgcmV0dXJuIDA7Ci19Ci0gICAgCisgICAKIGludCBHcmFwaGljc0NvbnRl eHQzRDo6dGV4U3ViSW1hZ2UyRCh1bnNpZ25lZCB0YXJnZXQsIHVuc2lnbmVkIGxldmVsLCB1bnNp Z25lZCB4b2ZmLCB1bnNpZ25lZCB5b2ZmLCB1bnNpZ25lZCB3aWR0aCwgdW5zaWduZWQgaGVpZ2h0 LCB1bnNpZ25lZCBmb3JtYXQsIHVuc2lnbmVkIHR5cGUsIHZvaWQqIHBpeGVscykKIHsKICAgICBn bFRleFN1YkltYWdlMkQodGFyZ2V0LCBsZXZlbCwgeG9mZiwgeW9mZiwgd2lkdGgsIGhlaWdodCwg Zm9ybWF0LCB0eXBlLCBwaXhlbHMpOwogICAgIHJldHVybiAwOwogfQogCi1pbnQgR3JhcGhpY3ND b250ZXh0M0Q6OnRleFN1YkltYWdlMkQodW5zaWduZWQgdGFyZ2V0LCB1bnNpZ25lZCBsZXZlbCwg dW5zaWduZWQgeG9mZiwgdW5zaWduZWQgeW9mZiwgSW1hZ2UqIGltYWdlLCBib29sIGZsaXBZLCBi b29sIHByZW11bHRpcGx5QWxwaGEpCi17Ci0gICAgQVNTRVJUKGltYWdlKTsKLQotICAgIFZlY3Rv cjx1aW50OF90PiBpbWFnZURhdGE7Ci0gICAgR0x1aW50IGZvcm1hdDsKLSAgICBHTHVpbnQgaW50 ZXJuYWxGb3JtYXQ7Ci0KLSAgICBpZiAoIWV4dHJhY3RJbWFnZURhdGEoaW1hZ2UsIGZsaXBZLCBw cmVtdWx0aXBseUFscGhhLCBpbWFnZURhdGEsICZmb3JtYXQsICZpbnRlcm5hbEZvcm1hdCkpIHsK LSAgICAgICAgTE9HX0VSUk9SKCJHcmFwaGljc0NvbnRleHQzRDo6dGV4U3ViSW1hZ2UyRDogY291 bGQgbm90IGV4dHJhY3QgSW1hZ2UgZGF0YSIpOwotICAgICAgICByZXR1cm4gLTE7Ci0gICAgfQot Ci0gICAgZ2xUZXhTdWJJbWFnZTJEKHRhcmdldCwgbGV2ZWwsIHhvZmYsIHlvZmYsIGltYWdlLT53 aWR0aCgpLCBpbWFnZS0+aGVpZ2h0KCksIAotICAgICAgICAgICAgICAgICAgICBmb3JtYXQsIEdy YXBoaWNzQ29udGV4dDNEOjpVTlNJR05FRF9CWVRFLCBpbWFnZURhdGEuZGF0YSgpKTsKLQotICAg IHJldHVybiAwOwotfQotCiB1bnNpZ25lZCBHcmFwaGljc0NvbnRleHQzRDo6Y3JlYXRlQnVmZmVy KCkKIHsKICAgICBtX2ludGVybmFsLT5tX2dsV2lkZ2V0LT5tYWtlQ3VycmVudCgpOwo=