38366 2010-04-29 19:03:10 -0700 Web Inspector: Missing INSPECTOR Guard in Console::lastWMLErrorMessage 2010-04-30 20:09:50 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 joepeck webkit-unassigned bweinstein joepeck keishi pfeldman pmuellr rik ryanzhu97 timothy yurys oldest_to_newest 219328 0 joepeck 2010-04-29 19:03:10 -0700 Reported on the webkit-dev mailing list: https://lists.webkit.org/pipermail/webkit-dev/2010-April/012706.html 219330 1 54771 joepeck 2010-04-29 19:09:41 -0700 Created attachment 54771 [PATCH] Proposed Fix 1: Remove Function if !ENABLE(INSPECTOR) Remove console.lastWMLErrorMessage altogether if INSPECTOR is not enabled. 219331 2 54772 joepeck 2010-04-29 19:10:43 -0700 Created attachment 54772 [PATCH] Proposed Fix 2: Leave Function but always return "" if !ENABLE(INSPECTOR) Leave console.lastWMLErrorMessage but make it non functional unless INSPECTOR is enabled. 219332 3 joepeck 2010-04-29 19:14:22 -0700 I think this is a weird scenario. Its weird that you can have a WML only function that only works whether or not the Inspector is enabled or not. I think the best current solution would be Proposed Fix 2, so that authors can always rely on console.lastWMLErrorMessage to exist, and not require checking for its existence first. Can anyone who uses WML comment on its usefulness? 219339 4 ryanzhu97 2010-04-29 19:51:23 -0700 Prefer on proposed fix 2. Thanks 219688 5 joepeck 2010-04-30 20:09:50 -0700 Committed r58628 M WebCore/ChangeLog M WebCore/page/Console.cpp r58628 = ab352d24008dbb4223c36159bbece5527d0645c8 (refs/remotes/trunk) http://trac.webkit.org/changeset/58628 54771 2010-04-29 19:09:41 -0700 2010-04-30 09:43:19 -0700 [PATCH] Proposed Fix 1: Remove Function if !ENABLE(INSPECTOR) fix1.patch text/plain 2100 joepeck ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NmY1YTdjNi4uNTE1NTg1NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wNC0yOSAgSm9zZXBoIFBlY29y YXJvICA8am9lcGVja0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IE1pc3NpbmcgSU5TUEVDVE9SIEd1YXJk IGluIENvbnNvbGU6Omxhc3RXTUxFcnJvck1lc3NhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4MzY2CisKKyAgICAgICAgQ29uc29sZTo6bGFzdFdN TEVycm9yTWVzc2FnZSBpcyBvbmx5IGF2YWlsYWJsZSBpZiBXTUwgaXMgZW5hYmxlZCwgaG93ZXZl cgorICAgICAgICBpdHMgaW1wbGVtZW50YXRpb24gb25seSBtYWtlcyBzZW5zZSBhcyBsb25nIGFz IElOU1BFQ1RPUiBpcyBlbmFibGVkCisgICAgICAgIGFzIHdlbGwuIFNvIHRoaXMgYWRkcyB0aGUg RU5BQkxFKElOU1BFQ1RPUikgZ3VhcmQgZm9yIHRoaXMgZnVuY3Rpb24uCisKKyAgICAgICAgKiBw YWdlL0NvbnNvbGUuY3BwOgorICAgICAgICAqIHBhZ2UvQ29uc29sZS5oOgorICAgICAgICAqIHBh Z2UvQ29uc29sZS5pZGw6CisKIDIwMTAtMDQtMjkgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCmRpZmYgLS1naXQgYS9X ZWJDb3JlL3BhZ2UvQ29uc29sZS5jcHAgYi9XZWJDb3JlL3BhZ2UvQ29uc29sZS5jcHAKaW5kZXgg ZDVmZjdiYy4uM2EyZDk0ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL0NvbnNvbGUuY3BwCisr KyBiL1dlYkNvcmUvcGFnZS9Db25zb2xlLmNwcApAQCAtMjg2LDcgKzI4Niw3IEBAIHZvaWQgQ29u c29sZTo6bWFya1RpbWVsaW5lKFNjcmlwdENhbGxTdGFjayogY2FsbFN0YWNrKQogI2VuZGlmCiB9 CiAKLSNpZiBFTkFCTEUoV01MKQorI2lmIEVOQUJMRShXTUwpICYmIEVOQUJMRShJTlNQRUNUT1Ip CiBTdHJpbmcgQ29uc29sZTo6bGFzdFdNTEVycm9yTWVzc2FnZSgpIGNvbnN0CiB7CiAgICAgUGFn ZSogcGFnZSA9IHRoaXMtPnBhZ2UoKTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9Db25zb2xl LmggYi9XZWJDb3JlL3BhZ2UvQ29uc29sZS5oCmluZGV4IDlhNmQ4OGMuLjIwYjMwYjMgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvcGFnZS9Db25zb2xlLmgKKysrIGIvV2ViQ29yZS9wYWdlL0NvbnNvbGUu aApAQCAtOTQsNyArOTQsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBhc3NlcnRDb25kaXRpb24oYm9v bCBjb25kaXRpb24sIFNjcmlwdENhbGxTdGFjayopOwogICAgIHZvaWQgY291bnQoU2NyaXB0Q2Fs bFN0YWNrKik7CiAgICAgdm9pZCBtYXJrVGltZWxpbmUoU2NyaXB0Q2FsbFN0YWNrKik7Ci0jaWYg RU5BQkxFKFdNTCkKKyNpZiBFTkFCTEUoV01MKSAmJiBFTkFCTEUoSU5TUEVDVE9SKQogICAgIFN0 cmluZyBsYXN0V01MRXJyb3JNZXNzYWdlKCkgY29uc3Q7CiAjZW5kaWYKICNpZiBFTkFCTEUoSkFW QVNDUklQVF9ERUJVR0dFUikKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9Db25zb2xlLmlkbCBi L1dlYkNvcmUvcGFnZS9Db25zb2xlLmlkbAppbmRleCBiM2MwYzI0Li4yNWQ1OWE4IDEwMDY0NAot LS0gYS9XZWJDb3JlL3BhZ2UvQ29uc29sZS5pZGwKKysrIGIvV2ViQ29yZS9wYWdlL0NvbnNvbGUu aWRsCkBAIC00Niw3ICs0Niw3IEBAIG1vZHVsZSB3aW5kb3cgewogICAgICAgICBbQ3VzdG9tQXJn dW1lbnRIYW5kbGluZ10gdm9pZCBjb3VudCgpOwogICAgICAgICBbQ3VzdG9tQXJndW1lbnRIYW5k bGluZ10gdm9pZCBtYXJrVGltZWxpbmUoKTsKIAotI2lmIGRlZmluZWQoRU5BQkxFX1dNTCkgJiYg RU5BQkxFX1dNTAorI2lmIGRlZmluZWQoRU5BQkxFX1dNTCkgJiYgRU5BQkxFX1dNTCAmJiBkZWZp bmVkKEVOQUJMRV9JTlNQRUNUT1IpICYmIEVOQUJMRV9JTlNQRUNUT1IKICAgICAgICAgW0RvbnRF bnVtXSBET01TdHJpbmcgbGFzdFdNTEVycm9yTWVzc2FnZSgpOwogI2VuZGlmCiAK 54772 2010-04-29 19:10:43 -0700 2010-04-30 20:06:32 -0700 [PATCH] Proposed Fix 2: Leave Function but always return "" if !ENABLE(INSPECTOR) fix2.patch text/plain 1350 joepeck ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NmY1YTdjNi4uZjk4ZDRiMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wNC0yOSAgSm9zZXBoIFBlY29y YXJvICA8am9lcGVja0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IE1pc3NpbmcgSU5TUEVDVE9SIEd1YXJk IGluIENvbnNvbGU6Omxhc3RXTUxFcnJvck1lc3NhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4MzY2CisKKyAgICAgICAgQ29uc29sZTo6bGFzdFdN TEVycm9yTWVzc2FnZSBpcyBvbmx5IGF2YWlsYWJsZSBpZiBXTUwgaXMgZW5hYmxlZCwgaG93ZXZl cgorICAgICAgICBpdHMgaW1wbGVtZW50YXRpb24gb25seSBtYWtlcyBzZW5zZSBhcyBsb25nIGFz IElOU1BFQ1RPUiBpcyBlbmFibGVkCisgICAgICAgIGFzIHdlbGwuIFNvIHRoaXMgYWRkcyB0aGUg RU5BQkxFKElOU1BFQ1RPUikgZ3VhcmQgaW4gdGhlIGZ1bmN0aW9uLiBBCisgICAgICAgIGJyb3dz ZXIgd2l0aG91dCBFTkFCTEUoSU5TUEVDVE9SKSB3aWxsIGFsd2F5cyBnZXQgYW4gZW1wdHkgcmVz dWx0LgorCisgICAgICAgICogcGFnZS9Db25zb2xlLmNwcDoKKwogMjAxMC0wNC0yOSAgRGFuIEJl cm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZy YXNlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9Db25zb2xlLmNwcCBiL1dlYkNvcmUvcGFn ZS9Db25zb2xlLmNwcAppbmRleCBkNWZmN2JjLi44NjRiODM0IDEwMDY0NAotLS0gYS9XZWJDb3Jl L3BhZ2UvQ29uc29sZS5jcHAKKysrIGIvV2ViQ29yZS9wYWdlL0NvbnNvbGUuY3BwCkBAIC0yODks NiArMjg5LDcgQEAgdm9pZCBDb25zb2xlOjptYXJrVGltZWxpbmUoU2NyaXB0Q2FsbFN0YWNrKiBj YWxsU3RhY2spCiAjaWYgRU5BQkxFKFdNTCkKIFN0cmluZyBDb25zb2xlOjpsYXN0V01MRXJyb3JN ZXNzYWdlKCkgY29uc3QKIHsKKyNpZiBFTkFCTEUoSU5TUEVDVE9SKQogICAgIFBhZ2UqIHBhZ2Ug PSB0aGlzLT5wYWdlKCk7CiAgICAgaWYgKCFwYWdlKQogICAgICAgICByZXR1cm4gU3RyaW5nKCk7 CkBAIC0zMDcsNyArMzA4LDcgQEAgU3RyaW5nIENvbnNvbGU6Omxhc3RXTUxFcnJvck1lc3NhZ2Uo KSBjb25zdAogCiAgICAgICAgIHJldHVybiBtZXNzYWdlLT5tZXNzYWdlKCk7CiAgICAgfQotCisj ZW5kaWYKICAgICByZXR1cm4gU3RyaW5nKCk7CiB9CiAjZW5kaWYK