38352 2010-04-29 14:33:43 -0700 Need to updateLayout after typing commands too 2010-04-29 17:51:32 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 justin.garcia justin.garcia enrica oldest_to_newest 219187 0 justin.garcia 2010-04-29 14:33:43 -0700 In EditCommand::apply(), unapply() and reapply(), we do an updateLayout in case the editing operation doesn't do it itself. We should provide this convenience for typing commands, too. Text insertion is part of some open typing command, and they don't go through these functions, but all high level editing operations go through Editor::appliedEditing, unappliedEditing and reappliedEditing. We should move the updateLayout there. 219232 1 54746 justin.garcia 2010-04-29 15:59:20 -0700 Created attachment 54746 patch 219264 2 enrica 2010-04-29 16:39:39 -0700 Looks good to me. 219274 3 54746 justin.garcia 2010-04-29 16:52:39 -0700 Comment on attachment 54746 patch enrica r+d this over email 219278 4 54746 justin.garcia 2010-04-29 16:55:20 -0700 Comment on attachment 54746 patch Oops Enrica doesn't have r+ privs yet, resetting the review flag. 219280 5 54746 adele 2010-04-29 16:59:52 -0700 Comment on attachment 54746 patch looks fine. 219306 6 justin.garcia 2010-04-29 17:51:32 -0700 trac.webkit.org/projects/webkit/changeset/58551 54746 2010-04-29 15:59:20 -0700 2010-04-29 16:59:52 -0700 patch layout.txt text/plain 5309 justin.garcia SW5kZXg6IGVkaXRpbmcvRWRpdENvbW1hbmQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBlZGl0aW5nL0VkaXRD b21tYW5kLmgJKHJldmlzaW9uIDU4NTQzKQorKysgZWRpdGluZy9FZGl0Q29tbWFuZC5oCSh3b3Jr aW5nIGNvcHkpCkBAIC01Nyw2ICs1Nyw4IEBACiAgICAgdmlydHVhbCBib29sIGlzVHlwaW5nQ29t bWFuZCgpIGNvbnN0OwogICAgIAogICAgIHZpcnR1YWwgYm9vbCBwcmVzZXJ2ZXNUeXBpbmdTdHls ZSgpIGNvbnN0OworICAgIAorICAgIGJvb2wgaXNUb3BMZXZlbENvbW1hbmQoKSBjb25zdCB7IHJl dHVybiAhbV9wYXJlbnQ7IH0KIAogcHJvdGVjdGVkOgogICAgIEVkaXRDb21tYW5kKERvY3VtZW50 Kik7CkluZGV4OiBlZGl0aW5nL0VkaXRvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gZWRpdGluZy9FZGl0 b3IuY3BwCShyZXZpc2lvbiA1ODU0MykKKysrIGVkaXRpbmcvRWRpdG9yLmNwcAkod29ya2luZyBj b3B5KQpAQCAtODY3LDYgKzg2Nyw4IEBACiAKIHZvaWQgRWRpdG9yOjphcHBsaWVkRWRpdGluZyhQ YXNzUmVmUHRyPEVkaXRDb21tYW5kPiBjbWQpCiB7CisgICAgbV9mcmFtZS0+ZG9jdW1lbnQoKS0+ dXBkYXRlTGF5b3V0KCk7CisgICAgCiAgICAgZGlzcGF0Y2hFZGl0YWJsZUNvbnRlbnRDaGFuZ2Vk RXZlbnRzKCpjbWQpOwogICAgIAogICAgIFZpc2libGVTZWxlY3Rpb24gbmV3U2VsZWN0aW9uKGNt ZC0+ZW5kaW5nU2VsZWN0aW9uKCkpOwpAQCAtODkxLDYgKzg5Myw4IEBACiAKIHZvaWQgRWRpdG9y Ojp1bmFwcGxpZWRFZGl0aW5nKFBhc3NSZWZQdHI8RWRpdENvbW1hbmQ+IGNtZCkKIHsKKyAgICBt X2ZyYW1lLT5kb2N1bWVudCgpLT51cGRhdGVMYXlvdXQoKTsKKyAgICAKICAgICBkaXNwYXRjaEVk aXRhYmxlQ29udGVudENoYW5nZWRFdmVudHMoKmNtZCk7CiAgICAgCiAgICAgVmlzaWJsZVNlbGVj dGlvbiBuZXdTZWxlY3Rpb24oY21kLT5zdGFydGluZ1NlbGVjdGlvbigpKTsKQEAgLTkwNCw2ICs5 MDgsOCBAQAogCiB2b2lkIEVkaXRvcjo6cmVhcHBsaWVkRWRpdGluZyhQYXNzUmVmUHRyPEVkaXRD b21tYW5kPiBjbWQpCiB7CisgICAgbV9mcmFtZS0+ZG9jdW1lbnQoKS0+dXBkYXRlTGF5b3V0KCk7 CisgICAgCiAgICAgZGlzcGF0Y2hFZGl0YWJsZUNvbnRlbnRDaGFuZ2VkRXZlbnRzKCpjbWQpOwog ICAgIAogICAgIFZpc2libGVTZWxlY3Rpb24gbmV3U2VsZWN0aW9uKGNtZC0+ZW5kaW5nU2VsZWN0 aW9uKCkpOwpJbmRleDogZWRpdGluZy9FZGl0Q29tbWFuZC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gZWRp dGluZy9FZGl0Q29tbWFuZC5jcHAJKHJldmlzaW9uIDU4NTQzKQorKysgZWRpdGluZy9FZGl0Q29t bWFuZC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYyLDcgKzYyLDcgQEAKICAKICAgICBGcmFtZSog ZnJhbWUgPSBtX2RvY3VtZW50LT5mcmFtZSgpOwogICAgIAotICAgIGlmICghbV9wYXJlbnQpIHsK KyAgICBpZiAoaXNUb3BMZXZlbENvbW1hbmQoKSkgewogICAgICAgICBpZiAoIWVuZGluZ1NlbGVj dGlvbigpLmlzQ29udGVudFJpY2hseUVkaXRhYmxlKCkpIHsKICAgICAgICAgICAgIHN3aXRjaCAo ZWRpdGluZ0FjdGlvbigpKSB7CiAgICAgICAgICAgICAgICAgY2FzZSBFZGl0QWN0aW9uVHlwaW5n OgpAQCAtODMsNyArODMsNyBAQAogICAgIC8vIHJlcXVpcmUgYSBsYXlvdXQsIGFzIGluIDxyZGFy Oi8vcHJvYmxlbS81NjU4NjAzPi4gIExvdyBsZXZlbCBvcGVyYXRpb25zLCBsaWtlIAogICAgIC8v IFJlbW92ZU5vZGVDb21tYW5kLCBkb24ndCByZXF1aXJlIGEgbGF5b3V0IGJlY2F1c2UgdGhlIGhp Z2ggbGV2ZWwgb3BlcmF0aW9ucyB0aGF0IAogICAgIC8vIHVzZSB0aGVtIHBlcmZvcm0gb25lIGlm IG9uZSBpcyBuZWNlc3NhcnkgKGxpa2UgZm9yIHRoZSBjcmVhdGlvbiBvZiBWaXNpYmxlUG9zaXRp b25zKS4KLSAgICBpZiAoIW1fcGFyZW50KQorICAgIGlmIChpc1RvcExldmVsQ29tbWFuZCgpKQog ICAgICAgICB1cGRhdGVMYXlvdXQoKTsKIAogICAgIERlbGV0ZUJ1dHRvbkNvbnRyb2xsZXIqIGRl bGV0ZUJ1dHRvbkNvbnRyb2xsZXIgPSBmcmFtZS0+ZWRpdG9yKCktPmRlbGV0ZUJ1dHRvbkNvbnRy b2xsZXIoKTsKQEAgLTkxLDggKzkxLDcgQEAKICAgICBkb0FwcGx5KCk7CiAgICAgZGVsZXRlQnV0 dG9uQ29udHJvbGxlci0+ZW5hYmxlKCk7CiAKLSAgICBpZiAoIW1fcGFyZW50KSB7Ci0gICAgICAg IHVwZGF0ZUxheW91dCgpOworICAgIGlmIChpc1RvcExldmVsQ29tbWFuZCgpKSB7CiAgICAgICAg IC8vIE9ubHkgbmVlZCB0byBjYWxsIGFwcGxpZWRFZGl0aW5nIGZvciB0b3AtbGV2ZWwgY29tbWFu ZHMsIGFuZCBUeXBpbmdDb21tYW5kcyBkbyBpdCBvbiB0aGVpcgogICAgICAgICAvLyBvd24gKHNl ZSBUeXBpbmdDb21tYW5kOjp0eXBpbmdBZGRlZFRvT3BlbkNvbW1hbmQpLgogICAgICAgICBpZiAo IWlzVHlwaW5nQ29tbWFuZCgpKQpAQCAtMTExLDcgKzExMCw3IEBACiAgICAgLy8gcmVxdWlyZSBh IGxheW91dCwgYXMgaW4gPHJkYXI6Ly9wcm9ibGVtLzU2NTg2MDM+LiAgTG93IGxldmVsIG9wZXJh dGlvbnMsIGxpa2UgCiAgICAgLy8gUmVtb3ZlTm9kZUNvbW1hbmQsIGRvbid0IHJlcXVpcmUgYSBs YXlvdXQgYmVjYXVzZSB0aGUgaGlnaCBsZXZlbCBvcGVyYXRpb25zIHRoYXQgCiAgICAgLy8gdXNl IHRoZW0gcGVyZm9ybSBvbmUgaWYgb25lIGlzIG5lY2Vzc2FyeSAobGlrZSBmb3IgdGhlIGNyZWF0 aW9uIG9mIFZpc2libGVQb3NpdGlvbnMpLgotICAgIGlmICghbV9wYXJlbnQpCisgICAgaWYgKGlz VG9wTGV2ZWxDb21tYW5kKCkpCiAgICAgICAgIHVwZGF0ZUxheW91dCgpOwogICAgIAogICAgIERl bGV0ZUJ1dHRvbkNvbnRyb2xsZXIqIGRlbGV0ZUJ1dHRvbkNvbnRyb2xsZXIgPSBmcmFtZS0+ZWRp dG9yKCktPmRlbGV0ZUJ1dHRvbkNvbnRyb2xsZXIoKTsKQEAgLTExOSwxMCArMTE4LDggQEAKICAg ICBkb1VuYXBwbHkoKTsKICAgICBkZWxldGVCdXR0b25Db250cm9sbGVyLT5lbmFibGUoKTsKIAot ICAgIGlmICghbV9wYXJlbnQpIHsKLSAgICAgICAgdXBkYXRlTGF5b3V0KCk7CisgICAgaWYgKGlz VG9wTGV2ZWxDb21tYW5kKCkpCiAgICAgICAgIGZyYW1lLT5lZGl0b3IoKS0+dW5hcHBsaWVkRWRp dGluZyh0aGlzKTsKLSAgICB9CiB9CiAKIHZvaWQgRWRpdENvbW1hbmQ6OnJlYXBwbHkoKQpAQCAt MTM2LDcgKzEzMyw3IEBACiAgICAgLy8gcmVxdWlyZSBhIGxheW91dCwgYXMgaW4gPHJkYXI6Ly9w cm9ibGVtLzU2NTg2MDM+LiAgTG93IGxldmVsIG9wZXJhdGlvbnMsIGxpa2UgCiAgICAgLy8gUmVt b3ZlTm9kZUNvbW1hbmQsIGRvbid0IHJlcXVpcmUgYSBsYXlvdXQgYmVjYXVzZSB0aGUgaGlnaCBs ZXZlbCBvcGVyYXRpb25zIHRoYXQgCiAgICAgLy8gdXNlIHRoZW0gcGVyZm9ybSBvbmUgaWYgb25l IGlzIG5lY2Vzc2FyeSAobGlrZSBmb3IgdGhlIGNyZWF0aW9uIG9mIFZpc2libGVQb3NpdGlvbnMp LgotICAgIGlmICghbV9wYXJlbnQpCisgICAgaWYgKGlzVG9wTGV2ZWxDb21tYW5kKCkpCiAgICAg ICAgIHVwZGF0ZUxheW91dCgpOwogCiAgICAgRGVsZXRlQnV0dG9uQ29udHJvbGxlciogZGVsZXRl QnV0dG9uQ29udHJvbGxlciA9IGZyYW1lLT5lZGl0b3IoKS0+ZGVsZXRlQnV0dG9uQ29udHJvbGxl cigpOwpAQCAtMTQ0LDEwICsxNDEsOCBAQAogICAgIGRvUmVhcHBseSgpOwogICAgIGRlbGV0ZUJ1 dHRvbkNvbnRyb2xsZXItPmVuYWJsZSgpOwogCi0gICAgaWYgKCFtX3BhcmVudCkgewotICAgICAg ICB1cGRhdGVMYXlvdXQoKTsKKyAgICBpZiAoaXNUb3BMZXZlbENvbW1hbmQoKSkKICAgICAgICAg ZnJhbWUtPmVkaXRvcigpLT5yZWFwcGxpZWRFZGl0aW5nKHRoaXMpOwotICAgIH0KIH0KIAogdm9p ZCBFZGl0Q29tbWFuZDo6ZG9SZWFwcGx5KCkKSW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBDaGFuZ2VMb2cJKHJldmlzaW9uIDU4NTQ0KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMjYgQEAKKzIwMTAtMDQtMjkgIEp1c3RpbiBHYXJjaWEgIDxqdXN0aW4uZ2Fy Y2lhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBOZWVkIHRvIHVwZGF0ZUxheW91dCBhZnRlciB0eXBpbmcgY29tbWFuZHMgdG9vCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODM1MgorCisg ICAgICAgIFJlcGxhY2VkICFtX3BhcmVudCBjaGVja3MgaW4gRWRpdENvbW1hbmQuY3BwIGJ5IHRo ZSBtb3JlIGRlc2NyaXB0aXZlIGlzVG9wTGV2ZWxDb21tYW5kKCkuCisgICAgICAgIE1vdmUgdGhl IHBvc3QgZWRpdGluZyBvcGVyYXRpb24gdXBkYXRlTGF5b3V0KCkgY2FsbCB0byB7dW4scmV9YXBw bGllZEVkaXRpbmcgc28gdGhhdCB0ZXh0IGluc2VydGlvbnMsCisgICAgICAgIHdoaWNoIGRvbid0 IGdvIHRocm91Z2ggRWRpdENvbW1hbmQ6Ont1bixyZX1hcHBseSgpIGNhbiBiZW5lZml0IGZyb20g aXQgdG9vLiAgTm8gdGVzdCBjYXNlIHBvc3NpYmxlCisgICAgICAgIHNpbmNlIG1vc3QgcGxhdGZv cm1zIGhhdmUgYSBsYXlvdXQgcGVyZm9ybWVkIGFzIGEgc2lkZSBlZmZlY3Qgb2YgcG9zdCBvcGVy YXRpb24gc2VsZWN0aW9uIGNvZGUuCisKKyAgICAgICAgKiBlZGl0aW5nL0VkaXRDb21tYW5kLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkVkaXRDb21tYW5kOjphcHBseSk6CisgICAgICAgIChXZWJD b3JlOjpFZGl0Q29tbWFuZDo6dW5hcHBseSk6CisgICAgICAgIChXZWJDb3JlOjpFZGl0Q29tbWFu ZDo6cmVhcHBseSk6CisgICAgICAgICogZWRpdGluZy9FZGl0Q29tbWFuZC5oOgorICAgICAgICAo V2ViQ29yZTo6RWRpdENvbW1hbmQ6OmlzVG9wTGV2ZWxDb21tYW5kKToKKyAgICAgICAgKiBlZGl0 aW5nL0VkaXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFZGl0b3I6OmFwcGxpZWRFZGl0aW5n KToKKyAgICAgICAgKFdlYkNvcmU6OkVkaXRvcjo6dW5hcHBsaWVkRWRpdGluZyk6CisgICAgICAg IChXZWJDb3JlOjpFZGl0b3I6OnJlYXBwbGllZEVkaXRpbmcpOgorCiAyMDEwLTA0LTI5ICBEYW4g QmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24g RnJhc2VyLgo=