38350 2010-04-29 14:21:06 -0700 REGRESSION (r57820): Controller is not displayed in window when opening a MP3 file in browser window 2010-04-29 23:17:04 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED http://ht.salemweb.net/oneplace/mp3/3257280/tbd20100428.mp3 InRadar, Regression P1 Normal --- 38376 1 mitz webkit-unassigned abarth eric.carlson eric webkit.review.bot oldest_to_newest 219178 0 mitz 2010-04-29 14:21:06 -0700 <rdar://problem/7918086> To reproduce, open the URL. The MP3 loads and plays but no controller is displayed in window. Patch coming soon! 219199 1 54738 mitz 2010-04-29 14:58:21 -0700 Created attachment 54738 Ignore player natural size before metadata has loaded, special-case media documents, don’t special-case zero-size video 219211 2 eric.carlson 2010-04-29 15:16:15 -0700 > * bindings/js/ScriptCallStack.cpp: > - (WebCore::ScriptCallStack::ScriptCallStack): If the caller is unknown, the line number and source information is still availble so pass it to the ScriptCallFrame being constructed. > + (WebCore::ScriptCallStack::ScriptCallStack): If the caller is unknown, the line number and source information is still available so pass it to the ScriptCallFrame being constructed. > Nice catch, an eleven week old misspelling! 219212 3 mitz 2010-04-29 15:22:39 -0700 Fixed in <http://trac.webkit.org/changeset/58543>. 219227 4 webkit.review.bot 2010-04-29 15:53:23 -0700 http://trac.webkit.org/changeset/58543 might have broken Qt Linux Release 54738 2010-04-29 14:58:21 -0700 2010-04-29 15:14:15 -0700 Ignore player natural size before metadata has loaded, special-case media documents, don’t special-case zero-size video 7918086_r1.diff text/plain 6997 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1ODUzOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDQtMjkgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICA8cmRh cjovL3Byb2JsZW0vNzkxODA4Nj4gUkVHUkVTU0lPTiAocjU3ODIwKTogQ29udHJvbGxlciBpcyBu b3QgZGlzcGxheWVkIGluIHdpbmRvdyB3aGVuIG9wZW5pbmcgYSBNUDMgZmlsZSBpbiBicm93c2Vy IHdpbmRvdworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzgzNTAKKworICAgICAgICBUZXN0czogbWVkaWEvYXVkaW8tb25seS12aWRlby1pbnRyaW5zaWMt c2l6ZS5odG1sCisgICAgICAgICAgICAgICBtZWRpYS9tZWRpYS1kb2N1bWVudC1hdWRpby1zaXpl Lmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJWaWRlby5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJWaWRlbzo6UmVuZGVyVmlkZW8pOiBVbnRpbCBtZXRhZGF0YSBpcyBhdmFp bGFibGUsIGlnbm9yZSB0aGUgbmF0dXJhbCBzaXplCisgICAgICAgIHJlcG9ydGVkIGJ5IHRoZSBw bGF5ZXIuCisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJWaWRlbzo6dmlkZW9TaXplQ2hhbmdlZCk6 IFJlc3BlY3QgYSBuYXR1cmFsIHNpemUgb2YgemVybyBpZiByZXBvcnRlZCBieSB0aGUKKyAgICAg ICAgcGxheWVyLCBleGNlcHQgaW4gc3RhbmRhbG9uZSBtZWRpYSBkb2N1bWVudHMuCisKIDIwMTAt MDQtMjkgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBBbmRlcnMgQ2FybHNzb24uCkBAIC00MDE0Myw3ICs0MDE1OSw3IEBACiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDMzNQogCiAgICAgICAgICogYmlu ZGluZ3MvanMvU2NyaXB0Q2FsbFN0YWNrLmNwcDoKLSAgICAgICAgKFdlYkNvcmU6OlNjcmlwdENh bGxTdGFjazo6U2NyaXB0Q2FsbFN0YWNrKTogSWYgdGhlIGNhbGxlciBpcyB1bmtub3duLCB0aGUg bGluZSBudW1iZXIgYW5kIHNvdXJjZSBpbmZvcm1hdGlvbiBpcyBzdGlsbCBhdmFpbGJsZSBzbyBw YXNzIGl0IHRvIHRoZSBTY3JpcHRDYWxsRnJhbWUgYmVpbmcgY29uc3RydWN0ZWQuCisgICAgICAg IChXZWJDb3JlOjpTY3JpcHRDYWxsU3RhY2s6OlNjcmlwdENhbGxTdGFjayk6IElmIHRoZSBjYWxs ZXIgaXMgdW5rbm93biwgdGhlIGxpbmUgbnVtYmVyIGFuZCBzb3VyY2UgaW5mb3JtYXRpb24gaXMg c3RpbGwgYXZhaWxhYmxlIHNvIHBhc3MgaXQgdG8gdGhlIFNjcmlwdENhbGxGcmFtZSBiZWluZyBj b25zdHJ1Y3RlZC4KIAogMjAxMC0wMi0wMSAgRGlyayBTY2h1bHplICA8a3JpdEB3ZWJraXQub3Jn PgogCkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWRlby5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlkZW8uY3BwCShyZXZpc2lvbiA1ODUyMSkKKysr IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZGVvLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTAs NyArNTAsNyBAQCB1c2luZyBuYW1lc3BhY2UgSFRNTE5hbWVzOwogUmVuZGVyVmlkZW86OlJlbmRl clZpZGVvKEhUTUxWaWRlb0VsZW1lbnQqIHZpZGVvKQogICAgIDogUmVuZGVyTWVkaWEodmlkZW8p CiB7Ci0gICAgaWYgKHZpZGVvLT5wbGF5ZXIoKSkKKyAgICBpZiAodmlkZW8tPnBsYXllcigpICYm IHZpZGVvLT5yZWFkeVN0YXRlKCkgPj0gSFRNTFZpZGVvRWxlbWVudDo6SEFWRV9NRVRBREFUQSkK ICAgICAgICAgc2V0SW50cmluc2ljU2l6ZSh2aWRlby0+cGxheWVyKCktPm5hdHVyYWxTaXplKCkp OwogICAgIGVsc2UgewogICAgICAgICAvLyBXaGVuIHRoZSBuYXR1cmFsIHNpemUgb2YgdGhlIHZp ZGVvIGlzIHVuYXZhaWxhYmxlLCB3ZSB1c2UgdGhlIHByb3ZpZGVkCkBAIC0xMDEsNyArMTAxLDEx IEBAIHZvaWQgUmVuZGVyVmlkZW86OnZpZGVvU2l6ZUNoYW5nZWQoKQogICAgIGlmICghcGxheWVy KCkpCiAgICAgICAgIHJldHVybjsKICAgICBJbnRTaXplIHNpemUgPSBwbGF5ZXIoKS0+bmF0dXJh bFNpemUoKTsKLSAgICBpZiAoIXNpemUuaXNFbXB0eSgpICYmIHNpemUgIT0gaW50cmluc2ljU2l6 ZSgpKSB7CisgICAgaWYgKHNpemUuaXNFbXB0eSgpKSB7CisgICAgICAgIGlmIChub2RlKCktPm93 bmVyRG9jdW1lbnQoKSAmJiBub2RlKCktPm93bmVyRG9jdW1lbnQoKS0+aXNNZWRpYURvY3VtZW50 KCkpCisgICAgICAgICAgICByZXR1cm47CisgICAgfQorICAgIGlmIChzaXplICE9IGludHJpbnNp Y1NpemUoKSkgewogICAgICAgICBzZXRJbnRyaW5zaWNTaXplKHNpemUpOwogICAgICAgICBzZXRQ cmVmV2lkdGhzRGlydHkodHJ1ZSk7CiAgICAgICAgIHNldE5lZWRzTGF5b3V0KHRydWUpOwpJbmRl eDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5n ZUxvZwkocmV2aXNpb24gNTg1MzkpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcg Y29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNC0yOSAgRGFuIEJlcm5zdGVpbiAgPG1pdHpA YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS83OTE4MDg2PiBSRUdSRVNTSU9OIChyNTc4MjApOiBDb250cm9s bGVyIGlzIG5vdCBkaXNwbGF5ZWQgaW4gd2luZG93IHdoZW4gb3BlbmluZyBhIE1QMyBmaWxlIGlu IGJyb3dzZXIgd2luZG93CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zODM1MAorCisgICAgICAgICogbWVkaWEvYXVkaW8tb25seS12aWRlby1pbnRyaW5z aWMtc2l6ZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIG1lZGlhL2F1ZGlvLW9ubHkt dmlkZW8taW50cmluc2ljLXNpemUuaHRtbDogQWRkZWQuCisgICAgICAgICogbWVkaWEvbWVkaWEt ZG9jdW1lbnQtYXVkaW8tc2l6ZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIG1lZGlh L21lZGlhLWRvY3VtZW50LWF1ZGlvLXNpemUuaHRtbDogQWRkZWQuCisKIDIwMTAtMDQtMjkgIFlh YXIgU2Nobml0bWFuICA8eWFhckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTm90IFJldmlld2Vk LgpJbmRleDogTGF5b3V0VGVzdHMvbWVkaWEvYXVkaW8tb25seS12aWRlby1pbnRyaW5zaWMtc2l6 ZS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvbWVkaWEvYXVkaW8tb25s eS12aWRlby1pbnRyaW5zaWMtc2l6ZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlv dXRUZXN0cy9tZWRpYS9hdWRpby1vbmx5LXZpZGVvLWludHJpbnNpYy1zaXplLWV4cGVjdGVkLnR4 dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw1IEBACitUaGlzIHRlc3RzIHRoZSBpbnRyaW5zaWMg c2l6ZSBvZiBhIHZpZGVvIGVsZW1lbnQgaXMgdGhlIGRlZmF1bHQgMzAww5cxNTAgYmVmb3JlIG1l dGFkYXRhIGlzIGxvYWRlZCwgYW5kIDDDlzAgYWZ0ZXIgbWV0YWRhdGEgaXMgbG9hZGVkIGZvciBh biBhdWRpby1vbmx5IGZpbGUuCisKK0luaXRpYWwgZGltZW5zaW9uczogMzAww5cxNTAKK0RpbWVu c2lvbnMgYWZ0ZXIgbWV0YWRhdGEgbG9hZGVkOiAww5cwCisKSW5kZXg6IExheW91dFRlc3RzL21l ZGlhL2F1ZGlvLW9ubHktdmlkZW8taW50cmluc2ljLXNpemUuaHRtbAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9tZWRpYS9hdWRpby1vbmx5LXZpZGVvLWludHJpbnNpYy1zaXplLmh0bWwJKHJl dmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9tZWRpYS9hdWRpby1vbmx5LXZpZGVvLWludHJpbnNp Yy1zaXplLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjYgQEAKKzx2aWRlbyBpZD0idmlk IiBzcmM9ImNvbnRlbnQvdGVzdC53YXYiIG9ubG9hZGVkbWV0YWRhdGE9ImxvYWRlZE1ldGFkYXRh KCkiPjwvdmlkZW8+Cis8cD4KKyAgICBUaGlzIHRlc3RzIHRoZSBpbnRyaW5zaWMgc2l6ZSBvZiBh IHZpZGVvIGVsZW1lbnQgaXMgdGhlIGRlZmF1bHQgMzAwJiN4ZDc7MTUwIGJlZm9yZSBtZXRhZGF0 YSBpcworICAgIGxvYWRlZCwgYW5kIDAmI3hkNzswIGFmdGVyIG1ldGFkYXRhIGlzIGxvYWRlZCBm b3IgYW4gYXVkaW8tb25seSBmaWxlLgorPC9wPgorPHByZSBpZD0iY29uc29sZSI+PC9wcmU+Cis8 c2NyaXB0PgorICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICAgICAg bGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgICAgICBsYXlvdXRUZXN0Q29u dHJvbGxlci53YWl0VW50aWxEb25lKCk7CisgICAgfQorCisgICAgZnVuY3Rpb24gbG9nKG1lc3Nh Z2UpCisgICAgeworICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY29uc29sZSIpLmFw cGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKG1lc3NhZ2UgKyAiXG4iKSk7CisgICAg fQorCisgICAgdmFyIHZpZGVvRWxlbWVudCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ2aWQi KTsKKyAgICBsb2coIkluaXRpYWwgZGltZW5zaW9uczogIiArIHZpZGVvRWxlbWVudC5vZmZzZXRX aWR0aCArICJcdTAwZDciICsgdmlkZW9FbGVtZW50Lm9mZnNldEhlaWdodCk7CisKKyAgICBmdW5j dGlvbiBsb2FkZWRNZXRhZGF0YSgpCisgICAgeworICAgICAgICBsb2coIkRpbWVuc2lvbnMgYWZ0 ZXIgbWV0YWRhdGEgbG9hZGVkOiAiICsgdmlkZW9FbGVtZW50Lm9mZnNldFdpZHRoICsgIlx1MDBk NyIgKyB2aWRlb0VsZW1lbnQub2Zmc2V0SGVpZ2h0KTsgICAgICAgIAorICAgICAgICBsYXlvdXRU ZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CisgICAgfQorPC9zY3JpcHQ+CkluZGV4OiBMYXlv dXRUZXN0cy9tZWRpYS9tZWRpYS1kb2N1bWVudC1hdWRpby1zaXplLWV4cGVjdGVkLnR4dAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1kb2N1bWVudC1hdWRpby1zaXplLWV4 cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL21lZGlhL21lZGlhLWRvY3Vt ZW50LWF1ZGlvLXNpemUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDQgQEAK K1RoaXMgdGVzdHMgdGhhdCBpbiBhIHN0YW5kYWxvbmUgbWVkaWEgZG9jdW1lbnQgd2l0aCBhdWRp byBjb250ZW50LCB0aGUgbWVkaWEgZWxlbWVudCBoYXMgbm9uLXplcm8gc2l6ZS4KKworUEFTUwor CkluZGV4OiBMYXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1kb2N1bWVudC1hdWRpby1zaXplLmh0bWwK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvbWVkaWEvbWVkaWEtZG9jdW1lbnQtYXVkaW8tc2l6 ZS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvbWVkaWEvbWVkaWEtZG9jdW1lbnQt YXVkaW8tc2l6ZS5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDMwIEBACis8cD4KKyAgICBU aGlzIHRlc3RzIHRoYXQgaW4gYSBzdGFuZGFsb25lIG1lZGlhIGRvY3VtZW50IHdpdGggYXVkaW8g Y29udGVudCwgdGhlIG1lZGlhIGVsZW1lbnQgaGFzIG5vbi16ZXJvCisgICAgc2l6ZS4KKzwvcD4K KzxwcmUgaWQ9ImNvbnNvbGUiPjwvcHJlPgorPGlmcmFtZSBzcmM9ImNvbnRlbnQvdGVzdC53YXYi IGlkPSJmciIgd2lkdGg9MzgwIGhlaWdodD0zMzAgb25sb2FkPSJmcmFtZUxvYWRlZCgpIj48L2lm cmFtZT4KKzxzY3JpcHQ+CisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgewor ICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgICAgIGxheW91 dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKKyAgICB9CisKKyAgICBmdW5jdGlvbiBs b2cobWVzc2FnZSkKKyAgICB7CisgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJjb25z b2xlIikuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUobWVzc2FnZSArICJcbiIp KTsKKyAgICB9CisKKyAgICBmdW5jdGlvbiBmcmFtZUxvYWRlZCgpCisgICAgeworICAgICAgICB2 YXIgdmlkZW9FbGVtZW50ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImZyIikuY29udGVudERv Y3VtZW50LnF1ZXJ5U2VsZWN0b3IoInZpZGVvIik7CisgICAgICAgIHZhciBlbGVtZW50V2lkdGgg PSB2aWRlb0VsZW1lbnQub2Zmc2V0V2lkdGg7CisgICAgICAgIHZhciBlbGVtZW50SGVpZ2h0ID0g dmlkZW9FbGVtZW50Lm9mZnNldEhlaWdodDsKKyAgICAgICAgaWYgKGVsZW1lbnRXaWR0aCA+IDAg JiYgZWxlbWVudEhlaWdodCA+IDApCisgICAgICAgICAgICBsb2coIlBBU1MiKTsKKyAgICAgICAg ZWxzZQorICAgICAgICAgICAgbG9nKCJGQUlMOiB0aGUgdmlkZW8gZWxlbWVudCBkaW1lbnNpb25z IGFyZSAiICsgZWxlbWVudFdpZHRoICsgIiBieSAiICsgZWxlbWVudEhlaWdodCk7CisgICAgICAg IGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgICAgICBsYXlvdXRUZXN0 Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CisgICAgfQorPC9zY3JpcHQ+Cg==