38322 2010-04-29 06:16:47 -0700 Web Inspector: Timeline panel is not refreshing. 2010-04-29 11:13:01 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 loislo webkit-unassigned commit-queue pfeldman timothy yurys oldest_to_newest 218985 0 loislo 2010-04-29 06:16:47 -0700 a) If Timeline panel is in recording mode and is not visible and some events have arrived then it will not refresh when it becomes visible. Use case: 1) switch to timeline panel; 2) start recording; 3) switch to resource panel; 4) force reload of inspected page; 5) switch back to timeline panel; 6) You will see crystal clear panel in recording state. The records will appear if you change filters. b) timeline popup can appear at up-left corner when you switched to some other panel. 218995 1 54695 loislo 2010-04-29 06:35:19 -0700 Created attachment 54695 [patch] initial version. 219007 2 54695 yurys 2010-04-29 07:03:59 -0700 Comment on attachment 54695 [patch] initial version. WebCore/inspector/front-end/TimelinePanel.js:413 + if (!("_refreshTimeout" in this)) simple "if (!this._refreshTimeout)" should work 219018 3 54702 loislo 2010-04-29 07:22:37 -0700 Created attachment 54702 [patch] second iteration. style changes 219029 4 54702 commit-queue 2010-04-29 07:36:58 -0700 Comment on attachment 54702 [patch] second iteration. Rejecting patch 54702 from review queue. loislo@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your reviewer rights. 219102 5 54702 commit-queue 2010-04-29 11:12:56 -0700 Comment on attachment 54702 [patch] second iteration. Clearing flags on attachment: 54702 Committed r58528: <http://trac.webkit.org/changeset/58528> 219104 6 commit-queue 2010-04-29 11:13:01 -0700 All reviewed patches have been landed. Closing bug. 54695 2010-04-29 06:35:19 -0700 2010-04-29 07:22:37 -0700 [patch] initial version. patch text/plain 3500 loislo ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Yzg5ZWI5Yi4uMGJiZTIwYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMC0wNC0yOSAgSWx5YSBUaWtob25v dnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2ViSW5zcGVjdG9yOiBJZiBUaW1lbGluZSBwYW5lbCBpcyBp biByZWNvcmRpbmcgbW9kZSBhbmQgaXMgbm90IHZpc2libGUgYW5kIGhhcyByZWNlaXZlZAorICAg ICAgICBuZXcgZXZlbnRzIHRoZW4gdGhlc2UgZXZlbnRzIGRvIG5vdCBhcHBlYXIgaW4gdGhlIHBh bmVsIHdoZW4gdGhlIHBhbmVsIGJlY29tZXMgdmlzaWJsZS4KKyAgICAgICAgVGltZWxpbmUgcG9w dXAgbWF5IGFwcGVhciBpbiB0aGUgdXBwZXIgbGVmdCB3aW5kb3cgY29ybmVyIHdoZW4geW91IHN3 aXRjaCB0byBhbm90aGVyIHBhbmVsLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzgzMjIKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvUG9w b3Zlci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Qb3BvdmVySGVscGVyLnByb3RvdHlwZS5f bW91c2VNb3ZlLmRvSGlkZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUG9wb3ZlckhlbHBlci5w cm90b3R5cGUuX21vdXNlTW92ZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUG9wb3ZlckhlbHBl ci5wcm90b3R5cGUuaGlkZVBvcHVwKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Qb3BvdmVySGVs cGVyLnByb3RvdHlwZS5faGlkZVBvcHVwKToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5k L1RpbWVsaW5lUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVQYW5lbC5w cm90b3R5cGUuc2hvdyk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVQYW5lbC5wcm90 b3R5cGUuX3NjaGVkdWxlUmVmcmVzaCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVQ YW5lbC5wcm90b3R5cGUuX3JlZnJlc2gpOgorCiAyMDEwLTA0LTI5ICBHdXN0YXZvIFN2ZXJ6dXQg QmFyYmllcmkgIDxiYXJiaWVyaUBwcm9mdXNpb24ubW9iaT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Q b3BvdmVyLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1BvcG92ZXIuanMKaW5kZXgg ODQ4Yzk5ZS4uNTliNDhmOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L1BvcG92ZXIuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1BvcG92ZXIuanMK QEAgLTE3NSw3ICsxNzUsNyBAQCBXZWJJbnNwZWN0b3IuUG9wb3ZlckhlbHBlci5wcm90b3R5cGUg PSB7CiAgICAgICAgICAgICB2YXIgc2VsZiA9IHRoaXM7CiAgICAgICAgICAgICBmdW5jdGlvbiBk b0hpZGUoKQogICAgICAgICAgICAgewotICAgICAgICAgICAgICAgIHNlbGYuaGlkZVBvcHVwKCk7 CisgICAgICAgICAgICAgICAgc2VsZi5faGlkZVBvcHVwKCk7CiAgICAgICAgICAgICAgICAgZGVs ZXRlIHNlbGYuX2hpZGVQb3B1cFRpbWVyOwogICAgICAgICAgICAgfQogICAgICAgICAgICAgdGhp cy5faGlkZVBvcHVwVGltZXIgPSBzZXRUaW1lb3V0KGRvSGlkZSwgNTAwKTsKQEAgLTIwNiw2ICsy MDYsMTIgQEAgV2ViSW5zcGVjdG9yLlBvcG92ZXJIZWxwZXIucHJvdG90eXBlID0gewogCiAgICAg aGlkZVBvcHVwOiBmdW5jdGlvbigpCiAgICAgeworICAgICAgICB0aGlzLl9yZXNldEhvdmVyVGlt ZXIoKTsKKyAgICAgICAgdGhpcy5faGlkZVBvcHVwKCk7CisgICAgfSwKKworICAgIF9oaWRlUG9w dXA6IGZ1bmN0aW9uKCkKKyAgICB7CiAgICAgICAgIGlmICghdGhpcy5fcG9wdXApCiAgICAgICAg ICAgICByZXR1cm47CiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9U aW1lbGluZVBhbmVsLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFu ZWwuanMKaW5kZXggMzRmM2EyYi4uZTUxNDNiZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL1RpbWVsaW5lUGFuZWwuanMKQEAgLTM3NSw4ICszNzUsNyBAQCBXZWJJbnNwZWN0b3Iu VGltZWxpbmVQYW5lbC5wcm90b3R5cGUgPSB7CiAgICAgICAgIFdlYkluc3BlY3Rvci5QYW5lbC5w cm90b3R5cGUuc2hvdy5jYWxsKHRoaXMpOwogICAgICAgICBpZiAodHlwZW9mIHRoaXMuX3Njcm9s bFRvcCA9PT0gIm51bWJlciIpCiAgICAgICAgICAgICB0aGlzLl9jb250YWluZXJFbGVtZW50LnNj cm9sbFRvcCA9IHRoaXMuX3Njcm9sbFRvcDsKLSAgICAgICAgZWxzZSBpZiAodGhpcy5fbmVlZHNS ZWZyZXNoKQotICAgICAgICAgICAgdGhpcy5fcmVmcmVzaCgpOworICAgICAgICB0aGlzLl9yZWZy ZXNoKCk7CiAgICAgfSwKIAogICAgIGhpZGU6IGZ1bmN0aW9uKCkKQEAgLTQwNCwyMSArNDAzLDE5 IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZVBhbmVsLnByb3RvdHlwZSA9IHsKICAgICB7CiAgICAg ICAgIHRoaXMuX2Nsb3NlUmVjb3JkRGV0YWlscygpOwogICAgICAgICB0aGlzLl9ib3VuZGFyaWVz QXJlVmFsaWQgJj0gcHJlc2VydmVCb3VuZGFyaWVzOwotICAgICAgICBpZiAodGhpcy5fbmVlZHNS ZWZyZXNoKQotICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICB0aGlzLl9uZWVkc1JlZnJlc2gg PSB0cnVlOwogCi0gICAgICAgIGlmICh0aGlzLnZpc2libGUgJiYgISgiX3JlZnJlc2hUaW1lb3V0 IiBpbiB0aGlzKSkgewotICAgICAgICAgICAgaWYgKHByZXNlcnZlQm91bmRhcmllcykKLSAgICAg ICAgICAgICAgICB0aGlzLl9yZWZyZXNoKCk7Ci0gICAgICAgICAgICBlbHNlCisgICAgICAgIGlm ICghdGhpcy52aXNpYmxlKQorICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAKKyAgICAgICAg aWYgKHByZXNlcnZlQm91bmRhcmllcykKKyAgICAgICAgICAgIHRoaXMuX3JlZnJlc2goKTsKKyAg ICAgICAgZWxzZQorICAgICAgICAgICAgaWYgKCEoIl9yZWZyZXNoVGltZW91dCIgaW4gdGhpcykp CiAgICAgICAgICAgICAgICAgdGhpcy5fcmVmcmVzaFRpbWVvdXQgPSBzZXRUaW1lb3V0KHRoaXMu X3JlZnJlc2guYmluZCh0aGlzKSwgMTAwKTsKLSAgICAgICAgfQogICAgIH0sCiAKICAgICBfcmVm cmVzaDogZnVuY3Rpb24oKQogICAgIHsKLSAgICAgICAgdGhpcy5fbmVlZHNSZWZyZXNoID0gZmFs c2U7CiAgICAgICAgIGlmICgiX3JlZnJlc2hUaW1lb3V0IiBpbiB0aGlzKSB7CiAgICAgICAgICAg ICBjbGVhclRpbWVvdXQodGhpcy5fcmVmcmVzaFRpbWVvdXQpOwogICAgICAgICAgICAgZGVsZXRl IHRoaXMuX3JlZnJlc2hUaW1lb3V0Owo= 54702 2010-04-29 07:22:37 -0700 2010-04-29 11:12:56 -0700 [patch] second iteration. patch text/plain 3512 loislo ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Yzg5ZWI5Yi4uMGJiZTIwYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMC0wNC0yOSAgSWx5YSBUaWtob25v dnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2ViSW5zcGVjdG9yOiBJZiBUaW1lbGluZSBwYW5lbCBpcyBp biByZWNvcmRpbmcgbW9kZSBhbmQgaXMgbm90IHZpc2libGUgYW5kIGhhcyByZWNlaXZlZAorICAg ICAgICBuZXcgZXZlbnRzIHRoZW4gdGhlc2UgZXZlbnRzIGRvIG5vdCBhcHBlYXIgaW4gdGhlIHBh bmVsIHdoZW4gdGhlIHBhbmVsIGJlY29tZXMgdmlzaWJsZS4KKyAgICAgICAgVGltZWxpbmUgcG9w dXAgbWF5IGFwcGVhciBpbiB0aGUgdXBwZXIgbGVmdCB3aW5kb3cgY29ybmVyIHdoZW4geW91IHN3 aXRjaCB0byBhbm90aGVyIHBhbmVsLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzgzMjIKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvUG9w b3Zlci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Qb3BvdmVySGVscGVyLnByb3RvdHlwZS5f bW91c2VNb3ZlLmRvSGlkZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUG9wb3ZlckhlbHBlci5w cm90b3R5cGUuX21vdXNlTW92ZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUG9wb3ZlckhlbHBl ci5wcm90b3R5cGUuaGlkZVBvcHVwKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Qb3BvdmVySGVs cGVyLnByb3RvdHlwZS5faGlkZVBvcHVwKToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5k L1RpbWVsaW5lUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVQYW5lbC5w cm90b3R5cGUuc2hvdyk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVQYW5lbC5wcm90 b3R5cGUuX3NjaGVkdWxlUmVmcmVzaCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVQ YW5lbC5wcm90b3R5cGUuX3JlZnJlc2gpOgorCiAyMDEwLTA0LTI5ICBHdXN0YXZvIFN2ZXJ6dXQg QmFyYmllcmkgIDxiYXJiaWVyaUBwcm9mdXNpb24ubW9iaT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Q b3BvdmVyLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1BvcG92ZXIuanMKaW5kZXgg ODQ4Yzk5ZS4uNTliNDhmOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L1BvcG92ZXIuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1BvcG92ZXIuanMK QEAgLTE3NSw3ICsxNzUsNyBAQCBXZWJJbnNwZWN0b3IuUG9wb3ZlckhlbHBlci5wcm90b3R5cGUg PSB7CiAgICAgICAgICAgICB2YXIgc2VsZiA9IHRoaXM7CiAgICAgICAgICAgICBmdW5jdGlvbiBk b0hpZGUoKQogICAgICAgICAgICAgewotICAgICAgICAgICAgICAgIHNlbGYuaGlkZVBvcHVwKCk7 CisgICAgICAgICAgICAgICAgc2VsZi5faGlkZVBvcHVwKCk7CiAgICAgICAgICAgICAgICAgZGVs ZXRlIHNlbGYuX2hpZGVQb3B1cFRpbWVyOwogICAgICAgICAgICAgfQogICAgICAgICAgICAgdGhp cy5faGlkZVBvcHVwVGltZXIgPSBzZXRUaW1lb3V0KGRvSGlkZSwgNTAwKTsKQEAgLTIwNiw2ICsy MDYsMTIgQEAgV2ViSW5zcGVjdG9yLlBvcG92ZXJIZWxwZXIucHJvdG90eXBlID0gewogCiAgICAg aGlkZVBvcHVwOiBmdW5jdGlvbigpCiAgICAgeworICAgICAgICB0aGlzLl9yZXNldEhvdmVyVGlt ZXIoKTsKKyAgICAgICAgdGhpcy5faGlkZVBvcHVwKCk7CisgICAgfSwKKworICAgIF9oaWRlUG9w dXA6IGZ1bmN0aW9uKCkKKyAgICB7CiAgICAgICAgIGlmICghdGhpcy5fcG9wdXApCiAgICAgICAg ICAgICByZXR1cm47CiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9U aW1lbGluZVBhbmVsLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFu ZWwuanMKaW5kZXggMzRmM2EyYi4uZTM5MzkzYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL1RpbWVsaW5lUGFuZWwuanMKQEAgLTM3NSw4ICszNzUsNyBAQCBXZWJJbnNwZWN0b3Iu VGltZWxpbmVQYW5lbC5wcm90b3R5cGUgPSB7CiAgICAgICAgIFdlYkluc3BlY3Rvci5QYW5lbC5w cm90b3R5cGUuc2hvdy5jYWxsKHRoaXMpOwogICAgICAgICBpZiAodHlwZW9mIHRoaXMuX3Njcm9s bFRvcCA9PT0gIm51bWJlciIpCiAgICAgICAgICAgICB0aGlzLl9jb250YWluZXJFbGVtZW50LnNj cm9sbFRvcCA9IHRoaXMuX3Njcm9sbFRvcDsKLSAgICAgICAgZWxzZSBpZiAodGhpcy5fbmVlZHNS ZWZyZXNoKQotICAgICAgICAgICAgdGhpcy5fcmVmcmVzaCgpOworICAgICAgICB0aGlzLl9yZWZy ZXNoKCk7CiAgICAgfSwKIAogICAgIGhpZGU6IGZ1bmN0aW9uKCkKQEAgLTQwNCwyMiArNDAzLDIw IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZVBhbmVsLnByb3RvdHlwZSA9IHsKICAgICB7CiAgICAg ICAgIHRoaXMuX2Nsb3NlUmVjb3JkRGV0YWlscygpOwogICAgICAgICB0aGlzLl9ib3VuZGFyaWVz QXJlVmFsaWQgJj0gcHJlc2VydmVCb3VuZGFyaWVzOwotICAgICAgICBpZiAodGhpcy5fbmVlZHNS ZWZyZXNoKQorCisgICAgICAgIGlmICghdGhpcy52aXNpYmxlKQogICAgICAgICAgICAgcmV0dXJu OwotICAgICAgICB0aGlzLl9uZWVkc1JlZnJlc2ggPSB0cnVlOwogCi0gICAgICAgIGlmICh0aGlz LnZpc2libGUgJiYgISgiX3JlZnJlc2hUaW1lb3V0IiBpbiB0aGlzKSkgewotICAgICAgICAgICAg aWYgKHByZXNlcnZlQm91bmRhcmllcykKLSAgICAgICAgICAgICAgICB0aGlzLl9yZWZyZXNoKCk7 Ci0gICAgICAgICAgICBlbHNlCisgICAgICAgIGlmIChwcmVzZXJ2ZUJvdW5kYXJpZXMpCisgICAg ICAgICAgICB0aGlzLl9yZWZyZXNoKCk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIGlmICgh dGhpcy5fcmVmcmVzaFRpbWVvdXQpCiAgICAgICAgICAgICAgICAgdGhpcy5fcmVmcmVzaFRpbWVv dXQgPSBzZXRUaW1lb3V0KHRoaXMuX3JlZnJlc2guYmluZCh0aGlzKSwgMTAwKTsKLSAgICAgICAg fQogICAgIH0sCiAKICAgICBfcmVmcmVzaDogZnVuY3Rpb24oKQogICAgIHsKLSAgICAgICAgdGhp cy5fbmVlZHNSZWZyZXNoID0gZmFsc2U7Ci0gICAgICAgIGlmICgiX3JlZnJlc2hUaW1lb3V0IiBp biB0aGlzKSB7CisgICAgICAgIGlmICh0aGlzLl9yZWZyZXNoVGltZW91dCkgewogICAgICAgICAg ICAgY2xlYXJUaW1lb3V0KHRoaXMuX3JlZnJlc2hUaW1lb3V0KTsKICAgICAgICAgICAgIGRlbGV0 ZSB0aGlzLl9yZWZyZXNoVGltZW91dDsKICAgICAgICAgfQo=