38316 2010-04-29 03:11:49 -0700 [Qt] REGRESSION(r57638): tst_qwebframe::objectDeleted() fails 2010-04-29 03:21:51 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All CLOSED FIXED Qt P1 Blocker --- 35784 1 hausmann hausmann bruno.schmidt oldest_to_newest 218924 0 hausmann 2010-04-29 03:11:49 -0700 After r57638 the objectDeleted() test fails: FAIL! : tst_QWebFrame::objectDeleted() Compared values are not the same Actual (type): undefined Expected (sError): error Loc: [/home/shausman/src/webkit/trunk/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(2056)] The test creates a QObject, accesses its properties, deletes it and tries to access it again. Accessing the properties of a deleted object should give an exception, just like in QtScript. The following hunk from r57638 caused a slight change in behaviour, triggering the regression: @@ -171,6 +171,8 @@ QtInstance* QtInstance::getInstance(JSObject* object) Class* QtInstance::getClass() const { + if (!m_object) + return 0; if (!m_class) m_class = QtClass::classForObject(m_object); return m_class; After that change even if m_class existed, null is returned. QtClass itself is protected to handle null objects, so a safe solution would be to return null only if we have never created the class wrapper in the first place. 218926 1 54687 hausmann 2010-04-29 03:14:15 -0700 Created attachment 54687 Patch 218929 2 hausmann 2010-04-29 03:20:58 -0700 Committed r58493: <http://trac.webkit.org/changeset/58493> 218930 3 hausmann 2010-04-29 03:21:38 -0700 Revision r58493 cherry-picked into qtwebkit-2.0 with commit 1a40220a82197023c1b1ac6eff027be6dd3168d3 54687 2010-04-29 03:14:15 -0700 2010-04-29 03:18:42 -0700 Patch bug-38316-20100429121412.patch text/plain 1574 hausmann ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTdkM2I4MTEyYjAzN2MwOTlmNGVlZjYxZWY0ZmViNjI5NzNjOGE5Ni4uMjRmNTYxYzkwYWY0NjMy MjVhYjlhODUxYWI2ZjJlYjA4YmVjYTE2MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMC0wNC0yOSAgU2lt b24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBSRUdSRVNTSU9OKHI1NzYzOCk6 IHRzdF9xd2ViZnJhbWU6Om9iamVjdERlbGV0ZWQoKSBmYWlscworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzgzMTYKKworICAgICAgICBBY2Nlc3Npbmcg cHJvcGVydGllcyBvZiBhIGRlbGV0ZWQgb2JqZWN0cyBkb2Vzbid0IHRocm93IGFuIGV4Y2VwdGlv bgorICAgICAgICBhbnltb3JlLgorCisgICAgICAgIENvbnRpbnVlIHRvIGV4cG9zZSB0aGUgUU9i amVjdCBjbGFzcyB3cmFwcGVyIGZvciBvYmplY3RzIHRoYXQKKyAgICAgICAgcHJldmlvdXNseSBl eGlzdGVkIGJ1dCBkb24ndCBleGlzdCBhbnltb3JlLiBRdENsYXNzIGlzIHNhZmUgdG8KKyAgICAg ICAgdXNlIHdpdGggYSBkZWxldGVkIFFPYmplY3QuCisKKyAgICAgICAgKiBicmlkZ2UvcXQvcXRf aW5zdGFuY2UuY3BwOgorICAgICAgICAoSlNDOjpCaW5kaW5nczo6UXRJbnN0YW5jZTo6Z2V0Q2xh c3MpOiBSZXR1cm4gbnVsbCBvbmx5IGlmIG1fY2xhc3MKKyAgICAgICAgZG9lc24ndCBleGlzdCB5 ZXQgYW5kIHRoZXJlJ3Mgbm8gbV9vYmplY3QuCisKIDIwMTAtMDQtMjkgIEphcmtrbyBTYWtraW5l biAgPGphcmtrby5qLnNha2tpbmVuQGdtYWlsLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBT aW1vbiBIYXVzbWFubi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvYnJpZGdlL3F0L3F0X2luc3RhbmNl LmNwcCBiL1dlYkNvcmUvYnJpZGdlL3F0L3F0X2luc3RhbmNlLmNwcAppbmRleCA0ZTM5MzcxOTA3 ZjYyYWM4MDJhNDI4OTIzMWU5ODM2NDY4MGM3MjgyLi5mNmYzNjhiZTgwODZiY2NmMzBlZjM1Yzgz NTlkNTYwNzExMzE1MjlhIDEwMDY0NAotLS0gYS9XZWJDb3JlL2JyaWRnZS9xdC9xdF9pbnN0YW5j ZS5jcHAKKysrIGIvV2ViQ29yZS9icmlkZ2UvcXQvcXRfaW5zdGFuY2UuY3BwCkBAIC0xNzEsMTAg KzE3MSwxMSBAQCBRdEluc3RhbmNlKiBRdEluc3RhbmNlOjpnZXRJbnN0YW5jZShKU09iamVjdCog b2JqZWN0KQogCiBDbGFzcyogUXRJbnN0YW5jZTo6Z2V0Q2xhc3MoKSBjb25zdAogewotICAgIGlm ICghbV9vYmplY3QpCi0gICAgICAgIHJldHVybiAwOwotICAgIGlmICghbV9jbGFzcykKKyAgICBp ZiAoIW1fY2xhc3MpIHsKKyAgICAgICAgaWYgKCFtX29iamVjdCkKKyAgICAgICAgICAgIHJldHVy biAwOwogICAgICAgICBtX2NsYXNzID0gUXRDbGFzczo6Y2xhc3NGb3JPYmplY3QobV9vYmplY3Qp OworICAgIH0KICAgICByZXR1cm4gbV9jbGFzczsKIH0KIAo=