38314 2010-04-29 01:33:32 -0700 [Qt] REGRESSION(r57982): tst_qwebpage::showModalDialog() crashes 2010-04-29 04:38:58 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All CLOSED FIXED Qt P1 Blocker --- 35784 1 hausmann hausmann max.hong.shen oldest_to_newest 218900 0 hausmann 2010-04-29 01:33:32 -0700 r57982 caused the showModalDialog() unit test to regress/crash. This is caused by not always calling mainFrame() anymore, inside ChromeClientQt::createWindow. When returning from that function WebCore expects that a main frame exists. 218902 1 54684 hausmann 2010-04-29 01:35:52 -0700 Created attachment 54684 Patch 218904 2 hausmann 2010-04-29 01:42:20 -0700 Committed r58485: <http://trac.webkit.org/changeset/58485> 218906 3 hausmann 2010-04-29 01:44:48 -0700 Revision r58485 cherry-picked into qtwebkit-2.0 with commit 52345b219c57e8986cd399c148d85b7909a1dd6e 218958 4 max.hong.shen 2010-04-29 04:38:58 -0700 Sorry Simon, my patch causes the crash :( I will be careful next time 54684 2010-04-29 01:35:52 -0700 2010-04-29 01:40:00 -0700 Patch bug-38314-20100429103550.patch text/plain 1606 hausmann ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IDE4MDdlYzVjNDA1MDUxZTI1NGQyMDAyZDlmZjM1MGM5MjQzM2Y5MTMuLmVhOWJiYmM4MGNj NmI0MzFhZjkwY2ExOWZhYTA0ZjNhZWE4NmE0ZjAgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFu Z2VMb2cKKysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEwLTA0 LTI5ICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFJFR1JFU1NJT04o cjU3OTgyKTogdHN0X3F3ZWJwYWdlOjpzaG93TW9kYWxEaWFsb2coKSBjcmFzaGVzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODMxNAorCisgICAgICAg IE1ha2Ugc3VyZSB0aGF0IHRoZXJlJ3MgYWx3YXlzIGEgbWFpbiBmcmFtZSB3aGVuIHJldHVybmlu ZyBmcm9tIGNyZWF0ZVdpbmRvdygpCisgICAgICAgIHRvIHRoZSBjYWxsZXIgaW4gV2ViQ29yZS4K KworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudFF0LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkNocm9tZUNsaWVudFF0OjpjcmVhdGVXaW5kb3cpOgorCiAyMDEwLTA0LTI4ICBM YXN6bG8gR29tYm9zICA8bGFzemxvLjEuZ29tYm9zQG5va2lhLmNvbT4KIAogICAgICAgICBVbnJl dmlld2VkLCBRdCBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBv cnQvQ2hyb21lQ2xpZW50UXQuY3BwIGIvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNs aWVudFF0LmNwcAppbmRleCA1ZWEwNzJkMzJkMzkxNWMzNDI2ODE4ODViYTgyMmUxOGU1NGQ0MWNh Li5jZjEwMGY3NmUwZGRlMjNhYjYzMzczZjlmYmQ3NTBmMjYzNWZmYTAyIDEwMDY0NAotLS0gYS9X ZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50UXQuY3BwCisrKyBiL1dlYktpdC9x dC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRRdC5jcHAKQEAgLTE2Nyw4ICsxNjcsMTIgQEAg UGFnZSogQ2hyb21lQ2xpZW50UXQ6OmNyZWF0ZVdpbmRvdyhGcmFtZSosIGNvbnN0IEZyYW1lTG9h ZFJlcXVlc3QmIHJlcXVlc3QsIGNvbnMKICAgICBpZiAoIW5ld1BhZ2UpCiAgICAgICAgIHJldHVy biAwOwogCisgICAgLy8gQSBjYWxsIHRvIFFXZWJQYWdlOjptYWluRnJhbWUoKSBpbXBsaWNpdGx5 IGNyZWF0ZXMgdGhlIG1haW4gZnJhbWUuCisgICAgLy8gTWFrZSBzdXJlIGl0IGV4aXN0cywgYXMg V2ViQ29yZSBleHBlY3RzIGl0IHdoZW4gcmV0dXJuaW5nIGZyb20gdGhpcyBjYWxsLgorICAgIFFX ZWJGcmFtZSogbWFpbkZyYW1lID0gbmV3UGFnZS0+bWFpbkZyYW1lKCk7CisKICAgICBpZiAoIXJl cXVlc3QuaXNFbXB0eSgpKQotICAgICAgICBuZXdQYWdlLT5tYWluRnJhbWUoKS0+bG9hZChyZXF1 ZXN0LnJlc291cmNlUmVxdWVzdCgpLnVybCgpKTsKKyAgICAgICAgbWFpbkZyYW1lLT5sb2FkKHJl cXVlc3QucmVzb3VyY2VSZXF1ZXN0KCkudXJsKCkpOwogICAgIHJldHVybiBuZXdQYWdlLT5kLT5w YWdlOwogfQogCg==