38312 2010-04-29 00:57:14 -0700 Add sqrt support for ARM port 2010-05-06 23:25:56 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Enhancement --- 1 zherczeg webkit-unassigned commit-queue eric loki oliver webkit.review.bot oldest_to_newest 218880 0 zherczeg 2010-04-29 00:57:14 -0700 Patch for sqrt support 218888 1 54680 zherczeg 2010-04-29 01:03:35 -0700 Created attachment 54680 patch 218889 2 webkit.review.bot 2010-04-29 01:04:58 -0700 Attachment 54680 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 JavaScriptCore/assembler/ARMAssembler.h:430: fsqrtd_r is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 218996 3 54680 commit-queue 2010-04-29 06:42:32 -0700 Comment on attachment 54680 patch Rejecting patch 54680 from commit-queue. Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html 219035 4 zherczeg 2010-04-29 07:54:40 -0700 > Found no modified ChangeLogs, cannot create a commit message. There IS a ChangeLog in the patch, bot. Anyway, landed in r58515 219047 5 eric 2010-04-29 08:38:24 -0700 I suspect there may be an error in the date line. Webkit-patch commit-message can tell you. 222197 6 eric 2010-05-06 23:25:56 -0700 Turns out there was a regression in svn-apply. cjersonek fixed. 54680 2010-04-29 01:03:35 -0700 2010-04-29 06:42:32 -0700 patch 0001-sqrt.patch text/plain 3021 zherczeg RnJvbSBiMTQzZTQ2ZjMxOWQ5ZmE2NGI0YzdlNjdkYTVlOTA4NjE1YzI3Y2ZmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAaW5mLnUtc3plZ2Vk Lmh1PgpEYXRlOiBUaHUsIDI5IEFwciAyMDEwIDEwOjAyOjA4ICswMjAwClN1YmplY3Q6IFtQQVRD SF0gc3FydAoKU2lnbmVkLW9mZi1ieTogWm9sdGFuIEhlcmN6ZWcgPHpoZXJjemVnQGluZi51LXN6 ZWdlZC5odT4KLS0tCiBKYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAg ICB8ICAgMTQgKysrKysrKysrKysrKysKIEphdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk1Bc3Nl bWJsZXIuaCAgICAgIHwgICAgNiArKysrKysKIEphdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNy b0Fzc2VtYmxlckFSTS5oIHwgICAgNiArKystLS0KIDMgZmlsZXMgY2hhbmdlZCwgMjMgaW5zZXJ0 aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9DaGFu Z2VMb2cgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggM2ZhMDFlMC4uMzBkNjY0ZSAx MDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL0phdmFTY3JpcHRDb3Jl L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEwLTA0LTI5ICBab2x0YW4gSGVyY3plZyAg PHpoZXJjemVnQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQWRkIHNxcnQoKSBpbnN0cnVjdGlvbiBzdXBwb3J0IGZvciBBUk0gYXNz ZW1ibGVyICh1c2luZyBWRlApCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zODMxMgorCisgICAgICAgICogYXNzZW1ibGVyL0FSTUFzc2VtYmxlci5oOgor ICAgICAgICAoSlNDOjpBUk1Bc3NlbWJsZXI6Oik6CisgICAgICAgIChKU0M6OkFSTUFzc2VtYmxl cjo6ZnNxcnRkX3IpOgorICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5oOgor ICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlckFSTTo6c3VwcG9ydHNGbG9hdGluZ1BvaW50U3Fy dCk6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNOjpzcXJ0RG91YmxlKToKKwogMjAx MC0wNC0yOCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIERvIGFu IHVub3JkZXJlZCBjb21wYXJlIHNvIHRoYXQgd2UgZG9uJ3QgdHJlYXQgTmFOIGluY29ycmVjdGx5 LgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTUFzc2VtYmxlci5oIGIv SmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTUFzc2VtYmxlci5oCmluZGV4IDRjMmUwZDAuLjJj YTA5NDkgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk1Bc3NlbWJsZXIu aAorKysgYi9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQVJNQXNzZW1ibGVyLmgKQEAgLTEyMyw2 ICsxMjMsNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgICAgIEZTVUJEID0gMHgwZTMwMGI0 MCwKICAgICAgICAgICAgIEZNVUxEID0gMHgwZTIwMGIwMCwKICAgICAgICAgICAgIEZDTVBEID0g MHgwZWI0MGI0MCwKKyAgICAgICAgICAgIEZTUVJURCA9IDB4MGViMTBiYzAsCiAgICAgICAgICAg ICBEVFIgPSAweDA1MDAwMDAwLAogICAgICAgICAgICAgTERSSCA9IDB4MDAxMDAwOTAsCiAgICAg ICAgICAgICBTVFJIID0gMHgwMDAwMDA5MCwKQEAgLTQyNiw2ICs0MjcsMTEgQEAgbmFtZXNwYWNl IEpTQyB7CiAgICAgICAgICAgICBlbWl0SW5zdChzdGF0aWNfY2FzdDxBUk1Xb3JkPihjYykgfCBG Q01QRCwgZGQsIDAsIGRtKTsKICAgICAgICAgfQogCisgICAgICAgIHZvaWQgZnNxcnRkX3IoaW50 IGRkLCBpbnQgZG0sIENvbmRpdGlvbiBjYyA9IEFMKQorICAgICAgICB7CisgICAgICAgICAgICBl bWl0SW5zdChzdGF0aWNfY2FzdDxBUk1Xb3JkPihjYykgfCBGU1FSVEQsIGRkLCAwLCBkbSk7Cisg ICAgICAgIH0KKwogICAgICAgICB2b2lkIGxkcl9pbW0oaW50IHJkLCBBUk1Xb3JkIGltbSwgQ29u ZGl0aW9uIGNjID0gQUwpCiAgICAgICAgIHsKICAgICAgICAgICAgIG1fYnVmZmVyLnB1dEludFdp dGhDb25zdGFudEludChzdGF0aWNfY2FzdDxBUk1Xb3JkPihjYykgfCBEVFIgfCBEVF9MT0FEIHwg RFRfVVAgfCBSTihBUk1SZWdpc3RlcnM6OnBjKSB8IFJEKHJkKSwgaW1tLCB0cnVlKTsKZGlmZiAt LWdpdCBhL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5oIGIvSmF2 YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmgKaW5kZXggNDQ4YmMxNC4u MzRlNjBjNiAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1i bGVyQVJNLmgKKysrIGIvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJN LmgKQEAgLTc1Myw3ICs3NTMsNyBAQCBwdWJsaWM6CiAKICAgICBib29sIHN1cHBvcnRzRmxvYXRp bmdQb2ludFNxcnQoKSBjb25zdAogICAgIHsKLSAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAg ICByZXR1cm4gc19pc1ZGUFByZXNlbnQ7CiAgICAgfQogCiAgICAgdm9pZCBsb2FkRG91YmxlKElt cGxpY2l0QWRkcmVzcyBhZGRyZXNzLCBGUFJlZ2lzdGVySUQgZGVzdCkKQEAgLTgxNyw5ICs4MTcs OSBAQCBwdWJsaWM6CiAgICAgICAgIG11bERvdWJsZShBUk1SZWdpc3RlcnM6OlNEMCwgZGVzdCk7 CiAgICAgfQogCi0gICAgdm9pZCBzcXJ0RG91YmxlKEZQUmVnaXN0ZXJJRCwgRlBSZWdpc3RlcklE KQorICAgIHZvaWQgc3FydERvdWJsZShGUFJlZ2lzdGVySUQgc3JjLCBGUFJlZ2lzdGVySUQgZGVz dCkKICAgICB7Ci0gICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAgICBtX2Fzc2Vt Ymxlci5mc3FydGRfcihkZXN0LCBzcmMpOwogICAgIH0KIAogICAgIHZvaWQgY29udmVydEludDMy VG9Eb3VibGUoUmVnaXN0ZXJJRCBzcmMsIEZQUmVnaXN0ZXJJRCBkZXN0KQotLSAKMS42LjAuNAoK