38304 2010-04-28 18:40:06 -0700 [Qt] Reinstate qt_drt_ symbol exports as of QtWebKit 4.6 release 2010-04-29 11:26:34 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED Qt P2 Normal --- 1 laszlo.gombos webkit-unassigned hausmann kenneth robert oldest_to_newest 218756 0 laszlo.gombos 2010-04-28 18:40:06 -0700 It would be a small effort (and small overhead) and potentially a big win to maintain some of the previously exported qt_drt_ symbols after r57433 for some time until all QtWebKit clients transition to the API changes. There is no backward compatibility grantee on the qt_drt interfaces, but some of these interfaces are only not exported because a "clean" Qt-style interface has not been commonly agreed (and not because they are not useful). This is a stop gap solution until a proper QtWebKit API is commonly agreed for some of this functionality. 218760 1 54660 laszlo.gombos 2010-04-28 18:48:20 -0700 Created attachment 54660 proposed patch 218774 2 54660 kenneth 2010-04-28 20:10:08 -0700 Comment on attachment 54660 proposed patch > void QWEBKIT_EXPORT qt_drt_run(bool b) I'm pretty sure this one is not used by anyone outside the DRT, does it really make sense to reintroduce it? WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:431 + bool QWEBKIT_EXPORT qt_drt_pauseAnimation(QWebFrame *qframe, const QString &animationName, double time, const QString &elementId) Wrong coding style, please fix before landing. Also, just use frame, not need to call it qFrame/qframe. I think it makes sense to order the DRT methods together and the QWebPage ones as well; right now they are mixed. 218818 3 hausmann 2010-04-28 22:06:38 -0700 I'm fine with reinstating the qt_* functions that were accidentially removed, but why should we reinstate the qt_drt_* ones? As the DRT suffix suggests they are only meant for the DRT implementation, which doesn't need them. Are you using the qt_drt_* functions in applications? 218968 4 kenneth 2010-04-29 05:07:30 -0700 Judging from the email to the list, they indeed are. 219081 5 laszlo.gombos 2010-04-29 10:30:03 -0700 Bug 31875 would be a good example of a functionality that should be a public API but the only way this is exposed today is trough DRT methods. 219112 6 laszlo.gombos 2010-04-29 11:26:17 -0700 Landed as http://trac.webkit.org/changeset/58527 with the changes suggested by Kenneth. I kept qt_drt_run for now - we would need to mark the symbol ABSENT in the def file for Symbian if we remove it. It also potentially allows using the same DRT binary for a few different WebKit versions to check for differences between releases, but I'm not sure if this is a compelling enough case. 54660 2010-04-28 18:48:20 -0700 2010-04-29 11:26:34 -0700 proposed patch 38304.patch text/plain 4590 laszlo.gombos SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNTg0NjEpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMzEgQEAKKzIwMTAtMDQtMjggIExhc3psbyBHb21ib3MgIDxsYXN6bG8u MS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFtRdF0gUmVpbnN0YXRlIHF0X2RydF8gc3ltYm9sIGV4cG9ydHMgYXMgb2Yg UXRXZWJLaXQgNC42IHJlbGVhc2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTM4MzA0CisKKyAgICAgICAgVGhpcyBpcyB0byBwcm92aWRlIGEgYmFja3dh cmQgY29tcGF0aWJpbGl0eSB3aXRoIHByZXZpb3VzbHkgZXhwb3J0ZWQKKyAgICAgICAgc3ltYm9s cy4gIE5vIG5ldyAgZnVuY3Rpb25hbGl0eSBpbnRyb2R1Y2VkLgorCisgICAgICAgICogV2ViQ29y ZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQuY3BwOgorICAgICAgICAocXRfZHJ0X3J1 bik6CisgICAgICAgIChxdF9kcnRfY2xlYXJGcmFtZU5hbWUpOgorICAgICAgICAocXRfZHJ0X3Bh dXNlQW5pbWF0aW9uKToKKyAgICAgICAgKHF0X2RydF9qYXZhU2NyaXB0T2JqZWN0c0NvdW50KToK KyAgICAgICAgKHF0X2RydF9nYXJiYWdlQ29sbGVjdG9yX2NvbGxlY3QpOgorICAgICAgICAocXRf ZHJ0X251bWJlck9mQWN0aXZlQW5pbWF0aW9ucyk6CisgICAgICAgIChxdF9kcnRfcGF1c2VUcmFu c2l0aW9uT2ZQcm9wZXJ0eSk6CisgICAgICAgIChxdF9kcnRfb3ZlcndyaXRlUGx1Z2luRGlyZWN0 b3JpZXMpOgorICAgICAgICAocXRfZHJ0X3NldEphdmFTY3JpcHRQcm9maWxpbmdFbmFibGVkKToK KyAgICAgICAgKHF0X2RydF9nYXJiYWdlQ29sbGVjdG9yX2NvbGxlY3RPbkFsdGVybmF0ZVRocmVh ZCk6CisgICAgICAgIChxdF9zdXNwZW5kQWN0aXZlRE9NT2JqZWN0cyk6CisgICAgICAgIChxdF9y ZXN1bWVBY3RpdmVET01PYmplY3RzKToKKyAgICAgICAgKHF0X3dlYnBhZ2VfZ3JvdXBOYW1lKToK KyAgICAgICAgKHF0X3dlYnBhZ2Vfc2V0R3JvdXBOYW1lKToKKyAgICAgICAgKHF0X2RydF93aGl0 ZUxpc3RBY2Nlc3NGcm9tT3JpZ2luKToKKyAgICAgICAgKHF0X2RydF9yZXNldE9yaWdpbkFjY2Vz c1doaXRlTGlzdHMpOgorCiAyMDEwLTA0LTI4ICBBbnRvbmlvIEdvbWVzICA8dG9uaWtpdG9vQHdl YmtpdC5vcmc+LCBZaSBTaGVuIDx5aS40LnNoZW5Abm9raWEuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpJbmRleDogV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0R1 bXBSZW5kZXJUcmVlU3VwcG9ydFF0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvV2ViQ29y ZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQuY3BwCShyZXZpc2lvbiA1ODQ2MSkKKysr IFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRRdC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTQxNSwzICs0MTUsODUgQEAgUVZhcmlhbnRMaXN0IER1bXBSZW5kZXJU cmVlU3VwcG9ydFF0OjpmaQogICAgIHJlY3QgPDwgcmVzdWx0UmVjdC54KCkgPDwgcmVzdWx0UmVj dC55KCkgPDwgcmVzdWx0UmVjdC53aWR0aCgpIDw8IHJlc3VsdFJlY3QuaGVpZ2h0KCk7CiAgICAg cmV0dXJuIHJlY3Q7CiB9CisKKy8vIFByb3ZpZGUgYSBiYWNrd2FyZCBjb21wYXRpYmlsaXR5IHdp dGggcHJldmlvdXNseSBleHBvcnRlZCBwcml2YXRlIHN5bWJvbHMgYXMgb2YgUXRXZWJLaXQgNC42 IHJlbGVhc2UKKwordm9pZCBRV0VCS0lUX0VYUE9SVCBxdF9kcnRfcnVuKGJvb2wgYikKK3sKKyAg ICBEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6c2V0RHVtcFJlbmRlclRyZWVNb2RlRW5hYmxlZChi KTsKK30KKwordm9pZCBRV0VCS0lUX0VYUE9SVCBxdF9kcnRfY2xlYXJGcmFtZU5hbWUoUVdlYkZy YW1lKiBxRnJhbWUpCit7CisgICAgRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQ6OmNsZWFyRnJhbWVO YW1lKHFGcmFtZSk7Cit9CisKK2Jvb2wgUVdFQktJVF9FWFBPUlQgcXRfZHJ0X3BhdXNlQW5pbWF0 aW9uKFFXZWJGcmFtZSAqcWZyYW1lLCBjb25zdCBRU3RyaW5nICZhbmltYXRpb25OYW1lLCBkb3Vi bGUgdGltZSwgY29uc3QgUVN0cmluZyAmZWxlbWVudElkKQoreworICAgIHJldHVybiBEdW1wUmVu ZGVyVHJlZVN1cHBvcnRRdDo6cGF1c2VBbmltYXRpb24ocWZyYW1lLCBhbmltYXRpb25OYW1lLCB0 aW1lLCBlbGVtZW50SWQpOworfQorCitpbnQgUVdFQktJVF9FWFBPUlQgcXRfZHJ0X2phdmFTY3Jp cHRPYmplY3RzQ291bnQoKQoreworICAgIHJldHVybiBEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6 amF2YVNjcmlwdE9iamVjdHNDb3VudCgpOworfQorCit2b2lkIFFXRUJLSVRfRVhQT1JUIHF0X2Ry dF9nYXJiYWdlQ29sbGVjdG9yX2NvbGxlY3QoKQoreworICAgIER1bXBSZW5kZXJUcmVlU3VwcG9y dFF0OjpnYXJiYWdlQ29sbGVjdG9yQ29sbGVjdCgpOworfQorCitpbnQgUVdFQktJVF9FWFBPUlQg cXRfZHJ0X251bWJlck9mQWN0aXZlQW5pbWF0aW9ucyhRV2ViRnJhbWUgKnFmcmFtZSkKK3sKKyAg ICByZXR1cm4gRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQ6Om51bWJlck9mQWN0aXZlQW5pbWF0aW9u cyhxZnJhbWUpOworfQorCitib29sIFFXRUJLSVRfRVhQT1JUIHF0X2RydF9wYXVzZVRyYW5zaXRp b25PZlByb3BlcnR5KFFXZWJGcmFtZSAqcWZyYW1lLCBjb25zdCBRU3RyaW5nICZwcm9wZXJ0eU5h bWUsIGRvdWJsZSB0aW1lLCBjb25zdCBRU3RyaW5nICZlbGVtZW50SWQpCit7CisgICAgcmV0dXJu IER1bXBSZW5kZXJUcmVlU3VwcG9ydFF0OjpwYXVzZVRyYW5zaXRpb25PZlByb3BlcnR5KHFmcmFt ZSwgcHJvcGVydHlOYW1lLCB0aW1lLCBlbGVtZW50SWQpOworfQorCit2b2lkIFFXRUJLSVRfRVhQ T1JUIHF0X2RydF9vdmVyd3JpdGVQbHVnaW5EaXJlY3RvcmllcygpCit7CisgICAgRHVtcFJlbmRl clRyZWVTdXBwb3J0UXQ6Om92ZXJ3cml0ZVBsdWdpbkRpcmVjdG9yaWVzKCk7Cit9CisKK3ZvaWQg UVdFQktJVF9FWFBPUlQgcXRfZHJ0X3NldEphdmFTY3JpcHRQcm9maWxpbmdFbmFibGVkKFFXZWJG cmFtZSogcWZyYW1lLCBib29sIGVuYWJsZWQpCit7CisgICAgRHVtcFJlbmRlclRyZWVTdXBwb3J0 UXQ6OnNldEphdmFTY3JpcHRQcm9maWxpbmdFbmFibGVkKHFmcmFtZSwgZW5hYmxlZCk7Cit9CisK K3ZvaWQgUVdFQktJVF9FWFBPUlQgcXRfZHJ0X2dhcmJhZ2VDb2xsZWN0b3JfY29sbGVjdE9uQWx0 ZXJuYXRlVGhyZWFkKGJvb2wgd2FpdFVudGlsRG9uZSkKK3sKKyAgICBEdW1wUmVuZGVyVHJlZVN1 cHBvcnRRdDo6Z2FyYmFnZUNvbGxlY3RvckNvbGxlY3RPbkFsdGVybmF0ZVRocmVhZCh3YWl0VW50 aWxEb25lKTsKK30KKwordm9pZCBRV0VCS0lUX0VYUE9SVCBxdF9zdXNwZW5kQWN0aXZlRE9NT2Jq ZWN0cyhRV2ViRnJhbWUqIHFGcmFtZSkKK3sKKyAgICBEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6 c3VzcGVuZEFjdGl2ZURPTU9iamVjdHMocUZyYW1lKTsKK30KKwordm9pZCBRV0VCS0lUX0VYUE9S VCBxdF9yZXN1bWVBY3RpdmVET01PYmplY3RzKFFXZWJGcmFtZSogcUZyYW1lKQoreworICAgIER1 bXBSZW5kZXJUcmVlU3VwcG9ydFF0OjpyZXN1bWVBY3RpdmVET01PYmplY3RzKHFGcmFtZSk7Cit9 CisKK1FTdHJpbmcgUVdFQktJVF9FWFBPUlQgcXRfd2VicGFnZV9ncm91cE5hbWUoUVdlYlBhZ2Uq IHBhZ2UpCit7CisgICAgcmV0dXJuIER1bXBSZW5kZXJUcmVlU3VwcG9ydFF0Ojp3ZWJQYWdlR3Jv dXBOYW1lKHBhZ2UpOworfSAgICAgICAgICAKKwordm9pZCBRV0VCS0lUX0VYUE9SVCBxdF93ZWJw YWdlX3NldEdyb3VwTmFtZShRV2ViUGFnZSogcGFnZSwgY29uc3QgUVN0cmluZyYgZ3JvdXBOYW1l KQoreworICAgIER1bXBSZW5kZXJUcmVlU3VwcG9ydFF0Ojp3ZWJQYWdlU2V0R3JvdXBOYW1lKHBh Z2UsIGdyb3VwTmFtZSk7Cit9ICAgICAgCisKK3ZvaWQgUVdFQktJVF9FWFBPUlQgcXRfZHJ0X3do aXRlTGlzdEFjY2Vzc0Zyb21PcmlnaW4oY29uc3QgUVN0cmluZyYgc291cmNlT3JpZ2luLCBjb25z dCBRU3RyaW5nJiBkZXN0aW5hdGlvblByb3RvY29sLCBjb25zdCBRU3RyaW5nJiBkZXN0aW5hdGlv bkhvc3QsIGJvb2wgYWxsb3dEZXN0aW5hdGlvblN1YmRvbWFpbnMpCit7CisgICAgRHVtcFJlbmRl clRyZWVTdXBwb3J0UXQ6OndoaXRlTGlzdEFjY2Vzc0Zyb21PcmlnaW4oc291cmNlT3JpZ2luLCBk ZXN0aW5hdGlvblByb3RvY29sLCBkZXN0aW5hdGlvbkhvc3QsIGFsbG93RGVzdGluYXRpb25TdWJk b21haW5zKTsKK30KKyAgICAKK3ZvaWQgUVdFQktJVF9FWFBPUlQgcXRfZHJ0X3Jlc2V0T3JpZ2lu QWNjZXNzV2hpdGVMaXN0cygpCit7CisgICAgIER1bXBSZW5kZXJUcmVlU3VwcG9ydFF0OjpyZXNl dE9yaWdpbkFjY2Vzc1doaXRlTGlzdHMoKTsKK30K