38301 2010-04-28 18:30:48 -0700 Change chromium WebViewClient::createView to include WindowFeatures 2010-05-02 00:23:31 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 38332 1 rafaelw webkit-unassigned commit-queue dglazkov fishd oldest_to_newest 218750 0 rafaelw 2010-04-28 18:30:48 -0700 This is a follow-up to https://bugs.webkit.org/show_bug.cgi?id=38013 which now additionally passes the WindowFeatures to the WebViewClient::createView method. 218757 1 54658 rafaelw 2010-04-28 18:45:33 -0700 Created attachment 54658 Patch 218939 2 54658 commit-queue 2010-04-29 03:55:30 -0700 Comment on attachment 54658 Patch Clearing flags on attachment: 54658 Committed r58498: <http://trac.webkit.org/changeset/58498> 218940 3 commit-queue 2010-04-29 03:55:37 -0700 All reviewed patches have been landed. Closing bug. 219062 4 dglazkov 2010-04-29 09:14:53 -0700 This broke about a bunch of tests on the canaries. Has the method been hooked up properly downstream? 219333 5 54773 rafaelw 2010-04-29 19:18:45 -0700 Created attachment 54773 Patch 219334 6 rafaelw 2010-04-29 19:21:17 -0700 The first attempt at landing this patch broke the chromium canary bot because I missed an implementor of WebClientView (TestWebClientDelegate in test_shell). This has been addressed in http://src.chromium.org/viewvc/chrome?view=rev&revision=46024. 219787 7 54773 commit-queue 2010-05-02 00:23:25 -0700 Comment on attachment 54773 Patch Clearing flags on attachment: 54773 Committed r58643: <http://trac.webkit.org/changeset/58643> 219788 8 commit-queue 2010-05-02 00:23:31 -0700 All reviewed patches have been landed. Closing bug. 54658 2010-04-28 18:45:33 -0700 2010-04-29 19:18:41 -0700 Patch bug-38301-20100428184532.patch text/plain 3189 rafaelw ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDFhNzNlYjUzNGI5OWY2ZTZkMjcxOTcyYjJkNjgwYjkwYjI2Y2VjYzIu LmE2Njk0MzczMTJiNzM3MzIyM2RmODA5Yzc1ZmRiMjBmOWQ5N2MzZmEgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE3IEBACisyMDEwLTA0LTI4ICBSYWZhZWwgV2VpbnN0ZWluICA8cmFmYWVsd0Bj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgSW5jbHVkZSBXaW5kb3dGZWF0dXJlcyBpbiBjYWxsIHRvIFdlYlZpZXdDbGllbnQ6OmNy ZWF0ZVZpZXcuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTM4MzAxCisKKyAgICAgICAgKiBwdWJsaWMvV2ViVmlld0NsaWVudC5oOgorICAgICAgICAo V2ViS2l0OjpXZWJWaWV3Q2xpZW50OjpjcmVhdGVWaWV3KToKKyAgICAgICAgKiBwdWJsaWMvV2Vi V2luZG93RmVhdHVyZXMuaDoKKyAgICAgICAgKiBzcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OkNocm9tZUNsaWVudEltcGw6OmNyZWF0ZVdpbmRvdyk6CisKIDIwMTAt MDQtMjggIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBEYXZpZCBMZXZpbi4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViVmlld0NsaWVudC5oIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3Q2xpZW50LmgK aW5kZXggYzJhOTZkYzBiMTY0YjkzODkzNTgzY2Q4MjY2OTZlZWI5N2NjZjc4ZC4uNmYwNTc0NzI2 NzRhMTU3MGY4NzliMjE0MTFmZDZkZjY0OWVlOGM5NCAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJWaWV3Q2xpZW50LmgKKysrIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJWaWV3Q2xpZW50LmgKQEAgLTYwLDYgKzYwLDcgQEAgc3RydWN0IFdlYkNvbnNvbGVNZXNzYWdl Owogc3RydWN0IFdlYkNvbnRleHRNZW51RGF0YTsKIHN0cnVjdCBXZWJQb2ludDsKIHN0cnVjdCBX ZWJQb3B1cE1lbnVJbmZvOworc3RydWN0IFdlYldpbmRvd0ZlYXR1cmVzOwogCiAvLyBTaW5jZSBh IFdlYlZpZXcgaXMgYSBXZWJXaWRnZXQsIGEgV2ViVmlld0NsaWVudCBpcyBhIFdlYldpZGdldENs aWVudC4KIC8vIFZpcnR1YWwgaW5oZXJpdGFuY2UgYWxsb3dzIGFuIGltcGxlbWVudGF0aW9uIG9m IFdlYldpZGdldENsaWVudCB0byBiZQpAQCAtNzEsNyArNzIsOCBAQCBwdWJsaWM6CiAgICAgLy8g Q3JlYXRlIGEgbmV3IHJlbGF0ZWQgV2ViVmlldy4gIFRoaXMgbWV0aG9kIG11c3QgY2xvbmUgaXRz IHNlc3Npb24gc3RvcmFnZQogICAgIC8vIHNvIGFueSBzdWJzZXF1ZW50IGNhbGxzIHRvIGNyZWF0 ZVNlc3Npb25TdG9yYWdlTmFtZXNwYWNlIGNvbmZvcm0gdG8gdGhlCiAgICAgLy8gV2ViU3RvcmFn ZSBzcGVjaWZpY2F0aW9uLgotICAgIHZpcnR1YWwgV2ViVmlldyogY3JlYXRlVmlldyhXZWJGcmFt ZSogY3JlYXRvcikgeyByZXR1cm4gMDsgfQorICAgIHZpcnR1YWwgV2ViVmlldyogY3JlYXRlVmll dyhXZWJGcmFtZSogY3JlYXRvciwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29u c3QgV2ViV2luZG93RmVhdHVyZXMmIGZlYXR1cmVzKSB7IHJldHVybiAwOyB9CiAKICAgICAvLyBD cmVhdGUgYSBuZXcgV2ViUG9wdXBNZW51LiAgSW4gdGhlIHNlY29uZCBmb3JtLCB0aGUgY2xpZW50 IGlzCiAgICAgLy8gcmVzcG9uc2libGUgZm9yIHJlbmRlcmluZyB0aGUgY29udGVudHMgb2YgdGhl IHBvcHVwIG1lbnUuCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYldpbmRv d0ZlYXR1cmVzLmggYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYldpbmRvd0ZlYXR1cmVzLmgK aW5kZXggYTI4NWE0OTdkMzhhYWRjMGVkOWEzOTM4MThjMDZmNzk5MjUxZTVlNC4uMmU3Mjc4YTBi Y2I0ZDNmNDllZGRjMzMwOTg4OTRiZDcwZmMwMjk0OCAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJXaW5kb3dGZWF0dXJlcy5oCisrKyBiL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViV2luZG93RmVhdHVyZXMuaApAQCAtMzIsNiArMzIsOCBAQAogI2RlZmluZSBXZWJXaW5k b3dGZWF0dXJlc19oCiAKICNpbmNsdWRlICJXZWJDb21tb24uaCIKKyNpbmNsdWRlICJXZWJTdHJp bmcuaCIKKyNpbmNsdWRlICJXZWJWZWN0b3IuaCIKIAogI2lmIFdFQktJVF9JTVBMRU1FTlRBVElP TgogI2luY2x1ZGUgIldpbmRvd0ZlYXR1cmVzLmgiCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21p dW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVD bGllbnRJbXBsLmNwcAppbmRleCA5NDhlNzc2ZTkyNWRkZmNmZWUxMzdmMDdlYWQ1OWRmMzAyZmIx NTNmLi4zZGE3ZWRhZmYyYTk1YzliMGI5MDA2MTNkMTNlMGVmYmIzYjAxN2Q5IDEwMDY0NAotLS0g YS9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwCisrKyBiL1dlYktpdC9j aHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAKQEAgLTc0LDYgKzc0LDcgQEAKICNpbmNs dWRlICJXZWJVUkxSZXF1ZXN0LmgiCiAjaW5jbHVkZSAiV2ViVmlld0NsaWVudC5oIgogI2luY2x1 ZGUgIldlYlZpZXdJbXBsLmgiCisjaW5jbHVkZSAiV2ViV2luZG93RmVhdHVyZXMuaCIKICNpbmNs dWRlICJXaW5kb3dGZWF0dXJlcy5oIgogI2luY2x1ZGUgIldyYXBwZWRSZXNvdXJjZVJlcXVlc3Qu aCIKIApAQCAtMjMzLDcgKzIzNCw3IEBAIFBhZ2UqIENocm9tZUNsaWVudEltcGw6OmNyZWF0ZVdp bmRvdygKICAgICAgICAgcmV0dXJuIDA7CiAKICAgICBXZWJWaWV3SW1wbCogbmV3VmlldyA9IHN0 YXRpY19jYXN0PFdlYlZpZXdJbXBsKj4oCi0gICAgICAgIG1fd2ViVmlldy0+Y2xpZW50KCktPmNy ZWF0ZVZpZXcoV2ViRnJhbWVJbXBsOjpmcm9tRnJhbWUoZnJhbWUpKSk7CisgICAgICAgIG1fd2Vi Vmlldy0+Y2xpZW50KCktPmNyZWF0ZVZpZXcoV2ViRnJhbWVJbXBsOjpmcm9tRnJhbWUoZnJhbWUp LCBmZWF0dXJlcykpOwogICAgIGlmICghbmV3VmlldykKICAgICAgICAgcmV0dXJuIDA7CiAK 54773 2010-04-29 19:18:45 -0700 2010-05-02 00:23:25 -0700 Patch bug-38301-20100429191844.patch text/plain 3191 rafaelw ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDQzOGNiNjAwMjE3NjY4MzU5MGU2MGY1NjZkNzdjZDRhYzNkNTc3ZjEu LmVlNjE2MjFmMjQxZGEwZjQwNTM5MGI3MjFkMjNmMTUzMjdmNWRkMzAgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE2IEBACisyMDEwLTA0LTI5ICBSYWZhZWwgV2VpbnN0ZWluICA8cmFmYWVsd0Bj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgSW5jbHVkZSBXZWJXaW5kb3dGZWF0dXJlcyBpbiBjYWxsIHRvIFdlYlZpZXdDbGllbnQ6 OmNyZWF0ZVZpZXcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zODMwMQorCisgICAgICAgICogcHVibGljL1dlYlZpZXdDbGllbnQuaDoKKyAgICAgICAg KFdlYktpdDo6V2ViVmlld0NsaWVudDo6Y3JlYXRlVmlldyk6CisgICAgICAgICogcHVibGljL1dl YldpbmRvd0ZlYXR1cmVzLmg6CisgICAgICAgICogc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwOgor ICAgICAgICAoV2ViS2l0OjpDaHJvbWVDbGllbnRJbXBsOjpjcmVhdGVXaW5kb3cpOgorCiAyMDEw LTA0LTI5ICBBbnRvbiBNdWhpbiAgPGFudG9ubUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9XZWJWaWV3Q2xpZW50LmggYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXdDbGllbnQu aAppbmRleCBjMmE5NmRjMGIxNjRiOTM4OTM1ODNjZDgyNjY5NmVlYjk3Y2NmNzhkLi42ZjA1NzQ3 MjY3NGExNTcwZjg3OWIyMTQxMWZkNmRmNjQ5ZWU4Yzk0IDEwMDY0NAotLS0gYS9XZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYlZpZXdDbGllbnQuaAorKysgYi9XZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYlZpZXdDbGllbnQuaApAQCAtNjAsNiArNjAsNyBAQCBzdHJ1Y3QgV2ViQ29uc29sZU1lc3Nh Z2U7CiBzdHJ1Y3QgV2ViQ29udGV4dE1lbnVEYXRhOwogc3RydWN0IFdlYlBvaW50Owogc3RydWN0 IFdlYlBvcHVwTWVudUluZm87CitzdHJ1Y3QgV2ViV2luZG93RmVhdHVyZXM7CiAKIC8vIFNpbmNl IGEgV2ViVmlldyBpcyBhIFdlYldpZGdldCwgYSBXZWJWaWV3Q2xpZW50IGlzIGEgV2ViV2lkZ2V0 Q2xpZW50LgogLy8gVmlydHVhbCBpbmhlcml0YW5jZSBhbGxvd3MgYW4gaW1wbGVtZW50YXRpb24g b2YgV2ViV2lkZ2V0Q2xpZW50IHRvIGJlCkBAIC03MSw3ICs3Miw4IEBAIHB1YmxpYzoKICAgICAv LyBDcmVhdGUgYSBuZXcgcmVsYXRlZCBXZWJWaWV3LiAgVGhpcyBtZXRob2QgbXVzdCBjbG9uZSBp dHMgc2Vzc2lvbiBzdG9yYWdlCiAgICAgLy8gc28gYW55IHN1YnNlcXVlbnQgY2FsbHMgdG8gY3Jl YXRlU2Vzc2lvblN0b3JhZ2VOYW1lc3BhY2UgY29uZm9ybSB0byB0aGUKICAgICAvLyBXZWJTdG9y YWdlIHNwZWNpZmljYXRpb24uCi0gICAgdmlydHVhbCBXZWJWaWV3KiBjcmVhdGVWaWV3KFdlYkZy YW1lKiBjcmVhdG9yKSB7IHJldHVybiAwOyB9CisgICAgdmlydHVhbCBXZWJWaWV3KiBjcmVhdGVW aWV3KFdlYkZyYW1lKiBjcmVhdG9yLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBj b25zdCBXZWJXaW5kb3dGZWF0dXJlcyYgZmVhdHVyZXMpIHsgcmV0dXJuIDA7IH0KIAogICAgIC8v IENyZWF0ZSBhIG5ldyBXZWJQb3B1cE1lbnUuICBJbiB0aGUgc2Vjb25kIGZvcm0sIHRoZSBjbGll bnQgaXMKICAgICAvLyByZXNwb25zaWJsZSBmb3IgcmVuZGVyaW5nIHRoZSBjb250ZW50cyBvZiB0 aGUgcG9wdXAgbWVudS4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViV2lu ZG93RmVhdHVyZXMuaCBiL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViV2luZG93RmVhdHVyZXMu aAppbmRleCBhMjg1YTQ5N2QzOGFhZGMwZWQ5YTM5MzgxOGMwNmY3OTkyNTFlNWU0Li4yZTcyNzhh MGJjYjRkM2Y0OWVkZGMzMzA5ODg5NGJkNzBmYzAyOTQ4IDEwMDY0NAotLS0gYS9XZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYldpbmRvd0ZlYXR1cmVzLmgKKysrIGIvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJXaW5kb3dGZWF0dXJlcy5oCkBAIC0zMiw2ICszMiw4IEBACiAjZGVmaW5lIFdlYldp bmRvd0ZlYXR1cmVzX2gKIAogI2luY2x1ZGUgIldlYkNvbW1vbi5oIgorI2luY2x1ZGUgIldlYlN0 cmluZy5oIgorI2luY2x1ZGUgIldlYlZlY3Rvci5oIgogCiAjaWYgV0VCS0lUX0lNUExFTUVOVEFU SU9OCiAjaW5jbHVkZSAiV2luZG93RmVhdHVyZXMuaCIKZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJv bWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAgYi9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9t ZUNsaWVudEltcGwuY3BwCmluZGV4IDk0OGU3NzZlOTI1ZGRmY2ZlZTEzN2YwN2VhZDU5ZGYzMDJm YjE1M2YuLjNkYTdlZGFmZjJhOTVjOWIwYjkwMDYxM2QxM2UwZWZiYjNiMDE3ZDkgMTAwNjQ0Ci0t LSBhL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAKKysrIGIvV2ViS2l0 L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcApAQCAtNzQsNiArNzQsNyBAQAogI2lu Y2x1ZGUgIldlYlVSTFJlcXVlc3QuaCIKICNpbmNsdWRlICJXZWJWaWV3Q2xpZW50LmgiCiAjaW5j bHVkZSAiV2ViVmlld0ltcGwuaCIKKyNpbmNsdWRlICJXZWJXaW5kb3dGZWF0dXJlcy5oIgogI2lu Y2x1ZGUgIldpbmRvd0ZlYXR1cmVzLmgiCiAjaW5jbHVkZSAiV3JhcHBlZFJlc291cmNlUmVxdWVz dC5oIgogCkBAIC0yMzMsNyArMjM0LDcgQEAgUGFnZSogQ2hyb21lQ2xpZW50SW1wbDo6Y3JlYXRl V2luZG93KAogICAgICAgICByZXR1cm4gMDsKIAogICAgIFdlYlZpZXdJbXBsKiBuZXdWaWV3ID0g c3RhdGljX2Nhc3Q8V2ViVmlld0ltcGwqPigKLSAgICAgICAgbV93ZWJWaWV3LT5jbGllbnQoKS0+ Y3JlYXRlVmlldyhXZWJGcmFtZUltcGw6OmZyb21GcmFtZShmcmFtZSkpKTsKKyAgICAgICAgbV93 ZWJWaWV3LT5jbGllbnQoKS0+Y3JlYXRlVmlldyhXZWJGcmFtZUltcGw6OmZyb21GcmFtZShmcmFt ZSksIGZlYXR1cmVzKSk7CiAgICAgaWYgKCFuZXdWaWV3KQogICAgICAgICByZXR1cm4gMDsKIAo=