38291 2010-04-28 16:01:36 -0700 CSS counters in :before pseudo-elements do not always update 2011-04-28 19:24:38 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED HasReduction P2 Normal --- 1 nathan.whetsell jchaffraix commit-queue jchaffraix oldest_to_newest 218683 0 54634 nathan.whetsell 2010-04-28 16:01:36 -0700 Created attachment 54634 Test HTML document When using more than one CSS counter and generating counted elements using JavaScript, counters placed in the content of a :before pseudo-element do not update themselves, but counters placed in the content of an :after pseudo-element do. I will attach a test HTML document illustrating the problem. In this test document, the number of red "xxx" strings should be counted; there are counters placed before and after the x's. The counters placed after the x's update appropriately as elements are added. The counters placed before the x's do not update as expected. In Firefox, both counters show the same number as elements are added. 218688 1 nathan.whetsell 2010-04-28 16:11:19 -0700 This issue may be related to bug #11033. 278596 2 jchaffraix 2010-09-13 17:38:34 -0700 Confirmed on nightly build (Chromium Windows). 393947 3 jchaffraix 2011-04-27 16:25:21 -0700 Some refactoring went into the CSS counter code and this bug got solved (tested on Qt/Linux ToT and Chromium Canary build). It is still reproducible in Chromium stable. I will turn the test case into an regression test and have it landed. 394081 4 nathan.whetsell 2011-04-27 18:41:38 -0700 For posterity's sake, the last Mac OS X nightly build where I can reproduce the bug is r81689. The bug is fixed in r81756. 394702 5 91544 jchaffraix 2011-04-28 13:29:59 -0700 Created attachment 91544 Patch 394796 6 91544 jchaffraix 2011-04-28 15:11:06 -0700 Comment on attachment 91544 Patch Thanks for confirming Nate! 395035 7 91544 commit-queue 2011-04-28 19:24:33 -0700 Comment on attachment 91544 Patch Clearing flags on attachment: 91544 Committed r85288: <http://trac.webkit.org/changeset/85288> 395036 8 commit-queue 2011-04-28 19:24:38 -0700 All reviewed patches have been landed. Closing bug. 54634 2010-04-28 16:01:36 -0700 2010-04-28 16:01:36 -0700 Test HTML document test.html text/html 1044 nathan.whetsell PCFET0NUWVBFIGh0bWw+CjxodG1sIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hodG1s IiB4bWw6bGFuZz0iZW4tVVMiIGxhbmc9ImVuLVVTIj4KPGhlYWQ+CiAgPHRpdGxlPlRlc3Q8L3Rp dGxlPgogIDxtZXRhIGh0dHAtZXF1aXY9ImNvbnRlbnQtdHlwZSIgY29udGVudD0idGV4dC9odG1s OyBjaGFyc2V0PXV0Zi04IiAvPgogIDxzdHlsZT4KICAgIGJvZHkge2NvdW50ZXItcmVzZXQ6aSAw IGogMDt9CiAgICBkaXY6YmVmb3JlIHsKICAgICAgY29udGVudDogImk6IiBjb3VudGVyKGkpOwog ICAgICBjb3VudGVyLWluY3JlbWVudDogaTsKICAgIH0KICAgIGRpdjphZnRlciB7CiAgICAgIGNv bnRlbnQ6ICJqOiIgY291bnRlcihqKTsKICAgICAgY291bnRlci1pbmNyZW1lbnQ6IGo7CiAgICB9 CiAgPC9zdHlsZT4KICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+CiAgICBmdW5jdGlv biBpbnNlcnQoKSB7CiAgICAgIHZhciBzZWxlY3Rpb24gPSB3aW5kb3cuZ2V0U2VsZWN0aW9uKCk7 CiAgICAgIGlmIChzZWxlY3Rpb24ucmFuZ2VDb3VudCA+IDApIHsKICAgICAgICB2YXIgbmV3RWxl bWVudCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2RpdicpOwogICAgICAgIG5ld0VsZW1lbnQu aW5uZXJIVE1MID0gJzxzcGFuIHN0eWxlPSJjb2xvcjojRkYwMDAwOyI+eHh4PC9zcGFuPic7CiAg ICAgICAgdmFyIG5vZGUgPSBzZWxlY3Rpb24uZ2V0UmFuZ2VBdCgwKS5zdGFydENvbnRhaW5lci5w YXJlbnROb2RlLnBhcmVudE5vZGU7CiAgICAgICAgbm9kZS5wYXJlbnROb2RlLmluc2VydEJlZm9y ZShuZXdFbGVtZW50LCBub2RlLm5leHRTaWJsaW5nKTsKICAgICAgfQogICAgfQogIDwvc2NyaXB0 Pgo8L2hlYWQ+Cjxib2R5PgogIDxpbnB1dCB0eXBlPSJidXR0b24iIHZhbHVlPSJTZWxlY3QgeHh4 LCB0aGVuIGNsaWNrIGF0IGxlYXN0IHR3aWNlIiBuYW1lPSJidXR0b24iIG9uQ2xpY2s9Imluc2Vy dCgpIj4KICA8ZGl2PjxzcGFuIHN0eWxlPSJjb2xvcjojRkYwMDAwOyI+eHh4PC9zcGFuPjwvZGl2 Pgo8L2JvZHk+CjwvaHRtbD4K 91544 2011-04-28 13:29:59 -0700 2011-04-28 19:24:33 -0700 Patch bug-38291-20110428132958.patch text/plain 4212 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogODUyMzEKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBiZWVkODA3MWU0NTE3YWY4Y2EyYzc4 ZTQ5ODYyNGVmZGFjNGY4MTExLi5mYWZlNDAwY2ZhM2MxNGViZGI5ZmQ4OWE4ODI4NDllZTRkZGI2 OTE5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDQtMjggIEp1bGllbiBDaGFmZnJhaXgg IDxqY2hhZmZyYWl4QGNvZGVhdXJvcmEub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIENTUyBjb3VudGVycyBpbiA6YmVmb3JlIHBzZXVkby1lbGVt ZW50cyBkbyBub3QgYWx3YXlzIHVwZGF0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzgyOTEKKworICAgICAgICBUaGUgcHJldmlvdXMgYnVnIHdhcyBz b2x2ZWQgc28ganVzdCBsYW5kaW5nIHRoZSB0ZXN0IGNhc2UgdG8gZW5zdXJlIHRoYXQKKyAgICAg ICAgd2UgZG9uJ3QgcmVncmVzcyBpdC4KKworICAgICAgICAqIGZhc3QvY3NzL2NvdW50ZXJzL2Nv dW50ZXItYmVmb3JlLWNvbnRlbnQtbm90LWluY3JlbWVudGVkLWV4cGVjdGVkLnR4dDogQWRkZWQu CisgICAgICAgICogZmFzdC9jc3MvY291bnRlcnMvY291bnRlci1iZWZvcmUtY29udGVudC1ub3Qt aW5jcmVtZW50ZWQuaHRtbDogQWRkZWQuCisKIDIwMTEtMDQtMjggIEtlbm5ldGggUnVzc2VsbCAg PGtickBnb29nbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgdGVzdCBleHBlY3RhdGlvbnMg dXBkYXRlLiBNYXJrZWQgZmxha3kgYW5kIGNyYXNoaW5nIHRlc3RzLgpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvZmFzdC9jc3MvY291bnRlcnMvY291bnRlci1iZWZvcmUtY29udGVudC1ub3QtaW5j cmVtZW50ZWQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvY291bnRlcnMvY291 bnRlci1iZWZvcmUtY29udGVudC1ub3QtaW5jcmVtZW50ZWQtZXhwZWN0ZWQudHh0Cm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAuLmRhYmNlMDY0NTMxMWQ0OTU3ZDE3MmQ2NmI5NGM5ZGE4ZjI1ZGZlZjAKLS0tIC9kZXYvbnVs bAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9jb3VudGVycy9jb3VudGVyLWJlZm9yZS1jb250 ZW50LW5vdC1pbmNyZW1lbnRlZC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw3IEBACitCdWcgMzgy OTEgLSBDU1MgY291bnRlcnMgaW4gOmJlZm9yZSBwc2V1ZG8tZWxlbWVudHMgZG8gbm90IGFsd2F5 cyB1cGRhdGUKKworVGhlIGZvbGxvd2luZyB0d28gbGluZXMgc2hvdWxkIGJlIHRoZSBzYW1lOgor CistMS0tMi0zLTQtNS02CisKKy0xLS0yLTMtNC01LTYKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2Zhc3QvY3NzL2NvdW50ZXJzL2NvdW50ZXItYmVmb3JlLWNvbnRlbnQtbm90LWluY3JlbWVudGVk Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9jb3VudGVycy9jb3VudGVyLWJlZm9yZS1jb250 ZW50LW5vdC1pbmNyZW1lbnRlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjBmNGExMGI4ZjFlMjQ1YzViNTc3 NDA3MTg5MjM0ZGI2MmI3MGY5NWQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0 L2Nzcy9jb3VudGVycy9jb3VudGVyLWJlZm9yZS1jb250ZW50LW5vdC1pbmNyZW1lbnRlZC5odG1s CkBAIC0wLDAgKzEsNzAgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKyAgICA8 c3R5bGU+CisgICAgICAgIGJvZHkKKyAgICAgICAgeworICAgICAgICAgICAgY291bnRlci1yZXNl dDogaSAwOworICAgICAgICB9CisKKyAgICAgICAgZGl2OmJlZm9yZQorICAgICAgICB7CisgICAg ICAgICAgICBjb250ZW50OiAiLSIgY291bnRlcihpKTsKKyAgICAgICAgICAgIGNvdW50ZXItaW5j cmVtZW50OiBpOworICAgICAgICB9CisgICAgICAgIGRpdiB7CisgICAgICAgICAgICBkaXNwbGF5 OmlubGluZTsKKyAgICAgICAgfQorICAgIDwvc3R5bGU+CisgICAgPHNjcmlwdD4KKyAgICAgICAg aWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgICAgICAgICAgbGF5b3V0VGVz dENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xs ZXIud2FpdFVudGlsRG9uZSgpOworICAgICAgICB9CisKKyAgICAgICAgZnVuY3Rpb24gaW5zZXJ0 QXV0byhpKSB7CisgICAgICAgICAgICAvLyBXZSBuZWVkIHRvIHVzZSB0aGUgc2VsZWN0aW9uIG9y IHdlIGNhbm5vdCByZXByb2R1Y2UgdGhpcyBidWchCisgICAgICAgICAgICB2YXIgc2VsZWN0aW9u ID0gd2luZG93LmdldFNlbGVjdGlvbigpOworICAgICAgICAgICAgdmFyIGNvbnRhaW5lciA9IGRv Y3VtZW50LmdldEVsZW1lbnRCeUlkKCJjb250YWluZXIiKTsKKyAgICAgICAgICAgIHNlbGVjdGlv bi5zZXRQb3NpdGlvbihjb250YWluZXIsIDApOworICAgICAgICAgICAgaWYgKHNlbGVjdGlvbi5y YW5nZUNvdW50ID4gMCkgeworICAgICAgICAgICAgICAgIHZhciBuZXdFbGVtZW50ID0gZG9jdW1l bnQuY3JlYXRlRWxlbWVudCgnZGl2Jyk7CisgICAgICAgICAgICAgICAgbmV3RWxlbWVudC5pZCA9 ICdkaXYnICsgaTsKKyAgICAgICAgICAgICAgICAvL25ld0VsZW1lbnQuaW5uZXJIVE1MID0gJzxz cGFuIj4gLSBpOicgKyAoNiAtIGkpICsgJzwvc3Bhbj4nOworICAgICAgICAgICAgICAgIHZhciBu b2RlID0gc2VsZWN0aW9uLmdldFJhbmdlQXQoMCkuc3RhcnRDb250YWluZXIucGFyZW50Tm9kZS5w YXJlbnROb2RlOworICAgICAgICAgICAgICAgIG5vZGUucGFyZW50Tm9kZS5pbnNlcnRCZWZvcmUo bmV3RWxlbWVudCwgbm9kZS5uZXh0U2libGluZyk7CisgICAgICAgICAgICB9CisgICAgICAgIH0K KworICAgICAgICBmdW5jdGlvbiBkdW1wQ291bnRlcnMoKQorICAgICAgICB7CisgICAgICAgICAg ICB2YXIgc3Bhbkxpc3QgPSBkb2N1bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgiZGl2Iik7Cisg ICAgICAgICAgICB2YXIgY291bnRlcnMgPSAnJzsKKyAgICAgICAgICAgIGZvciAodmFyIGkgPSAw OyBpIDwgc3Bhbkxpc3QubGVuZ3RoOyArK2kgKSB7CisgICAgICAgICAgICAgICAgdmFyIGRpdkl0 ZW0gPSBzcGFuTGlzdC5pdGVtKGkpOworICAgICAgICAgICAgICAgIGNvdW50ZXJzICs9ICctJzsK KyAgICAgICAgICAgICAgICBjb3VudGVycyArPSBsYXlvdXRUZXN0Q29udHJvbGxlci5jb3VudGVy VmFsdWVGb3JFbGVtZW50QnlJZChkaXZJdGVtLmdldEF0dHJpYnV0ZSgiaWQiKSk7CisgICAgICAg ICAgICAgICAgY291bnRlcnMgKz0gZGl2SXRlbS50ZXh0Q29udGVudDsKKyAgICAgICAgICAgIH0K KyAgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJjb250YWluZXIiKS5pbm5lckhU TUwgPSBjb3VudGVyczsKKyAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURv bmUoKTsKKyAgICAgICAgfQorCisgICAgICAgIGZ1bmN0aW9uIHRlc3QoKQorICAgICAgICB7Cisg ICAgICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IDU7ICsraSkKKyAgICAgICAgICAgICAgICBp bnNlcnRBdXRvKGkpOworICAgICAgICAgICAgaWYgKGxheW91dFRlc3RDb250cm9sbGVyKSB7Cisg ICAgICAgICAgICAgICAgc2V0VGltZW91dCgiZHVtcENvdW50ZXJzKCkiLCAwKTsKKyAgICAgICAg ICAgIH0KKyAgICAgICAgfQorICAgICAgICB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcigibG9hZCIs IHRlc3QsIGZhbHNlKTsKKyAgPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKyAgICA8cD5CdWcg PGEgaHJlZj0iaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4MjkxIj4z ODI5MTwvYT4gLSBDU1MgY291bnRlcnMgaW4gOmJlZm9yZSBwc2V1ZG8tZWxlbWVudHMgZG8gbm90 IGFsd2F5cyB1cGRhdGU8L3A+CisgICAgPHA+VGhlIGZvbGxvd2luZyB0d28gbGluZXMgc2hvdWxk IGJlIHRoZSBzYW1lOjwvcD4KKyAgICA8cD4tMS0tMi0zLTQtNS02PC9wPgorICAgIDxkaXYgaWQ9 ImNvbnRhaW5lciI+PHNwYW4+LTwvc3Bhbj48L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4K