38288 2010-04-28 15:24:42 -0700 [chromium] revert getFontDataForCharacters change in r58341 2010-04-28 17:38:47 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 evan webkit-unassigned agl oldest_to_newest 218665 0 evan 2010-04-28 15:24:42 -0700 [chromium] revert getFontDataForCharacters change 218668 1 54629 evan 2010-04-28 15:26:32 -0700 Created attachment 54629 Patch 218670 2 evan 2010-04-28 15:28:25 -0700 We hit this code path repeatedly while rendering. It wasn't so bad before (since it was just computing a font name) but it is very bad now (since we're loading a font). 218672 3 agl 2010-04-28 15:32:36 -0700 LGTM. (I think a rollout is permitted without a real WebKit review so you could just land this now.) 218713 4 evan 2010-04-28 17:38:47 -0700 Committed r58447: <http://trac.webkit.org/changeset/58447> 54629 2010-04-28 15:26:32 -0700 2010-04-28 15:57:19 -0700 Patch bug-38288-20100428152620.patch text/plain 4736 evan ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjNGI2ZmQ4YWM1M2UzMDM3ZDJmNzk5ODc1ZjcyY2RkNTg4ZjA5OTA3Li42NmQ5ZTcz MjMyMjRmNWQzNzk0ZGJlM2YxYzI1MTZhMjlmNjkwOGQxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAK IDIwMTAtMDQtMjggIEV2YW4gTWFydGluICA8ZXZhbkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSByZXZlcnQg Z2V0Rm9udERhdGFGb3JDaGFyYWN0ZXJzIGNoYW5nZSBpbiByNTgzNDEKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4Mjg4CisKKyAgICAgICAgKiBwbGF0 Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6IGFkZCB0aGUgdGVzdCB0byB0aGUg bm93LWZhaWxpbmcgbGlzdC4KKworMjAxMC0wNC0yOCAgRXZhbiBNYXJ0aW4gIDxldmFuQGNocm9t aXVtLm9yZz4KKwogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KIAogICAgICAgICBm YXN0L3RleHQvaW50ZXJuYXRpb25hbC9ib2xkLWJlbmdhbGkgbmVlZHMgYmFzZWxpbmVzCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50 eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQK aW5kZXggZjFmNTJlNDA1MGFhNzkyYzFiOTAwOGNjMmZjYzdkZWE2ZGYyZTRjZi4uYjhkOGI4MWQ4 Y2Y4ZTU0Yzk3ODRlZmY5MTg2ZmYyNzU5YWQ1ZGI0MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv cGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CisrKyBiL0xheW91dFRlc3Rz L3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dApAQCAtMjg2OCwzICsyODY4 LDcgQEAgQlVHV0szODEwOCBNQUMgOiBmYXN0L2JhY2tncm91bmRzL3NpemUvY29udGFpbi1hbmQt Y292ZXIuaHRtbCA9IElNQUdFCiAKIC8vIFdlYktpdCByb2xsIDU4MzA0OjU4NDAwCiBCVUdVS0FJ IFdJTiBNQUMgOiBmYXN0L3RleHQvaW50ZXJuYXRpb25hbC9ib2xkLWJlbmdhbGkuaHRtbCA9IE1J U1NJTkcKKworLy8gV2UncmUgcmV2ZXJ0aW5nIHRoZSBwYXRjaCB0aGF0IGZpeGVkIHRoaXMgdGVz dCBvbiBMaW51eCBkdWUgdG8KKy8vIHRoZSBwZXJmIHJlZ3Jlc3Npb24gZGVzY3JpYmVkIGluIHRo ZSBidWcuCitCVUc0Mjc2MCBMSU5VWCA6IGZhc3QvdGV4dC9pbnRlcm5hdGlvbmFsL2JvbGQtYmVu Z2FsaS5odG1sID0gRkFJTApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3Jl L0NoYW5nZUxvZwppbmRleCA5ZjM4MTQwNzVmMWUzZTIyZDY1ZWU4ZjUzMTE1ZDMwZjczZTdmMTA2 Li4wNDkyMTQzZGM2Y2MwZGM4NDYwMjgwZTI4ZWUzY2MxOWEyMjU0NDY4IDEwMDY0NAotLS0gYS9X ZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBA CisyMDEwLTA0LTI4ICBFdmFuIE1hcnRpbiAgPGV2YW5AY2hyb21pdW0ub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gcmV2ZXJ0 IGdldEZvbnREYXRhRm9yQ2hhcmFjdGVycyBjaGFuZ2UgaW4gcjU4MzQxCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODI4OAorCisgICAgICAgIEl0IGNh dXNlZCBhIHBlcmZvcm1hbmNlIHJlZ3Jlc3Npb24uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJv bWl1bS9DaHJvbWl1bUJyaWRnZS5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL0ZvbnRDYWNoZUxpbnV4LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZvbnRDYWNoZTo6Z2V0 Rm9udERhdGFGb3JDaGFyYWN0ZXJzKToKKwogMjAxMC0wNC0yOCAgUGF2ZWwgRmVsZG1hbiAgPHBm ZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNo ZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0Nocm9taXVtQnJpZGdl LmggYi9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0Nocm9taXVtQnJpZGdlLmgKaW5kZXggMWYw MDQwZGExYzYwNDAxZTFjOGM4OTU5NTRiZTVmOGY4ODY5YjBkNi4uZTU4MjI0MTdhOTBhMzExNThi NDQ1OTMzYTM0ZGZhNjc2ODgzMjk3ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9jaHJv bWl1bS9DaHJvbWl1bUJyaWRnZS5oCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vQ2hy b21pdW1CcmlkZ2UuaApAQCAtMTE2LDggKzExNiw2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICNl bmRpZgogI2lmIE9TKExJTlVYKQogICAgICAgICBzdGF0aWMgdm9pZCBnZXRSZW5kZXJTdHlsZUZv clN0cmlrZShjb25zdCBjaGFyKiBmYW1pbHksIGludCBzaXplQW5kU3R5bGUsIEZvbnRSZW5kZXJT dHlsZSogcmVzdWx0KTsKLSAgICAgICAgLy8gVGhpcyBjb2RlIGlzIGN1cnJlbnRseSBpbiB0aGUg cHJvY2VzcyBvZiBnZXR0aW5nIHJlamlnZ2VyZWQsIGFuZCB0aG91Z2gKLSAgICAgICAgLy8gaXQg aXMgbm90IGN1cnJlbnRseSB1c2VkLCBpdCB3aWxsIGhvcGVmdWxseSBiZSB1c2VkIGFnYWluIHNv b24uCiAgICAgICAgIHN0YXRpYyBTdHJpbmcgZ2V0Rm9udEZhbWlseUZvckNoYXJhY3RlcnMoY29u c3QgVUNoYXIqLCBzaXplX3QgbnVtQ2hhcmFjdGVycyk7CiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Gb250Q2FjaGVMaW51eC5jcHAgYi9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRDYWNoZUxpbnV4LmNwcAppbmRl eCBiMzdlMWM3MTA1NzNhMTUxMThjNTk3ZGNkNzUyMGQ3MWRkMjQxYjZhLi5lY2VjZDEzMzRjOTFm YjY3ODJjMTg1Y2IzOGM2NjljY2E5NTE3ZWVjIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRDYWNoZUxpbnV4LmNwcAorKysgYi9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRDYWNoZUxpbnV4LmNwcApAQCAtNTgsMjcgKzU4LDEy IEBAIGNvbnN0IFNpbXBsZUZvbnREYXRhKiBGb250Q2FjaGU6OmdldEZvbnREYXRhRm9yQ2hhcmFj dGVycyhjb25zdCBGb250JiBmb250LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IFVDaGFyKiBjaGFyYWN0ZXJzLAogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludCBs ZW5ndGgpCiB7Ci0gICAgaW50IHN0eWxlID0gU2tUeXBlZmFjZTo6a05vcm1hbDsKLSAgICBpZiAo Zm9udC5mb250RGVzY3JpcHRpb24oKS53ZWlnaHQoKSA+PSBGb250V2VpZ2h0Qm9sZCkKLSAgICAg ICAgc3R5bGUgfD0gU2tUeXBlZmFjZTo6a0JvbGQ7Ci0gICAgaWYgKGZvbnQuZm9udERlc2NyaXB0 aW9uKCkuaXRhbGljKCkpCi0gICAgICAgIHN0eWxlIHw9IFNrVHlwZWZhY2U6OmtJdGFsaWM7Ci0K LSAgICBTa1R5cGVmYWNlKiB0ZiA9IFNrVHlwZWZhY2U6OkNyZWF0ZUZvckNoYXJzKGNoYXJhY3Rl cnMsIGxlbmd0aCAqIDIsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBzdGF0aWNfY2FzdDxTa1R5cGVmYWNlOjpTdHlsZT4oc3R5bGUpKTsKLSAgICBpZiAo IXRmKQorICAgIFN0cmluZyBmYW1pbHkgPSBDaHJvbWl1bUJyaWRnZTo6Z2V0Rm9udEZhbWlseUZv ckNoYXJhY3RlcnMoY2hhcmFjdGVycywgbGVuZ3RoKTsKKyAgICBpZiAoZmFtaWx5LmlzRW1wdHko KSkKICAgICAgICAgcmV0dXJuIDA7CiAKLSAgICAvLyBGSVhNRTogd2UgZG9uJ3QgaGF2ZSBhIGZh bWlseSBuYW1lIGZvciB0aGlzIGZvbnQuCi0gICAgLy8gSG93ZXZlciwgdGhlIGZhbWlseSBuYW1l IHdpdGhpbiBGb250UGxhdGZvcm1EYXRhIGlzIG9ubHkgdXNlZCB3aGVuIHBpY2tpbmcKLSAgICAv LyBhIHJlbmRlciBzdHlsZSBmb3IgdGhlIGZvbnQsIHNvIGl0J3Mgbm90IHRvbyBncmVhdCBvZiBh IGxvc3MuCi0gICAgRm9udFBsYXRmb3JtRGF0YSByZXN1bHQodGYsCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgIiIsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgZm9udC5mb250RGVz Y3JpcHRpb24oKS5jb21wdXRlZFNpemUoKSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAo c3R5bGUgJiBTa1R5cGVmYWNlOjprQm9sZCkgJiYgIXRmLT5pc0JvbGQoKSwKLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAoc3R5bGUgJiBTa1R5cGVmYWNlOjprSXRhbGljKSAmJiAhdGYtPmlz SXRhbGljKCkpOwotICAgIHRmLT51bnJlZigpOwotICAgIHJldHVybiBnZXRDYWNoZWRGb250RGF0 YSgmcmVzdWx0KTsKKyAgICBBdG9taWNTdHJpbmcgYXRvbWljRmFtaWx5KGZhbWlseSk7CisgICAg cmV0dXJuIGdldENhY2hlZEZvbnREYXRhKGdldENhY2hlZEZvbnRQbGF0Zm9ybURhdGEoZm9udC5m b250RGVzY3JpcHRpb24oKSwgYXRvbWljRmFtaWx5LCBmYWxzZSkpOwogfQogCiBTaW1wbGVGb250 RGF0YSogRm9udENhY2hlOjpnZXRTaW1pbGFyRm9udFBsYXRmb3JtRGF0YShjb25zdCBGb250JiBm b250KQo=