38272 2010-04-28 10:52:24 -0700 SHOULD NEVER BE REACHED assertion loading forbes.com 2010-05-05 18:23:32 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED http://www.forbes.com InRadar P1 Major --- 1 simon.fraser webkit-unassigned darin hamaji yuzo oldest_to_newest 218474 0 simon.fraser 2010-04-28 10:52:24 -0700 I hit the SHOULD NEVER BE REACHED assertion here: (WebCore/css/CSSStyleSelector.cpp:2562 bool WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector(WebCore::CSSSelector*, WebCore::Element*, WTF::HashSet<WebCore::AtomicStringImpl*, WTF::PtrHash<WebCore::AtomicStringImpl*>, WTF::HashTraits<WebCore::AtomicStringImpl*> >*, WebCore::PseudoId&, bool, WebCore::RenderStyle*, WebCore::RenderStyle*) const) loading forbes.com 218489 1 54587 simon.fraser 2010-04-28 11:00:13 -0700 Created attachment 54587 Testcase 218490 2 simon.fraser 2010-04-28 11:01:27 -0700 Why are we picking up :first outside of @page? 218500 3 simon.fraser 2010-04-28 11:10:53 -0700 Regression from bug 35329, http://trac.webkit.org/changeset/58374 219219 4 simon.fraser 2010-04-29 15:41:15 -0700 Ping? I keep hitting this. 219234 5 darin 2010-04-29 16:02:47 -0700 If we don’t get this resolved soon, I suggest we roll out r58374 and add a test for this to the layout tests. 219235 6 darin 2010-04-29 16:03:09 -0700 <rdar://problem/7925163> 219391 7 54787 hamaji 2010-04-30 00:35:23 -0700 Created attachment 54787 Patch v1 219392 8 hamaji 2010-04-30 00:43:56 -0700 (In reply to comment #7) > Created an attachment (id=54787) [details] > Patch v1 Hi, sorry for the latency. Yuzo is taking his vacation so I'll take care this bug. I guess rolling out r58374 can be difficult as we've already landed other patches which depend on r58374. Instead of reverting the change, I'd like to just ignore paged media related pseudo classes for now. 219497 9 hamaji 2010-04-30 08:46:18 -0700 Committed r58578: <http://trac.webkit.org/changeset/58578> 221419 10 yuzo 2010-05-05 18:23:32 -0700 Sorry for the regression and thank you for the fix. Yuzo 54587 2010-04-28 11:00:13 -0700 2010-04-28 11:00:13 -0700 Testcase pseudo-first.html text/html 214 simon.fraser PCFET0NUWVBFIGh0bWw+Cgo8aHRtbD4KPGhlYWQ+CiAgPHN0eWxlIHR5cGU9InRleHQvY3NzIiBt ZWRpYT0ic2NyZWVuIj4KICAgIGRpdjpmaXJzdCB7CiAgICAgIGNvbG9yOiByZWQ7CiAgICB9CiAg PC9zdHlsZT4KPC9oZWFkPgo8Ym9keT4KICA8ZGl2IGNsYXNzPSJ0ZXN0Ij4KICAgIDxwPm9uZTwv cD4KICAgIDxwPnR3bzwvcD4KICA8L2Rpdj4KPC9ib2R5Pgo8L2h0bWw+Cg== 54787 2010-04-30 00:35:23 -0700 2010-04-30 08:32:23 -0700 Patch v1 bug-38272-20100430003521.patch text/plain 4411 hamaji ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjZjNlZGYyZGEyZWNkN2FjNTVlMjU3NTFkYTMxZjFkYjlhNTMzOTAxLi4zYzFiZTRi ZGJiYjc2MzczNmNhZmEwNmNkZmRiZTMwYjYwNjg2MTExIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMDQtMzAgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTSE9VTEQgTkVW RVIgQkUgUkVBQ0hFRCBhc3NlcnRpb24gbG9hZGluZyBmb3JiZXMuY29tCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODI3MgorCisgICAgICAgICogcHJp bnRpbmcvcHNldWRvLWNsYXNzLW91dHNpZGUtcGFnZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAg ICAgICAqIHByaW50aW5nL3BzZXVkby1jbGFzcy1vdXRzaWRlLXBhZ2UuaHRtbDogQWRkZWQuCisK IDIwMTAtMDQtMjkgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFVucmV2aWV3ZWQuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wcmludGluZy9wc2V1ZG8tY2xh c3Mtb3V0c2lkZS1wYWdlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3ByaW50aW5nL3BzZXVk by1jbGFzcy1vdXRzaWRlLXBhZ2UtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjFkNjQ3ZTA3NTIx YmU3NTUyMjhhY2ViM2FkZmVhYzM5ODNmNmJmYWQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9wcmludGluZy9wc2V1ZG8tY2xhc3Mtb3V0c2lkZS1wYWdlLWV4cGVjdGVkLnR4dApAQCAt MCwwICsxLDUgQEAKK1Rlc3QgY2FzZSBmb3IgU0hPVUxEIE5FVkVSIEJFIFJFQUNIRUQgYXNzZXJ0 aW9uIGxvYWRpbmcgZm9yYmVzLmNvbS4gUGFnZWQgbWVkaWEgcmVsYXRlZCBwc2V1ZG8tY2xhc3Nl cyBzaG91bGQgYmUgaWdub3JlZCBvdXRzaWRlIG9mIEBwYWdlLgorCitZb3Ugc2hvdWxkIHNlZSBh IGdyZWVuIGJveC4KKworUEFTUwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcHJpbnRpbmcvcHNl dWRvLWNsYXNzLW91dHNpZGUtcGFnZS5odG1sIGIvTGF5b3V0VGVzdHMvcHJpbnRpbmcvcHNldWRv LWNsYXNzLW91dHNpZGUtcGFnZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjlkODhhMDMzMzFkMWEzNGYwYWRj YTVmNWRkNzc2ODgxY2JjZDliNjIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9wcmlu dGluZy9wc2V1ZG8tY2xhc3Mtb3V0c2lkZS1wYWdlLmh0bWwKQEAgLTAsMCArMSw1NCBAQAorPCFE T0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorCis8c3R5bGUgdHlwZT0idGV4dC9jc3MiIG1l ZGlhPSJzY3JlZW4iPgorICAgICNncmVlbiB7CisgICAgICAgIGJhY2tncm91bmQtY29sb3I6IGdy ZWVuOworICAgIH0KKyAgICAjdGVzdCB7CisgICAgICAgIHdpZHRoOiAxMDBweDsKKyAgICAgICAg aGVpZ2h0OiAxMDBweDsKKyAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogZ3JlZW47CisgICAgfQor ICAgIC8qIFRoZXNlIHNlbGVjdG9ycyBzaG91bGQgYmUgaWdub3JlZCAqLworICAgICN0ZXN0OmZp cnN0IHsKKyAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogcmVkOworICAgIH0KKyAgICAjdGVzdDps ZWZ0IHsKKyAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogcmVkOworICAgIH0KKyAgICAjdGVzdDpy aWdodCB7CisgICAgICAgIGJhY2tncm91bmQtY29sb3I6IHJlZDsKKyAgICB9Cis8L3N0eWxlPgor PHNjcmlwdD4KKyAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICBs YXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisKKyAgICBmdW5jdGlvbiB0ZXN0KCkK KyAgICB7CisgICAgICAgIHZhciBleHBlY3RlZCA9IGdldENvbXB1dGVkU3R5bGUoZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoImdyZWVuIiksIG51bGwpLmJhY2tncm91bmRDb2xvcjsKKyAgICAgICAg dmFyIGFjdHVhbCA9IGdldENvbXB1dGVkU3R5bGUoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRl c3QiKSwgbnVsbCkuYmFja2dyb3VuZENvbG9yOworICAgICAgICB2YXIgcmVzdWx0ID0gIlBBU1Mi OworICAgICAgICBpZiAoYWN0dWFsICE9IGV4cGVjdGVkKQorICAgICAgICAgICAgcmVzdWx0ID0g IkV4cGVjdGVkICIgKyBleHBlY3RlZCArICIsIGJ1dCBjb21lcyAiICsgYWN0dWFsOworICAgICAg ICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0IikuaW5uZXJIVE1MID0gcmVzdWx0Owor ICAgIH0KKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25sb2FkPSJ0ZXN0KCkiPgorCis8cD4K K1Rlc3QgY2FzZSBmb3IgPGEgaHJlZj0iaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM4MjcyIj5TSE9VTEQgTkVWRVIgQkUgUkVBQ0hFRCBhc3NlcnRpb24gbG9hZGluZyBm b3JiZXMuY29tPC9hPi4KK1BhZ2VkIG1lZGlhIHJlbGF0ZWQgcHNldWRvLWNsYXNzZXMgc2hvdWxk IGJlIGlnbm9yZWQgb3V0c2lkZSBvZiBAcGFnZS4KKworPHA+CitZb3Ugc2hvdWxkIHNlZSBhIGdy ZWVuIGJveC4KKworPGRpdiBpZD0iZ3JlZW4iPjwvZGl2PgorPGRpdiBpZD0idGVzdCI+PC9kaXY+ Cis8ZGl2IGlkPSJyZXN1bHQiPjwvZGl2PgorCis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQg YS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDI5YzY2YzhiZGZm YzQ5ZTU3NTM1ZmMwZGJiNDg0YjZjNDIyOWUwZjEuLjgyMjllZjlmMmY3Njk4NjRmYjhhNzBhYTE5 Yjk3NzM3YTY2Y2E5NDUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNv cmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDQtMzAgIFNoaW5pY2hpcm8gSGFt YWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBTSE9VTEQgTkVWRVIgQkUgUkVBQ0hFRCBhc3NlcnRpb24gbG9h ZGluZyBmb3JiZXMuY29tCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zODI3MgorCisgICAgICAgIElnbm9yZSBwYWdlIG1lZGlhIHJlbGF0ZWQgcHNldWRv IGNsYXNzZXMuCisKKyAgICAgICAgVGVzdDogcHJpbnRpbmcvcHNldWRvLWNsYXNzLW91dHNpZGUt cGFnZS5odG1sCisKKyAgICAgICAgKiBjc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpDU1NTdHlsZVNlbGVjdG9yOjpTZWxlY3RvckNoZWNrZXI6OmNoZWNrT25lU2Vs ZWN0b3IpOgorCiAyMDEwLTA0LTI5ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgVW5yZXZpZXdlZC4gIFVwZGF0ZSBKU0MgQ29kZUdlbmVyYXRvciBiYXNlbGluZS4g IE5vdCBzdXJlIGhvdyBJIG1pc3NlZApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9jc3MvQ1NTU3R5bGVT ZWxlY3Rvci5jcHAgYi9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAppbmRleCA1ZmIw MTA5ZTVjN2M1ZTZiZmY1NzkyYjgzNjk4YjdmYTc2ZDY5OTc5Li45MjdlZjkxN2YzYjA0NDhiNDNi NzU0NGQ4NmNlZDYwZWFkNTA2MzllIDEwMDY0NAotLS0gYS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNl bGVjdG9yLmNwcAorKysgYi9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcApAQCAtMjU1 Niw2ICsyNTU2LDExIEBAIGJvb2wgQ1NTU3R5bGVTZWxlY3Rvcjo6U2VsZWN0b3JDaGVja2VyOjpj aGVja09uZVNlbGVjdG9yKENTU1NlbGVjdG9yKiBzZWwsIEVsZW1lCiAgICAgICAgICAgICAgICAg ICAgIGJyZWFrOwogICAgICAgICAgICAgICAgIHJldHVybiB0cnVlOwogICAgICAgICAgICAgfQor ICAgICAgICAgICAgY2FzZSBDU1NTZWxlY3Rvcjo6UHNldWRvTGVmdFBhZ2U6CisgICAgICAgICAg ICBjYXNlIENTU1NlbGVjdG9yOjpQc2V1ZG9SaWdodFBhZ2U6CisgICAgICAgICAgICBjYXNlIENT U1NlbGVjdG9yOjpQc2V1ZG9GaXJzdFBhZ2U6CisgICAgICAgICAgICAgICAgLy8gUGFnZSBtZWRp YSByZWxhdGVkIHBzZXVkby1jbGFzc2VzIGFyZSBub3QgaGFuZGxlZCB5ZXQuCisgICAgICAgICAg ICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICAgICAgY2FzZSBDU1NTZWxlY3Rvcjo6UHNldWRv VW5rbm93bjoKICAgICAgICAgICAgIGNhc2UgQ1NTU2VsZWN0b3I6OlBzZXVkb05vdFBhcnNlZDoK ICAgICAgICAgICAgIGRlZmF1bHQ6Cg==