38247 2010-04-28 01:10:36 -0700 Unnecessary PrintContext::end() calls 2010-04-30 02:14:44 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 hamaji webkit-unassigned oldest_to_newest 218257 0 hamaji 2010-04-28 01:10:36 -0700 With http://trac.webkit.org/changeset/58386 , now PrintContext calls end() in its destructor. Let's remove unnecessary end() calls. I won't modify port specific code for now. I don't know how to check Qt and GTK printing. Chromium is using PrintContext in different way and it seems we need some refactoring works. 218259 1 54535 hamaji 2010-04-28 01:12:00 -0700 Created attachment 54535 Patch v1 219410 2 hamaji 2010-04-30 02:14:44 -0700 Committed r58566: <http://trac.webkit.org/changeset/58566> 54535 2010-04-28 01:12:00 -0700 2010-04-28 10:29:37 -0700 Patch v1 bug-38247-20100428011158.patch text/plain 1860 hamaji ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTkxZWZiNjhkYTlhM2Y4MzI4N2Q3NjAwMTNlMDJkZjE4YTY0YTg2NC4uNWU0MDUyYjdhNGE3MGRi MTQ4ZTdmODA0ZWY0MzZjZjA5ZGJlNjgwNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNC0yOCAgU2hp bmljaGlybyBIYW1hamkgIDxoYW1hamlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVubmVjZXNzYXJ5IFByaW50Q29udGV4dDo6 ZW5kKCkgY2FsbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTM4MjQ3CisKKyAgICAgICAgUmVmYWN0b3Jpbmcgb25seSwgc28gbm8gbmV3IHRlc3RzLgor CisgICAgICAgICogcGFnZS9QcmludENvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UHJp bnRDb250ZXh0OjpwYWdlTnVtYmVyRm9yRWxlbWVudCk6CisgICAgICAgIChXZWJDb3JlOjpQcmlu dENvbnRleHQ6Om51bWJlck9mUGFnZXMpOgorCiAyMDEwLTA0LTI3ICBTaGluaWNoaXJvIEhhbWFq aSAgPGhhbWFqaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRs ZXIgYW5kIEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL1ByaW50Q29udGV4 dC5jcHAgYi9XZWJDb3JlL3BhZ2UvUHJpbnRDb250ZXh0LmNwcAppbmRleCA4NjhmOGUxN2ZiYzc4 NmE1YjQzZmYyMjE3MTRjYWI5YTE1MDg1NDhjLi5mZmRlMGJlYjFlM2MwYmU0NGQ3ZTUyMjk3N2Iz YWI1MzYyODZjMWQwIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvUHJpbnRDb250ZXh0LmNwcAor KysgYi9XZWJDb3JlL3BhZ2UvUHJpbnRDb250ZXh0LmNwcApAQCAtMTkzLDEwICsxOTMsOSBAQCBp bnQgUHJpbnRDb250ZXh0OjpwYWdlTnVtYmVyRm9yRWxlbWVudChFbGVtZW50KiBlbGVtZW50LCBj b25zdCBGbG9hdFNpemUmIHBhZ2VTaQogICAgIGZvciAoOyBwYWdlTnVtYmVyIDwgcHJpbnRDb250 ZXh0LnBhZ2VDb3VudCgpOyBwYWdlTnVtYmVyKyspIHsKICAgICAgICAgY29uc3QgSW50UmVjdCYg cGFnZSA9IHByaW50Q29udGV4dC5wYWdlUmVjdChwYWdlTnVtYmVyKTsKICAgICAgICAgaWYgKHBh Z2UueCgpIDw9IGxlZnQgJiYgbGVmdCA8IHBhZ2UucmlnaHQoKSAmJiBwYWdlLnkoKSA8PSB0b3Ag JiYgdG9wIDwgcGFnZS5ib3R0b20oKSkKLSAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAg cmV0dXJuIHBhZ2VOdW1iZXI7CiAgICAgfQotICAgIHByaW50Q29udGV4dC5lbmQoKTsKLSAgICBy ZXR1cm4gKHBhZ2VOdW1iZXIgPCBwcmludENvbnRleHQucGFnZUNvdW50KCkgPyBwYWdlTnVtYmVy IDogLTEpOworICAgIHJldHVybiAtMTsKIH0KIAogaW50IFByaW50Q29udGV4dDo6bnVtYmVyT2ZQ YWdlcyhGcmFtZSogZnJhbWUsIGNvbnN0IEZsb2F0U2l6ZSYgcGFnZVNpemVJblBpeGVscykKQEAg LTIwNyw3ICsyMDYsNiBAQCBpbnQgUHJpbnRDb250ZXh0OjpudW1iZXJPZlBhZ2VzKEZyYW1lKiBm cmFtZSwgY29uc3QgRmxvYXRTaXplJiBwYWdlU2l6ZUluUGl4ZWxzKQogICAgIFByaW50Q29udGV4 dCBwcmludENvbnRleHQoZnJhbWUpOwogICAgIHByaW50Q29udGV4dC5iZWdpbihwYWdlUmVjdC53 aWR0aCgpKTsKICAgICBwcmludENvbnRleHQuY29tcHV0ZVBhZ2VSZWN0c1dpdGhQYWdlU2l6ZShw YWdlU2l6ZUluUGl4ZWxzLCBmYWxzZSk7Ci0gICAgcHJpbnRDb250ZXh0LmVuZCgpOwogICAgIHJl dHVybiBwcmludENvbnRleHQucGFnZUNvdW50KCk7CiB9CiAK