38234 2010-04-27 17:23:41 -0700 Fix typo that prevents NRWT --verbose from working in a Chromium checkout 2010-04-27 18:15:48 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jamesr webkit-unassigned oldest_to_newest 218071 0 jamesr 2010-04-27 17:23:41 -0700 Fix typo that prevents NRWT --verbose from working in a Chromium checkout 218072 1 54481 jamesr 2010-04-27 17:26:34 -0700 Created attachment 54481 Patch 218075 2 jamesr 2010-04-27 17:27:47 -0700 This is obviously begging for an automated test, but I'm not sure how to construct one :( absent that I have verified that in a chromium checkout doing "./webkit/tools/layout_tests/run_webkit_tests.sh --verbose" fails without this patch and succeeds with it. 218111 3 jamesr 2010-04-27 18:15:48 -0700 Committed r58364: <http://trac.webkit.org/changeset/58364> 54481 2010-04-27 17:26:34 -0700 2010-04-27 17:27:19 -0700 Patch bug-38234-20100427172633.patch text/plain 1515 jamesr SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU4MzU3KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDQtMjcgIEphbWVzIFJvYmluc29uICA8 amFtZXNyQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBGaXggYSB0eXBvIGluIGNocm9taXVtLnB5IHRoYXQgY2F1c2VzIE5SV1Qg dG8gZmFpbCBpbiAtLXZlcmJvc2UKKyAgICAgICAgbW9kZSBpbiBhIENocm9taXVtIGNoZWNrb3V0 LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzgyMzQK KworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0u cHk6CisKIDIwMTAtMDQtMjcgIEV2YW4gTWFydGluICA8ZXZhbkBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgVW5yZXZpZXdlZC4KSW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bS5weQkocmV2aXNpb24gNTgz NDQpCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2No cm9taXVtLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xODIsOCArMTgyLDggQEAgY2xhc3MgQ2hyb21p dW1Qb3J0KGJhc2UuUG9ydCk6CiAgICAgZGVmIGNyZWF0ZV9kcml2ZXIoc2VsZiwgaW1hZ2VfcGF0 aCwgb3B0aW9ucyk6CiAgICAgICAgICIiIlN0YXJ0cyBhIG5ldyBEcml2ZXIgYW5kIHJldHVybnMg YSBoYW5kbGUgdG8gaXQuIiIiCiAgICAgICAgIGlmIHNlbGYuX29wdGlvbnMudXNlX2RydDoKLSAg ICAgICAgICAgIHJldHVybiB3ZWJraXQuV2ViS2l0RHJpdmVyKHNlbGYsIGltYWdlX3BhdGgsIG9w dGlvbnMsIGV4ZWN0dWl2ZT1zZWxmLl9leGVjdXRpdmUpCi0gICAgICAgIHJldHVybiBDaHJvbWl1 bURyaXZlcihzZWxmLCBpbWFnZV9wYXRoLCBvcHRpb25zLCBleGVjdHVpdmU9c2VsZi5fZXhlY3V0 aXZlKQorICAgICAgICAgICAgcmV0dXJuIHdlYmtpdC5XZWJLaXREcml2ZXIoc2VsZiwgaW1hZ2Vf cGF0aCwgb3B0aW9ucywgZXhlY3V0aXZlPXNlbGYuX2V4ZWN1dGl2ZSkKKyAgICAgICAgcmV0dXJu IENocm9taXVtRHJpdmVyKHNlbGYsIGltYWdlX3BhdGgsIG9wdGlvbnMsIGV4ZWN1dGl2ZT1zZWxm Ll9leGVjdXRpdmUpCiAKICAgICBkZWYgc3RhcnRfaGVscGVyKHNlbGYpOgogICAgICAgICBoZWxw ZXJfcGF0aCA9IHNlbGYuX3BhdGhfdG9faGVscGVyKCkK