3823 2005-07-02 20:07:51 -0700 GW: Fix KWQStaticDeleter to comply with modern KDE API 2005-07-03 03:19:43 -0700 1 1 1 Unclassified WebKit New Bugs 420+ Mac OS X 10.4 RESOLVED FIXED P4 Enhancement --- 3250 1 eric eric oldest_to_newest 13718 0 eric 2005-07-02 20:07:51 -0700 KWQStatic deleter only takes two parameters (one optional) when the KDE one takes 3 (one optiona). This can cause unexpected crashes due to silent pointer -> bool casting. This patch fixes our KWQStaticDeleter to comply with the KDE one. 13719 1 2762 eric 2005-07-02 20:10:31 -0700 Created attachment 2762 fixes our KWQStaticDeleter 13749 2 2762 mjs 2005-07-03 01:59:36 -0700 Comment on attachment 2762 fixes our KWQStaticDeleter r=me 13750 3 2762 mjs 2005-07-03 02:02:14 -0700 Comment on attachment 2762 fixes our KWQStaticDeleter r=me 2762 2005-07-02 20:10:31 -0700 2005-07-03 01:59:36 -0700 fixes our KWQStaticDeleter static_deleter.patch text/plain 1330 eric SW5kZXg6IC4va2h0bWwveG1sL2RvbV9kb2NpbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAv Y3ZzL3Jvb3QvV2ViQ29yZS9raHRtbC94bWwvZG9tX2RvY2ltcGwuY3BwLHYKcmV0cmlldmluZyBy ZXZpc2lvbiAxLjIzMApkaWZmIC1wIC11IC1yMS4yMzAgLi9raHRtbC94bWwvZG9tX2RvY2ltcGwu Y3BwCi0tLSAuL2todG1sL3htbC9kb21fZG9jaW1wbC5jcHAJMjAwNS8wNi8yMiAxODoyMjowMgkx LjIzMAorKysgLi9raHRtbC94bWwvZG9tX2RvY2ltcGwuY3BwCTIwMDUvMDcvMDMgMDM6MDA6MTIK QEAgLTEwNzgsNyArMTA3OCw3IEBAIFRyZWVXYWxrZXJJbXBsICpEb2N1bWVudEltcGw6OmNyZWF0 ZVRyZWUKIHZvaWQgRG9jdW1lbnRJbXBsOjpzZXREb2N1bWVudENoYW5nZWQoYm9vbCBiKQogewog ICAgIGlmICghY2hhbmdlZERvY3VtZW50cykKLSAgICAgICAgY2hhbmdlZERvY3VtZW50cyA9IHNf Y2hhbmdlZERvY3VtZW50c0RlbGV0ZXIuc2V0T2JqZWN0KCBuZXcgUVB0ckxpc3Q8RG9jdW1lbnRJ bXBsPigpICk7CisgICAgICAgIGNoYW5nZWREb2N1bWVudHMgPSBzX2NoYW5nZWREb2N1bWVudHNE ZWxldGVyLnNldE9iamVjdChjaGFuZ2VkRG9jdW1lbnRzLCBuZXcgUVB0ckxpc3Q8RG9jdW1lbnRJ bXBsPigpKTsKIAogICAgIGlmIChiICYmICFtX2RvY0NoYW5nZWQpCiAgICAgICAgIGNoYW5nZWRE b2N1bWVudHMtPmFwcGVuZCh0aGlzKTsKSW5kZXg6IC4va3dxL0tXUUtTdGF0aWNEZWxldGVyLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dlYkNvcmUva3dxL0tXUUtTdGF0aWNEZWxl dGVyLmgsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTEKZGlmZiAtcCAtdSAtcjEuMTEgLi9rd3Ev S1dRS1N0YXRpY0RlbGV0ZXIuaAotLS0gLi9rd3EvS1dRS1N0YXRpY0RlbGV0ZXIuaAkyMDAzLzAx LzIyIDAwOjEyOjM1CTEuMTEKKysrIC4va3dxL0tXUUtTdGF0aWNEZWxldGVyLmgJMjAwNS8wNy8w MyAwMzowMDoxNApAQCAtMzIsNyArMzIsNyBAQAogCiB0ZW1wbGF0ZSA8Y2xhc3MgVD4gY2xhc3Mg S1N0YXRpY0RlbGV0ZXIgewogcHVibGljOgotICAgIFQgKnNldE9iamVjdChUICpwdHIsIGJvb2wg YXJyYXkgPSBmYWxzZSkgeyByZXR1cm4gcHRyOyB9CisgICAgVCAqc2V0T2JqZWN0KFQgKiZnbG9i YWwsIFQgKnB0ciwgYm9vbCBhcnJheSA9IGZhbHNlKSB7IGdsb2JhbCA9IHB0cjsgcmV0dXJuIHB0 cjsgfQogfTsKIAogI2VuZGlmCg==